Page MenuHomePhabricator

bakhtiyarneyman (Bakhtiyar Neyman)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Mar 29, 8:38 PM (3 w, 1 d)

Recent Activity

Fri, Apr 2

bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Aligned the calling convention of visit to match that of std::visit. Renamed the more convenient version of visit to match to have the best of the two worlds: better ergonomics and not clashing with std::visit. This time for real.

Fri, Apr 2, 12:31 AM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Include the VisitorTest.cpp into the CMakeList.txt.

Fri, Apr 2, 12:29 AM · Restricted Project

Thu, Apr 1

bakhtiyarneyman added a comment to D99560: Utility to construct visitors from lambdas..

Regarding deriving from using other kinds of functors: I have not yet seen a need for this. My preference is to cross that bridge when we reach it. :)

Thu, Apr 1, 11:53 PM · Restricted Project
bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Aligned the calling convention of visit to match that of std::visit. Renamed the more convenient version of visit to match to have the best of the two worlds: better ergonomics and not clashing with std::visit.

Thu, Apr 1, 11:48 PM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Added docs with usage example. Hid implementation in detail namespace.

Thu, Apr 1, 11:47 PM · Restricted Project

Tue, Mar 30

bakhtiyarneyman added inline comments to D99561: Support visitor pattern by PointerUnion..
Tue, Mar 30, 3:57 PM · Restricted Project
bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Replaced class with typename in template definition.

Tue, Mar 30, 3:56 PM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Replaced class with typename in template definition.

Tue, Mar 30, 3:55 PM · Restricted Project
bakhtiyarneyman added a comment to D99560: Utility to construct visitors from lambdas..

Re: handleAllErrors. Maybe. It might result in better runtime performance (because there is not recursion on the handlers), but it's also a rewrite. I am not sure if you are asking me to do something. :)

Tue, Mar 30, 3:45 PM · Restricted Project
bakhtiyarneyman added a comment to D99561: Support visitor pattern by PointerUnion..

Thanks for taking a look, Mehdi and David! PTAL.

Tue, Mar 30, 3:36 PM · Restricted Project
bakhtiyarneyman updated the diff for D99561: Support visitor pattern by PointerUnion..

Added a unit test.

Tue, Mar 30, 3:25 PM · Restricted Project
bakhtiyarneyman updated the diff for D99560: Utility to construct visitors from lambdas..

Added a unit test.

Tue, Mar 30, 3:25 PM · Restricted Project

Mon, Mar 29

bakhtiyarneyman added a reviewer for D99560: Utility to construct visitors from lambdas.: mehdi_amini.
Mon, Mar 29, 9:17 PM · Restricted Project
bakhtiyarneyman added a reviewer for D99561: Support visitor pattern by PointerUnion.: mehdi_amini.
Mon, Mar 29, 9:17 PM · Restricted Project
bakhtiyarneyman requested review of D99561: Support visitor pattern by PointerUnion..
Mon, Mar 29, 9:15 PM · Restricted Project
bakhtiyarneyman requested review of D99560: Utility to construct visitors from lambdas..
Mon, Mar 29, 9:13 PM · Restricted Project