Page MenuHomePhabricator

azabaznov (Anton Zabaznov)
Compiler Engineer at Intel

Projects

User does not belong to any projects.

User Details

User Since
Sep 23 2020, 3:53 AM (9 w, 1 d)

Recent Activity

Tue, Nov 24

azabaznov updated the diff for D89869: [OpenCL] Define OpenCL feature macros for all versions.

Addressed almost all technical and cosmetic concerns concerns. Except putting reference of OpenCLOptions in Sema due to const of TargetInfo. I think I'll think about that later. Also:

Tue, Nov 24, 12:37 PM
azabaznov added a comment to D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

Hi! Great to see the interest in OpenCL C 3.0!

Tue, Nov 24, 5:48 AM · Restricted Project

Mon, Nov 23

azabaznov added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

So if I understand it well you are suggesting to perform a check for every parsed macro definition that would identify whether the macro has a name matching what is provided in -cl-ext=? Then if the name matches it would check whether the macro should be defined or not?

Mon, Nov 23, 3:08 PM
azabaznov added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

Perhaps if you give me an example it would help to understand

Mon, Nov 23, 9:28 AM

Thu, Nov 19

azabaznov added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

Yes, in general this approach looks good to me conceptually. I have two suggestions:

Thu, Nov 19, 12:14 PM

Wed, Nov 18

azabaznov added inline comments to D89869: [OpenCL] Define OpenCL feature macros for all versions.
Wed, Nov 18, 6:58 AM

Tue, Nov 17

azabaznov added inline comments to D89869: [OpenCL] Define OpenCL feature macros for all versions.
Tue, Nov 17, 2:39 AM

Wed, Nov 11

azabaznov added a comment to D89869: [OpenCL] Define OpenCL feature macros for all versions.

What did you think in mind regarding activation of features for SPIR?

Wed, Nov 11, 5:49 AM
azabaznov updated the diff for D89869: [OpenCL] Define OpenCL feature macros for all versions.

Addressed all concerns except replacing __opencl_c_int64 definition into header. The reason for this as follows: this macro should be predefined regardless if clang includes default header or not.

Wed, Nov 11, 5:45 AM

Fri, Nov 6

azabaznov added a comment to D89869: [OpenCL] Define OpenCL feature macros for all versions.

I guess targets like SPIR will be supporting all features by default?

Fri, Nov 6, 1:19 AM

Oct 21 2020

azabaznov requested review of D89869: [OpenCL] Define OpenCL feature macros for all versions.
Oct 21 2020, 4:00 AM

Oct 14 2020

azabaznov added inline comments to D89372: [OpenCL] Remove unused extensions.
Oct 14 2020, 11:18 AM · Restricted Project
azabaznov requested changes to D89372: [OpenCL] Remove unused extensions.
Oct 14 2020, 7:48 AM · Restricted Project
azabaznov accepted D89143: [OpenCL][Docs] Improved description of the supported language functionality..

Looks good to me, thanks for the note.

Oct 14 2020, 7:40 AM

Oct 9 2020

azabaznov added a comment to D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.

Anastasia, Sven, thanks for the review! Anastasia, it seems that I don't have write access yet. Would you mind landing this change on behalf of me? Thanks!

Oct 9 2020, 4:10 AM · Restricted Project

Sep 30 2020

azabaznov added a comment to D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.

LGTM! I'd suggest waiting a bit before committing this though, to give people time to catch up on the RFC.

Sep 30 2020, 2:18 AM · Restricted Project

Sep 25 2020

azabaznov updated azabaznov.
Sep 25 2020, 6:52 AM
azabaznov updated the diff for D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.
Sep 25 2020, 6:44 AM · Restricted Project
azabaznov requested review of D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.
Sep 25 2020, 6:32 AM · Restricted Project