Page MenuHomePhabricator

azabaznov (Anton Zabaznov)
Compiler Engineer at Intel

Projects

User does not belong to any projects.

User Details

User Since
Sep 23 2020, 3:53 AM (28 w, 6 d)

Recent Activity

Fri, Apr 9

azabaznov updated the diff for D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.

Remove unrelated change, fixed error in test to check only cl_khr_fp64 for OpenCL C < 1.2

Fri, Apr 9, 6:28 AM · Restricted Project
azabaznov added inline comments to D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.
Fri, Apr 9, 6:19 AM · Restricted Project
azabaznov updated the diff for D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.

Addressed comments, rebased after refactoring: https://reviews.llvm.org/D97058

Fri, Apr 9, 6:16 AM · Restricted Project

Wed, Apr 7

azabaznov added a comment to D99969: [OpenCL] Accept .rgba in OpenCL 3.0.

Thanks for working on this! Looks good to me in general. I have a small comment.

Wed, Apr 7, 1:17 AM · Restricted Project

Thu, Apr 1

azabaznov added a comment to D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing.

Thanks for feedback!

Thu, Apr 1, 1:24 AM · Restricted Project

Tue, Mar 30

azabaznov accepted D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0.

Looks good to me. Thanks!

Tue, Mar 30, 7:40 AM · Restricted Project
azabaznov updated the summary of D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing.
Tue, Mar 30, 5:14 AM · Restricted Project
azabaznov added a comment to D99425: [OpenCL] Fix parsing of opencl-c.h in CL 3.0.

Thanks for  the patch! Sorry for the delay

Tue, Mar 30, 4:29 AM · Restricted Project
azabaznov requested review of D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing.
Tue, Mar 30, 3:59 AM · Restricted Project

Tue, Mar 16

azabaznov added a comment to D97869: [OpenCL][Draft] Add OpenCL builtin test generator.

I have one more though.

Tue, Mar 16, 5:10 AM

Mon, Mar 15

azabaznov added a comment to D98539: [OpenCL] Set target as spir for c-index-test for OpenCL.

@Anastasia, thanks for landing this! Sorry for delay, I though that this can wait until Monday

Mon, Mar 15, 1:48 AM · Restricted Project
azabaznov added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Do you also get fatal error: 'opencl-c-base.h' file not found? If so, we might need at least to file a clang bug that we should look at before the next release.

Mon, Mar 15, 1:47 AM · Restricted Project

Mar 12 2021

azabaznov added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Yes, I was able to reproduce the failure with -target arm64-apple-macosx flag, I provided the fix to set explicit target: https://reviews.llvm.org/D98539.

Mar 12 2021, 11:02 AM · Restricted Project
azabaznov requested review of D98539: [OpenCL] Set target as spir for c-index-test for OpenCL.
Mar 12 2021, 10:57 AM · Restricted Project
azabaznov added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Thanks guys,

Mar 12 2021, 10:21 AM · Restricted Project
azabaznov added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Yeah,  I'm looking into it, but I can't reproduce it locally: the test passes at x86_64 linux system. I'll revert the change if it takes too much time to investigate what's going on. Thanks.

Mar 12 2021, 9:55 AM · Restricted Project
azabaznov committed rG840643bbe1d2: [OpenCL] Refactor diagnostic for OpenCL extension/feature (authored by azabaznov).
[OpenCL] Refactor diagnostic for OpenCL extension/feature
Mar 12 2021, 12:44 AM
azabaznov closed D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.
Mar 12 2021, 12:44 AM · Restricted Project

Mar 10 2021

azabaznov added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Ok, addressing in a separate patch is reasonable, but why do you think that we will break backward compatibility? My current worry is that the implementation is so messy and inconsistent that it will take us longer time if we do the incremental steps. Also, we risk introducing the regressions since it is so hard to make sense out of it.

Mar 10 2021, 5:50 AM · Restricted Project
azabaznov updated the diff for D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Replaced atomic_double implicit definition

Mar 10 2021, 12:32 AM · Restricted Project
azabaznov updated the diff for D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Corrected some mistakes, added a test for diagnosing undeclared identifiers when a extension is unsupported. Generally leaving the change as it is as completely removing pragma may break backward compatibility now: let's do it in a separate patch and notify everyone before doing that. Also, we should wait before spec will be finalized.

Mar 10 2021, 12:11 AM · Restricted Project

Mar 4 2021

azabaznov added a comment to D97869: [OpenCL][Draft] Add OpenCL builtin test generator.

That's awesome!

Mar 4 2021, 5:29 AM
azabaznov added inline comments to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.
Mar 4 2021, 1:03 AM · Restricted Project

Mar 3 2021

azabaznov added inline comments to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.
Mar 3 2021, 6:38 AM · Restricted Project
azabaznov updated the diff for D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

Check 'isEnabled' is now private: it is used only for non-core or non-optional core features;
creation of implicit type definitions is guarder with extension support check; minor refactoring

Mar 3 2021, 6:27 AM · Restricted Project

Mar 2 2021

azabaznov added a comment to D97052: [OpenCL] Prevent adding extension pragma by default.

Thanks for working on this. LGTM in general. I'll let Marco comment on the latest changes.

Mar 2 2021, 12:53 AM · Restricted Project

Feb 25 2021

azabaznov added a comment to D97052: [OpenCL] Prevent adding extension pragma by default.

I see the update regaring this functionality on github issue: https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. Is it a right way to reflect this information in`OpenCLExtensions.def`?

Feb 25 2021, 1:18 AM · Restricted Project
azabaznov added a comment to D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.

FYI, I would even be ok if we remove the need for enabling non-core

Feb 25 2021, 1:15 AM · Restricted Project
azabaznov added inline comments to D97052: [OpenCL] Prevent adding extension pragma by default.
Feb 25 2021, 12:59 AM · Restricted Project

Feb 20 2021

azabaznov added inline comments to D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.
Feb 20 2021, 12:15 AM · Restricted Project
azabaznov added inline comments to D97052: [OpenCL] Prevent adding extension pragma by default.
Feb 20 2021, 12:12 AM · Restricted Project

Feb 19 2021

azabaznov added inline comments to D97052: [OpenCL] Prevent adding extension pragma by default.
Feb 19 2021, 10:31 AM · Restricted Project
azabaznov added a comment to D97052: [OpenCL] Prevent adding extension pragma by default.

Thanks! I review is shortly. As for now, I also was doing some refactoring: https://reviews.llvm.org/D97058. Check-clang passes, as I see there are no conflicts for now.

Feb 19 2021, 8:54 AM · Restricted Project
azabaznov requested review of D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature.
Feb 19 2021, 8:51 AM · Restricted Project

Feb 17 2021

azabaznov committed rGe1a64aa66c33: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode (authored by azabaznov).
[OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode
Feb 17 2021, 1:19 AM
azabaznov closed D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.
Feb 17 2021, 1:19 AM · Restricted Project

Feb 16 2021

azabaznov added a comment to D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.

Thanks for review. Last change is a small fix for if clang-tidy warnings

Feb 16 2021, 7:06 AM · Restricted Project
azabaznov updated the diff for D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.

Fix clang-tidy warnings

Feb 16 2021, 7:05 AM · Restricted Project

Feb 15 2021

azabaznov added inline comments to D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.
Feb 15 2021, 1:18 AM · Restricted Project

Feb 12 2021

azabaznov added inline comments to D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.
Feb 12 2021, 11:50 AM · Restricted Project
azabaznov updated the diff for D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.

Rewrote 'RemoveAddressSpaceFromPtr' to return canonical type

Feb 12 2021, 11:41 AM · Restricted Project

Feb 11 2021

azabaznov requested review of D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64.
Feb 11 2021, 9:57 AM · Restricted Project

Feb 10 2021

azabaznov added a comment to D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.

Thanks for review. Just to be clear: can I proceed with this? Or we should discuss it first? As I see possible this change can be abandoned after discussion.

Feb 10 2021, 8:29 AM · Restricted Project

Feb 5 2021

azabaznov requested review of D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode.
Feb 5 2021, 2:00 PM · Restricted Project
azabaznov committed rGd88c55ab95c9: [OpenCL] Add macro definitions of OpenCL C 3.0 features (authored by azabaznov).
[OpenCL] Add macro definitions of OpenCL C 3.0 features
Feb 5 2021, 7:43 AM
azabaznov closed D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.
Feb 5 2021, 7:42 AM · Restricted Project
azabaznov committed rGa5b627aa4fe7: [OpenCL] Introduce new language options for OpenCL keywords. (authored by azabaznov).
[OpenCL] Introduce new language options for OpenCL keywords.
Feb 5 2021, 12:19 AM
azabaznov closed D95778: [OpenCL] Introduce new language options for OpenCL keywords..
Feb 5 2021, 12:19 AM · Restricted Project

Feb 4 2021

azabaznov updated the diff for D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.

Adjusted test one more time: moved header functionality into separate test

Feb 4 2021, 7:20 AM · Restricted Project
azabaznov added inline comments to D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.
Feb 4 2021, 5:27 AM · Restricted Project
azabaznov updated the diff for D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.

Features remain defined in header for OpenCL C 2.0; adjusted the test

Feb 4 2021, 4:45 AM · Restricted Project
azabaznov updated the diff for D95778: [OpenCL] Introduce new language options for OpenCL keywords..

Renamed language options and adjusted comment.

Feb 4 2021, 1:45 AM · Restricted Project

Feb 2 2021

azabaznov added inline comments to D95778: [OpenCL] Introduce new language options for OpenCL keywords..
Feb 2 2021, 7:23 AM · Restricted Project
azabaznov added a comment to D95778: [OpenCL] Introduce new language options for OpenCL keywords..

LGTM, but perhaps you can add a test that has each keyword disabled?

FYI we currently already test that pipe and generic are valid for OpenCL 2.0 and invalid for OpenCL < 2.0. Or do you mean different kind of tests? In OpenCL 3.0 we will have to set the new LangOpts fields based on the values of OpenCLOptions but my guess is that is going to be added in the subsequent patches...

Feb 2 2021, 7:19 AM · Restricted Project
azabaznov added inline comments to D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.
Feb 2 2021, 7:16 AM · Restricted Project
azabaznov updated the diff for D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.

Rebased one more time

Feb 2 2021, 1:26 AM · Restricted Project
azabaznov updated the diff for D95778: [OpenCL] Introduce new language options for OpenCL keywords..

Rebased

Feb 2 2021, 1:22 AM · Restricted Project
azabaznov updated the diff for D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.

Rebased

Feb 2 2021, 1:19 AM · Restricted Project

Feb 1 2021

azabaznov requested review of D95778: [OpenCL] Introduce new language options for OpenCL keywords..
Feb 1 2021, 2:46 AM · Restricted Project
azabaznov added a comment to D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.

I suggest that renaming 'extension' to 'option' (extensions + features) concept to be done in separate commit. There are a lot of places to change all over the place in clang.

Feb 1 2021, 1:46 AM · Restricted Project
azabaznov abandoned D89869: [OpenCL] Define OpenCL feature macros for all versions.

Due to refactoring in https://reviews.llvm.org/D92277 this flow is no longer valid. New patch for this functionality is here: https://reviews.llvm.org/D95776.

Feb 1 2021, 1:43 AM
azabaznov requested review of D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features.
Feb 1 2021, 1:37 AM · Restricted Project

Jan 25 2021

azabaznov committed rGe123cd674c02: [OpenCL] Refactor of targets OpenCL option settings (authored by azabaznov).
[OpenCL] Refactor of targets OpenCL option settings
Jan 25 2021, 8:50 AM
azabaznov closed D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 25 2021, 8:50 AM · Restricted Project

Jan 22 2021

azabaznov updated the summary of D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 22 2021, 1:51 AM · Restricted Project
azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 22 2021, 1:42 AM · Restricted Project
azabaznov updated the diff for D92277: [OpenCL] Refactor of targets OpenCL option settings.

Removed getCoreFeatures() as it's not used in this change.

Jan 22 2021, 1:39 AM · Restricted Project

Jan 21 2021

azabaznov updated the diff for D92277: [OpenCL] Refactor of targets OpenCL option settings.

Thanks for feedback. I agree that providing diagnostics for unsupported core features is enough for now (I guess I'll try to come up with something for OpenCL C 3.0 features to set them unconditionally for 2.0, or at least these macros can be defined in header only). So I removed setting of core features (and also addressed all cosmetic concerns).

Jan 21 2021, 5:15 AM · Restricted Project

Jan 20 2021

azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 20 2021, 1:47 AM · Restricted Project

Jan 18 2021

azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 18 2021, 8:23 AM · Restricted Project
azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 18 2021, 8:13 AM · Restricted Project
azabaznov updated the summary of D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 18 2021, 4:38 AM · Restricted Project
azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 18 2021, 4:35 AM · Restricted Project

Jan 14 2021

azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Jan 14 2021, 5:01 AM · Restricted Project
azabaznov updated the diff for D92277: [OpenCL] Refactor of targets OpenCL option settings.

Changes in the latest patch:

Jan 14 2021, 4:55 AM · Restricted Project

Dec 13 2020

azabaznov added inline comments to D92277: [OpenCL] Refactor of targets OpenCL option settings.
Dec 13 2020, 5:49 AM · Restricted Project

Dec 9 2020

azabaznov updated the diff for D92277: [OpenCL] Refactor of targets OpenCL option settings.

Changes in the latest patch:

Dec 9 2020, 7:21 AM · Restricted Project

Dec 1 2020

azabaznov added a comment to D92277: [OpenCL] Refactor of targets OpenCL option settings.

Thanks for working on this! It is a very good refactoring that brings OpenCL closer inline with convention design flow

Dec 1 2020, 5:52 AM · Restricted Project

Nov 29 2020

azabaznov updated the summary of D92277: [OpenCL] Refactor of targets OpenCL option settings.
Nov 29 2020, 3:22 PM · Restricted Project
azabaznov added a comment to D89869: [OpenCL] Define OpenCL feature macros for all versions.

I didn't want to end up with a big refactoring from this patch but now I start to think that considering the situation it might be unavoidable. :(

Nov 29 2020, 8:57 AM
azabaznov added a comment to D92277: [OpenCL] Refactor of targets OpenCL option settings.

@Anastasia, there is common functionality with your approach in https://reviews.llvm.org/D91531. I guess these two patches can be unified at some point once we discuss it.

Nov 29 2020, 8:46 AM · Restricted Project
azabaznov requested review of D92277: [OpenCL] Refactor of targets OpenCL option settings.
Nov 29 2020, 8:34 AM · Restricted Project

Nov 24 2020

azabaznov updated the diff for D89869: [OpenCL] Define OpenCL feature macros for all versions.

Addressed almost all technical and cosmetic concerns. Except putting reference of OpenCLOptions in Sema due to const of TargetInfo. I am going to think about that later. Also:

Nov 24 2020, 12:37 PM
azabaznov added a comment to D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

Hi! Great to see the interest in OpenCL C 3.0!

Nov 24 2020, 5:48 AM · Restricted Project

Nov 23 2020

azabaznov added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

So if I understand it well you are suggesting to perform a check for every parsed macro definition that would identify whether the macro has a name matching what is provided in -cl-ext=? Then if the name matches it would check whether the macro should be defined or not?

Nov 23 2020, 3:08 PM
azabaznov added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

Perhaps if you give me an example it would help to understand

Nov 23 2020, 9:28 AM

Nov 19 2020

azabaznov added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

Yes, in general this approach looks good to me conceptually. I have two suggestions:

Nov 19 2020, 12:14 PM

Nov 18 2020

azabaznov added inline comments to D89869: [OpenCL] Define OpenCL feature macros for all versions.
Nov 18 2020, 6:58 AM

Nov 17 2020

azabaznov added inline comments to D89869: [OpenCL] Define OpenCL feature macros for all versions.
Nov 17 2020, 2:39 AM

Nov 11 2020

azabaznov added a comment to D89869: [OpenCL] Define OpenCL feature macros for all versions.

What did you think in mind regarding activation of features for SPIR?

Nov 11 2020, 5:49 AM
azabaznov updated the diff for D89869: [OpenCL] Define OpenCL feature macros for all versions.

Addressed all concerns except replacing __opencl_c_int64 definition into header. The reason for this as follows: this macro should be predefined regardless if clang includes default header or not.

Nov 11 2020, 5:45 AM

Nov 6 2020

azabaznov added a comment to D89869: [OpenCL] Define OpenCL feature macros for all versions.

I guess targets like SPIR will be supporting all features by default?

Nov 6 2020, 1:19 AM

Oct 21 2020

azabaznov requested review of D89869: [OpenCL] Define OpenCL feature macros for all versions.
Oct 21 2020, 4:00 AM

Oct 14 2020

azabaznov added inline comments to D89372: [OpenCL] Remove unused extensions.
Oct 14 2020, 11:18 AM · Restricted Project
azabaznov requested changes to D89372: [OpenCL] Remove unused extensions.
Oct 14 2020, 7:48 AM · Restricted Project
azabaznov accepted D89143: [OpenCL][Docs] Improved description of the supported language functionality..

Looks good to me, thanks for the note.

Oct 14 2020, 7:40 AM

Oct 9 2020

azabaznov added a comment to D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.

Anastasia, Sven, thanks for the review! Anastasia, it seems that I don't have write access yet. Would you mind landing this change on behalf of me? Thanks!

Oct 9 2020, 4:10 AM · Restricted Project

Sep 30 2020

azabaznov added a comment to D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.

LGTM! I'd suggest waiting a bit before committing this though, to give people time to catch up on the RFC.

Sep 30 2020, 2:18 AM · Restricted Project

Sep 25 2020

azabaznov updated azabaznov.
Sep 25 2020, 6:52 AM
azabaznov updated the diff for D88300: [OpenCL] Initial patch for OpenCL C 3.0 support.
Sep 25 2020, 6:44 AM · Restricted Project