Page MenuHomePhabricator

asmith (Aaron Smith)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2017, 3:16 PM (151 w, 6 d)

Recent Activity

Wed, Sep 23

asmith added a comment to D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1.

@rjmccall wrote:
I think you're missing what I'm asking. If LLVM accepts this feature, it will become our collective responsibility as a project to keep it working. You have a large external correctness test suite for this feature. It does not sound like you intend to open-source that test suite; instead, you intend to extract a small number of unit tests from it and add those to the LLVM test suite. So I'm asking if you're at least going to have an external CI bot which will run the full test suite for this feature to ensure it hasn't been broken by the last day of commits. It does not seem reasonable to expect that the few unit tests you extract will themselves be sufficient to keep the feature tested.

Wed, Sep 23, 4:38 PM · Restricted Project, Restricted Project

Thu, Sep 3

asmith added a comment to D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1.

Yes there was an RFC and discussion and several requests for comments.
http://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html

Thu, Sep 3, 11:40 AM · Restricted Project, Restricted Project
asmith accepted D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1.
Thu, Sep 3, 11:03 AM · Restricted Project, Restricted Project

Aug 27 2020

asmith added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

@srhines Not at the moment. I updated the PR with the changes I have locally.

Aug 27 2020, 10:05 AM · Restricted Project
asmith updated the diff for D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.
Aug 27 2020, 10:03 AM · Restricted Project

Aug 3 2020

asmith added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

The buildbot is using MSVC 19.16.27042.0 which is Visual Studio 2017 15.9.25.

Aug 3 2020, 3:21 PM · Restricted Project
asmith added a comment to D84023: Make MSVC generate appropriate __cplusplus macro definition.

The warning is due to the version of Gtest that LLVM is using.

Aug 3 2020, 11:58 AM · Restricted Project

Jul 31 2020

asmith accepted D84023: Make MSVC generate appropriate __cplusplus macro definition.

I think this should be okay. VS2017 or higher are required to build LLVM and this support is in VS2017.

Jul 31 2020, 2:18 PM · Restricted Project
asmith accepted D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error.

Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error"

Jul 31 2020, 2:12 PM · Restricted Project

Jul 10 2020

asmith accepted D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally.
Jul 10 2020, 11:38 AM · Restricted Project

Jul 1 2020

asmith added a comment to D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally.

Thanks for all the helpful feedback. Before we commit this just want to double check there are no final comments?

Jul 1 2020, 12:26 PM · Restricted Project

Jun 16 2020

asmith committed rG7e01675ea50e: [SelectionDAG] Add MVT::bf16 to getConstantFP() (authored by asmith).
[SelectionDAG] Add MVT::bf16 to getConstantFP()
Jun 16 2020, 3:24 PM
asmith closed D81779: [SelectionDAG] Add MVT::bf16 to getConstantFP().
Jun 16 2020, 3:24 PM · Restricted Project

Jun 12 2020

asmith created D81779: [SelectionDAG] Add MVT::bf16 to getConstantFP().
Jun 12 2020, 6:15 PM · Restricted Project

May 22 2020

asmith added inline comments to D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1.
May 22 2020, 8:01 AM · Restricted Project, Restricted Project

May 19 2020

asmith abandoned D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table.

Duplicated by https://reviews.llvm.org/D79474

May 19 2020, 1:14 PM · Restricted Project

May 18 2020

asmith added a comment to D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table.

LGTM. Anyone else have comments?

May 18 2020, 7:32 PM · Restricted Project

May 6 2020

asmith added a comment to D76077: [ARM] Add __bf16 as new Bfloat16 C Type.

really happy for native bfloat support!

May 6 2020, 9:01 PM · Restricted Project

Apr 30 2020

asmith added a comment to D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table.

Thanks for all the comments! Does this look good? Or other considerations?

Apr 30 2020, 5:11 PM · Restricted Project
asmith committed rG4eabd0061254: [Windows SEH] Fix abnormal-exits in _try (authored by asmith).
[Windows SEH] Fix abnormal-exits in _try
Apr 30 2020, 10:09 AM
asmith closed D77936: [Windows SEH] Fix abnormal-exits in _try.
Apr 30 2020, 10:08 AM · Restricted Project
asmith committed rG292058a5d6d7: [clang-format] Fix Microsoft style for enums (authored by asmith).
[clang-format] Fix Microsoft style for enums
Apr 30 2020, 9:36 AM
asmith closed D78982: [clang-format] Fix Microsoft style for enums.
Apr 30 2020, 9:36 AM · Restricted Project, Restricted Project
asmith added a comment to D78982: [clang-format] Fix Microsoft style for enums.

LGTM

Apr 30 2020, 9:35 AM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.
Apr 30 2020, 9:02 AM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.
Apr 30 2020, 9:02 AM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.
Apr 30 2020, 8:30 AM · Restricted Project, Restricted Project

Apr 29 2020

asmith added inline comments to D78982: [clang-format] Fix Microsoft style for enums.
Apr 29 2020, 9:07 AM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.

Enable for C#

Apr 29 2020, 9:06 AM · Restricted Project, Restricted Project
asmith added inline comments to D78982: [clang-format] Fix Microsoft style for enums.
Apr 29 2020, 8:33 AM · Restricted Project, Restricted Project
asmith added a comment to D78982: [clang-format] Fix Microsoft style for enums.

The is done unless there are other comments.

Apr 29 2020, 7:28 AM · Restricted Project, Restricted Project

Apr 28 2020

asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.
Apr 28 2020, 6:22 PM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.
Apr 28 2020, 6:22 PM · Restricted Project, Restricted Project
asmith added a comment to D78982: [clang-format] Fix Microsoft style for enums.
  • This needs unit tests in clang/unittests/Format to demonstrate the problem and test this fixing it
Apr 28 2020, 12:56 PM · Restricted Project, Restricted Project
asmith added inline comments to D78982: [clang-format] Fix Microsoft style for enums.
Apr 28 2020, 12:56 PM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.

Rename option
Add test case
Only apply to Microsoft CPP style

Apr 28 2020, 12:56 PM · Restricted Project, Restricted Project
asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.

Fix line breaks like this:

Apr 28 2020, 12:29 AM · Restricted Project, Restricted Project

Apr 27 2020

asmith updated the diff for D78982: [clang-format] Fix Microsoft style for enums.
Apr 27 2020, 10:05 PM · Restricted Project, Restricted Project
asmith edited reviewers for D78982: [clang-format] Fix Microsoft style for enums, added: rnk; removed: thakis.
Apr 27 2020, 9:33 PM · Restricted Project, Restricted Project
asmith updated the summary of D78982: [clang-format] Fix Microsoft style for enums.
Apr 27 2020, 9:03 PM · Restricted Project, Restricted Project
asmith added a comment to D78982: [clang-format] Fix Microsoft style for enums.

This change tries to fix this bug.
https://bugs.llvm.org/show_bug.cgi?id=32810

Apr 27 2020, 9:02 PM · Restricted Project, Restricted Project
asmith created D78982: [clang-format] Fix Microsoft style for enums.
Apr 27 2020, 9:01 PM · Restricted Project, Restricted Project
asmith added a reviewer for D78982: [clang-format] Fix Microsoft style for enums: thakis.
Apr 27 2020, 9:01 PM · Restricted Project, Restricted Project

Apr 15 2020

asmith added a comment to D78221: [COFF] Assign unique identifiers to ObjFiles from LTO.

Use the unique filenames that are used when /lldsavetemps is passed.

Is this for debug convenience? (llvm-pdbutil dump output) Or required by some tools?

Apr 15 2020, 10:01 PM · Restricted Project

Apr 10 2020

asmith added a reviewer for D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table: tentzen.
Apr 10 2020, 5:15 PM · Restricted Project
asmith updated the diff for D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table.

Nit - update comment

Apr 10 2020, 4:42 PM · Restricted Project
asmith created D77920: [Windows EH] Fix the order of Nested try-catches in $tryMap$ table.
Apr 10 2020, 4:09 PM · Restricted Project

Mar 31 2020

asmith abandoned D76537: [obj2yaml] Dump ELF program headers.
Mar 31 2020, 8:22 PM · Restricted Project

Mar 29 2020

asmith committed rG6dab8067123c: [mlir] Add exp2 conversion to llvm.intr.exp2 (authored by asmith).
[mlir] Add exp2 conversion to llvm.intr.exp2
Mar 29 2020, 1:34 AM
asmith closed D76895: [mlir] Add exp2 conversion to llvm.intr.exp2.
Mar 29 2020, 1:34 AM · Restricted Project
asmith updated the diff for D76895: [mlir] Add exp2 conversion to llvm.intr.exp2.
Mar 29 2020, 1:34 AM · Restricted Project

Mar 26 2020

asmith updated the diff for D76895: [mlir] Add exp2 conversion to llvm.intr.exp2.

Adding a test

Mar 26 2020, 6:32 PM · Restricted Project
asmith added a reviewer for D76895: [mlir] Add exp2 conversion to llvm.intr.exp2: ftynse.
Mar 26 2020, 4:52 PM · Restricted Project
asmith created D76895: [mlir] Add exp2 conversion to llvm.intr.exp2.
Mar 26 2020, 4:52 PM · Restricted Project

Mar 21 2020

asmith added a comment to D60962: [NativePDB] Extend .pdb files search folders.

Curious what the status of this is? Looks like its been ready for almost one year :)

Mar 21 2020, 10:09 AM · Restricted Project

Mar 20 2020

asmith created D76537: [obj2yaml] Dump ELF program headers.
Mar 20 2020, 7:31 PM · Restricted Project
asmith updated the summary of D76537: [obj2yaml] Dump ELF program headers.
Mar 20 2020, 7:31 PM · Restricted Project
asmith committed rGaa1e0e01d89d: [MLIR] Fix Xcode build due to incorrect library path (authored by asmith).
[MLIR] Fix Xcode build due to incorrect library path
Mar 20 2020, 4:51 PM

Nov 18 2019

asmith committed rGdbb64b39b8bc: Fix a print error found while testing llvm-objcopy (authored by asmith).
Fix a print error found while testing llvm-objcopy
Nov 18 2019, 5:19 AM

Oct 14 2019

asmith committed rL374813: Request commit access for asmith.
Request commit access for asmith
Oct 14 2019, 12:56 PM

Sep 23 2019

asmith updated the diff for D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Address comments on comment character #, auto and rst file.

Sep 23 2019, 9:12 PM · Restricted Project
asmith added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Thinks for the patch! I haven't had time to review the meat of it yet, but will try to get back to it in the next couple of days. One quick question in the meantime: what's the motivation behind this? Is it to improve GNU compatibility?

Sep 23 2019, 11:32 AM · Restricted Project

Sep 22 2019

asmith added inline comments to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.
Sep 22 2019, 12:37 PM · Restricted Project
asmith updated the diff for D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Add new options to objcopy documentation

Sep 22 2019, 12:33 PM · Restricted Project
asmith updated the diff for D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Address reviewers comments about auto

Sep 22 2019, 12:24 PM · Restricted Project

Sep 19 2019

asmith added a comment to D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.

Any comments from the llvm-objcopy community?

Sep 19 2019, 10:39 PM · Restricted Project

Sep 17 2019

asmith created D67689: [llvm-objcopy] Add support for --gap-fill and --pad-to options.
Sep 17 2019, 8:44 PM · Restricted Project

Aug 15 2019

asmith committed rG5032c6ea0803: [lldb-server] Disable a test on Windows until it can be fixed (authored by asmith).
[lldb-server] Disable a test on Windows until it can be fixed
Aug 15 2019, 8:51 PM
asmith committed rL369083: [lldb-server] Disable a test on Windows until it can be fixed.
[lldb-server] Disable a test on Windows until it can be fixed
Aug 15 2019, 8:51 PM

Aug 14 2019

asmith committed rG86649980464e: Add missing NativeProcessFactory for lldb-server on Windows (authored by asmith).
Add missing NativeProcessFactory for lldb-server on Windows
Aug 14 2019, 9:41 AM
asmith committed rL368872: Add missing NativeProcessFactory for lldb-server on Windows.
Add missing NativeProcessFactory for lldb-server on Windows
Aug 14 2019, 9:41 AM
asmith abandoned D56233: [lldb-server] Add initial support for lldb-server on Windows.

This was split into separate patches and committed. No longer need this review.

Aug 14 2019, 7:04 AM
asmith committed rG03eacbd489d0: Add missing SetID method to fix Windows build (authored by asmith).
Add missing SetID method to fix Windows build
Aug 14 2019, 6:52 AM
asmith committed rL368852: Add missing SetID method to fix Windows build.
Add missing SetID method to fix Windows build
Aug 14 2019, 6:49 AM

Aug 13 2019

asmith committed rG2a39024ac822: Update Python tests for lldb-server on Windows (authored by asmith).
Update Python tests for lldb-server on Windows
Aug 13 2019, 5:15 PM
asmith committed rL368776: Update Python tests for lldb-server on Windows.
Update Python tests for lldb-server on Windows
Aug 13 2019, 5:15 PM
asmith closed D61687: Update Python tests for lldb-server on Windows.
Aug 13 2019, 5:15 PM · Restricted Project, Restricted Project
asmith added a comment to D61687: Update Python tests for lldb-server on Windows.

Any more comments on the tests for Windows?

Aug 13 2019, 5:01 PM · Restricted Project, Restricted Project
asmith updated the diff for D61687: Update Python tests for lldb-server on Windows.
Aug 13 2019, 5:01 PM · Restricted Project, Restricted Project
asmith committed rG216944ee035a: Enable lldb-server on Windows (authored by asmith).
Enable lldb-server on Windows
Aug 13 2019, 4:53 PM
asmith committed rL368774: Enable lldb-server on Windows.
Enable lldb-server on Windows
Aug 13 2019, 4:50 PM
asmith closed D61686: Enable lldb-server on Windows.
Aug 13 2019, 4:49 PM · Restricted Project
asmith updated the diff for D61686: Enable lldb-server on Windows.
Aug 13 2019, 4:49 PM · Restricted Project
asmith committed rG5146a9ea5d8d: Initial support for native debugging of x86/x64 Windows processes (authored by asmith).
Initial support for native debugging of x86/x64 Windows processes
Aug 13 2019, 3:18 PM
asmith committed rL368759: Initial support for native debugging of x86/x64 Windows processes.
Initial support for native debugging of x86/x64 Windows processes
Aug 13 2019, 3:18 PM
asmith closed D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 3:18 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 3:17 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 3:04 PM · Restricted Project, Restricted Project
asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

This is done.

Aug 13 2019, 1:33 AM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 13 2019, 1:33 AM · Restricted Project, Restricted Project

Aug 11 2019

asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

Any last comments before this is committed?

Aug 11 2019, 4:50 PM · Restricted Project, Restricted Project

Aug 6 2019

asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 6 2019, 7:02 PM · Restricted Project, Restricted Project
asmith added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

Do you need some help fixing the build?

Aug 6 2019, 6:43 AM · Restricted Project, Restricted Project

Aug 2 2019

asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

I can make the one simplification but Im not sure what you are asking as far as the refactoring. Provide an example and I will try to accommodate your request. I'm not going to be able to spend much more time on lldb patches though.

Aug 2 2019, 2:30 AM · Restricted Project, Restricted Project
asmith added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Aug 2 2019, 12:12 AM · Restricted Project, Restricted Project

Jul 30 2019

asmith added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

I don't see anything else to address in this review. Comments?

Jul 30 2019, 5:10 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
Jul 30 2019, 5:05 PM · Restricted Project, Restricted Project

Jul 29 2019

asmith added a comment to D62213: [ABI] Implement Windows ABI for x86_64.

I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub.

Jul 29 2019, 9:23 PM · Restricted Project, Restricted Project
asmith added inline comments to D63165: Initial support for native debugging of x86/x64 Windows processes.
Jul 29 2019, 6:12 PM · Restricted Project, Restricted Project
asmith updated the diff for D63165: Initial support for native debugging of x86/x64 Windows processes.
  • Undo the change to the test client
  • Remove changes for threads
  • Invalidate module cache on loading/unloading DLLs
Jul 29 2019, 6:04 PM · Restricted Project, Restricted Project