- User Since
- Nov 1 2017, 3:16 PM (219 w, 6 d)
Aug 14 2021
Hi, this patch has been up for 3 months. Is there anything reviewers would like addressed before it's committed?
May 13 2021
Thanks everyone for the great feedback!
We'll move forward with landing this first patch and start the review of the next one.
Apr 6 2021
Mar 9 2021
Hi John, how does this look now?
Feb 17 2021
Jan 12 2021
This patch looks ready to land. Are there any other concerns or feedback?
Nov 12 2020
addressed reviewer comments
Oct 23 2020
Since this has no impact on anyone I think we can just commit it. Anyone else want to comment on the change?
Oct 17 2020
Oct 16 2020
Sep 23 2020
I think you're missing what I'm asking. If LLVM accepts this feature, it will become our collective responsibility as a project to keep it working. You have a large external correctness test suite for this feature. It does not sound like you intend to open-source that test suite; instead, you intend to extract a small number of unit tests from it and add those to the LLVM test suite. So I'm asking if you're at least going to have an external CI bot which will run the full test suite for this feature to ensure it hasn't been broken by the last day of commits. It does not seem reasonable to expect that the few unit tests you extract will themselves be sufficient to keep the feature tested.
Sep 3 2020
Yes there was an RFC and discussion and several requests for comments.
Aug 27 2020
@srhines Not at the moment. I updated the PR with the changes I have locally.
Aug 3 2020
The buildbot is using MSVC 19.16.27042.0 which is Visual Studio 2017 15.9.25.
The warning is due to the version of Gtest that LLVM is using.
Jul 31 2020
I think this should be okay. VS2017 or higher are required to build LLVM and this support is in VS2017.
Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error"
Jul 10 2020
Jul 1 2020
Thanks for all the helpful feedback. Before we commit this just want to double check there are no final comments?
Jun 16 2020
Jun 12 2020
May 22 2020
May 19 2020
Duplicated by https://reviews.llvm.org/D79474
May 18 2020
LGTM. Anyone else have comments?
May 6 2020
really happy for native bfloat support!
Apr 30 2020
Thanks for all the comments! Does this look good? Or other considerations?
Apr 29 2020
Enable for C#
The is done unless there are other comments.
Apr 28 2020
Add test case
Only apply to Microsoft CPP style
Fix line breaks like this:
Apr 27 2020
This change tries to fix this bug.
Apr 15 2020
Apr 10 2020
Nit - update comment
Mar 31 2020
Mar 29 2020
Mar 26 2020
Adding a test
Mar 21 2020
Curious what the status of this is? Looks like its been ready for almost one year :)
Mar 20 2020
Nov 18 2019
Oct 14 2019
Sep 23 2019
Address comments on comment character #, auto and rst file.
Sep 22 2019
Add new options to objcopy documentation
Address reviewers comments about auto
Sep 19 2019
Any comments from the llvm-objcopy community?
Sep 17 2019
Aug 15 2019
Aug 14 2019
This was split into separate patches and committed. No longer need this review.
Aug 13 2019
Any more comments on the tests for Windows?