Page MenuHomePhabricator

arnamoy10 (Arnamoy B)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 26 2020, 5:33 AM (14 w, 4 d)

Recent Activity

Fri, Mar 5

arnamoy10 updated the diff for D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.

Updated code through the use of newly introduced FindClauseMult() function, which returns an iterator from the multimap, in case where multiple occurrence of a clause happens within a directive.

Fri, Mar 5, 2:11 PM · Restricted Project
arnamoy10 added a comment to D96875: [flang][driver] Add -fdebug-module-writer option.

OK, I will merge it on Monday unless @tskeith has any other comments.

Fri, Mar 5, 12:29 PM · Restricted Project

Thu, Mar 4

arnamoy10 added a comment to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.

Thanks @arnamoy10 for this patch.

Did you try the other approach that I mentioned using FindClause? I am guessing FindClause will only return a single clause and hence cannot be used directly. Would adding another function (if a similar one does not exist) which returns multiple clauses (using equal_range) work? This way we do not need to use the clauseList.

Thu, Mar 4, 2:54 PM · Restricted Project
arnamoy10 requested review of D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Thu, Mar 4, 9:07 AM · Restricted Project

Wed, Mar 3

arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Fixing build failures, also moved the pipeline check to an existing file.

Wed, Mar 3, 7:17 AM · Restricted Project

Tue, Mar 2

arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Rebased on main

Tue, Mar 2, 1:50 PM · Restricted Project
arnamoy10 updated the diff for D97724: [flang][driver] Fix -fdefault* family bug.

Taken out -module related changes, updated the commit message as well.

Tue, Mar 2, 6:25 AM · Restricted Project, Restricted Project
arnamoy10 retitled D97724: [flang][driver] Fix -fdefault* family bug from [flang][driver] Add -module-dir alias to f18, also fix -fdefault* family bug to [flang][driver] Fix -fdefault* family bug.
Tue, Mar 2, 6:24 AM · Restricted Project, Restricted Project

Mon, Mar 1

arnamoy10 retitled D97119: [flang][driver] Add options for -std=f2018 from [flang][driver] Add options for -std=2018 to [flang][driver] Add options for -std=f2018.
Mon, Mar 1, 1:55 PM · Restricted Project, Restricted Project
arnamoy10 added a comment to D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.

LGTM

Mon, Mar 1, 1:54 PM · Restricted Project, Restricted Project
arnamoy10 requested review of D97724: [flang][driver] Fix -fdefault* family bug.
Mon, Mar 1, 1:22 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D96875: [flang][driver] Add -fdebug-module-writer option.

Minor changes as per comments, also updated commit message to include description of changes related to Setters.

Mon, Mar 1, 11:59 AM · Restricted Project
arnamoy10 updated the summary of D96875: [flang][driver] Add -fdebug-module-writer option.
Mon, Mar 1, 11:19 AM · Restricted Project

Fri, Feb 26

arnamoy10 updated the diff for D97119: [flang][driver] Add options for -std=f2018.
  1. Updated the test case to include a check when the option is not given and make sure works with f18 as well (with Mstandard)
  2. Changed variable names as suggested.
Fri, Feb 26, 11:47 AM · Restricted Project, Restricted Project

Wed, Feb 24

arnamoy10 updated the diff for D97080: [flang][driver] Add -fintrinsic-modules-path option.

Addressing comments, by separating the search directories from fintrinsic-modules-path in a separate variables. Also added dummy modules for the test case, as using %llvmshlibdir did not work out.

Wed, Feb 24, 4:15 PM · Restricted Project, Restricted Project

Sat, Feb 20

arnamoy10 updated the diff for D97080: [flang][driver] Add -fintrinsic-modules-path option.

Updating the test case to include -fc1 as well

Sat, Feb 20, 8:06 AM · Restricted Project, Restricted Project
arnamoy10 requested review of D97119: [flang][driver] Add options for -std=f2018.
Sat, Feb 20, 7:52 AM · Restricted Project, Restricted Project

Fri, Feb 19

arnamoy10 requested review of D97080: [flang][driver] Add -fintrinsic-modules-path option.
Fri, Feb 19, 12:47 PM · Restricted Project, Restricted Project
arnamoy10 updated the summary of D96875: [flang][driver] Add -fdebug-module-writer option.
Fri, Feb 19, 12:27 PM · Restricted Project
arnamoy10 added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Fri, Feb 19, 8:42 AM · Restricted Project
arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Added a missing option test for -flarge-sizes

Fri, Feb 19, 8:42 AM · Restricted Project
arnamoy10 updated the diff for D96875: [flang][driver] Add -fdebug-module-writer option.

Set the option as a frontend-only option, also modified the test case accordingly.

Fri, Feb 19, 4:46 AM · Restricted Project

Thu, Feb 18

arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
  • Rewritten the test cases
  • Moved flarge-sizes to a standalone test file
Thu, Feb 18, 3:04 PM · Restricted Project
arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Updated test case to check module content

Thu, Feb 18, 9:14 AM · Restricted Project
arnamoy10 added inline comments to D96875: [flang][driver] Add -fdebug-module-writer option.
Thu, Feb 18, 6:11 AM · Restricted Project
arnamoy10 added inline comments to D96875: [flang][driver] Add -fdebug-module-writer option.
Thu, Feb 18, 5:38 AM · Restricted Project
arnamoy10 updated the diff for D96875: [flang][driver] Add -fdebug-module-writer option.

Added some setters to work with.

Thu, Feb 18, 5:38 AM · Restricted Project

Wed, Feb 17

arnamoy10 requested review of D96875: [flang][driver] Add -fdebug-module-writer option.
Wed, Feb 17, 9:28 AM · Restricted Project
arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
  • Added option for setting DOUBLE PRECISION when fdefault-real-8 is given
  • Also added link to relevant gfortran doc
Wed, Feb 17, 9:05 AM · Restricted Project
arnamoy10 added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Wed, Feb 17, 8:15 AM · Restricted Project
arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Addresses proper handling of sizes

Wed, Feb 17, 6:54 AM · Restricted Project

Mon, Feb 15

arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Addressed latest reviewer's comments, no longer using a pointer for defaultKinds

Mon, Feb 15, 7:28 AM · Restricted Project

Fri, Feb 12

arnamoy10 updated the diff for D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.

Addressing reviewers' comments.

Fri, Feb 12, 2:26 PM · Restricted Project
arnamoy10 added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Fri, Feb 12, 4:25 AM · Restricted Project

Thu, Feb 11

arnamoy10 added inline comments to D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Thu, Feb 11, 2:29 PM · Restricted Project

Tue, Feb 9

arnamoy10 requested review of D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes.
Tue, Feb 9, 7:39 AM · Restricted Project

Feb 2 2021

arnamoy10 added a comment to D95448: [flang][driver] Add support for `-J/-module-dir`.

Sounds good to me, thanks for the help. In the meantime I will work on the fdefault-* family of flags, which will be dependent on this patch I think.

Feb 2 2021, 7:01 AM · Restricted Project, Restricted Project

Feb 1 2021

arnamoy10 updated the diff for D95448: [flang][driver] Add support for `-J/-module-dir`.

A few more comments addressed and a new test case added for write-module check.

Feb 1 2021, 3:14 PM · Restricted Project, Restricted Project

Jan 30 2021

arnamoy10 updated the diff for D95448: [flang][driver] Add support for `-J/-module-dir`.

Addressing reviewers' comments, adding -module-dir as the default option instead of -J

Jan 30 2021, 9:00 AM · Restricted Project, Restricted Project

Jan 29 2021

arnamoy10 updated the diff for D95448: [flang][driver] Add support for `-J/-module-dir`.

Added test for the driver-help, also contains all the changes that was done in the previous diff (Aliasing -J and -module-dir, changing data structures etc).

Jan 29 2021, 12:10 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D95448: [flang][driver] Add support for `-J/-module-dir`.

Addressing reviewers' comments with the following changes:

Jan 29 2021, 11:49 AM · Restricted Project, Restricted Project

Jan 26 2021

arnamoy10 requested review of D95448: [flang][driver] Add support for `-J/-module-dir`.
Jan 26 2021, 8:02 AM · Restricted Project, Restricted Project

Dec 18 2020

arnamoy10 updated the diff for D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Rebased to the latest master of LLVM

Dec 18 2020, 6:08 AM · Restricted Project

Dec 17 2020

arnamoy10 added a comment to D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

@lebedev.ri Is there any instructions on how to land this? Sorry I am doing it for the first time

Dec 17 2020, 8:32 AM · Restricted Project

Dec 11 2020

arnamoy10 updated the diff for D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Nullptr check change

Dec 11 2020, 11:49 AM · Restricted Project
arnamoy10 updated the diff for D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Creating a patch with more context

Dec 11 2020, 9:12 AM · Restricted Project

Dec 10 2020

arnamoy10 updated the diff for D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Adding more context to the diff.

Dec 10 2020, 10:03 AM · Restricted Project
arnamoy10 updated the diff for D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Using WeakVH instead of Instruction to take care of dangling pointers. Had to replace the "insert" calls of SetVector with a SmallVector push_back

Dec 10 2020, 9:44 AM · Restricted Project

Dec 4 2020

arnamoy10 added a comment to D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Thanks for the suggestion, as per your suggestion, I did the modification in the deleteDeadInstructions() function as follows:

Dec 4 2020, 6:55 AM · Restricted Project

Dec 1 2020

arnamoy10 added a comment to D92431: [SROA] Remove Dead Instructions while creating speculative instructions.

Here is a diff for the content of DeadInsts just before and after a speculatePHINodeLoads()

Dec 1 2020, 2:18 PM · Restricted Project
arnamoy10 requested review of D92431: [SROA] Remove Dead Instructions while creating speculative instructions.
Dec 1 2020, 2:12 PM · Restricted Project