- User Since
- May 29 2020, 9:41 PM (10 w, 3 d)
Thu, Aug 6
Thanks for your review!
Add suggested test.
Address review comments.
Wed, Aug 5
clang-format again. Mention redundancy checks in the Simplex.h header comment and first paragraph of the Simplex class documentation.
Tue, Aug 4
Mon, Aug 3
Addressed comments. Also changed the names of some Simplex objects to simplex for uniformity.
Thu, Jul 30
Jul 2 2020
I don't have commit access yet, so I think someone else will need to land this.
Jul 1 2020
Switched from ArrayRef of ArrayRef to ArrayRef of SmallVectors.
Jun 30 2020
Jun 25 2020
Improved test coverage. There is still one uncovered line; it seems quite difficult to find a case that covers this. I ran hundreds of tests with randomly generated sets intersected with a 1000 x 1000 x 1000 cube. Whenever GBR and the FM/GCD-based algorithm disagreed, I checked against a brute-force that checks every point in this cube. All these tests passed, as well as tests from some other types of generated cases.
Jun 17 2020
Fix a comment in Fraction.
Added the requested test.
Jun 16 2020
I've added some more tests and documentation as requested.
Jun 15 2020
Address comments. Made findIntegerSample iterative.
Jun 11 2020
Thanks for your review. Apologies for the delayed response.
Jun 4 2020
Add two tests of "long" sets. Fix some bugs that this revealed.
Jun 2 2020
Fix some whitespace and clang-format.
Changed the Simplex.cpp comments to use ///. Changed SmallVector function arguments to ArrayRefs.
Use ArrayRef in Matrix::getRow.
Address Jean-Michel's comments.
Jun 1 2020
Thanks for your comments!
Address the remaining reviewer comments by Kayjukh.
Address Kayjukh's reviewer comments.
May 31 2020
resolve clang-tidy warnings
clang-format without --style=LLVM as the pre-merge check seems to want