Page MenuHomePhabricator

arjunp (Arjun P)
User

Projects

User does not belong to any projects.

User Details

User Since
May 29 2020, 9:41 PM (10 w, 3 d)

Recent Activity

Thu, Aug 6

arjunp added a comment to D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

Thanks for your review!

Thu, Aug 6, 9:31 AM · Restricted Project
arjunp updated the diff for D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

Add suggested test.

Thu, Aug 6, 8:50 AM · Restricted Project
arjunp retitled D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex from Redundancy detection for FlatAffineConstraints using Simplex to [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.
Thu, Aug 6, 8:31 AM · Restricted Project
arjunp updated the diff for D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

Address review comments.

Thu, Aug 6, 8:29 AM · Restricted Project

Wed, Aug 5

arjunp updated the diff for D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

clang-format again. Mention redundancy checks in the Simplex.h header comment and first paragraph of the Simplex class documentation.

Wed, Aug 5, 11:11 AM · Restricted Project

Tue, Aug 4

arjunp added inline comments to D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.
Tue, Aug 4, 3:24 AM · Restricted Project
arjunp updated the diff for D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

clang-format.

Tue, Aug 4, 3:23 AM · Restricted Project

Mon, Aug 3

arjunp updated the diff for D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

Addressed comments. Also changed the names of some Simplex objects to simplex for uniformity.

Mon, Aug 3, 9:57 PM · Restricted Project

Thu, Jul 30

arjunp updated the summary of D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.
Thu, Jul 30, 6:42 AM · Restricted Project
arjunp updated the diff for D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.

Improved documentation.

Thu, Jul 30, 5:57 AM · Restricted Project
arjunp retitled D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex from Redundancy detection for FlatAffineConstraints using Simplex This patch adds the capability to perform constraint redundancy checks for FlatAffineConstraints using Simplex, via a new member function FlatAffineConstraints... to Redundancy detection for FlatAffineConstraints using Simplex.
Thu, Jul 30, 5:17 AM · Restricted Project
arjunp requested review of D84935: [MLIR] Redundancy detection for FlatAffineConstraints using Simplex.
Thu, Jul 30, 5:16 AM · Restricted Project

Jul 2 2020

arjunp added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

I don't have commit access yet, so I think someone else will need to land this.

Jul 2 2020, 6:25 AM · Restricted Project, Restricted Project

Jul 1 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

clang-format.

Jul 1 2020, 4:49 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Switched from ArrayRef of ArrayRef to ArrayRef of SmallVectors.

Jul 1 2020, 3:11 AM · Restricted Project, Restricted Project

Jun 30 2020

arjunp added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

Added some tests that GBR detects as empty but the existing FM/GCD-based algorithm does not.

It'll be useful if you marked these tests with a comment to that effect. I might have missed it if you already did.

Jun 30 2020, 7:32 PM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Addressed comments.

Jun 30 2020, 7:32 PM · Restricted Project, Restricted Project

Jun 25 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Improved test coverage. There is still one uncovered line; it seems quite difficult to find a case that covers this. I ran hundreds of tests with randomly generated sets intersected with a 1000 x 1000 x 1000 cube. Whenever GBR and the FM/GCD-based algorithm disagreed, I checked against a brute-force that checks every point in this cube. All these tests passed, as well as tests from some other types of generated cases.

Jun 25 2020, 5:29 PM · Restricted Project, Restricted Project

Jun 17 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Fix a comment in Fraction.

Jun 17 2020, 1:02 AM · Restricted Project, Restricted Project
arjunp added inline comments to D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 17 2020, 1:02 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Added the requested test.

Jun 17 2020, 1:02 AM · Restricted Project, Restricted Project

Jun 16 2020

arjunp added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

I've added some more tests and documentation as requested.

Jun 16 2020, 4:24 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Addressed comments.

Jun 16 2020, 4:24 AM · Restricted Project, Restricted Project

Jun 15 2020

arjunp added inline comments to D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 15 2020, 4:35 PM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Address comments. Made findIntegerSample iterative.

Jun 15 2020, 4:35 PM · Restricted Project, Restricted Project

Jun 11 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 11 2020, 2:53 PM · Restricted Project, Restricted Project
arjunp added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

Thanks for your review. Apologies for the delayed response.

Jun 11 2020, 2:53 PM · Restricted Project, Restricted Project

Jun 4 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Add two tests of "long" sets. Fix some bugs that this revealed.

Jun 4 2020, 4:50 AM · Restricted Project, Restricted Project

Jun 2 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Fix some whitespace and clang-format.

Jun 2 2020, 2:45 AM · Restricted Project, Restricted Project
arjunp added inline comments to D80860: Exact integer emptiness checks for FlatAffineConstraints.
Jun 2 2020, 1:04 AM · Restricted Project, Restricted Project
arjunp added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

Changed the Simplex.cpp comments to use ///. Changed SmallVector function arguments to ArrayRefs.

Jun 2 2020, 1:04 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Use ArrayRef in Matrix::getRow.

Jun 2 2020, 1:04 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Address Jean-Michel's comments.

Jun 2 2020, 1:04 AM · Restricted Project, Restricted Project

Jun 1 2020

arjunp added a comment to D80860: Exact integer emptiness checks for FlatAffineConstraints.

Thanks for your comments!

Jun 1 2020, 4:46 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Address the remaining reviewer comments by Kayjukh.

Jun 1 2020, 4:14 AM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

Address Kayjukh's reviewer comments.

Jun 1 2020, 12:29 AM · Restricted Project, Restricted Project

May 31 2020

arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

clang-format again.

May 31 2020, 1:02 PM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

resolve clang-tidy warnings

May 31 2020, 12:30 PM · Restricted Project, Restricted Project
arjunp updated the diff for D80860: Exact integer emptiness checks for FlatAffineConstraints.

clang-format without --style=LLVM as the pre-merge check seems to want

May 31 2020, 11:26 AM · Restricted Project, Restricted Project

May 29 2020

arjunp created D80860: Exact integer emptiness checks for FlatAffineConstraints.
May 29 2020, 11:22 PM · Restricted Project, Restricted Project