Page MenuHomePhabricator

anjankgk (Anjan Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2020, 6:56 AM (28 w, 4 d)

Recent Activity

Tue, Jan 12

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Another gentle reminder for the review.. Thanks!

Tue, Jan 12, 5:41 AM · Restricted Project

Mon, Jan 4

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Gentle ping...

Mon, Jan 4, 10:33 AM · Restricted Project

Dec 18 2020

anjankgk added a comment to D88460: Strlen loop idiom recognition.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Thank you for the feedback @hiraditya! I have tested the latest patch at various options (O2, O3, LTO and PGO) against the SPEC benchmarks as well as run the lnt tests and bootstrap tests successfully. If you were concerned about any other specific testsuite, pls let me know.

Nice, if we have performance improvements on any of the benchmarks/workloads then do share.

Dec 18 2020, 5:24 AM · Restricted Project

Dec 16 2020

anjankgk added a comment to D88460: Strlen loop idiom recognition.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Dec 16 2020, 9:16 AM · Restricted Project
anjankgk added a comment to D88460: Strlen loop idiom recognition.

Phabricator doesn't track incremental patches the way you're uploading them; please upload the full diff against master.

Dec 16 2020, 9:14 AM · Restricted Project
anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Changes from previous review comments:

  • Replaced LCSSAEv->getStart() by LoadEv->getStart()
  • Added another test function where multiple LCSSAPhi nodes were present and therefore shouldn't have replaced with strlen function.
Dec 16 2020, 9:12 AM · Restricted Project

Oct 19 2020

anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Rewrite the LCSSAPhi instruction to reflect strlen idiom recognition.

Oct 19 2020, 3:27 PM · Restricted Project

Oct 15 2020

anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 15 2020, 2:37 PM · Restricted Project

Oct 7 2020

anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 7 2020, 8:05 PM · Restricted Project
anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 7 2020, 3:31 PM · Restricted Project
anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Check for i8 type and use update_test_checks.py for testfile.

Oct 7 2020, 3:24 PM · Restricted Project
anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 7 2020, 3:15 PM · Restricted Project

Oct 2 2020

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Gentle ping..

Oct 2 2020, 6:47 AM · Restricted Project
anjankgk added reviewers for D88460: Strlen loop idiom recognition: bmahjour, etiotto.
Oct 2 2020, 6:46 AM · Restricted Project

Sep 28 2020

anjankgk requested review of D88460: Strlen loop idiom recognition.
Sep 28 2020, 6:19 PM · Restricted Project