Page MenuHomePhabricator

andrewng (Andrew Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2017, 6:37 AM (195 w, 13 h)

Recent Activity

Oct 26 2020

andrewng committed rG2add7c5cf3eb: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables (authored by andrewng).
[llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables
Oct 26 2020, 5:41 AM
andrewng closed D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 26 2020, 5:41 AM · Restricted Project

Oct 22 2020

andrewng abandoned D89789: [LLD][ELF] Add --force-tls-variant2 option.
Oct 22 2020, 10:23 AM
andrewng updated the diff for D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.

Update to clarify the purpose of the initial call to writeSymbolTableHeader.

Oct 22 2020, 9:14 AM · Restricted Project
andrewng added inline comments to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 22 2020, 6:49 AM · Restricted Project
andrewng added inline comments to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 22 2020, 6:42 AM · Restricted Project
andrewng added a comment to D89789: [LLD][ELF] Add --force-tls-variant2 option.

Putting together, I think this option cannot be accepted.
On the good side, the place you modify is very stable and you usually will not get merge conflict.

Oct 22 2020, 6:19 AM
andrewng added inline comments to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 22 2020, 6:07 AM · Restricted Project
andrewng added a comment to D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.

I understand that a test may be problematic because it requires 4+GiB output. Do you have a script to craft such a test case so that people working on llvm-ar can run it on demand? The test can have UNSUPPORTED: *.

Oct 22 2020, 5:08 AM · Restricted Project
andrewng updated the diff for D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.

Updated to address review comments and updated to add better testing. Whilst adding this testing, found another bug in the detection code; it was also not accounting for the size of the file signature!

Oct 22 2020, 5:02 AM · Restricted Project

Oct 21 2020

andrewng requested review of D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables.
Oct 21 2020, 8:58 AM · Restricted Project

Oct 20 2020

andrewng requested review of D89789: [LLD][ELF] Add --force-tls-variant2 option.
Oct 20 2020, 6:29 AM

Oct 15 2020

andrewng committed rG88ce27c39c5e: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases" (authored by andrewng).
[LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases"
Oct 15 2020, 4:49 AM
andrewng closed D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 15 2020, 4:48 AM · Restricted Project

Oct 14 2020

andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 14 2020, 1:56 AM · Restricted Project

Oct 13 2020

andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 13 2020, 3:26 PM · Restricted Project
andrewng added a comment to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".

Ping.

Oct 13 2020, 5:53 AM · Restricted Project

Oct 8 2020

andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 8 2020, 1:40 AM · Restricted Project

Oct 6 2020

andrewng added a comment to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".

The description can be shortened a bit. The important part is that variableEq returns false if two relocations reference a pair of aliased symbols in an ineligible section.

Oct 6 2020, 3:05 AM · Restricted Project
andrewng added inline comments to D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 6 2020, 2:54 AM · Restricted Project
andrewng updated the diff for D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".

Address review comments.

Oct 6 2020, 2:53 AM · Restricted Project

Oct 5 2020

andrewng abandoned D88151: [LLD][ELF] Fix inconsistencies with ICF equality class.

Abandoning due to lack of interest and in favour of D88830 which requires these changes.

Oct 5 2020, 6:12 AM
andrewng requested review of D88830: [LLD][ELF] Improve ICF for relocations to ineligible sections via "aliases".
Oct 5 2020, 6:10 AM · Restricted Project

Sep 23 2020

andrewng added inline comments to D88151: [LLD][ELF] Fix inconsistencies with ICF equality class.
Sep 23 2020, 9:13 AM
andrewng added a comment to D88151: [LLD][ELF] Fix inconsistencies with ICF equality class.

I may be missing something about how the ICF code works, but whilst looking at a separate ICF performance issue, I noticed these oddities in the code. I haven't actually seen any issues myself but reading through the code, it feels like there could be issues. Although I suspect they would be highly unlikely or perhaps not possible in actual practice.

Sep 23 2020, 7:59 AM
andrewng updated subscribers of D88151: [LLD][ELF] Fix inconsistencies with ICF equality class.
Sep 23 2020, 7:51 AM
andrewng requested review of D88151: [LLD][ELF] Fix inconsistencies with ICF equality class.
Sep 23 2020, 7:50 AM

Sep 16 2020

andrewng committed rG77152a6b7ac0: [LLD][ELF] Optimize linker script filename glob pattern matching NFC (authored by andrewng).
[LLD][ELF] Optimize linker script filename glob pattern matching NFC
Sep 16 2020, 2:28 AM
andrewng committed rG6040e2a6d97d: [Support] Add GlobPattern::isTrivialMatchAll() (authored by andrewng).
[Support] Add GlobPattern::isTrivialMatchAll()
Sep 16 2020, 2:28 AM
andrewng closed D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.
Sep 16 2020, 2:27 AM · Restricted Project
andrewng closed D87468: [Support] Add GlobPattern::isTrivialMatchAll().
Sep 16 2020, 2:27 AM · Restricted Project

Sep 15 2020

andrewng added inline comments to D87468: [Support] Add GlobPattern::isTrivialMatchAll().
Sep 15 2020, 10:55 AM · Restricted Project
andrewng updated the diff for D87468: [Support] Add GlobPattern::isTrivialMatchAll().

Update for review suggestion.

Sep 15 2020, 10:55 AM · Restricted Project
andrewng added inline comments to D87468: [Support] Add GlobPattern::isTrivialMatchAll().
Sep 15 2020, 7:15 AM · Restricted Project
andrewng updated the diff for D87468: [Support] Add GlobPattern::isTrivialMatchAll().

Update for review comments.

Sep 15 2020, 7:06 AM · Restricted Project
andrewng added inline comments to D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.
Sep 15 2020, 6:30 AM · Restricted Project
andrewng updated the diff for D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.

Update to address review comments.

Sep 15 2020, 6:12 AM · Restricted Project

Sep 11 2020

andrewng added a comment to D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.

I think this is fine approach in general. I wonder if it should/could be splitted into 2 patches though:
one for InputSectionDescription and one for SectionPattern?

Sep 11 2020, 8:01 AM · Restricted Project
andrewng updated the diff for D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.

Update to address review comments and suggestions.

Sep 11 2020, 7:56 AM · Restricted Project
andrewng added inline comments to D87468: [Support] Add GlobPattern::isTrivialMatchAll().
Sep 11 2020, 7:52 AM · Restricted Project
andrewng updated the diff for D87468: [Support] Add GlobPattern::isTrivialMatchAll().

Updated to address review comments and suggestions.

Sep 11 2020, 7:48 AM · Restricted Project

Sep 10 2020

andrewng added a comment to D87468: [Support] Add GlobPattern::isTrivialMatchAll().

Can you demonstrate how the old code has overhead related to the input?

Sep 10 2020, 11:17 AM · Restricted Project
andrewng added inline comments to D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.
Sep 10 2020, 11:01 AM · Restricted Project
andrewng added a comment to D87468: [Support] Add GlobPattern::isTrivialMatchAll().

GlobPattern::matchOne has a fast path for '*'. Isn't it fast enough?

Sep 10 2020, 10:52 AM · Restricted Project
andrewng added a comment to D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.

This change requires D87468.

Sep 10 2020, 10:24 AM · Restricted Project
andrewng added a comment to D87468: [Support] Add GlobPattern::isTrivialMatchAll().

This is a prerequisite of D87469.

Sep 10 2020, 10:23 AM · Restricted Project
andrewng added a reviewer for D87468: [Support] Add GlobPattern::isTrivialMatchAll(): grimar.
Sep 10 2020, 10:22 AM · Restricted Project
andrewng requested review of D87469: [LLD][ELF] Optimize linker script filename glob pattern matching NFC.
Sep 10 2020, 10:20 AM · Restricted Project
andrewng requested review of D87468: [Support] Add GlobPattern::isTrivialMatchAll().
Sep 10 2020, 10:15 AM · Restricted Project
andrewng added inline comments to D87272: [lld] Buffer writes when composing a single diagnostic.
Sep 10 2020, 2:25 AM · Restricted Project

Sep 8 2020

andrewng committed rG863aa0a37bd1: [LLD][ELF] Fix performance of MarkLive::scanEhFrameSection (authored by andrewng).
[LLD][ELF] Fix performance of MarkLive::scanEhFrameSection
Sep 8 2020, 11:36 AM
andrewng closed D87245: [LLD][ELF] Fix performance of MarkLive::scanEhFrameSection.
Sep 8 2020, 11:36 AM · Restricted Project
andrewng added a comment to D87245: [LLD][ELF] Fix performance of MarkLive::scanEhFrameSection.

Thanks for noting this issue! Were you profiling ld.lld?

Sep 8 2020, 1:59 AM · Restricted Project
andrewng updated the diff for D87245: [LLD][ELF] Fix performance of MarkLive::scanEhFrameSection.

Address review comments.

Sep 8 2020, 1:51 AM · Restricted Project

Sep 7 2020

andrewng requested review of D87245: [LLD][ELF] Fix performance of MarkLive::scanEhFrameSection.
Sep 7 2020, 10:09 AM · Restricted Project

Aug 27 2020

andrewng committed rGd4e2e2852aff: [ELF][test] Add test coverage of TLS to gc-sections.s (authored by andrewng).
[ELF][test] Add test coverage of TLS to gc-sections.s
Aug 27 2020, 4:30 AM
andrewng closed D86639: [ELF][test] Add test coverage of TLS to gc-sections.s.
Aug 27 2020, 4:30 AM · Restricted Project

Aug 26 2020

andrewng requested review of D86639: [ELF][test] Add test coverage of TLS to gc-sections.s.
Aug 26 2020, 9:46 AM · Restricted Project
andrewng accepted D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle().

LGTM with that last one change.

Aug 26 2020, 7:21 AM · Restricted Project
andrewng added inline comments to D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle().
Aug 26 2020, 6:20 AM · Restricted Project
andrewng added inline comments to D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle().
Aug 26 2020, 6:01 AM · Restricted Project
andrewng added inline comments to D86564: [Support][Windows] Fix incorrect GetFinalPathNameByHandleW() return value check in realPathFromHandle().
Aug 26 2020, 2:34 AM · Restricted Project

Jul 29 2020

andrewng committed rG8725a49409c4: [ELF][test] Add test coverage of `__real_` to wrap-plt.s (authored by andrewng).
[ELF][test] Add test coverage of `__real_` to wrap-plt.s
Jul 29 2020, 6:12 AM
andrewng closed D84749: [ELF][test] Add test coverage of `__real_` to wrap-plt.s.
Jul 29 2020, 6:12 AM · Restricted Project

Jul 28 2020

andrewng requested review of D84749: [ELF][test] Add test coverage of `__real_` to wrap-plt.s.
Jul 28 2020, 6:41 AM · Restricted Project

Jul 15 2020

andrewng committed rGf6eb5daa1636: [Support] Fix Windows directory_iterator_construct out of bounds (authored by andrewng).
[Support] Fix Windows directory_iterator_construct out of bounds
Jul 15 2020, 2:19 AM
andrewng closed D83689: [Support] Fix Windows directory_iterator_construct out of bounds.
Jul 15 2020, 2:19 AM · Restricted Project

Jul 13 2020

Herald added a project to D83689: [Support] Fix Windows directory_iterator_construct out of bounds: Restricted Project.
Jul 13 2020, 10:04 AM · Restricted Project

Jul 9 2020

andrewng added a comment to D83321: [Support] Fix utf16 path's index upper bound.

That test is for widenPath and it does cover a similar situation (I know because I wrote it). The code you have changed relates to directory_iterator_construct which does not have coverage of the situation where the UTF16 length is less than the UTF8 length, i.e. the issue that you are fixing.

Jul 9 2020, 6:55 AM · Restricted Project
andrewng added a comment to D83321: [Support] Fix utf16 path's index upper bound.

Full context attached @andrewng .

Jul 9 2020, 3:53 AM · Restricted Project

Jul 8 2020

andrewng added a comment to D83321: [Support] Fix utf16 path's index upper bound.

The usual practice is to include the entire context in the diff. However, the change itself LGTM.

Jul 8 2020, 8:28 AM · Restricted Project

Apr 14 2020

andrewng added a comment to D77750: [ELF][test] Improve reproduce tests and enable for Windows.

Can you take a look, please?

Apr 14 2020, 8:00 AM · Restricted Project

Apr 9 2020

andrewng committed rGd08105482e15: [ELF][test] Improve reproduce tests and enable for Windows (authored by andrewng).
[ELF][test] Improve reproduce tests and enable for Windows
Apr 9 2020, 8:08 AM
andrewng closed D77750: [ELF][test] Improve reproduce tests and enable for Windows.
Apr 9 2020, 8:08 AM · Restricted Project

Apr 8 2020

andrewng created D77750: [ELF][test] Improve reproduce tests and enable for Windows.
Apr 8 2020, 1:02 PM · Restricted Project
andrewng committed rG3db215089f48: [ELF][test] Add reproduce test for dependent libraries (authored by andrewng).
[ELF][test] Add reproduce test for dependent libraries
Apr 8 2020, 5:24 AM
andrewng closed D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 8 2020, 5:24 AM · Restricted Project
andrewng added inline comments to D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 8 2020, 4:17 AM · Restricted Project
andrewng updated the diff for D77659: [ELF][test] Add reproduce test for dependent libraries.

Add comment to explain the Windows deficiencies (one of many)...

Apr 8 2020, 3:12 AM · Restricted Project
andrewng added inline comments to D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 8 2020, 2:39 AM · Restricted Project

Apr 7 2020

andrewng added inline comments to D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 7 2020, 2:10 PM · Restricted Project
andrewng updated the diff for D77659: [ELF][test] Add reproduce test for dependent libraries.

Updated to address review comments.

Apr 7 2020, 2:10 PM · Restricted Project
andrewng added inline comments to D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 7 2020, 11:23 AM · Restricted Project
andrewng updated the diff for D77659: [ELF][test] Add reproduce test for dependent libraries.

Updated to address review comments.

Apr 7 2020, 11:23 AM · Restricted Project
andrewng created D77659: [ELF][test] Add reproduce test for dependent libraries.
Apr 7 2020, 9:44 AM · Restricted Project

Apr 6 2020

andrewng added a comment to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

grimar, andrewng: You both have checkout and build on different drives too, yes?

Apr 6 2020, 3:45 AM · Restricted Project, Restricted Project

Apr 3 2020

andrewng added a comment to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

The following patch fixes my issues on Windows, but I haven't tested that it doesn't break anything else:

Apr 3 2020, 5:20 AM · Restricted Project, Restricted Project

Mar 23 2020

andrewng committed rG328b72dd8209: [Support] Fix clang warning in widenPath NFC (authored by andrewng).
[Support] Fix clang warning in widenPath NFC
Mar 23 2020, 12:01 PM
andrewng closed D76544: [Support] Fix clang warning in widenPath NFC.
Mar 23 2020, 12:01 PM · Restricted Project

Mar 21 2020

andrewng created D76544: [Support] Fix clang warning in widenPath NFC.
Mar 21 2020, 5:20 AM · Restricted Project

Mar 19 2020

andrewng committed rGe6f6c551213a: [Support] Improve Windows widenPath and add support for long UNC paths (authored by andrewng).
[Support] Improve Windows widenPath and add support for long UNC paths
Mar 19 2020, 6:27 AM
andrewng closed D75372: [Support] Improve Windows widenPath and add support for long UNC paths.
Mar 19 2020, 6:27 AM · Restricted Project

Mar 16 2020

andrewng added a comment to D75372: [Support] Improve Windows widenPath and add support for long UNC paths.

Ping.

Mar 16 2020, 5:52 AM · Restricted Project

Mar 9 2020

andrewng added a comment to D75372: [Support] Improve Windows widenPath and add support for long UNC paths.

Ping.

Mar 9 2020, 4:48 AM · Restricted Project

Mar 2 2020

andrewng updated the summary of D75372: [Support] Improve Windows widenPath and add support for long UNC paths.
Mar 2 2020, 3:53 AM · Restricted Project
andrewng updated the diff for D75372: [Support] Improve Windows widenPath and add support for long UNC paths.

Updated to address review comments and suggestions.

Mar 2 2020, 3:53 AM · Restricted Project
andrewng added inline comments to D75372: [Support] Improve Windows widenPath and add support for long UNC paths.
Mar 2 2020, 3:53 AM · Restricted Project

Feb 28 2020

andrewng created D75372: [Support] Improve Windows widenPath and add support for long UNC paths.
Feb 28 2020, 10:51 AM · Restricted Project

Feb 14 2020

andrewng added a comment to D74477: [llvm-ar] Simplify Windows comparePaths NFCI.

Just curious: Do we know that the paths stored in the archive are actually UTF-8 and not just MBCS using whatever code page the user had when they created the archive?

Feb 14 2020, 4:34 AM · Restricted Project
andrewng committed rG430fc538e6dc: [llvm-ar] Simplify Windows comparePaths NFCI (authored by andrewng).
[llvm-ar] Simplify Windows comparePaths NFCI
Feb 14 2020, 3:24 AM