Page MenuHomePhabricator

andrewjcg (Andrew Gallagher)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 11 2018, 4:24 PM (140 w, 4 d)

Recent Activity

Sep 18 2020

andrewjcg added a comment to D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag.

@vsk: Looks good, thanks!

Sep 18 2020, 3:04 PM · Restricted Project
andrewjcg retitled D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag from [llvm-cov] Allow commas in filenams passed to `-object` flag to [llvm-cov] Allow commas in filenames passed to `-object` flag.
Sep 18 2020, 12:14 PM · Restricted Project

Sep 15 2020

andrewjcg added a comment to D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag.

As I don't have commit access, is there someone on this diff that can push this? Or is there some process for this?

Sep 15 2020, 12:38 PM · Restricted Project
andrewjcg added inline comments to D83154: [clang] Add -fprofile-prefix-map.
Sep 15 2020, 11:28 AM · Restricted Project

Sep 14 2020

andrewjcg updated the diff for D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag.

test for something more than exit code

Sep 14 2020, 10:17 PM · Restricted Project

Sep 10 2020

andrewjcg updated the diff for D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag.

add test

Sep 10 2020, 2:28 PM · Restricted Project

Sep 2 2020

andrewjcg updated the diff for D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`.

feedback

Sep 2 2020, 10:16 AM · Restricted Project

Sep 1 2020

andrewjcg added reviewers for D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag: vsk, arphaman.
Sep 1 2020, 10:56 PM · Restricted Project
andrewjcg requested review of D87003: [llvm-cov] Allow commas in filenames passed to `-object` flag.
Sep 1 2020, 10:55 PM · Restricted Project
andrewjcg abandoned D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

Ahh, I see, make sense.

Sep 1 2020, 1:16 PM · Restricted Project
andrewjcg updated the diff for D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

simplify test

Sep 1 2020, 11:38 AM · Restricted Project

Aug 30 2020

andrewjcg updated the summary of D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`.
Aug 30 2020, 2:27 PM · Restricted Project
andrewjcg retitled D86853: [modules] Fix crash in call to `FunctionDecl::setPure()` from [modules] Repro for pure virtual base class method crash to [modules] Fix crash in call to `FunctionDecl::setPure()`.
Aug 30 2020, 2:00 PM · Restricted Project
andrewjcg requested review of D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`.
Aug 30 2020, 2:00 PM · Restricted Project

Aug 28 2020

andrewjcg updated the diff for D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

add test

Aug 28 2020, 1:32 PM · Restricted Project
andrewjcg added a comment to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

How about a malformed module map is not loaded and gives no errors?

Aug 28 2020, 12:46 PM · Restricted Project
andrewjcg added a comment to D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.

Can you add a simple testcase to prove the point of the change?

Aug 28 2020, 12:28 PM · Restricted Project
andrewjcg added a reviewer for D86802: [Modules] Don't parse/load explicit module maps if modules are disabled: bruno.
Aug 28 2020, 12:13 PM · Restricted Project
andrewjcg requested review of D86802: [Modules] Don't parse/load explicit module maps if modules are disabled.
Aug 28 2020, 12:13 PM · Restricted Project

Aug 1 2020

andrewjcg updated the summary of D85084: [modules] Repro for pure virtual base class method crash.
Aug 1 2020, 4:35 PM · Restricted Project
andrewjcg updated the summary of D85084: [modules] Repro for pure virtual base class method crash.
Aug 1 2020, 4:35 PM · Restricted Project
andrewjcg updated the summary of D85084: [modules] Repro for pure virtual base class method crash.
Aug 1 2020, 4:31 PM · Restricted Project
andrewjcg requested review of D85084: [modules] Repro for pure virtual base class method crash.
Aug 1 2020, 4:31 PM · Restricted Project

Dec 4 2019

andrewjcg updated the diff for D70219: Make `-fmodule-file=<name>=<path>` apply to .pcm file compilations.

rebase onto monorepo and clang-format

Dec 4 2019, 12:35 PM · Restricted Project

Nov 13 2019

andrewjcg updated subscribers of D70219: Make `-fmodule-file=<name>=<path>` apply to .pcm file compilations.
Nov 13 2019, 9:14 PM · Restricted Project
andrewjcg added reviewers for D70219: Make `-fmodule-file=<name>=<path>` apply to .pcm file compilations: dblaikie, rsmith.
Nov 13 2019, 9:14 PM · Restricted Project
andrewjcg created D70219: Make `-fmodule-file=<name>=<path>` apply to .pcm file compilations.
Nov 13 2019, 9:12 PM · Restricted Project

Apr 10 2019

andrewjcg added a comment to D58920: [Modules][PR39287] Consolidate multiple std's.

Sorry for the delay. Just catching up on the code this covers, so apologies if the questions don't make sense.

Apr 10 2019, 9:54 AM · Restricted Project

Feb 21 2019

Herald added a project to D52956: Support `-fno-visibility-inlines-hidden`: Restricted Project.

Sorry for the delay here, but this should be ready to go.

Feb 21 2019, 4:44 PM · Restricted Project

Nov 29 2018

andrewjcg added a comment to D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

I don't think we need to change the serialization format for this: a serialized path beginning with / is already treated as absolute and any other path is already treated as relative, so we don't need a flag to carry that information.

Nov 29 2018, 8:14 PM

Oct 7 2018

andrewjcg added a reviewer for D52956: Support `-fno-visibility-inlines-hidden`: elsteveogrande.
Oct 7 2018, 11:20 AM · Restricted Project

Oct 5 2018

andrewjcg created D52956: Support `-fno-visibility-inlines-hidden`.
Oct 5 2018, 5:10 PM · Restricted Project

Sep 24 2018

andrewjcg updated the summary of D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 24 2018, 9:56 AM
andrewjcg retitled D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules from [modules] Add `-fdisable-module-directory` flag for relocatable modules to [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 24 2018, 9:56 AM
andrewjcg updated the diff for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

Dropping the module directory entirely and fully resolving paths on serialization
broke some things during deserialization, specifically when the deserializer wanted
to update paths to use an alternate module directory.

Sep 24 2018, 9:56 AM

Sep 1 2018

andrewjcg updated the diff for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

fix umbrella writing

Sep 1 2018, 1:16 AM
andrewjcg added a comment to D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.

I'm not sure this is the best approach, but I wasn't sure of a better one (to support module files w/o absolute paths). Another approach I tried, was relativizing the other input files (from outside the module directory) using chains of ../ (e.g. ../../../../../other/modules/module.modulemap), but this causes issues when symlinks appear in the module directory path. Another potential option could be to add a bit to the serialized module format for each input, to allow some inputs to mark themselves as relative to the CWD, rather than the module directory.

Sep 1 2018, 12:56 AM
andrewjcg updated subscribers of D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 1 2018, 12:50 AM
andrewjcg added a reviewer for D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules: rsmith.
Sep 1 2018, 12:50 AM
andrewjcg created D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules.
Sep 1 2018, 12:50 AM