Page MenuHomePhabricator

alexshap (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (218 w, 2 d)

Recent Activity

Fri, Sep 25

alexshap committed rG97702c3d9234: [Object][MachO] Refine the interface of Slice (authored by alexshap).
[Object][MachO] Refine the interface of Slice
Fri, Sep 25, 4:28 PM
alexshap closed D88320: [Object][MachO] Refine interface of Slice.
Fri, Sep 25, 4:28 PM · Restricted Project
alexshap updated the diff for D88320: [Object][MachO] Refine interface of Slice.

Apply clang-format

Fri, Sep 25, 11:16 AM · Restricted Project
alexshap added a reviewer for D88320: [Object][MachO] Refine interface of Slice: rupprecht.
Fri, Sep 25, 11:07 AM · Restricted Project
alexshap requested review of D88320: [Object][MachO] Refine interface of Slice.
Fri, Sep 25, 9:56 AM · Restricted Project
alexshap updated subscribers of D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 5:11 AM · Restricted Project
alexshap added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 4:24 AM · Restricted Project

Thu, Sep 24

alexshap added a reviewer for D88213: [llvm-objcopy][NFC] refactor error handling. part 2.: mstorsjo.
Thu, Sep 24, 10:41 AM · Restricted Project
alexshap accepted D88113: [llvm-objcopy][NFC] refactor error handling. part 1..

LG, thanks

Thu, Sep 24, 3:24 AM · Restricted Project
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Thu, Sep 24, 2:21 AM · Restricted Project
alexshap committed rGe60a760b7da9: [llvm-objcopy][MachO] Fix --add-section (authored by alexshap).
[llvm-objcopy][MachO] Fix --add-section
Thu, Sep 24, 1:51 AM
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Thu, Sep 24, 1:24 AM · Restricted Project
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Thu, Sep 24, 1:18 AM · Restricted Project
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Thu, Sep 24, 12:30 AM · Restricted Project
alexshap added a comment to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..

apart from the minor comment above, I think this change is in the right direction. Looks good.

Thu, Sep 24, 12:17 AM · Restricted Project

Fri, Sep 18

alexshap committed rG2ca68b6542cf: [llvm-objcopy][MachO] Clean up the interface of Object (authored by alexshap).
[llvm-objcopy][MachO] Clean up the interface of Object
Fri, Sep 18, 6:27 PM
alexshap committed rG5495b6916469: [llvm-objcopy][MachO] Add llvm-bitcode-strip driver (authored by alexshap).
[llvm-objcopy][MachO] Add llvm-bitcode-strip driver
Fri, Sep 18, 6:14 PM
alexshap closed D87493: [llvm-install-name-tool] Update the command-line guide.
Fri, Sep 18, 6:07 PM · Restricted Project
alexshap committed rGe9f9027c3c07: [llvm-install-name-tool] Validate -id value early (authored by alexshap).
[llvm-install-name-tool] Validate -id value early
Fri, Sep 18, 6:03 PM
alexshap closed D87855: [llvm-install-name-tool] Validate -id value early.
Fri, Sep 18, 6:03 PM · Restricted Project

Thu, Sep 17

alexshap updated the diff for D87855: [llvm-install-name-tool] Validate -id value early.

Apply clang-format

Thu, Sep 17, 1:57 PM · Restricted Project
alexshap committed rG53ba045f488f: [llvm-install-name-tool] Update the command-line guide (authored by alexshap).
[llvm-install-name-tool] Update the command-line guide
Thu, Sep 17, 1:45 PM
alexshap requested review of D87855: [llvm-install-name-tool] Validate -id value early.
Thu, Sep 17, 1:39 PM · Restricted Project

Thu, Sep 10

alexshap requested review of D87493: [llvm-install-name-tool] Update the command-line guide.
Thu, Sep 10, 10:10 PM · Restricted Project

Wed, Sep 9

alexshap committed rGb897729a39d3: [llvm-install-name-tool] Add -V flag (authored by alexshap).
[llvm-install-name-tool] Add -V flag
Wed, Sep 9, 5:25 PM
alexshap closed D87264: [llvm-install-name-tool] Add -V flag.
Wed, Sep 9, 5:25 PM · Restricted Project

Tue, Sep 8

alexshap committed rGce49b7d9ca01: [llvm-install-name-tool] Add a test with multiple input files (authored by alexshap).
[llvm-install-name-tool] Add a test with multiple input files
Tue, Sep 8, 11:32 AM
alexshap closed D87268: [llvm-install-name-tool] Add a test with multiple input files.
Tue, Sep 8, 11:31 AM · Restricted Project

Mon, Sep 7

alexshap requested review of D87268: [llvm-install-name-tool] Add a test with multiple input files.
Mon, Sep 7, 10:05 PM · Restricted Project
alexshap requested review of D87264: [llvm-install-name-tool] Add -V flag.
Mon, Sep 7, 9:15 PM · Restricted Project
alexshap committed rG10af5bad443d: [llvm-objcopy] Consolidate and unify version tests (authored by alexshap).
[llvm-objcopy] Consolidate and unify version tests
Mon, Sep 7, 6:45 PM
alexshap closed D87211: [llvm-objcopy] Consolidate and unify version tests.
Mon, Sep 7, 6:44 PM · Restricted Project
alexshap added inline comments to D87211: [llvm-objcopy] Consolidate and unify version tests.
Mon, Sep 7, 1:44 AM · Restricted Project
alexshap updated the diff for D87211: [llvm-objcopy] Consolidate and unify version tests.

Bring back the check for "GNU"

Mon, Sep 7, 1:38 AM · Restricted Project

Sun, Sep 6

alexshap requested review of D87211: [llvm-objcopy] Consolidate and unify version tests.
Sun, Sep 6, 2:26 PM · Restricted Project

Aug 25 2020

alexshap committed rGc6f7ac0071a1: [llvm-lipo] Add support for bitcode files (authored by aguinet).
[llvm-lipo] Add support for bitcode files
Aug 25 2020, 9:11 PM
alexshap closed D85740: Universal MachO: support LLVM IR objects.
Aug 25 2020, 9:11 PM · Restricted Project

Aug 24 2020

alexshap accepted D86359: [llvm-libtool-darwin] Add support for -V option.

LG

Aug 24 2020, 12:35 PM · Restricted Project
alexshap added inline comments to D85740: Universal MachO: support LLVM IR objects.
Aug 24 2020, 12:20 PM · Restricted Project
alexshap accepted D85740: Universal MachO: support LLVM IR objects.

LGTM

Aug 24 2020, 9:50 AM · Restricted Project

Aug 23 2020

alexshap added inline comments to D85740: Universal MachO: support LLVM IR objects.
Aug 23 2020, 5:43 PM · Restricted Project
alexshap added inline comments to D85740: Universal MachO: support LLVM IR objects.
Aug 23 2020, 5:39 PM · Restricted Project

Aug 16 2020

alexshap added inline comments to D85740: Universal MachO: support LLVM IR objects.
Aug 16 2020, 12:08 AM · Restricted Project

Aug 11 2020

alexshap added a comment to D85740: Universal MachO: support LLVM IR objects.

@aguinet,
thanks for the patch!

Aug 11 2020, 10:18 AM · Restricted Project

Aug 4 2020

alexshap accepted D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.
Aug 4 2020, 12:57 PM · Restricted Project

Jul 31 2020

alexshap added a comment to D85041: [llvm-libtool-darwin] Add constant CPU_TYPE_ARM64_V8.

I'd probably add a simple test for llvm-readobj as well.

Jul 31 2020, 5:01 PM · Restricted Project

Jul 30 2020

alexshap accepted D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary.

LG

Jul 30 2020, 1:15 PM · Restricted Project

Jul 28 2020

alexshap added inline comments to D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary.
Jul 28 2020, 2:05 PM · Restricted Project
alexshap accepted D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary.
Jul 28 2020, 11:59 AM · Restricted Project

Jul 27 2020

alexshap added inline comments to D84662: [llvm-libtool-darwin] Refactor Slice and writeUniversalBinary.
Jul 27 2020, 1:56 PM · Restricted Project

Jul 9 2020

alexshap added inline comments to D83002: [llvm-libtool-darwin] Add support for -static option.
Jul 9 2020, 6:21 PM · Restricted Project

Jul 8 2020

alexshap accepted D82923: introducing llvm-libtool-darwin.
Jul 8 2020, 1:46 AM · Restricted Project

Jul 6 2020

alexshap accepted D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jul 6 2020, 2:26 PM · Restricted Project
alexshap added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jul 6 2020, 2:21 PM · Restricted Project

Jul 5 2020

alexshap added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jul 5 2020, 12:15 PM · Restricted Project

Jul 2 2020

alexshap added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jul 2 2020, 11:10 PM · Restricted Project

Jul 1 2020

alexshap added a comment to D82923: introducing llvm-libtool-darwin.

I didn't reply on the mailing list, but to me the motivation for this tool sounds reasonable too.
I'll try to take a look at the code a bit later this week.

Jul 1 2020, 11:20 AM · Restricted Project
alexshap accepted D82812: [llvm-install-name-tool] Merge rpath with id/change.

LGTM

Jul 1 2020, 10:48 AM · Restricted Project
alexshap added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jul 1 2020, 2:39 AM · Restricted Project
alexshap added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jul 1 2020, 2:39 AM · Restricted Project

Jun 30 2020

alexshap added a comment to D82812: [llvm-install-name-tool] Merge rpath with id/change.

I've added a few comments but other than that this version looks good to me

Jun 30 2020, 8:35 PM · Restricted Project
alexshap added inline comments to D82812: [llvm-install-name-tool] Merge rpath with id/change.
Jun 30 2020, 2:08 AM · Restricted Project

Jun 29 2020

alexshap committed rG2c663aa539c3: [llvm-objcopy][MachO] Fix segment size alignment (authored by alexshap).
[llvm-objcopy][MachO] Fix segment size alignment
Jun 29 2020, 11:57 PM
alexshap added a comment to D82768: [llvm-install-name-tool] Guard isLoadCommandWithPayloadString.

Btw, this issue has already been fixed by https://github.com/llvm/llvm-project/commit/cc836950ab2a4309ae68d78a1b2330fd922fa3a2

Jun 29 2020, 11:57 PM · Restricted Project
alexshap accepted D82768: [llvm-install-name-tool] Guard isLoadCommandWithPayloadString.
Jun 29 2020, 10:32 PM · Restricted Project

Jun 26 2020

alexshap committed rGb925ca37a8f2: [llvm-install-name-tool] Add support for -rpath option (authored by alexshap).
[llvm-install-name-tool] Add support for -rpath option
Jun 26 2020, 5:44 PM
alexshap closed D82051: [llvm-install-name-tool] Add -rpath option.
Jun 26 2020, 5:44 PM · Restricted Project
alexshap accepted D82051: [llvm-install-name-tool] Add -rpath option.
Jun 26 2020, 4:38 PM · Restricted Project

Jun 24 2020

alexshap committed rG395920a61493: [llvm-objcopy] Update help message tests (authored by alexshap).
[llvm-objcopy] Update help message tests
Jun 24 2020, 1:02 PM
alexshap closed D82012: [llvm-objcopy] Merging tool-help-text tests.
Jun 24 2020, 1:02 PM · Restricted Project
alexshap accepted D82484: [Hexagon] llvm-objcopy check for SHN_HEXAGON_SCOMMON_1.
Jun 24 2020, 1:01 PM · Restricted Project
alexshap committed rGca133cdecfea: [llvm-objcopy] Update help messages (authored by alexshap).
[llvm-objcopy] Update help messages
Jun 24 2020, 11:23 AM
alexshap closed D81907: [llvm-objcopy] Fix help text.
Jun 24 2020, 11:23 AM · Restricted Project
alexshap accepted D82012: [llvm-objcopy] Merging tool-help-text tests.

LG

Jun 24 2020, 11:22 AM · Restricted Project
alexshap accepted D81907: [llvm-objcopy] Fix help text.

LGTM, thanks!

Jun 24 2020, 10:47 AM · Restricted Project

Jun 23 2020

alexshap added inline comments to D81907: [llvm-objcopy] Fix help text.
Jun 23 2020, 11:48 AM · Restricted Project
alexshap added inline comments to D81907: [llvm-objcopy] Fix help text.
Jun 23 2020, 1:00 AM · Restricted Project

Jun 22 2020

alexshap added inline comments to D82051: [llvm-install-name-tool] Add -rpath option.
Jun 22 2020, 11:25 PM · Restricted Project
alexshap requested changes to D81907: [llvm-objcopy] Fix help text.
Jun 22 2020, 6:17 PM · Restricted Project
alexshap requested changes to D82051: [llvm-install-name-tool] Add -rpath option.
Jun 22 2020, 5:45 PM · Restricted Project
alexshap committed rGd332ec9209ac: [llvm-install-name-tool] Implement delete_rpath option (authored by alexshap).
[llvm-install-name-tool] Implement delete_rpath option
Jun 22 2020, 5:14 PM
alexshap closed D81527: [llvm-install-name-tool] Add `delete_rpath` option.
Jun 22 2020, 5:13 PM · Restricted Project
alexshap accepted D81527: [llvm-install-name-tool] Add `delete_rpath` option.
Jun 22 2020, 4:10 PM · Restricted Project

Jun 15 2020

alexshap added inline comments to D81527: [llvm-install-name-tool] Add `delete_rpath` option.
Jun 15 2020, 10:32 PM · Restricted Project
alexshap committed rG913bc312b551: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE (authored by alexshap).
[llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE
Jun 15 2020, 7:51 PM
alexshap closed D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.
Jun 15 2020, 7:51 PM · Restricted Project
alexshap updated the diff for D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.

Fix typos

Jun 15 2020, 7:19 PM · Restricted Project
alexshap added inline comments to D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.
Jun 15 2020, 6:14 PM · Restricted Project
alexshap added inline comments to D81527: [llvm-install-name-tool] Add `delete_rpath` option.
Jun 15 2020, 12:04 PM · Restricted Project

Jun 12 2020

alexshap added a comment to D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.

@hiraditya , if I'm not mistaken, yes, it will. https://github.com/llvm-mirror/llvm/blob/master/include/llvm/BinaryFormat/MachO.def#L53

Jun 12 2020, 8:28 PM · Restricted Project
alexshap updated the diff for D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.

Fix typo.

Jun 12 2020, 3:24 PM · Restricted Project
alexshap created D81768: [llvm-objcopy][MachO] Add support for LC_CODE_SIGNATURE.
Jun 12 2020, 2:49 PM · Restricted Project

Jun 11 2020

alexshap committed rGc966ed8dc7ce: [llvm-objcopy][MachO] Fix cmdsize of LC_RPATH (authored by alexshap).
[llvm-objcopy][MachO] Fix cmdsize of LC_RPATH
Jun 11 2020, 8:53 PM
alexshap closed D81575: [llvm-objcopy] Fix RPathLC.cmdsize.
Jun 11 2020, 8:52 PM · Restricted Project

Jun 10 2020

alexshap accepted D81575: [llvm-objcopy] Fix RPathLC.cmdsize.

LGTM

Jun 10 2020, 10:39 PM · Restricted Project
alexshap added inline comments to D81527: [llvm-install-name-tool] Add `delete_rpath` option.
Jun 10 2020, 3:14 AM · Restricted Project

Jun 5 2020

alexshap accepted D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF..

LGTM

Jun 5 2020, 9:25 AM · Restricted Project

Jun 4 2020

alexshap added inline comments to D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF..
Jun 4 2020, 1:15 PM · Restricted Project
alexshap added inline comments to D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF..
Jun 4 2020, 11:34 AM · Restricted Project

Jun 3 2020

alexshap added inline comments to D81097: [llvm-objcopy] Reorder --dump-section before --remove-section for ELF..
Jun 3 2020, 7:17 PM · Restricted Project