Page MenuHomePhabricator

alexshap (Alexander Shaposhnikov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 3:32 PM (235 w, 1 d)

Recent Activity

Nov 7 2020

alexshap committed rG273ba73689f4: [llvm-objcopy][MachO] Minor refactoring of MachOLayoutBuilder (authored by alexshap).
[llvm-objcopy][MachO] Minor refactoring of MachOLayoutBuilder
Nov 7 2020, 8:27 PM
alexshap committed rG4d54c6fc5ad5: [llvm-objcopy][MachO] Fix adding multiple sections (authored by eqv).
[llvm-objcopy][MachO] Fix adding multiple sections
Nov 7 2020, 6:19 PM
alexshap closed D90690: [llvm-objcopy][MachO] Fix adding multiple sections.
Nov 7 2020, 6:19 PM · Restricted Project

Nov 6 2020

alexshap committed rGf147f59cd377: [llvm-objcopy][MachO] Skip sections with zero offset (authored by alexshap).
[llvm-objcopy][MachO] Skip sections with zero offset
Nov 6 2020, 1:30 PM

Nov 5 2020

alexshap accepted D90690: [llvm-objcopy][MachO] Fix adding multiple sections.

besides a small nit this looks reasonable to me, I'd wait for @smeenai to take a look as well

Nov 5 2020, 1:03 PM · Restricted Project

Nov 4 2020

alexshap committed rGf7649f2d131f: [llvm-objcopy][MachO] Make isValidMachOCannonicalName static (authored by alexshap).
[llvm-objcopy][MachO] Make isValidMachOCannonicalName static
Nov 4 2020, 9:38 AM

Nov 3 2020

alexshap added inline comments to D90690: [llvm-objcopy][MachO] Fix adding multiple sections.
Nov 3 2020, 2:29 PM · Restricted Project
alexshap added inline comments to D90690: [llvm-objcopy][MachO] Fix adding multiple sections.
Nov 3 2020, 1:44 PM · Restricted Project
alexshap added inline comments to D90690: [llvm-objcopy][MachO] Fix adding multiple sections.
Nov 3 2020, 1:42 PM · Restricted Project

Oct 29 2020

alexshap committed rG05f7b682192b: [llvm-libtool-darwin] Add support for LLVM bitcode files (authored by parras).
[llvm-libtool-darwin] Add support for LLVM bitcode files
Oct 29 2020, 12:01 PM
alexshap closed D88722: [llvm-libtool-darwin] Add support for LLVM bitcode files.
Oct 29 2020, 12:01 PM · Restricted Project

Oct 28 2020

alexshap committed rG51f8d46491c7: [llvm-install-name-tool] Quote passed rpath args in error messages (authored by keith).
[llvm-install-name-tool] Quote passed rpath args in error messages
Oct 28 2020, 3:28 PM
alexshap closed D90080: [llvm-objcopy] Quote passed rpath args in errors.
Oct 28 2020, 3:28 PM · Restricted Project
alexshap added a comment to D88722: [llvm-libtool-darwin] Add support for LLVM bitcode files.

@parras - thanks for the patch! According to https://llvm.org/docs/DeveloperPolicy.html#commit-messages to correctly specify the author of the changes we need name + e-mail

Oct 28 2020, 2:01 AM · Restricted Project

Oct 27 2020

alexshap accepted D90080: [llvm-objcopy] Quote passed rpath args in errors.
Oct 27 2020, 8:31 AM · Restricted Project

Oct 23 2020

alexshap accepted D88722: [llvm-libtool-darwin] Add support for LLVM bitcode files.

Looks good!
I'd wait for @smeenai to take a look as well.

Oct 23 2020, 6:18 PM · Restricted Project
alexshap committed rG77cbf2595331: [llvm-install-name-tool] Add -prepend_rpath option (authored by keith).
[llvm-install-name-tool] Add -prepend_rpath option
Oct 23 2020, 3:04 PM
alexshap closed D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 23 2020, 3:04 PM · Restricted Project

Oct 22 2020

alexshap committed rG310a8e1d1284: [llvm-objcopy][NFC] Extract arg parsing logic into a helper function (authored by keith).
[llvm-objcopy][NFC] Extract arg parsing logic into a helper function
Oct 22 2020, 11:34 PM
alexshap closed D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.
Oct 22 2020, 11:33 PM · Restricted Project
alexshap committed rG27e11d7120c0: [MC] Adjust StringTableBuilder for linked Mach-O binaries (authored by alexshap).
[MC] Adjust StringTableBuilder for linked Mach-O binaries
Oct 22 2020, 7:20 PM
alexshap closed D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries.
Oct 22 2020, 7:20 PM · Restricted Project
alexshap committed rG861429160ca7: [llvm-objcopy][MachO] Fix the calculation of the output size (authored by alexshap).
[llvm-objcopy][MachO] Fix the calculation of the output size
Oct 22 2020, 1:58 PM
alexshap closed D89661: [llvm-objcopy][MachO] Fix the calculation of the output size.
Oct 22 2020, 1:58 PM · Restricted Project
alexshap updated the summary of D89661: [llvm-objcopy][MachO] Fix the calculation of the output size.
Oct 22 2020, 1:24 PM · Restricted Project
alexshap updated the diff for D89661: [llvm-objcopy][MachO] Fix the calculation of the output size.

Update the message inside assert(...)

Oct 22 2020, 12:29 AM · Restricted Project
alexshap added inline comments to D89661: [llvm-objcopy][MachO] Fix the calculation of the output size.
Oct 22 2020, 12:00 AM · Restricted Project

Oct 21 2020

alexshap added a comment to D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library..

My 0.02$: (perhaps, this should have been mentioned earlier) the current class CopyConfig contains e.g. file names (again, imo it is good enough for a tool, but not good enough for a library) and this means that if somebody wants to add a section to an object file he won't be able to accomplish this task using the current interface without creating extra files. It kind of defeats the idea. To solve this problem proper abstractions should be introduced / the code needs to be refactored. Personally I would strongly prefer to see the following iterative approach here: refactor the current code in llvm-objcopy step by step until it's ready to be moved into a library with a clean and easy-to-use interface. Maybe I'm missing something, but doing refactoring post factum seems to be a less controllable process and might get us to the state where the code has been move out of the tool, the interface has been modified to accomplish a very specific task and the rest (burden) will stay there for years creating more issues than benefits, moreover, it would introduce some risks.
Regarding where to place these functions - into libObject or create a separate library - libObject already contains several write* functions, (e.g. for archives), so indeed, putting this group of functions (e.g. one can use a bit less verbose name - copy(...)) into libObject seems to be quite natural.

Oct 21 2020, 11:07 PM · Restricted Project
alexshap accepted D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

LG, thanks!

Oct 21 2020, 10:05 AM · Restricted Project

Oct 20 2020

alexshap changed the visibility for D89661: [llvm-objcopy][MachO] Fix the calculation of the output size.
Oct 20 2020, 8:07 PM · Restricted Project
alexshap changed the visibility for D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries.
Oct 20 2020, 8:07 PM · Restricted Project
alexshap added inline comments to D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.
Oct 20 2020, 7:11 PM · Restricted Project
alexshap added inline comments to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 20 2020, 2:56 AM · Restricted Project

Oct 19 2020

alexshap added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

According to https://llvm.org/docs/DeveloperPolicy.html#commit-messages your name + e-mail are necessary (to correctly specify the author of the changes).
I'd wait for a day to see if there are any comments from other reviewers, if everything is okay I'll commit it.

Oct 19 2020, 11:00 AM · Restricted Project
alexshap accepted D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

LG

Oct 19 2020, 10:52 AM · Restricted Project

Oct 18 2020

alexshap added inline comments to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 18 2020, 5:34 PM · Restricted Project
alexshap accepted D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

LGTM, thanks!

Oct 18 2020, 5:32 PM · Restricted Project
alexshap requested review of D89661: [llvm-objcopy][MachO] Fix the calculation of the output size.
Oct 18 2020, 5:11 PM · Restricted Project

Oct 16 2020

alexshap updated the diff for D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries.

Fix typo

Oct 16 2020, 12:49 PM · Restricted Project
alexshap updated the diff for D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries.

Add more tests, 32-bit/64-bit

Oct 16 2020, 12:43 PM · Restricted Project
alexshap updated the diff for D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries.
Oct 16 2020, 10:51 AM · Restricted Project
alexshap requested review of D89561: [MC] Adjust StringTableBuilder for linked Mach-O binaries.
Oct 16 2020, 9:50 AM · Restricted Project

Oct 13 2020

alexshap committed rG61133e0b1110: [llvm-install-name-tool] Add -delete_all_rpaths option (authored by thieta).
[llvm-install-name-tool] Add -delete_all_rpaths option
Oct 13 2020, 1:01 AM
alexshap closed D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.
Oct 13 2020, 1:01 AM · Restricted Project
alexshap added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

@thieta - thanks for the patch and for your patience. According to https://llvm.org/docs/DeveloperPolicy.html#commit-messages we would need your name + e-mail (to correctly specify the author of the changes).

Oct 13 2020, 12:19 AM · Restricted Project

Oct 12 2020

alexshap accepted D88468: [llvm-readobj] Don't print out section names for STABS symbols.
Oct 12 2020, 3:09 PM · Restricted Project
alexshap added inline comments to D88468: [llvm-readobj] Don't print out section names for STABS symbols.
Oct 12 2020, 3:01 PM · Restricted Project

Oct 8 2020

alexshap added a reviewer for D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library.: mstorsjo.
Oct 8 2020, 4:47 AM · Restricted Project
alexshap updated subscribers of D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library..

I have some general comments / concerns (in addition to the inline comment).
The interface of the library is important and once it's committed and people start using the library in multiple places it might be harder to make changes / fix issues
(unfortunately this has already happened in LLVM a few times in the past) .

Oct 8 2020, 3:57 AM · Restricted Project

Oct 7 2020

alexshap added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

just want to add a few more words to explain what I meant: on the one hand this would provide more flexibility on the other hand this would introduce one more option + increase the code size.
If this flexibility is necessary (which is not clear) - yeah, we can add it.

Oct 7 2020, 4:56 PM · Restricted Project
alexshap added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

@rupprecht - in general, I'm not against using regex, however, as I mentioned above, it seems like it's not a very frequent use case + there are not so many rpaths (this is quite different from matching symbol names or section names).
Adding more options (--regex) + the required plumbing + tests coverage has its price, honestly I'm not convinced that it's strictly necessary in this particular case (when e.g. a binary has 2 or 3 rpaths).

Oct 7 2020, 4:47 PM · Restricted Project
alexshap added a comment to D88722: [llvm-libtool-darwin] Add support for LLVM bitcode files.

sorry about the delay, I'll try to review this diff this week / early next week

Oct 7 2020, 12:04 AM · Restricted Project

Oct 6 2020

alexshap changed the visibility for D88372: [Object][MachO] Refactor MachOUniversalWriter.
Oct 6 2020, 11:54 PM · Restricted Project
alexshap added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

I don't have a strong opinion regarding this either, usually there are not so many rpaths.
To me the current version looks reasonable, if you'd like I think we can proceed, but it's up to you.

Oct 6 2020, 9:52 PM · Restricted Project
alexshap added a comment to D88400: [llvm-objcopy][MachO] Add support for universal binaries.

@gribozavr2, many thanks, https://reviews.llvm.org/rG315970de1d71 (315970de1d7140fa689dbbe7482620f134e5d021) fixes the issue.

Oct 6 2020, 4:08 AM · Restricted Project
alexshap committed rG315970de1d71: [llvm-objcopy][MachO] Add support for universal binaries (authored by alexshap).
[llvm-objcopy][MachO] Add support for universal binaries
Oct 6 2020, 4:02 AM
alexshap added a comment to D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library..

This change needs some analysis & review, it might take some time (especially because this week we have the LLVM conference).

Oct 6 2020, 2:40 AM · Restricted Project

Oct 5 2020

alexshap committed rG6e25586990b9: [llvm-objcopy][MachO] Add missing std::move. (authored by alexshap).
[llvm-objcopy][MachO] Add missing std::move.
Oct 5 2020, 11:03 AM
alexshap committed rG32c8435ef700: [llvm-objcopy][MachO] Add support for universal binaries (authored by alexshap).
[llvm-objcopy][MachO] Add support for universal binaries
Oct 5 2020, 10:45 AM
alexshap closed D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Oct 5 2020, 10:44 AM · Restricted Project

Oct 4 2020

alexshap accepted D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

Thanks, looks good, I'd wait for ~1 day to see if other reviewers have any comments, if everything is fine I can commit it for you

Oct 4 2020, 4:39 PM · Restricted Project

Oct 3 2020

alexshap added inline comments to D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Oct 3 2020, 6:37 PM · Restricted Project
alexshap added inline comments to D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Oct 3 2020, 6:28 PM · Restricted Project
alexshap committed rGd20c602aad7c: [Object][MachO] Refactor MachOUniversalWriter (authored by alexshap).
[Object][MachO] Refactor MachOUniversalWriter
Oct 3 2020, 2:34 PM
alexshap closed D88372: [Object][MachO] Refactor MachOUniversalWriter.
Oct 3 2020, 2:34 PM · Restricted Project
alexshap added inline comments to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.
Oct 3 2020, 2:31 PM · Restricted Project

Oct 2 2020

alexshap added a comment to D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

(and yeah, we need a test for this option)

Oct 2 2020, 1:21 PM · Restricted Project
alexshap accepted D88674: [install-name-tool] Add --delete_all_rpaths to llvm-install-name-tool.

LG

Oct 2 2020, 11:38 AM · Restricted Project

Sep 30 2020

alexshap updated the diff for D88400: [llvm-objcopy][MachO] Add support for universal binaries.

Flesh out the comment.

Sep 30 2020, 1:31 PM · Restricted Project
alexshap added inline comments to D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Sep 30 2020, 1:37 AM · Restricted Project

Sep 29 2020

alexshap updated the diff for D88400: [llvm-objcopy][MachO] Add support for universal binaries.

Address comments

Sep 29 2020, 1:48 AM · Restricted Project

Sep 28 2020

alexshap added inline comments to D88468: [llvm-readobj] Don't print out section names for STABS symbols.
Sep 28 2020, 11:59 PM · Restricted Project
alexshap updated the diff for D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Sep 28 2020, 8:54 AM · Restricted Project
alexshap added reviewers for D88400: [llvm-objcopy][MachO] Add support for universal binaries: MaskRay, smeenai.
Sep 28 2020, 3:43 AM · Restricted Project
alexshap requested review of D88400: [llvm-objcopy][MachO] Add support for universal binaries.
Sep 28 2020, 3:42 AM · Restricted Project

Sep 26 2020

alexshap requested review of D88372: [Object][MachO] Refactor MachOUniversalWriter.
Sep 26 2020, 11:09 PM · Restricted Project

Sep 25 2020

alexshap committed rG97702c3d9234: [Object][MachO] Refine the interface of Slice (authored by alexshap).
[Object][MachO] Refine the interface of Slice
Sep 25 2020, 4:28 PM
alexshap closed D88320: [Object][MachO] Refine interface of Slice.
Sep 25 2020, 4:28 PM · Restricted Project
alexshap updated the diff for D88320: [Object][MachO] Refine interface of Slice.

Apply clang-format

Sep 25 2020, 11:16 AM · Restricted Project
alexshap added a reviewer for D88320: [Object][MachO] Refine interface of Slice: rupprecht.
Sep 25 2020, 11:07 AM · Restricted Project
alexshap requested review of D88320: [Object][MachO] Refine interface of Slice.
Sep 25 2020, 9:56 AM · Restricted Project
alexshap updated subscribers of D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Sep 25 2020, 5:11 AM · Restricted Project
alexshap added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Sep 25 2020, 4:24 AM · Restricted Project

Sep 24 2020

alexshap added a reviewer for D88213: [llvm-objcopy][NFC] refactor error handling. part 2.: mstorsjo.
Sep 24 2020, 10:41 AM · Restricted Project
alexshap accepted D88113: [llvm-objcopy][NFC] refactor error handling. part 1..

LG, thanks

Sep 24 2020, 3:24 AM · Restricted Project
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Sep 24 2020, 2:21 AM · Restricted Project
alexshap committed rGe60a760b7da9: [llvm-objcopy][MachO] Fix --add-section (authored by alexshap).
[llvm-objcopy][MachO] Fix --add-section
Sep 24 2020, 1:51 AM
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Sep 24 2020, 1:24 AM · Restricted Project
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Sep 24 2020, 1:18 AM · Restricted Project
alexshap added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Sep 24 2020, 12:30 AM · Restricted Project
alexshap added a comment to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..

apart from the minor comments, I think this change is in the right direction.

Sep 24 2020, 12:17 AM · Restricted Project

Sep 18 2020

alexshap committed rG2ca68b6542cf: [llvm-objcopy][MachO] Clean up the interface of Object (authored by alexshap).
[llvm-objcopy][MachO] Clean up the interface of Object
Sep 18 2020, 6:27 PM
alexshap committed rG5495b6916469: [llvm-objcopy][MachO] Add llvm-bitcode-strip driver (authored by alexshap).
[llvm-objcopy][MachO] Add llvm-bitcode-strip driver
Sep 18 2020, 6:14 PM
alexshap closed D87493: [llvm-install-name-tool] Update the command-line guide.
Sep 18 2020, 6:07 PM · Restricted Project
alexshap committed rGe9f9027c3c07: [llvm-install-name-tool] Validate -id value early (authored by alexshap).
[llvm-install-name-tool] Validate -id value early
Sep 18 2020, 6:03 PM
alexshap closed D87855: [llvm-install-name-tool] Validate -id value early.
Sep 18 2020, 6:03 PM · Restricted Project

Sep 17 2020

alexshap updated the diff for D87855: [llvm-install-name-tool] Validate -id value early.

Apply clang-format

Sep 17 2020, 1:57 PM · Restricted Project
alexshap committed rG53ba045f488f: [llvm-install-name-tool] Update the command-line guide (authored by alexshap).
[llvm-install-name-tool] Update the command-line guide
Sep 17 2020, 1:45 PM
alexshap requested review of D87855: [llvm-install-name-tool] Validate -id value early.
Sep 17 2020, 1:39 PM · Restricted Project

Sep 10 2020

alexshap requested review of D87493: [llvm-install-name-tool] Update the command-line guide.
Sep 10 2020, 10:10 PM · Restricted Project