Page MenuHomePhabricator

alexmc (Alex McCarthy)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2014, 8:11 AM (407 w, 5 d)

Recent Activity

Jul 31 2014

alexmc added a comment to D4740: Implement inlining of temporary destructors..

Woo :D nice work!

Jul 31 2014, 8:05 AM

Jul 29 2014

alexmc added a comment to D4706: An attempt at fixing lifetime extended temporaries in the CFG..

Thanks again for smashing on this, Manuel. This rabbit hole just keeps on getting deeper.

Jul 29 2014, 9:16 AM

Jul 28 2014

alexmc added a comment to D4696: Fix some cases of incorrect handling of lifetime extended temporaries..

Is there a test case that covers this bug?

Jul 28 2014, 7:58 AM

May 27 2014

alexmc added a comment to D3627: Proposal on how to fix temporary dtors..

I'm also confused by the use of LastBindTemporary, and why we only need to save the last one. A clearer name might help make this more understandable.

May 27 2014, 7:30 PM

May 23 2014

alexmc added inline comments to D3627: Proposal on how to fix temporary dtors..

Looking really good, thanks Manuel! I'll leave the final acceptance for Jordan or someone else with more clang cred than I.

May 23 2014, 11:01 AM

May 6 2014

alexmc added inline comments to D3627: Proposal on how to fix temporary dtors..

This is awesome, thanks Manuel! I can't wait to see this working :)

May 6 2014, 2:06 PM
alexmc retitled D3623: Throwaway commit to put in phabricator (WIP patch for temporary destructor analysis based on CFG changes) from to Throwaway commit to put in phabricator (WIP patch for temporary destructor analysis based on CFG changes).
May 6 2014, 10:56 AM

May 2 2014

alexmc closed D3589: Fix null pointer segfault when calling dump() on a DeclStmt containing a VarDecl..

Submitted as r207867

May 2 2014, 1:34 PM
alexmc added a comment to D3589: Fix null pointer segfault when calling dump() on a DeclStmt containing a VarDecl..

If you call Stmt::dump(), it creates an ASTDumper without a SourceManager: ASTDumper.cpp:2163 http://clang.llvm.org/doxygen/ASTDumper_8cpp_source.html#l02162

May 2 2014, 10:03 AM

May 1 2014

alexmc retitled D3589: Fix null pointer segfault when calling dump() on a DeclStmt containing a VarDecl. from to Fix null pointer segfault when calling dump() on a DeclStmt containing a VarDecl..
May 1 2014, 9:47 PM

Apr 30 2014

alexmc closed D3578: Fix ClangTidyOptions constructor to initialize all members. Fixes bug introduced in r207652..
Apr 30 2014, 3:42 PM
alexmc accepted D3578: Fix ClangTidyOptions constructor to initialize all members. Fixes bug introduced in r207652..

Richard approved via email.

Apr 30 2014, 3:42 PM
alexmc retitled D3578: Fix ClangTidyOptions constructor to initialize all members. Fixes bug introduced in r207652. from to Fix ClangTidyOptions constructor to initialize all members. Fixes bug introduced in r207652..
Apr 30 2014, 3:23 PM
alexmc closed D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..
Apr 30 2014, 9:02 AM
alexmc added inline comments to D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..
Apr 30 2014, 7:26 AM
alexmc added inline comments to D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..

Submitting now.

Apr 30 2014, 7:00 AM
alexmc updated the diff for D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..
  • Respond to review comments: copy options instead of maintaining a reference, and add more test cases.
Apr 30 2014, 6:58 AM

Apr 29 2014

alexmc updated the diff for D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..
  • Fix typo.
Apr 29 2014, 7:46 PM
alexmc added a comment to D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..

This is my first time sending a review with arc & phabricator: please let me know if I've set anything up incorrectly!

Apr 29 2014, 7:44 PM
alexmc retitled D3556: Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599). from to Add a clang-tidy flag to support temporary destructor-aware analysis (workaround for bug 15599)..
Apr 29 2014, 7:42 PM
alexmc added inline comments to D3552: Fix crash when resolving branch conditions for temporary destructor condition blocks..

Awesome, thanks for this fix, Manuel!

Apr 29 2014, 1:25 PM

Apr 28 2014

alexmc added inline comments to D3531: A non-principled fix of the symptom..

Thanks Manuel!

Apr 28 2014, 8:32 AM