User Details
- User Since
- Mar 7 2019, 2:10 PM (97 w, 4 d)
Fri, Jan 15
Thu, Jan 14
Remove llvm change.
-Add lit test, although it uses a hard-coded path
-Make -external_symbolizer_path take precedence
Wed, Jan 13
That sounds good
Tue, Jan 12
Fri, Jan 8
Dec 17 2020
Dec 16 2020
Remove other binary test
Add assembly test
Dec 15 2020
Dec 11 2020
Sure, I'm not really familiar with $ORIGIN - how does it work?
Dec 10 2020
Dec 7 2020
Dec 4 2020
Update failing tests
Dec 3 2020
Oh, I do need to fix the existing tests. Actually, the test I wrote probably belongs in that test directory.
Nov 30 2020
sorry, I messed up the code when rebasing; should be fixed now
rebase
Add test case
Nov 25 2020
Add test; add warning in lld when it sees empty subsection
I haven't added any tests here; I could upload an msvc-built binary for testing this. Not sure if that's necessary?
Nov 24 2020
avoid calling isa on a null value
Nov 23 2020
Use WithColor::warning() to print the warning
Nov 20 2020
fix typo
address comments
Nov 19 2020
Thanks, looks like I'll try to see if libcxx code can be changed here.
Nov 17 2020
thanks for writing tests for this! I think it looks good.
Ok, it seems like the general opinion here is that libc++ should be changed in some way and not ctor homing. I don't know who'd be responsible for changing the libc++ code, though.
more cleanup
Nov 16 2020
Remove comment and print statement
Nov 12 2020
address comment
Nov 10 2020
+ @ldionne for libc++ input?
Nov 5 2020
I added an assembly test and removed the other test in llvm/test/tools, since it pretty much does the same thing.
Add an assembly test for symbolizer
Nov 4 2020
Nov 3 2020
No, chromium doesn't need this fixed in clang, but I didn't see a clear way to fix this in libc++. Do you think it should be fixed as a bug in libc++?
Oct 30 2020
Oct 29 2020
I think we want to emit floats as unsigned, so add a function to check if the
constant is a float.
rebase
Oct 28 2020
Oct 27 2020
Moved isUnsignedDIType to DebugHandlerBase to avoid copying it.
Reverted because my copied isUnsignedDIType function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to be copied.
Oct 26 2020
Patch to emit signed ints for other S_CONSTANTs: https://reviews.llvm.org/D90199
Oct 23 2020
Fix test failures; remove assert for signed APSInts.
Whoops, forgot to check the tests. Apparently mapEncodedInteger asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary?