Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (97 w, 4 d)

Recent Activity

Fri, Jan 15

akhuang committed rGa1be47b47714: [CodeView][DebugInfo] Add test case to show that linkage names are not (authored by akhuang).
[CodeView][DebugInfo] Add test case to show that linkage names are not
Fri, Jan 15, 12:30 PM
akhuang committed rG6227069bdce6: [DebugInfo][CodeView] Change in line tables only mode to emit type information (authored by akhuang).
[DebugInfo][CodeView] Change in line tables only mode to emit type information
Fri, Jan 15, 9:29 AM
akhuang closed D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.
Fri, Jan 15, 9:28 AM · Restricted Project, Restricted Project

Thu, Jan 14

akhuang updated the summary of D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.
Thu, Jan 14, 2:49 PM · Restricted Project, Restricted Project
akhuang updated the diff for D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.

Remove llvm change.

Thu, Jan 14, 2:02 PM · Restricted Project, Restricted Project
akhuang added inline comments to D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.
Thu, Jan 14, 1:59 PM · Restricted Project, Restricted Project
akhuang updated the diff for D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..

-Add lit test, although it uses a hard-coded path
-Make -external_symbolizer_path take precedence

Thu, Jan 14, 1:21 PM · Restricted Project

Wed, Jan 13

akhuang retitled D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types from [DebugInfo][CodeView] Change in line tables only mode to emit type information for function scopes, rather than using the qualified name. to [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.
Wed, Jan 13, 4:46 PM · Restricted Project, Restricted Project
akhuang added a comment to D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.

What parts of this are motivated by CodeView requirements (do functions have to have unique names in CV?)?

Might be worth rephrasing from "emit type information for function scopes" to "emit parent/context scopes for functions, using declarations for any scopes that are types". (my own fault, but reading this quickly, I assumed it was about emitting type information for the parameters (DWARF gmlt drops the parameters/types))

That sounds good

Wed, Jan 13, 4:44 PM · Restricted Project, Restricted Project
akhuang added a comment to D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.

What parts of this are motivated by CodeView requirements (do functions have to have unique names in CV?)?
It'd be a bit unfortunate if we have divergence in -gmlt behavior between DWARF and CodeView due to different usage requirements, rather than format requirements - gmlt in DWARF I think uses only the unqualified name, though eventually combined with -fdebug-info-for-profiling which put the mangled name on such functions to make it clear for profilers. (though the unqualified name only behavior is still handy for the sanitizers - where the unqualified/ambiguous name is a "good enough" point for size V accuracy)

Wed, Jan 13, 4:11 PM · Restricted Project, Restricted Project
akhuang requested review of D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types.
Wed, Jan 13, 3:23 PM · Restricted Project, Restricted Project

Tue, Jan 12

akhuang requested review of D94563: [asan] Add flag (-external_symbolizer_path_from_binary) to find llvm-symbolizer relative to the binary's directory..
Tue, Jan 12, 4:21 PM · Restricted Project

Fri, Jan 8

akhuang requested review of D94325: [DebugInfo][CodeView] Use a fancier function display name when using line tables only to better differentiate between functions..
Fri, Jan 8, 11:21 AM · Restricted Project, Restricted Project

Dec 17 2020

akhuang committed rG7e13694ac745: [llvm-symbolizer][Windows] Add start line when searching in line table sections. (authored by akhuang).
[llvm-symbolizer][Windows] Add start line when searching in line table sections.
Dec 17 2020, 7:58 AM
akhuang closed D93306: [llvm-symbolizer][Windows] Add start line when searching in line table sections..
Dec 17 2020, 7:58 AM · Restricted Project

Dec 16 2020

akhuang updated the diff for D93306: [llvm-symbolizer][Windows] Add start line when searching in line table sections..

Remove other binary test

Dec 16 2020, 9:15 AM · Restricted Project
akhuang updated the diff for D93306: [llvm-symbolizer][Windows] Add start line when searching in line table sections..

Add assembly test

Dec 16 2020, 9:11 AM · Restricted Project

Dec 15 2020

akhuang committed rGaa7ae25613da: [llvm-symbolizer] Add missing include for config.h (authored by akhuang).
[llvm-symbolizer] Add missing include for config.h
Dec 15 2020, 9:21 AM
akhuang closed D93309: [llvm-symbolizer] Add missing include for config.h.
Dec 15 2020, 9:21 AM · Restricted Project
akhuang requested review of D93309: [llvm-symbolizer] Add missing include for config.h.
Dec 15 2020, 8:56 AM · Restricted Project
akhuang requested review of D93306: [llvm-symbolizer][Windows] Add start line when searching in line table sections..
Dec 15 2020, 8:29 AM · Restricted Project

Dec 11 2020

akhuang added a comment to D93070: [asan] Search for llvm-symbolizer in the executable's directory instead of only searching in PATH..

Sure, I'm not really familiar with $ORIGIN - how does it work?

Dec 11 2020, 12:42 PM · Restricted Project

Dec 10 2020

akhuang requested review of D93070: [asan] Search for llvm-symbolizer in the executable's directory instead of only searching in PATH..
Dec 10 2020, 2:10 PM · Restricted Project

Dec 7 2020

akhuang committed rG399bc48eccf0: [CodeView] Fix inline sites that are missing code offsets. (authored by akhuang).
[CodeView] Fix inline sites that are missing code offsets.
Dec 7 2020, 1:02 PM
akhuang closed D92590: [CodeView] Fix inline sites that are missing code offsets..
Dec 7 2020, 1:02 PM · Restricted Project

Dec 4 2020

akhuang updated the diff for D92590: [CodeView] Fix inline sites that are missing code offsets..

Update failing tests

Dec 4 2020, 10:53 AM · Restricted Project
akhuang added inline comments to D92590: [CodeView] Fix inline sites that are missing code offsets..
Dec 4 2020, 10:53 AM · Restricted Project

Dec 3 2020

akhuang added a comment to D92590: [CodeView] Fix inline sites that are missing code offsets..

Oh, I do need to fix the existing tests. Actually, the test I wrote probably belongs in that test directory.

Dec 3 2020, 1:33 PM · Restricted Project
akhuang updated the summary of D92590: [CodeView] Fix inline sites that are missing code offsets..
Dec 3 2020, 11:08 AM · Restricted Project
akhuang requested review of D92590: [CodeView] Fix inline sites that are missing code offsets..
Dec 3 2020, 10:55 AM · Restricted Project

Nov 30 2020

akhuang added a reverting change for rG1b63177a56e8: Revert "[llvm-symbolizer] Switch to using native symbolizer by default on…: rGefd1ec0dec14: Recommit "[llvm-symbolizer] Switch to using native symbolizer by default on….
Nov 30 2020, 5:36 PM
akhuang committed rGefd1ec0dec14: Recommit "[llvm-symbolizer] Switch to using native symbolizer by default on… (authored by akhuang).
Recommit "[llvm-symbolizer] Switch to using native symbolizer by default on…
Nov 30 2020, 5:36 PM
akhuang added a comment to D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..

sorry, I messed up the code when rebasing; should be fixed now

Nov 30 2020, 3:10 PM · Restricted Project
akhuang committed rG8cdf4920c47d: [llvm-symbolizer] Fix typo in llvm-symbolizer test from a previous commit. (authored by akhuang).
[llvm-symbolizer] Fix typo in llvm-symbolizer test from a previous commit.
Nov 30 2020, 3:10 PM
akhuang committed rG00bbef2bb20c: [llvm-symbolizer] Fix native symbolization on windows for inline sites. (authored by akhuang).
[llvm-symbolizer] Fix native symbolization on windows for inline sites.
Nov 30 2020, 2:32 PM
akhuang closed D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..
Nov 30 2020, 2:32 PM · Restricted Project
akhuang updated the diff for D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..

rebase

Nov 30 2020, 2:31 PM · Restricted Project
akhuang updated the diff for D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..

Add test case

Nov 30 2020, 12:59 PM · Restricted Project
akhuang added a comment to D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..
In D92134#2417347, @rnk wrote:

Well, I *can* think of a way to test this from a .s file. Instead of using .cv_inline_line_table, you could use a sequence of .byte 0xNN, 0xNN directives. I think you can get the hex codes from llvm-pdbutil dump -symbols. How about it?

Nov 30 2020, 9:34 AM · Restricted Project

Nov 25 2020

akhuang committed rG1363dfaf3105: [CodeView] Avoid emitting empty debug globals subsection. (authored by akhuang).
[CodeView] Avoid emitting empty debug globals subsection.
Nov 25 2020, 4:14 PM
akhuang closed D92049: [CodeView] Avoid emitting empty debug globals subsection..
Nov 25 2020, 4:13 PM · Restricted Project
akhuang updated the diff for D92049: [CodeView] Avoid emitting empty debug globals subsection..

Add test; add warning in lld when it sees empty subsection

Nov 25 2020, 4:05 PM · Restricted Project
akhuang added a comment to D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..

I haven't added any tests here; I could upload an msvc-built binary for testing this. Not sure if that's necessary?

Nov 25 2020, 1:43 PM · Restricted Project
akhuang requested review of D92134: [llvm-symbolizer] Fix native symbolization on windows for inline sites..
Nov 25 2020, 1:31 PM · Restricted Project
akhuang added inline comments to D88988: [llvm-symbolizer] Add inline stack traces for Windows..
Nov 25 2020, 11:41 AM · Restricted Project, Restricted Project

Nov 24 2020

akhuang updated the diff for D92049: [CodeView] Avoid emitting empty debug globals subsection..

avoid calling isa on a null value

Nov 24 2020, 2:39 PM · Restricted Project
akhuang requested review of D92049: [CodeView] Avoid emitting empty debug globals subsection..
Nov 24 2020, 11:41 AM · Restricted Project

Nov 23 2020

akhuang added a reverting change for rGc74b427cb2a9: [llvm-symbolizer] Switch to using native symbolizer by default on Windows: rG1b63177a56e8: Revert "[llvm-symbolizer] Switch to using native symbolizer by default on….
Nov 23 2020, 4:30 PM
akhuang committed rG1b63177a56e8: Revert "[llvm-symbolizer] Switch to using native symbolizer by default on… (authored by akhuang).
Revert "[llvm-symbolizer] Switch to using native symbolizer by default on…
Nov 23 2020, 4:30 PM
akhuang added a reverting change for D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows: rG1b63177a56e8: Revert "[llvm-symbolizer] Switch to using native symbolizer by default on….
Nov 23 2020, 4:30 PM · Restricted Project
akhuang committed rGc74b427cb2a9: [llvm-symbolizer] Switch to using native symbolizer by default on Windows (authored by akhuang).
[llvm-symbolizer] Switch to using native symbolizer by default on Windows
Nov 23 2020, 3:57 PM
akhuang closed D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.
Nov 23 2020, 3:57 PM · Restricted Project
akhuang updated the diff for D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.

Use WithColor::warning() to print the warning

Nov 23 2020, 11:31 AM · Restricted Project
akhuang committed rGb4902bcd986d: [NFC] remove print statement I accidentally added. (authored by akhuang).
[NFC] remove print statement I accidentally added.
Nov 23 2020, 10:51 AM

Nov 20 2020

akhuang updated the diff for D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.

fix typo

Nov 20 2020, 12:25 PM · Restricted Project
akhuang updated the diff for D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.

address comments

Nov 20 2020, 12:24 PM · Restricted Project

Nov 19 2020

akhuang requested review of D91814: [llvm-symbolizer] Switch to using native symbolizer by default on Windows.
Nov 19 2020, 12:02 PM · Restricted Project
akhuang added a comment to D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types.

Thanks, looks like I'll try to see if libcxx code can be changed here.

Nov 19 2020, 10:41 AM · Restricted Project

Nov 17 2020

akhuang accepted D91648: [DebugInfo] Dexter tests for -debug-info-kind=constructor.

thanks for writing tests for this! I think it looks good.

Nov 17 2020, 7:33 PM · Restricted Project
akhuang added a comment to D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types.

Ok, it seems like the general opinion here is that libc++ should be changed in some way and not ctor homing. I don't know who'd be responsible for changing the libc++ code, though.

Nov 17 2020, 2:00 PM · Restricted Project
akhuang committed rGbc9803404042: [llvm-symbolizer] Add inline stack traces for Windows. (authored by akhuang).
[llvm-symbolizer] Add inline stack traces for Windows.
Nov 17 2020, 1:19 PM
akhuang closed D88988: [llvm-symbolizer] Add inline stack traces for Windows..
Nov 17 2020, 1:19 PM · Restricted Project, Restricted Project
akhuang updated the diff for D88988: [llvm-symbolizer] Add inline stack traces for Windows..

more cleanup

Nov 17 2020, 12:59 PM · Restricted Project, Restricted Project

Nov 16 2020

akhuang added inline comments to D88988: [llvm-symbolizer] Add inline stack traces for Windows..
Nov 16 2020, 6:51 PM · Restricted Project, Restricted Project
akhuang updated the diff for D88988: [llvm-symbolizer] Add inline stack traces for Windows..

Remove comment and print statement

Nov 16 2020, 6:42 PM · Restricted Project, Restricted Project

Nov 12 2020

akhuang committed rG0c80b542d38b: Some updates/fixes to the creduce script. (authored by akhuang).
Some updates/fixes to the creduce script.
Nov 12 2020, 1:41 PM
akhuang closed D91372: Some updates/fixes to the creduce script..
Nov 12 2020, 1:40 PM · Restricted Project
akhuang updated the diff for D91372: Some updates/fixes to the creduce script..

address comment

Nov 12 2020, 1:40 PM · Restricted Project
akhuang added a reviewer for D91372: Some updates/fixes to the creduce script.: george.burgess.iv.
Nov 12 2020, 11:37 AM · Restricted Project
akhuang requested review of D91372: Some updates/fixes to the creduce script..
Nov 12 2020, 11:37 AM · Restricted Project

Nov 10 2020

akhuang updated subscribers of D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types.

+ @ldionne for libc++ input?

Nov 10 2020, 4:34 PM · Restricted Project

Nov 5 2020

akhuang added a comment to D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types.
In D90719#2377324, @rnk wrote:

I had another thought, which is that even if it is UB, perhaps we really shouldn't be using UB as the basis for debug info emission. All programs have bugs, and most bugs invoke some form of UB. If we don't provide sufficient info when UB is involved, it can become harder to find the UB. The vtable type homing heuristic works because violating the heuristic assumptions typically results in a link error. Creating an object without calling the class's constructor is the kind of UB that is likely to manifest as runtime errors.

Which is to say, I'm in favor of Amy's change as written.

The same would be true for the ctor homing generally though, I think? If there was a user-defined ctor and someone chose not to call it, that'd be UB too. I'm not sure there's especially more cases of not calling implicit non-trivial ctors versus non-trivial explicit non-trivial ctors to diverge on this criteria?

Nov 5 2020, 5:10 PM · Restricted Project
akhuang added inline comments to D88988: [llvm-symbolizer] Add inline stack traces for Windows..
Nov 5 2020, 4:04 PM · Restricted Project, Restricted Project
akhuang added a comment to D88988: [llvm-symbolizer] Add inline stack traces for Windows..

I added an assembly test and removed the other test in llvm/test/tools, since it pretty much does the same thing.

Nov 5 2020, 3:58 PM · Restricted Project, Restricted Project
akhuang updated the diff for D88988: [llvm-symbolizer] Add inline stack traces for Windows..

Add an assembly test for symbolizer

Nov 5 2020, 3:54 PM · Restricted Project, Restricted Project

Nov 4 2020

akhuang added inline comments to D88988: [llvm-symbolizer] Add inline stack traces for Windows..
Nov 4 2020, 2:26 PM · Restricted Project, Restricted Project

Nov 3 2020

akhuang added a comment to D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types.

No, chromium doesn't need this fixed in clang, but I didn't see a clear way to fix this in libc++. Do you think it should be fixed as a bug in libc++?

Nov 3 2020, 3:36 PM · Restricted Project
akhuang requested review of D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types.
Nov 3 2020, 2:40 PM · Restricted Project

Oct 30 2020

akhuang committed rG7156910d85fc: [CodeView] Encode signed int values correctly when emitting S_CONSTANTs (authored by akhuang).
[CodeView] Encode signed int values correctly when emitting S_CONSTANTs
Oct 30 2020, 9:31 AM
akhuang closed D90199: [CodeView] Encode signed int values correctly when emitting S_CONSTANTs.
Oct 30 2020, 9:31 AM · Restricted Project

Oct 29 2020

akhuang updated the diff for D90199: [CodeView] Encode signed int values correctly when emitting S_CONSTANTs.

I think we want to emit floats as unsigned, so add a function to check if the
constant is a float.

Oct 29 2020, 4:24 PM · Restricted Project
akhuang updated the diff for D90199: [CodeView] Encode signed int values correctly when emitting S_CONSTANTs.

rebase

Oct 29 2020, 11:31 AM · Restricted Project

Oct 28 2020

akhuang added a reverting change for rG504615353f31: Revert "[CodeView] Emit static data members as S_CONSTANTs.": rG7669f3c0f69d: Recommit "[CodeView] Emit static data members as S_CONSTANTs.".
Oct 28 2020, 4:36 PM
akhuang committed rG7669f3c0f69d: Recommit "[CodeView] Emit static data members as S_CONSTANTs." (authored by akhuang).
Recommit "[CodeView] Emit static data members as S_CONSTANTs."
Oct 28 2020, 4:36 PM
akhuang closed D89072: [CodeView] Emit static data members as S_CONSTANTs..
Oct 28 2020, 4:36 PM · Restricted Project, Restricted Project

Oct 27 2020

akhuang updated the diff for D89072: [CodeView] Emit static data members as S_CONSTANTs..

Moved isUnsignedDIType to DebugHandlerBase to avoid copying it.

Oct 27 2020, 12:09 PM · Restricted Project, Restricted Project
akhuang reopened D89072: [CodeView] Emit static data members as S_CONSTANTs..

Reverted because my copied isUnsignedDIType function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to be copied.

Oct 27 2020, 12:08 PM · Restricted Project, Restricted Project
akhuang added a reverting change for rG515973222ed2: [CodeView] Emit static data members as S_CONSTANTs.: rG504615353f31: Revert "[CodeView] Emit static data members as S_CONSTANTs.".
Oct 27 2020, 11:32 AM
akhuang committed rG504615353f31: Revert "[CodeView] Emit static data members as S_CONSTANTs." (authored by akhuang).
Revert "[CodeView] Emit static data members as S_CONSTANTs."
Oct 27 2020, 11:32 AM
akhuang added a reverting change for D89072: [CodeView] Emit static data members as S_CONSTANTs.: rG504615353f31: Revert "[CodeView] Emit static data members as S_CONSTANTs.".
Oct 27 2020, 11:32 AM · Restricted Project, Restricted Project

Oct 26 2020

akhuang added a comment to D89072: [CodeView] Emit static data members as S_CONSTANTs..

Patch to emit signed ints for other S_CONSTANTs: https://reviews.llvm.org/D90199

Oct 26 2020, 5:18 PM · Restricted Project, Restricted Project
akhuang requested review of D90199: [CodeView] Encode signed int values correctly when emitting S_CONSTANTs.
Oct 26 2020, 5:17 PM · Restricted Project
akhuang committed rG515973222ed2: [CodeView] Emit static data members as S_CONSTANTs. (authored by akhuang).
[CodeView] Emit static data members as S_CONSTANTs.
Oct 26 2020, 3:31 PM
akhuang closed D89072: [CodeView] Emit static data members as S_CONSTANTs..
Oct 26 2020, 3:30 PM · Restricted Project, Restricted Project

Oct 23 2020

akhuang updated the diff for D89072: [CodeView] Emit static data members as S_CONSTANTs..

Fix test failures; remove assert for signed APSInts.

Oct 23 2020, 5:08 PM · Restricted Project, Restricted Project
akhuang added a comment to D89072: [CodeView] Emit static data members as S_CONSTANTs..

Whoops, forgot to check the tests. Apparently mapEncodedInteger asserts if a signed APInt is not less than 0. I just removed the assert because it doesn't seem necessary?

Oct 23 2020, 4:27 PM · Restricted Project, Restricted Project
akhuang committed rG3827effe3ab5: [Asan][Windows] Fix asan stack traces on Windows. (authored by akhuang).
[Asan][Windows] Fix asan stack traces on Windows.
Oct 23 2020, 1:14 PM
akhuang closed D89996: [Asan][Windows] Fix asan stack traces on Windows..
Oct 23 2020, 1:14 PM · Restricted Project

Oct 22 2020

akhuang added a reviewer for D89996: [Asan][Windows] Fix asan stack traces on Windows.: vitalybuka.
Oct 22 2020, 5:30 PM · Restricted Project
akhuang updated the summary of D89996: [Asan][Windows] Fix asan stack traces on Windows..
Oct 22 2020, 5:26 PM · Restricted Project