- User Since
- Mar 7 2019, 2:10 PM (81 w, 3 d)
Thu, Sep 24
Add to comment for lambdas.
Wed, Sep 23
Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas.
Tue, Sep 22
Update ctor homing check, and add some test cases.
Mon, Sep 21
Fri, Sep 18
Wed, Sep 16
whoops, sorry for weird formatting in the previous comment.
This is causing a link error in the windows chromium build:
Mon, Sep 14
Ah, yeah. I'm not really sure if there could be cases where there is no size. If there are, I guess we shouldn't make any changes here.
Thu, Sep 3
Wed, Sep 2
remove assert; edit test case
Tue, Sep 1
ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f.
Aug 25 2020
just reopening to update the diff.
Aug 24 2020
unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code
Aug 21 2020
Simplify test and add comments.
Aug 20 2020
Add unit test and comment.
Aug 19 2020
I think that makes sense.
Aug 18 2020
Aug 17 2020
Aug 14 2020
Oh no, I'll upload the file here since I'm not sure how to make the bug visible again: https://reviews.llvm.org/F12619177
Aug 13 2020
Ok, I think the actual object file diff comes from this file: https://github.com/chromium/chromium/blob/master/sandbox/linux/syscall_broker/broker_command.cc
I checked that the test fails if I only build this object file with this change.
Actually, I've looked into it more and I think that isn't the correct object file. I'm bisecting to figure out which object file change causes the test failure. Sorry about that!
Sorry, I was hoping the object file diff would be clearer. If it could be reverted in the meantime, that would be helpful. I'm not sure if I'll be able to make an actual reproducer, but I'll at least try to narrow down the object file change.
I haven't been able to make a simple reproducer, but I attached a reproducer for compiling the object file here: https://crbug.com/1114852.
Aug 12 2020
Add more extensive check that -fuse-ctor-homing only does something when -debug-info-kind=limited
Yep, just added a line to the existing ctor homing test case.
Add test case.
This is causing test failures / crashes in several chromium android tests (https://crbug.com/1114852). I'm not really familiar with this code, but it seems like after this change, there are some lines missing in the assembly.
Aug 11 2020
Aug 10 2020
whoops, forgot about this patch; not sure who to add as reviewer?
Aug 7 2020
Jul 29 2020
remove change to add class types to retained types list,
Jul 28 2020
Jul 23 2020
Jul 22 2020
Jul 21 2020
Jul 20 2020