Page MenuHomePhabricator

akhuang (Amy Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 2:10 PM (81 w, 3 d)

Recent Activity

Thu, Sep 24

akhuang committed rGc8df781e54a4: [DebugInfo] Fix bug in constructor homing with classes with trivial (authored by akhuang).
[DebugInfo] Fix bug in constructor homing with classes with trivial
Thu, Sep 24, 2:44 PM
akhuang closed D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Thu, Sep 24, 2:44 PM · Restricted Project
akhuang retitled D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors. from [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors to [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Thu, Sep 24, 1:25 PM · Restricted Project
akhuang updated the diff for D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..

Add to comment for lambdas.

Thu, Sep 24, 1:23 PM · Restricted Project

Wed, Sep 23

akhuang updated the diff for D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..

Add comments to tests, and add a test for non instantiated trivial ctor and one for lambdas.

Wed, Sep 23, 11:33 AM · Restricted Project

Tue, Sep 22

akhuang updated the diff for D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..

Update ctor homing check, and add some test cases.

Tue, Sep 22, 3:56 PM · Restricted Project
akhuang added inline comments to D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Tue, Sep 22, 3:12 PM · Restricted Project

Mon, Sep 21

akhuang added a comment to D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
In D87808#2282223, @rnk wrote:

@rsmith What's the deal with these anonymous structs/unions? Why do they have copy/move constructors (are those technically called from the enclosing class's copy/move constructors?) but no default constructor to be called from the other ctors of the enclosing class?

Yes, I'm curious: copy and move constructors require an object of this type to already exist in memory. Is there a well-defined way of creating an object of this type in memory when it has no other constructors?

Maybe the issue is that this code is running into the lazy implicit special member declaration optimization. Maybe the class in question has an implicit, trivial, default constructor, but we there is no CXXConstructorDecl present in the ctors list for the loop to find.

Mon, Sep 21, 3:56 PM · Restricted Project

Fri, Sep 18

akhuang added a reviewer for D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors.: rnk.
Fri, Sep 18, 9:39 AM · Restricted Project

Wed, Sep 16

akhuang updated the summary of D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Wed, Sep 16, 6:17 PM · Restricted Project
akhuang requested review of D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Wed, Sep 16, 6:02 PM · Restricted Project
akhuang added a reverting change for rG4cff1b40dacf: Do not apply calling conventions to MSVC entry points: rGbebfc3b92d5e: Revert "Do not apply calling conventions to MSVC entry points".
Wed, Sep 16, 1:53 PM
akhuang committed rGbebfc3b92d5e: Revert "Do not apply calling conventions to MSVC entry points" (authored by akhuang).
Revert "Do not apply calling conventions to MSVC entry points"
Wed, Sep 16, 1:53 PM
akhuang added a reverting change for D87701: Do not apply calling conventions to MSVC entry points: rGbebfc3b92d5e: Revert "Do not apply calling conventions to MSVC entry points".
Wed, Sep 16, 1:53 PM · Restricted Project
akhuang added a comment to D87701: Do not apply calling conventions to MSVC entry points.

whoops, sorry for weird formatting in the previous comment.

Wed, Sep 16, 1:51 PM · Restricted Project
akhuang added a comment to D87701: Do not apply calling conventions to MSVC entry points.

This is causing a link error in the windows chromium build:

Wed, Sep 16, 1:48 PM · Restricted Project

Mon, Sep 14

akhuang added a comment to D87641: [DebugInfo] Add assert for variable size when creating fragments..

Ah, yeah. I'm not really sure if there could be cases where there is no size. If there are, I guess we shouldn't make any changes here.

Mon, Sep 14, 4:34 PM · Restricted Project
akhuang requested review of D87641: [DebugInfo] Add assert for variable size when creating fragments..
Mon, Sep 14, 3:30 PM · Restricted Project

Thu, Sep 3

akhuang committed rGaaf1a96408b1: [DebugInfo] Add size to class declarations in debug info. (authored by akhuang).
[DebugInfo] Add size to class declarations in debug info.
Thu, Sep 3, 3:43 PM
akhuang closed D87062: [DebugInfo] Add size to class declarations in debug info..
Thu, Sep 3, 3:43 PM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D87062: [DebugInfo] Add size to class declarations in debug info..
Thu, Sep 3, 3:41 PM · debug-info, Restricted Project, Restricted Project
akhuang updated the diff for D87062: [DebugInfo] Add size to class declarations in debug info..

rebase

Thu, Sep 3, 11:04 AM · debug-info, Restricted Project, Restricted Project
akhuang updated the summary of D87062: [DebugInfo] Add size to class declarations in debug info..
Thu, Sep 3, 11:03 AM · debug-info, Restricted Project, Restricted Project
akhuang committed rG5fe33f7399d8: [DebugInfo] Make DWARF ignore sizes on forward declared class types. (authored by akhuang).
[DebugInfo] Make DWARF ignore sizes on forward declared class types.
Thu, Sep 3, 11:02 AM
akhuang closed D87070: [DebugInfo] Make DWARF ignore sizes on forward declared class types..
Thu, Sep 3, 11:02 AM · Restricted Project
akhuang updated the diff for D87070: [DebugInfo] Make DWARF ignore sizes on forward declared class types..

update test

Thu, Sep 3, 11:01 AM · Restricted Project
akhuang added inline comments to D87070: [DebugInfo] Make DWARF ignore sizes on forward declared class types..
Thu, Sep 3, 11:00 AM · Restricted Project

Wed, Sep 2

akhuang requested review of D87070: [DebugInfo] Make DWARF ignore sizes on forward declared class types..
Wed, Sep 2, 8:46 PM · Restricted Project
akhuang updated the diff for D87062: [DebugInfo] Add size to class declarations in debug info..

remove assert; edit test case

Wed, Sep 2, 4:58 PM · debug-info, Restricted Project, Restricted Project
akhuang added inline comments to D87062: [DebugInfo] Add size to class declarations in debug info..
Wed, Sep 2, 4:52 PM · debug-info, Restricted Project, Restricted Project
akhuang added a project to D87062: [DebugInfo] Add size to class declarations in debug info.: debug-info.
Wed, Sep 2, 3:43 PM · debug-info, Restricted Project, Restricted Project
akhuang requested review of D87062: [DebugInfo] Add size to class declarations in debug info..
Wed, Sep 2, 3:42 PM · debug-info, Restricted Project, Restricted Project

Tue, Sep 1

akhuang closed D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..

ah sorry, this was relanded in b1009ee84fc0242bcebd07889306bf39d9b7170f.

Tue, Sep 1, 8:25 AM · Restricted Project

Aug 25 2020

akhuang added a reverting change for rG05777ab94106: Temporarily Revert "[DebugInfo] Move constructor homing case in…: rGb1009ee84fc0: Reland "[DebugInfo] Move constructor homing case in shouldOmitDefinition.".
Aug 25 2020, 12:37 PM
akhuang committed rGb1009ee84fc0: Reland "[DebugInfo] Move constructor homing case in shouldOmitDefinition." (authored by akhuang).
Reland "[DebugInfo] Move constructor homing case in shouldOmitDefinition."
Aug 25 2020, 12:37 PM
akhuang updated the diff for D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..

Fix errors.

Aug 25 2020, 12:30 PM · Restricted Project
akhuang reopened D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..

just reopening to update the diff.

Aug 25 2020, 12:20 PM · Restricted Project
akhuang added a comment to D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..

Note that Harbormaster actually reported the check-clang-codegencxx issues B69369..

Aug 25 2020, 10:53 AM · Restricted Project

Aug 24 2020

akhuang committed rG589ce5f7050d: [DebugInfo] Move constructor homing case in shouldOmitDefinition. (authored by akhuang).
[DebugInfo] Move constructor homing case in shouldOmitDefinition.
Aug 24 2020, 8:18 PM
akhuang closed D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..
Aug 24 2020, 8:18 PM · Restricted Project
akhuang added a comment to D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..

unfortunately not any thorough testing :) I just happened to notice it the last time I looked at this code

Aug 24 2020, 5:29 PM · Restricted Project
akhuang requested review of D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition..
Aug 24 2020, 3:19 PM · Restricted Project

Aug 21 2020

akhuang committed rG5e3fd471acb7: [Cloning] Fix to cloning DISubprograms. (authored by akhuang).
[Cloning] Fix to cloning DISubprograms.
Aug 21 2020, 11:55 AM
akhuang closed D86185: [Cloning] Fix to cloning DISubprograms..
Aug 21 2020, 11:55 AM · debug-info, Restricted Project
akhuang updated the diff for D86185: [Cloning] Fix to cloning DISubprograms..

Simplify test and add comments.

Aug 21 2020, 10:55 AM · debug-info, Restricted Project
akhuang added inline comments to D86185: [Cloning] Fix to cloning DISubprograms..
Aug 21 2020, 10:55 AM · debug-info, Restricted Project

Aug 20 2020

akhuang added inline comments to D86185: [Cloning] Fix to cloning DISubprograms..
Aug 20 2020, 6:55 PM · debug-info, Restricted Project
akhuang added inline comments to D86185: [Cloning] Fix to cloning DISubprograms..
Aug 20 2020, 5:51 PM · debug-info, Restricted Project
akhuang updated the diff for D86185: [Cloning] Fix to cloning DISubprograms..

Add unit test and comment.

Aug 20 2020, 4:20 PM · debug-info, Restricted Project

Aug 19 2020

akhuang added a comment to D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.

I think that makes sense.

Aug 19 2020, 9:03 AM · Restricted Project

Aug 18 2020

akhuang requested review of D86185: [Cloning] Fix to cloning DISubprograms..
Aug 18 2020, 6:06 PM · debug-info, Restricted Project

Aug 17 2020

akhuang committed rG51c152ca2a93: Revert "Make compiler-rt/asan tests run with llvm-lit." (authored by akhuang).
Revert "Make compiler-rt/asan tests run with llvm-lit."
Aug 17 2020, 10:01 AM
akhuang added a reverting change for rG7f84f62ef07a: Make compiler-rt/asan tests run with llvm-lit.: rG51c152ca2a93: Revert "Make compiler-rt/asan tests run with llvm-lit.".
Aug 17 2020, 10:01 AM
akhuang added a reverting change for D83821: Make compiler-rt/asan tests run with llvm-lit.: rG51c152ca2a93: Revert "Make compiler-rt/asan tests run with llvm-lit.".
Aug 17 2020, 10:01 AM · Restricted Project
akhuang committed rG7f84f62ef07a: Make compiler-rt/asan tests run with llvm-lit. (authored by akhuang).
Make compiler-rt/asan tests run with llvm-lit.
Aug 17 2020, 9:25 AM
akhuang closed D83821: Make compiler-rt/asan tests run with llvm-lit..
Aug 17 2020, 9:24 AM · Restricted Project

Aug 14 2020

akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.
Aug 14 2020, 10:03 AM · Restricted Project
akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

Oh no, I'll upload the file here since I'm not sure how to make the bug visible again: https://reviews.llvm.org/F12619177

Aug 14 2020, 10:02 AM · Restricted Project

Aug 13 2020

akhuang committed rGae6523cd62a4: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing… (authored by akhuang).
[DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing…
Aug 13 2020, 3:50 PM
akhuang closed D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on..
Aug 13 2020, 3:49 PM · Restricted Project
akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

Ok, I think the actual object file diff comes from this file: https://github.com/chromium/chromium/blob/master/sandbox/linux/syscall_broker/broker_command.cc
I checked that the test fails if I only build this object file with this change.

Aug 13 2020, 3:45 PM · Restricted Project
akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

Actually, I've looked into it more and I think that isn't the correct object file. I'm bisecting to figure out which object file change causes the test failure. Sorry about that!

Aug 13 2020, 3:00 PM · Restricted Project
akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

Sorry, I was hoping the object file diff would be clearer. If it could be reverted in the meantime, that would be helpful. I'm not sure if I'll be able to make an actual reproducer, but I'll at least try to narrow down the object file change.

Aug 13 2020, 2:09 PM · Restricted Project
akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

I haven't been able to make a simple reproducer, but I attached a reproducer for compiling the object file here: https://crbug.com/1114852.

Aug 13 2020, 11:00 AM · Restricted Project

Aug 12 2020

akhuang updated the diff for D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on..

Add more extensive check that -fuse-ctor-homing only does something when -debug-info-kind=limited

Aug 12 2020, 5:06 PM · Restricted Project
akhuang added a comment to D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on..

If possible, could you test the negative cases too? That -fuse-ctor-homing doesn't override -debug-info-kind=line-tables-only or no -debug-info-kind at all?

Aug 12 2020, 4:43 PM · Restricted Project
akhuang added a comment to D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on..

Yep, just added a line to the existing ctor homing test case.

Aug 12 2020, 4:03 PM · Restricted Project
akhuang updated the diff for D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on..

Add test case.

Aug 12 2020, 4:03 PM · Restricted Project
akhuang added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

This is causing test failures / crashes in several chromium android tests (https://crbug.com/1114852). I'm not really familiar with this code, but it seems like after this change, there are some lines missing in the assembly.

Aug 12 2020, 3:48 PM · Restricted Project

Aug 11 2020

akhuang requested review of D85799: [DebugInfo] Add -fuse-ctor-homing cc1 flag so we can turn on constructor homing only if limited debug info is already on..
Aug 11 2020, 5:39 PM · Restricted Project
akhuang added inline comments to D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.
Aug 11 2020, 3:45 PM · Restricted Project
akhuang committed rG54b6cca0f284: [globalopt] Change so that emitting fragments doesn't use the type size of… (authored by akhuang).
[globalopt] Change so that emitting fragments doesn't use the type size of…
Aug 11 2020, 2:52 PM
akhuang closed D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.
Aug 11 2020, 2:51 PM · Restricted Project

Aug 10 2020

akhuang added inline comments to D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.
Aug 10 2020, 5:23 PM · Restricted Project
akhuang added inline comments to D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.
Aug 10 2020, 4:17 PM · Restricted Project
akhuang added a comment to D83821: Make compiler-rt/asan tests run with llvm-lit..

whoops, forgot about this patch; not sure who to add as reviewer?

Aug 10 2020, 10:23 AM · Restricted Project
akhuang added a reviewer for D83821: Make compiler-rt/asan tests run with llvm-lit.: hans.
Aug 10 2020, 10:21 AM · Restricted Project

Aug 7 2020

akhuang requested review of D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.
Aug 7 2020, 5:10 PM · Restricted Project

Jul 29 2020

akhuang committed rGf71deb43abea: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors. (authored by akhuang).
[DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.
Jul 29 2020, 7:55 PM
akhuang closed D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors..
Jul 29 2020, 7:55 PM · Restricted Project
akhuang updated the diff for D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors..

remove change to add class types to retained types list,

Jul 29 2020, 1:37 PM · Restricted Project
akhuang added a comment to D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors..

I think it'd be good to separate these two issues/patches.

In part because I'm curious whether, even with a trivial ctor - if we did the retained types thing - would that be enough?

Jul 29 2020, 1:34 PM · Restricted Project
akhuang requested review of D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors..
Jul 29 2020, 9:55 AM · Restricted Project

Jul 28 2020

akhuang added a reverting change for rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited): rG394db2259575: Revert "Switch to using -debug-info-kind=constructor as default (from =limited)".
Jul 28 2020, 11:27 AM
akhuang committed rG394db2259575: Revert "Switch to using -debug-info-kind=constructor as default (from =limited)" (authored by akhuang).
Revert "Switch to using -debug-info-kind=constructor as default (from =limited)"
Jul 28 2020, 11:27 AM
akhuang added a reverting change for D79147: Switch to using -debug-info-kind=constructor as default (from =limited): rG394db2259575: Revert "Switch to using -debug-info-kind=constructor as default (from =limited)".
Jul 28 2020, 11:27 AM · debug-info, Restricted Project, Restricted Project

Jul 23 2020

akhuang added inline comments to D84380: [lit] Support running tests on Windows without GnuWin32..
Jul 23 2020, 10:55 AM · Restricted Project

Jul 22 2020

akhuang committed rG724bf4ee23a3: [Symbolize][PDB] Switch llvm-symbolizer to use PDB_ReaderType::Native. (authored by akhuang).
[Symbolize][PDB] Switch llvm-symbolizer to use PDB_ReaderType::Native.
Jul 22 2020, 5:18 PM
akhuang closed D84286: [Symbolize][PDB] Switch llvm-symbolizer to use PDB_ReaderType::Native..
Jul 22 2020, 5:18 PM · Restricted Project
akhuang added inline comments to D84345: [AMDGPU] Set the default globals address space to 1.
Jul 22 2020, 12:02 PM · Restricted Project, Restricted Project

Jul 21 2020

Herald added a project to D84286: [Symbolize][PDB] Switch llvm-symbolizer to use PDB_ReaderType::Native.: Restricted Project.
Jul 21 2020, 5:48 PM · Restricted Project
akhuang committed rG0881d0bed3aa: [PDB][NativeSession] Clean up some things in NativeSession. (authored by akhuang).
[PDB][NativeSession] Clean up some things in NativeSession.
Jul 21 2020, 4:56 PM
akhuang closed D84208: [PDB][NativeSession] Clean up some things in NativeSession..
Jul 21 2020, 4:55 PM · Restricted Project

Jul 20 2020

akhuang updated the diff for D84208: [PDB][NativeSession] Clean up some things in NativeSession..

more cleanup

Jul 20 2020, 9:16 PM · Restricted Project
Herald added a project to D84208: [PDB][NativeSession] Clean up some things in NativeSession.: Restricted Project.
Jul 20 2020, 9:16 PM · Restricted Project

Jul 14 2020

akhuang added a reviewer for D83821: Make compiler-rt/asan tests run with llvm-lit.: samsonov.
Jul 14 2020, 3:13 PM · Restricted Project
akhuang updated the summary of D83821: Make compiler-rt/asan tests run with llvm-lit..
Jul 14 2020, 3:10 PM · Restricted Project
Herald added a project to D83821: Make compiler-rt/asan tests run with llvm-lit.: Restricted Project.
Jul 14 2020, 3:06 PM · Restricted Project

Jul 9 2020

akhuang committed rG227db86a1b7d: Switch to using -debug-info-kind=constructor as default (from =limited) (authored by akhuang).
Switch to using -debug-info-kind=constructor as default (from =limited)
Jul 9 2020, 3:36 PM
akhuang closed D79147: Switch to using -debug-info-kind=constructor as default (from =limited).
Jul 9 2020, 3:36 PM · debug-info, Restricted Project, Restricted Project