- User Since
- Jun 23 2016, 2:29 PM (250 w, 4 d)
Mon, Apr 5
Mar 3 2021
So, what could be the futur of that patch? Would that be okay to merge with a target_abi Clang attribute?
Feb 3 2021
Jan 21 2021
I may be over-reacting to the way the patch seemed to be touching on the C++ ABI in multiple places. My understanding is that ms_abi is just a calling-convention attribute; it's basically "use the (default) calling convention that MSVC would use for this function". If that's all you want, then this is reasonable, although I am worried about creating a new attribute for every system that Wine chooses to target.
Jan 7 2021
Jan 5 2021
Rebase on current master, and take into account @aaron.ballman 's fixes (thanks!).
Dec 28 2020
Replace a just introduced const auto usage.
Clang format fixes
Rebased on current master branch, and added clang sema tests cc @aaron.ballman .
Dec 7 2020
Thanks @aaron.ballman for the comments!
Dec 3 2020
Dec 2 2020
Nov 29 2020
Relax checks in CodeGenCXX/darwinabi-returnthis.cpp Clang test (to adapt to new attributes), and removes some useless brackets in if statements.
Nov 28 2020
Oct 16 2020
One missing formatting case...
Add some clang-format tags, and restore back the "original" formatting for these cases
Oct 15 2020
Fix one clang-tidy warning
Update format + llvm tests
Aug 25 2020
This patch fixes one bug that was present: running llvm-lipo -archs on an LLVM IR object would crash, because we didn't check for that case in printBinaryArchs. This new patch fixes it, with an associated test.
@alexshap note that I don't have RW access to the llvm repository, so I can't merge this myself
Thanks for the new reviews! Fixed in the incoming diff
Aug 24 2020
Just a small variable naming cleanup
@alexshap there we go, it should fix all your remarks. Please let my know if there are still some issues.
Thanks @alexshap for your review and comments! Answers are inline.
Aug 22 2020
Aug 17 2020
Clang-tidy + format remarks
Fix fatal error message of MachOUniversalBinary::ObjectForArch::getAsIRObject
Here is a new patch that includes:
Aug 16 2020
- Update to monorepo and master
- Add forgotten RegisterMIRPasses.h
- Compile and test even in static mode
Aug 14 2020
Aug 12 2020
Thanks for the comments. Answers below:
Aug 11 2020
Dec 13 2019
Nov 26 2019
Use BUILDTREE_ONLY, as suggested by @serge-sans-paille .
Nov 25 2019
Nov 21 2019
Copyright added on new cpp files.
Nov 20 2019
Cleaning up some commented CMake code...
Thanks Serge for the comments !
Sep 5 2019
As a side remark, I have tested this with an out of tree MIR pass that dump MIR, and it works well. Should I add this test within the test suite? I didn't find such test for the current out-of-tree IR system (but chances are I missed it!).
Mar 21 2018
BTW, I don't have any commit rights thought, so I guess someone needs to merge this at some point?
Thanks everyone for the review and comments!
Feb 10 2018
Test case added!
Jan 31 2018
I'll try to do the same with icc by tring the various ABI it supports (https://software.intel.com/en-us/node/522787), and getting the potential value with readelf (all with a script to be able to run this again!)
Jan 22 2018
Jan 21 2018