Page MenuHomePhabricator

afd (Alastair Donaldson)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 5 2020, 4:48 PM (28 w, 1 d)

Recent Activity

Feb 24 2021

afd added a comment to D88931: [test-suite] Unit tests to improve code coverage.

@lenary Thanks for looking at this. Indeed, those uses of %i where it should be %u were oversights.

Feb 24 2021, 7:18 AM

Feb 19 2021

afd added a comment to D88931: [test-suite] Unit tests to improve code coverage.

Ace, thank you.

Feb 19 2021, 2:33 AM

Feb 18 2021

afd abandoned D96973: Unit tests to improve code coverage.

I had not intended to create this new diff - abandoning.

Feb 18 2021, 10:14 AM
afd added a comment to D88931: [test-suite] Unit tests to improve code coverage.

@lenary Thanks for the review! I have fixed the compiler warning that you spotted. I hope I did the right thing when I uploaded a revised patch (this is my first time working with the differential/arcanist workflow).

Feb 18 2021, 10:13 AM
afd updated the diff for D88931: [test-suite] Unit tests to improve code coverage.

Fixed a compiler warning as spotted by @lenary

Feb 18 2021, 10:11 AM
afd requested review of D96973: Unit tests to improve code coverage.
Feb 18 2021, 9:59 AM

Oct 6 2020

afd added reviewers for D88931: [test-suite] Unit tests to improve code coverage: anemet, lenary.

Hi @anemet and @lenary - I am keen to contribute these tests that improve on the code coverage achieved by the existing test suite. It's my first LLVM-related patch so I wasn't sure who the right folks to ask for reviews were, but I saw that you'd each done some recent reviews in the test suite so I wondered whether you might be suitable to review this, or to suggest other reviewers.

Oct 6 2020, 3:02 PM
afd requested review of D88931: [test-suite] Unit tests to improve code coverage.
Oct 6 2020, 2:49 PM