Page MenuHomePhabricator

abidmalikwaterloo (Abid)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 2:43 PM (76 w, 1 d)

Recent Activity

Yesterday

abidmalikwaterloo added a comment to D102816: [MLIR][OpenMP]Basic OpenMP target operation.

@kiranchandramohan I am not sure if I have commit access. You can do this for me.

Wed, Jun 23, 3:10 PM · Unknown Object (Project), Restricted Project

Tue, Jun 22

abidmalikwaterloo updated the diff for D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Took care of the comments from the reviewers.

Tue, Jun 22, 3:53 PM · Restricted Project
abidmalikwaterloo added a comment to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.

Took care of the comments.

Tue, Jun 22, 3:51 PM · Restricted Project
abidmalikwaterloo updated the diff for D102816: [MLIR][OpenMP]Basic OpenMP target operation.

Made changes according to the comments from the reviewers.
SI32 for If condition changes to I1 (boolean).

Tue, Jun 22, 5:47 AM · Unknown Object (Project), Restricted Project

Mon, Jun 21

abidmalikwaterloo abandoned D104674: Made changes as per comments from the reviewers.
Mon, Jun 21, 4:29 PM · Restricted Project
abidmalikwaterloo added a comment to D104674: Made changes as per comments from the reviewers.

How can I remove this patch?

Mon, Jun 21, 4:21 PM · Restricted Project
abidmalikwaterloo updated subscribers of D104674: Made changes as per comments from the reviewers.

Yes, I just realized this as well.

Mon, Jun 21, 4:20 PM · Restricted Project
abidmalikwaterloo requested review of D104674: Made changes as per comments from the reviewers.
Mon, Jun 21, 4:12 PM · Restricted Project

Wed, Jun 9

abidmalikwaterloo added inline comments to D102816: [MLIR][OpenMP]Basic OpenMP target operation.
Wed, Jun 9, 2:39 AM · Unknown Object (Project), Restricted Project

Fri, Jun 4

abidmalikwaterloo retitled D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct from [MLIR][OpenMP}Add custom parser and pretty printer for target construct to [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Fri, Jun 4, 5:02 PM · Restricted Project
abidmalikwaterloo retitled D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct from Add custom parser and pretty printer for target construct to [MLIR][OpenMP}Add custom parser and pretty printer for target construct.
Fri, Jun 4, 5:02 PM · Restricted Project
abidmalikwaterloo requested review of D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Fri, Jun 4, 2:59 PM · Restricted Project

Mon, May 31

abidmalikwaterloo added inline comments to D102816: [MLIR][OpenMP]Basic OpenMP target operation.
Mon, May 31, 7:26 AM · Unknown Object (Project), Restricted Project

May 25 2021

abidmalikwaterloo updated the summary of D102816: [MLIR][OpenMP]Basic OpenMP target operation.
May 25 2021, 3:07 AM · Unknown Object (Project), Restricted Project
abidmalikwaterloo retitled D102816: [MLIR][OpenMP]Basic OpenMP target operation from [MLIR][OpenMP}Basic OpenMP target operation to [MLIR][OpenMP]Basic OpenMP target operation.
May 25 2021, 2:56 AM · Unknown Object (Project), Restricted Project
abidmalikwaterloo retitled D102816: [MLIR][OpenMP]Basic OpenMP target operation from Basic OpenMP target operation to [MLIR][OpenMP}Basic OpenMP target operation.
May 25 2021, 2:55 AM · Unknown Object (Project), Restricted Project

May 24 2021

abidmalikwaterloo updated the diff for D102816: [MLIR][OpenMP]Basic OpenMP target operation.

Took care of the feedback and comments.

May 24 2021, 6:08 AM · Unknown Object (Project), Restricted Project
abidmalikwaterloo added inline comments to D102816: [MLIR][OpenMP]Basic OpenMP target operation.
May 24 2021, 6:04 AM · Unknown Object (Project), Restricted Project

May 21 2021

abidmalikwaterloo updated the diff for D102816: [MLIR][OpenMP]Basic OpenMP target operation.

Took care of the comments.

May 21 2021, 7:54 AM · Unknown Object (Project), Restricted Project

May 19 2021

abidmalikwaterloo retitled D102816: [MLIR][OpenMP]Basic OpenMP target operation from This includes a basic implementation for OpenMP target operation. The if, device, thread_limit and nowait. to Basic OpenMP target operation.
May 19 2021, 4:34 PM · Unknown Object (Project), Restricted Project
abidmalikwaterloo requested review of D102816: [MLIR][OpenMP]Basic OpenMP target operation.
May 19 2021, 4:29 PM · Unknown Object (Project), Restricted Project

Mar 12 2021

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.
  • Apply the update_test_checks.py
Mar 12 2021, 7:06 AM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.

x - Clean the code

  • clean the code
Mar 12 2021, 7:03 AM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • Apply the update_test_checks.py
Mar 12 2021, 6:56 AM · Restricted Project, Unknown Object (Project)

Mar 2 2021

abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • A modified parallel_omp_for_loop_merge1.ll is added . Taking care of the comments
Mar 2 2021, 7:39 AM · Restricted Project, Unknown Object (Project)

Feb 25 2021

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Let's focus on the tests without the optimization code.

On that front:

  1. Avoid unnecessary complexity, i.a., print, and go for simple identifiable calls, like body1()
  2. Remove everything from the test that is not needed, e.g. unrelated functions, attributes, etc.
  3. Preprocess the tests with common passes such as mem2reg, instcombine, and simplifycfg. We only want to run openmpopt on them later, never O3.
Feb 25 2021, 5:07 AM · Restricted Project, Unknown Object (Project)

Feb 8 2021

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Should I upload all potential tests in C/C++ format to define the scope of this patch? We can convert it to IR format later for upstreaming.

Feb 8 2021, 9:35 AM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

uploaded a new patch which is short and works on the cases without conditional statements

Feb 8 2021, 9:06 AM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  1. rewrote the patch and elimate lot of redundent stuff
Feb 8 2021, 9:03 AM · Restricted Project, Unknown Object (Project)

Feb 4 2021

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

The optimization code is lacking in various regards. Let's focus on addressing the test remarks first in order to upstream those. We can revisit how to proceed with the optimization code after, e.g., revisit the algorithm from scratch.

Feb 4 2021, 5:17 PM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

I have a new patch that I wrote with LLVM-11 .0. The current patchwork is based on LLVM-9.0. The OpenMPOpt.CPP has a lot of modifications. What is the best way to submit the new patch? Any suggestion would be helpful.

Feb 4 2021, 4:32 PM · Restricted Project, Unknown Object (Project)

Dec 23 2020

abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • Added a test case for OMP loop for merging
Dec 23 2020, 6:43 PM · Restricted Project, Unknown Object (Project)

Dec 9 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Added a test for OpenMP for loop fusion. Is the sample test acceptable? I can add more in the same format.

Dec 9 2020, 8:48 AM · Restricted Project, Unknown Object (Project)

Dec 5 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

added a test. Would like to have feedback to add more.

Dec 5 2020, 6:43 PM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • added test case for parallel openmp for loop merging
Dec 5 2020, 6:42 PM · Restricted Project, Unknown Object (Project)

Nov 23 2020

abidmalikwaterloo added inline comments to D90103: Add OpenMP for optimization.
Nov 23 2020, 2:59 AM · Restricted Project, Unknown Object (Project)

Nov 22 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

The tests should be in llvm-project/llvm/test/Transforms/OpenMP.

Nov 22 2020, 2:54 PM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.
Nov 22 2020, 9:05 AM · Restricted Project, Unknown Object (Project)
abidmalikwaterloo updated the diff for D90103: Add OpenMP for optimization.
  • make changes in OpenMPOpt
Nov 22 2020, 7:27 AM · Restricted Project, Unknown Object (Project)

Nov 19 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

See the new patch

Nov 19 2020, 2:43 PM · Restricted Project
abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Adding test cases

There are still no test cases.

Yes. I have tests. I will add it to the LIT and will update the patch.

Nov 19 2020, 2:35 PM · Restricted Project, Unknown Object (Project)

Oct 25 2020

abidmalikwaterloo added a comment to D90103: Add OpenMP for optimization.

Adding test cases

There are still no test cases.

Oct 25 2020, 9:59 AM · Restricted Project, Unknown Object (Project)

Oct 24 2020

abidmalikwaterloo requested review of D90103: Add OpenMP for optimization.
Oct 24 2020, 12:44 PM · Restricted Project, Unknown Object (Project)

Oct 14 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

I tried almost everything. Let me try again.

Oct 14 2020, 3:24 AM · Restricted Project

Oct 9 2020

abidmalikwaterloo requested review of D89132: OpenMP parallel for call elimination .
Oct 9 2020, 7:28 AM · Restricted Project

Oct 7 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

I have been trying to update my patch by following the steps on:

Oct 7 2020, 11:10 AM · Restricted Project

Oct 5 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

Yes, I am trying to figure it out why it is not loading my tests and changes

Oct 5 2020, 5:50 PM · Restricted Project
abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.
Oct 5 2020, 5:40 PM · Restricted Project
abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.

The patch now handles conditional blocks containing parallel for loops.

Oct 5 2020, 5:19 PM · Restricted Project

Jul 27 2020

abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.
Jul 27 2020, 1:42 PM · Restricted Project

Apr 7 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

This doesn't seem to use dominance at all. How do you handle

if (a) {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
} else {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
}

if the value of a is known at the time of compilation, we will only have one "for loop". Therefore, for this specific case, the implemented technique will see only one "for loop" at the IR level. This case should be a problem.

Apr 7 2020, 9:44 AM · Restricted Project
abidmalikwaterloo updated subscribers of D75384: OpenMP for loop fusion.
Apr 7 2020, 9:44 AM · Restricted Project

Apr 1 2020

abidmalikwaterloo added a comment to D75384: OpenMP for loop fusion.

This doesn't seem to use dominance at all. How do you handle

if (a) {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
} else {
#pragma omp for
for (int i = 0; i < 10; i++)
  ;
}
Apr 1 2020, 4:20 PM · Restricted Project

Mar 12 2020

abidmalikwaterloo updated the diff for D75384: OpenMP for loop fusion.
Mar 12 2020, 6:20 PM · Restricted Project

Feb 28 2020

abidmalikwaterloo created D75384: OpenMP for loop fusion.
Feb 28 2020, 1:42 PM · Restricted Project