Page MenuHomePhabricator

abialas (Artur Bialas)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2020, 4:58 AM (7 w, 6 d)

Recent Activity

Fri, Sep 25

abialas committed rG396e7f454893: [mlir][SCFToGPU] LaunchOp propagate optional attributes (authored by abialas).
[mlir][SCFToGPU] LaunchOp propagate optional attributes
Fri, Sep 25, 12:22 AM
abialas closed D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .
Fri, Sep 25, 12:22 AM · Restricted Project

Thu, Sep 24

abialas updated the diff for D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .

added simple test

Thu, Sep 24, 3:12 AM · Restricted Project
abialas requested review of D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .
Thu, Sep 24, 2:04 AM · Restricted Project

Thu, Sep 17

abialas added a reverting change for rG9d54b166c2e5: This is a test commit: rG5a733468e094: Revert "This is a test commit".
Thu, Sep 17, 11:45 PM
abialas committed rG5a733468e094: Revert "This is a test commit" (authored by abialas).
Revert "This is a test commit"
Thu, Sep 17, 11:45 PM
abialas committed rG9d54b166c2e5: This is a test commit (authored by abialas).
This is a test commit
Thu, Sep 17, 11:45 PM

Wed, Sep 16

abialas added a comment to D87688: [mlir][spirv] Add GroupNonUniformBroadcastOp.

Thanks Thomas for the review, may I ask you to push this change to llvm master?
Btw, to not bother you again with this, is there a process to get RW access to the repo so I can push future changes on my own?

Wed, Sep 16, 10:39 PM · Restricted Project

Tue, Sep 15

abialas updated the diff for D87688: [mlir][spirv] Add GroupNonUniformBroadcastOp.

removed static_casts

Tue, Sep 15, 8:24 AM · Restricted Project
abialas requested review of D87688: [mlir][spirv] Add GroupNonUniformBroadcastOp.
Tue, Sep 15, 5:47 AM · Restricted Project

Wed, Sep 2

abialas added a comment to D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.

Thanks Thomas, good catch. Please take a look at the updated version. If it looks good, may I ask you to push this change to llvm master?

Wed, Sep 2, 4:02 AM · Restricted Project
abialas updated the diff for D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.

added changes from code review

Wed, Sep 2, 4:01 AM · Restricted Project

Tue, Sep 1

abialas updated the diff for D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.
Tue, Sep 1, 5:41 AM · Restricted Project

Aug 31 2020

abialas requested review of D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.
Aug 31 2020, 6:26 AM · Restricted Project

Aug 10 2020

abialas added a comment to D85435: [mlir][spirv] Add OpGroupBroadcast.

I added remaining changes requested. Regarding the CHECK-* format I believe it is consistent with other tests.
Since I do not have rw access to llvm repo, may I ask someone to push this change to trunk?

Aug 10 2020, 1:18 AM · Restricted Project
abialas updated the diff for D85435: [mlir][spirv] Add OpGroupBroadcast.

Changes after code review

Aug 10 2020, 1:14 AM · Restricted Project

Aug 7 2020

abialas added a comment to D85435: [mlir][spirv] Add OpGroupBroadcast.

We also need tests for roundtripping the serialization to SPIR-V binary. Please see this section : https://mlir.llvm.org/docs/Dialects/SPIR-V/#add-a-new-op

"Tests for the op’s custom assembly form and verification should be added to the proper file in test/Dialect/SPIRV/.

The generated op will automatically gain the logic for (de)serialization. However, tests still need to be coupled with the change to make sure no surprises. Serialization tests live in test/Dialect/SPIRV/Serialization."

Aug 7 2020, 1:13 AM · Restricted Project
abialas updated the diff for D85435: [mlir][spirv] Add OpGroupBroadcast.

Changes added after code review

Aug 7 2020, 1:09 AM · Restricted Project

Aug 6 2020

abialas requested review of D85435: [mlir][spirv] Add OpGroupBroadcast.
Aug 6 2020, 8:32 AM · Restricted Project