LGTM

Sorry, I wasn't aware Windows didn't support "diff -B". I will try "diff -b" which appears in other lit tests.

Use diff -B to ignore extra blank lines.

There was an extra ^M carriage return at the end of two lines in lld/test/COFF/pdb-type-server-invalid-signature.yaml CHECK lines. This update removes them.

This patch replaces the memcpy in CharLiteralParser with an assignment. I've added an assertion for cases where the character size increases after translation.

Thanks for the review! I've addressed most of the comments but I still need to work on the translation issues in CharLiteralParser that was kindly pointed out by Tom and Richard. Here are the summary of changes in this patch:

Thanks for your patience, I've addressed some more comments. Here is the summary of the changes in this patch:

In D93031#2447230, @rsmith wrote:

I'm overall pretty happy about how clean and non-invasive the changes required here are. But please make sure you don't change the encodings of u8"..." / u"..." / U"..." literals; those need to stay as UTF-8 / UTF-16 / UTF-32. Also, we should have a story for how the wide execution character set is controlled -- is it derived from the narrow execution character set, or can the two be changed independently, or ...?

We should use the original source form of the string literal when pretty-printing a StringLiteral or CharacterLiteral; there are a bunch of UTF-8 assumptions baked into StmtPrinter that will need revisiting. And we'll need to modify the handful of places that put the contents of StringLiterals into diagnostics (#warning, #error, static_assert) and make them use a different ConversionState, since our assumption is that diagnostic output should be in UTF-8.

Thanks for your quick reviews! I haven't addressed all the comments yet but I plan to address all of them. I put up this patch early because it has a few major changes:

Add one more testcase.

LGTM

LGTM

lgtm

LGTM

Thanks Hubert, I removed the lines.

In D85324#2234712, @hubert.reinterpretcast wrote:

In D85324#2233290, @abhina.sreeskantharajan wrote:

Thanks Hubert, I fixed the comment.

Got it; I'll look into committing this.

Thanks Hubert, I fixed the comment.

Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes.

Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion.

Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands.

Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates.

LGTM

Thanks for catching that. I fixed up the testcase.

Thanks Hubert for the suggestion. I've updated the lit test.

Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's suggestion, and updated both testcases as requested.

Thanks Hubert for reviewing. I updated the patch to fix the wchar_t comment and the if guards for the macros. I also updated the lit test to reflect these new changes.

Thanks MaskRay, I removed the extra braces.

LGTM!

@hubert.reinterpretcast or @daltenty can you commit this revision?

Thanks for looking into this. Yes, with the fix you provided, the testcase now passes!