Page MenuHomePhabricator

abhina.sreeskantharajan (Abhina Sree)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2020, 9:23 AM (31 w, 3 d)

Recent Activity

Today

abhina.sreeskantharajan committed rG0fb97fd6a4f2: [SystemZ][z/OS] Set default wchar_t type for zOS (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Set default wchar_t type for zOS
Tue, Sep 22, 5:03 AM
abhina.sreeskantharajan closed D87624: [SystemZ][z/OS] Set default wchar_t type for zOS.
Tue, Sep 22, 5:03 AM · Restricted Project

Wed, Sep 16

abhina.sreeskantharajan committed rG2240ca0bd150: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS (authored by fanbo-meng).
[SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS
Wed, Sep 16, 11:49 AM
abhina.sreeskantharajan closed D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Wed, Sep 16, 11:49 AM · Restricted Project
abhina.sreeskantharajan accepted D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

LGTM

Wed, Sep 16, 8:58 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Wed, Sep 16, 8:54 AM · Restricted Project

Mon, Sep 14

abhina.sreeskantharajan requested review of D87624: [SystemZ][z/OS] Set default wchar_t type for zOS.
Mon, Sep 14, 11:49 AM · Restricted Project

Tue, Sep 1

abhina.sreeskantharajan committed rGc831a14aa16a: [SystemZ][z/OS] Fix build break in z/OS toolchain (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Fix build break in z/OS toolchain
Tue, Sep 1, 7:41 AM
abhina.sreeskantharajan committed rG3e1e5f54492d: [SystemZ][z/OS] Adding initial toolchain for z/OS (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Adding initial toolchain for z/OS
Tue, Sep 1, 7:16 AM
abhina.sreeskantharajan closed D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Tue, Sep 1, 7:16 AM · Restricted Project
abhina.sreeskantharajan committed rG5a3ede58e2c1: [NFC] Test commit, whitespace changes (authored by abhina.sreeskantharajan).
[NFC] Test commit, whitespace changes
Tue, Sep 1, 6:56 AM
abhina.sreeskantharajan updated the diff for D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.

Thanks Hubert, I removed the lines.

Tue, Sep 1, 6:28 AM · Restricted Project

Mon, Aug 31

abhina.sreeskantharajan added inline comments to D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Mon, Aug 31, 7:06 AM · Restricted Project

Thu, Aug 27

abhina.sreeskantharajan requested review of D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Thu, Aug 27, 6:38 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Thu, Aug 27, 5:08 AM · Restricted Project

Tue, Aug 25

abhina.sreeskantharajan added a comment to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I fixed the comment.

Got it; I'll look into committing this.

Tue, Aug 25, 8:11 AM · Restricted Project

Mon, Aug 24

abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I fixed the comment.

Mon, Aug 24, 4:19 AM · Restricted Project

Aug 21 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 21 2020, 8:45 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes.

Aug 21 2020, 8:41 AM · Restricted Project

Aug 20 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 20 2020, 10:25 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion.

Aug 20 2020, 10:24 AM · Restricted Project

Aug 17 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 17 2020, 11:16 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands.

Aug 17 2020, 11:15 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates.

Aug 17 2020, 7:08 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 17 2020, 6:58 AM · Restricted Project

Aug 14 2020

abhina.sreeskantharajan accepted D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..

LGTM

Aug 14 2020, 7:04 AM · Restricted Project

Aug 13 2020

abhina.sreeskantharajan updated the diff for D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

Thanks for catching that. I fixed up the testcase.

Aug 13 2020, 10:55 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

Thanks Hubert for the suggestion. I've updated the lit test.

Aug 13 2020, 9:23 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 13 2020, 7:07 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's suggestion, and updated both testcases as requested.

Aug 13 2020, 6:59 AM · Restricted Project
abhina.sreeskantharajan updated abhina.sreeskantharajan.
Aug 13 2020, 6:42 AM

Aug 11 2020

abhina.sreeskantharajan retitled D85324: [SystemZ][z/OS] Add z/OS Target and define macros from [z/OS] Add z/OS Target and define macros to [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 11 2020, 5:12 AM · Restricted Project
abhina.sreeskantharajan retitled D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS from [z/OS] enable trigraphs by default on z/OS to [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 11 2020, 5:11 AM · Restricted Project
abhina.sreeskantharajan requested review of D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 11 2020, 5:02 AM · Restricted Project

Aug 7 2020

abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert for reviewing. I updated the patch to fix the wchar_t comment and the if guards for the macros. I also updated the lit test to reflect these new changes.

Aug 7 2020, 10:17 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 7 2020, 9:12 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 7 2020, 8:54 AM · Restricted Project

Aug 6 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 6 2020, 5:29 AM · Restricted Project

Aug 5 2020

abhina.sreeskantharajan added reviewers for D85324: [SystemZ][z/OS] Add z/OS Target and define macros : tatyana-krasnukha, t.p.northover, sidneym, simoll, lenary.
Aug 5 2020, 11:17 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks MaskRay, I removed the extra braces.

Aug 5 2020, 10:23 AM · Restricted Project
abhina.sreeskantharajan added reviewers for D85324: [SystemZ][z/OS] Add z/OS Target and define macros : anirudhp, daltenty, stevewan.
Aug 5 2020, 9:51 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 5 2020, 9:44 AM · Restricted Project
abhina.sreeskantharajan requested review of D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 5 2020, 9:35 AM · Restricted Project

Jul 22 2020

abhina.sreeskantharajan accepted D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime().

LGTM!

Jul 22 2020, 7:15 AM · Restricted Project

Jul 15 2020

abhina.sreeskantharajan added a comment to D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS.

@hubert.reinterpretcast or @daltenty can you commit this revision?

Jul 15 2020, 10:56 AM · Restricted Project
Herald added a project to D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS: Restricted Project.
Jul 15 2020, 10:41 AM · Restricted Project

Feb 20 2020

abhina.sreeskantharajan added a comment to rGf8045b250d80: Recommit "[SCCP] Remove forcedconstant, go to overdefined instead".

Thanks for looking into this. Yes, with the fix you provided, the testcase now passes!

Feb 20 2020, 11:15 AM