Page MenuHomePhabricator

abhina.sreeskantharajan (Abhina Sree)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 15 2020, 9:23 AM (48 w, 14 h)

Recent Activity

Thu, Jan 14

abhina.sreeskantharajan accepted D94683: [Doc] Fix syntax error in CodeGenerator documentation example.

LGTM

Thu, Jan 14, 5:58 AM · Restricted Project

Mon, Jan 11

abhina.sreeskantharajan committed rG8ad998a6115a: [tools] Mark output of tools as text if it is really text (authored by abhina.sreeskantharajan).
[tools] Mark output of tools as text if it is really text
Mon, Jan 11, 12:14 PM
abhina.sreeskantharajan closed D94313: [tools] Mark output of tools as text if it is really text.
Mon, Jan 11, 12:14 PM · Restricted Project
abhina.sreeskantharajan committed rG1027a22ccd72: [SystemZ][z/OS] Fix Permission denied pattern matching (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Fix Permission denied pattern matching
Mon, Jan 11, 11:31 AM
abhina.sreeskantharajan closed D94432: [SystemZ][z/OS] Fix Permission denied pattern matching.
Mon, Jan 11, 11:31 AM · Restricted Project
abhina.sreeskantharajan requested review of D94432: [SystemZ][z/OS] Fix Permission denied pattern matching.
Mon, Jan 11, 9:56 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D94313: [tools] Mark output of tools as text if it is really text.

Sorry, I wasn't aware Windows didn't support "diff -B". I will try "diff -b" which appears in other lit tests.

Mon, Jan 11, 7:19 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D94313: [tools] Mark output of tools as text if it is really text.

Use diff -B to ignore extra blank lines.

Mon, Jan 11, 5:52 AM · Restricted Project

Fri, Jan 8

abhina.sreeskantharajan requested review of D94313: [tools] Mark output of tools as text if it is really text.
Fri, Jan 8, 8:21 AM · Restricted Project

Thu, Jan 7

abhina.sreeskantharajan updated the diff for D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests .

There was an extra ^M carriage return at the end of two lines in lld/test/COFF/pdb-type-server-invalid-signature.yaml CHECK lines. This update removes them.

Thu, Jan 7, 10:48 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan requested review of D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests .
Thu, Jan 7, 8:54 AM · Restricted Project, Restricted Project

Wed, Dec 30

abhina.sreeskantharajan added inline comments to D93031: Enable fexec-charset option .
Wed, Dec 30, 7:22 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added inline comments to D93031: Enable fexec-charset option .
Wed, Dec 30, 6:52 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D93031: Enable fexec-charset option .

This patch replaces the memcpy in CharLiteralParser with an assignment. I've added an assertion for cases where the character size increases after translation.

Wed, Dec 30, 6:49 AM · Restricted Project, Restricted Project

Tue, Dec 29

abhina.sreeskantharajan added inline comments to D93031: Enable fexec-charset option .
Tue, Dec 29, 12:45 PM · Restricted Project, Restricted Project
abhina.sreeskantharajan added inline comments to D93031: Enable fexec-charset option .
Tue, Dec 29, 11:39 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D93031: Enable fexec-charset option .

Thanks for the review! I've addressed most of the comments but I still need to work on the translation issues in CharLiteralParser that was kindly pointed out by Tom and Richard. Here are the summary of changes in this patch:

Tue, Dec 29, 11:34 AM · Restricted Project, Restricted Project

Mon, Dec 21

abhina.sreeskantharajan added a reviewer for D93031: Enable fexec-charset option : rsmith.
Mon, Dec 21, 8:32 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added inline comments to D93031: Enable fexec-charset option .
Mon, Dec 21, 8:29 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan added inline comments to D93031: Enable fexec-charset option .
Mon, Dec 21, 8:25 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D93031: Enable fexec-charset option .

Thanks for your patience, I've addressed some more comments. Here is the summary of the changes in this patch:

Mon, Dec 21, 8:14 AM · Restricted Project, Restricted Project

Dec 15 2020

abhina.sreeskantharajan added a comment to D93031: Enable fexec-charset option .

I'm overall pretty happy about how clean and non-invasive the changes required here are. But please make sure you don't change the encodings of u8"..." / u"..." / U"..." literals; those need to stay as UTF-8 / UTF-16 / UTF-32. Also, we should have a story for how the wide execution character set is controlled -- is it derived from the narrow execution character set, or can the two be changed independently, or ...?

We should use the original source form of the string literal when pretty-printing a StringLiteral or CharacterLiteral; there are a bunch of UTF-8 assumptions baked into StmtPrinter that will need revisiting. And we'll need to modify the handful of places that put the contents of StringLiterals into diagnostics (#warning, #error, static_assert) and make them use a different ConversionState, since our assumption is that diagnostic output should be in UTF-8.

Dec 15 2020, 8:40 AM · Restricted Project, Restricted Project
abhina.sreeskantharajan updated the diff for D93031: Enable fexec-charset option .

Thanks for your quick reviews! I haven't addressed all the comments yet but I plan to address all of them. I put up this patch early because it has a few major changes:

Dec 15 2020, 8:22 AM · Restricted Project, Restricted Project

Dec 10 2020

abhina.sreeskantharajan added reviewers for D93031: Enable fexec-charset option : Kai, fanbo-meng, tahonermann, hubert.reinterpretcast, efriedma, SeanP.
Dec 10 2020, 1:02 PM · Restricted Project, Restricted Project
abhina.sreeskantharajan requested review of D93031: Enable fexec-charset option .
Dec 10 2020, 5:49 AM · Restricted Project, Restricted Project

Dec 2 2020

abhina.sreeskantharajan committed rGf770ec1a4e8d: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c (authored by abhina.sreeskantharajan).
[SystemZ][NFC]Move all SystemZ tests to init-s390x.c
Dec 2 2020, 5:23 AM
abhina.sreeskantharajan closed D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c.
Dec 2 2020, 5:23 AM · Restricted Project

Nov 24 2020

abhina.sreeskantharajan requested review of D92048: [SystemZ][NFC]Move all SystemZ tests to init-s390x.c.
Nov 24 2020, 11:08 AM · Restricted Project

Nov 20 2020

abhina.sreeskantharajan committed rG2c7e24c4b689: Guard init_priority attribute within libc++ (authored by zibi).
Guard init_priority attribute within libc++
Nov 20 2020, 12:53 PM
abhina.sreeskantharajan closed D91565: Guard init_priority attribute within libc++.
Nov 20 2020, 12:53 PM · Restricted Project, Restricted Project

Nov 18 2020

abhina.sreeskantharajan committed rG057e6bb5540b: [SystemZ][NFC] Group SystemZ tests in SystemZ folder (authored by abhina.sreeskantharajan).
[SystemZ][NFC] Group SystemZ tests in SystemZ folder
Nov 18 2020, 8:49 AM
abhina.sreeskantharajan closed D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder.
Nov 18 2020, 8:49 AM · Restricted Project

Nov 17 2020

abhina.sreeskantharajan added reviewers for D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder: fanbo-meng, Kai, uweigand, Jonathan.Crowther.
Nov 17 2020, 7:04 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder.

Add one more testcase.

Nov 17 2020, 7:03 AM · Restricted Project
abhina.sreeskantharajan requested review of D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder.
Nov 17 2020, 7:01 AM · Restricted Project

Nov 12 2020

abhina.sreeskantharajan committed rGaa8a5b800def: [SystemZ][ZOS] libcxx - no posix memalign (authored by zibi).
[SystemZ][ZOS] libcxx - no posix memalign
Nov 12 2020, 11:48 AM
abhina.sreeskantharajan closed D90178: [SystemZ][ZOS] libcxx - no posix memalign.
Nov 12 2020, 11:48 AM · Restricted Project
abhina.sreeskantharajan committed rG173b51169b83: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS (authored by zibi).
[SystemZ][ZOS] Porting the time functions within libc++ to z/OS
Nov 12 2020, 8:29 AM
abhina.sreeskantharajan closed D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS.
Nov 12 2020, 8:29 AM · Restricted Project

Nov 10 2020

abhina.sreeskantharajan committed rGe72e785d4707: [SystemZ][z/OS] Enable POSIX_l functions for z/OS (authored by muiez).
[SystemZ][z/OS] Enable POSIX_l functions for z/OS
Nov 10 2020, 6:57 AM
abhina.sreeskantharajan closed D90319: [SystemZ][z/OS] Enable POSIX_l functions for z/OS.
Nov 10 2020, 6:57 AM · Restricted Project

Oct 22 2020

abhina.sreeskantharajan committed rG9bc02e892f54: [SystemZ][z/OS] Set short-enums as the default for z/OS (authored by Jonathan.Crowther).
[SystemZ][z/OS] Set short-enums as the default for z/OS
Oct 22 2020, 11:16 AM
abhina.sreeskantharajan closed D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS.
Oct 22 2020, 11:16 AM · Restricted Project
abhina.sreeskantharajan set the repository for D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS to rG LLVM Github Monorepo.
Oct 22 2020, 11:00 AM · Restricted Project
abhina.sreeskantharajan accepted D89801: [SystemZ][z/OS] Set short-enums as the default for z/OS.

LGTM

Oct 22 2020, 5:13 AM · Restricted Project

Oct 9 2020

abhina.sreeskantharajan accepted D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test.

LGTM

Oct 9 2020, 6:36 AM · Restricted Project

Oct 7 2020

abhina.sreeskantharajan committed rG9908ee567059: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target… (authored by fanbo-meng).
[SystemZ][z/OS] Add test of zero length bitfield type size larger than target…
Oct 7 2020, 8:34 AM
abhina.sreeskantharajan closed D88963: [SystemZ][z/OS] Add test of zero length bitfield type size larger than target zero length bitfield boundary.
Oct 7 2020, 8:34 AM · Restricted Project

Oct 6 2020

abhina.sreeskantharajan committed rG43cd0a98d1b1: [SystemZ][z/OS] Set default alignment rules for z/OS target (authored by fanbo-meng).
[SystemZ][z/OS] Set default alignment rules for z/OS target
Oct 6 2020, 11:23 AM
abhina.sreeskantharajan committed rGc781dc74a8b2: [SystemZ][z/OS] Set default alignment rules for z/OS target (authored by fanbo-meng).
[SystemZ][z/OS] Set default alignment rules for z/OS target
Oct 6 2020, 10:16 AM
abhina.sreeskantharajan closed D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target.
Oct 6 2020, 10:16 AM · Restricted Project
abhina.sreeskantharajan accepted D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target.

lgtm

Oct 6 2020, 6:36 AM · Restricted Project

Sep 22 2020

abhina.sreeskantharajan committed rG0fb97fd6a4f2: [SystemZ][z/OS] Set default wchar_t type for zOS (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Set default wchar_t type for zOS
Sep 22 2020, 5:03 AM
abhina.sreeskantharajan closed D87624: [SystemZ][z/OS] Set default wchar_t type for zOS.
Sep 22 2020, 5:03 AM · Restricted Project

Sep 16 2020

abhina.sreeskantharajan committed rG2240ca0bd150: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS (authored by fanbo-meng).
[SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS
Sep 16 2020, 11:49 AM
abhina.sreeskantharajan closed D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Sep 16 2020, 11:49 AM · Restricted Project
abhina.sreeskantharajan accepted D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

LGTM

Sep 16 2020, 8:58 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Sep 16 2020, 8:54 AM · Restricted Project

Sep 14 2020

abhina.sreeskantharajan requested review of D87624: [SystemZ][z/OS] Set default wchar_t type for zOS.
Sep 14 2020, 11:49 AM · Restricted Project

Sep 1 2020

abhina.sreeskantharajan committed rGc831a14aa16a: [SystemZ][z/OS] Fix build break in z/OS toolchain (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Fix build break in z/OS toolchain
Sep 1 2020, 7:41 AM
abhina.sreeskantharajan committed rG3e1e5f54492d: [SystemZ][z/OS] Adding initial toolchain for z/OS (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Adding initial toolchain for z/OS
Sep 1 2020, 7:16 AM
abhina.sreeskantharajan closed D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Sep 1 2020, 7:16 AM · Restricted Project
abhina.sreeskantharajan committed rG5a3ede58e2c1: [NFC] Test commit, whitespace changes (authored by abhina.sreeskantharajan).
[NFC] Test commit, whitespace changes
Sep 1 2020, 6:56 AM
abhina.sreeskantharajan updated the diff for D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.

Thanks Hubert, I removed the lines.

Sep 1 2020, 6:28 AM · Restricted Project

Aug 31 2020

abhina.sreeskantharajan added inline comments to D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Aug 31 2020, 7:06 AM · Restricted Project

Aug 27 2020

abhina.sreeskantharajan requested review of D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Aug 27 2020, 6:38 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 27 2020, 5:08 AM · Restricted Project

Aug 25 2020

abhina.sreeskantharajan added a comment to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I fixed the comment.

Got it; I'll look into committing this.

Aug 25 2020, 8:11 AM · Restricted Project

Aug 24 2020

abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I fixed the comment.

Aug 24 2020, 4:19 AM · Restricted Project

Aug 21 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 21 2020, 8:45 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes.

Aug 21 2020, 8:41 AM · Restricted Project

Aug 20 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 20 2020, 10:25 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion.

Aug 20 2020, 10:24 AM · Restricted Project

Aug 17 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 17 2020, 11:16 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands.

Aug 17 2020, 11:15 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates.

Aug 17 2020, 7:08 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 17 2020, 6:58 AM · Restricted Project

Aug 14 2020

abhina.sreeskantharajan accepted D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..

LGTM

Aug 14 2020, 7:04 AM · Restricted Project

Aug 13 2020

abhina.sreeskantharajan updated the diff for D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

Thanks for catching that. I fixed up the testcase.

Aug 13 2020, 10:55 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

Thanks Hubert for the suggestion. I've updated the lit test.

Aug 13 2020, 9:23 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 13 2020, 7:07 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's suggestion, and updated both testcases as requested.

Aug 13 2020, 6:59 AM · Restricted Project
abhina.sreeskantharajan updated abhina.sreeskantharajan.
Aug 13 2020, 6:42 AM

Aug 11 2020

abhina.sreeskantharajan retitled D85324: [SystemZ][z/OS] Add z/OS Target and define macros from [z/OS] Add z/OS Target and define macros to [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 11 2020, 5:12 AM · Restricted Project
abhina.sreeskantharajan retitled D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS from [z/OS] enable trigraphs by default on z/OS to [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 11 2020, 5:11 AM · Restricted Project
abhina.sreeskantharajan requested review of D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 11 2020, 5:02 AM · Restricted Project

Aug 7 2020

abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert for reviewing. I updated the patch to fix the wchar_t comment and the if guards for the macros. I also updated the lit test to reflect these new changes.

Aug 7 2020, 10:17 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 7 2020, 9:12 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 7 2020, 8:54 AM · Restricted Project

Aug 6 2020

abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 6 2020, 5:29 AM · Restricted Project

Aug 5 2020

abhina.sreeskantharajan added reviewers for D85324: [SystemZ][z/OS] Add z/OS Target and define macros : tatyana-krasnukha, t.p.northover, sidneym, simoll, lenary.
Aug 5 2020, 11:17 AM · Restricted Project
abhina.sreeskantharajan updated the diff for D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks MaskRay, I removed the extra braces.

Aug 5 2020, 10:23 AM · Restricted Project
abhina.sreeskantharajan added reviewers for D85324: [SystemZ][z/OS] Add z/OS Target and define macros : anirudhp, daltenty, stevewan.
Aug 5 2020, 9:51 AM · Restricted Project
abhina.sreeskantharajan added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 5 2020, 9:44 AM · Restricted Project
abhina.sreeskantharajan requested review of D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 5 2020, 9:35 AM · Restricted Project

Jul 22 2020

abhina.sreeskantharajan accepted D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime().

LGTM!

Jul 22 2020, 7:15 AM · Restricted Project

Jul 15 2020

abhina.sreeskantharajan added a comment to D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS.

@hubert.reinterpretcast or @daltenty can you commit this revision?

Jul 15 2020, 10:56 AM · Restricted Project
Herald added a project to D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS: Restricted Project.
Jul 15 2020, 10:41 AM · Restricted Project

Feb 20 2020

abhina.sreeskantharajan added a comment to rGf8045b250d80: Recommit "[SCCP] Remove forcedconstant, go to overdefined instead".

Thanks for looking into this. Yes, with the fix you provided, the testcase now passes!

Feb 20 2020, 11:15 AM