User Details
- User Since
- Feb 15 2020, 9:23 AM (48 w, 14 h)
Thu, Jan 14
LGTM
Mon, Jan 11
Sorry, I wasn't aware Windows didn't support "diff -B". I will try "diff -b" which appears in other lit tests.
Use diff -B to ignore extra blank lines.
Fri, Jan 8
Thu, Jan 7
There was an extra ^M carriage return at the end of two lines in lld/test/COFF/pdb-type-server-invalid-signature.yaml CHECK lines. This update removes them.
Wed, Dec 30
This patch replaces the memcpy in CharLiteralParser with an assignment. I've added an assertion for cases where the character size increases after translation.
Tue, Dec 29
Thanks for the review! I've addressed most of the comments but I still need to work on the translation issues in CharLiteralParser that was kindly pointed out by Tom and Richard. Here are the summary of changes in this patch:
Mon, Dec 21
Thanks for your patience, I've addressed some more comments. Here is the summary of the changes in this patch:
Dec 15 2020
Thanks for your quick reviews! I haven't addressed all the comments yet but I plan to address all of them. I put up this patch early because it has a few major changes:
Dec 10 2020
Dec 2 2020
Nov 24 2020
Nov 20 2020
Nov 18 2020
Nov 17 2020
Add one more testcase.
Nov 12 2020
Nov 10 2020
Oct 22 2020
LGTM
Oct 9 2020
LGTM
Oct 7 2020
Oct 6 2020
lgtm
Sep 22 2020
Sep 16 2020
LGTM
Sep 14 2020
Sep 1 2020
Thanks Hubert, I removed the lines.
Aug 31 2020
Aug 27 2020
Aug 25 2020
Aug 24 2020
Thanks Hubert, I fixed the comment.
Aug 21 2020
Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes.
Aug 20 2020
Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion.
Aug 17 2020
Thanks MaskRay. I moved the zos testcase to a new file called init-zos.c instead and reduced the number of RUN commands.
Addressed Hubert's comments, and removed some macros that are unnecessary with system header updates.
Aug 14 2020
LGTM
Aug 13 2020
Thanks for catching that. I fixed up the testcase.
Thanks Hubert for the suggestion. I've updated the lit test.
Thanks Hubert and Fanbo for reviewing. I updated the comment to Hubert's suggestion, and updated both testcases as requested.
Aug 11 2020
Aug 7 2020
Thanks Hubert for reviewing. I updated the patch to fix the wchar_t comment and the if guards for the macros. I also updated the lit test to reflect these new changes.
Aug 6 2020
Aug 5 2020
Thanks MaskRay, I removed the extra braces.
Jul 22 2020
LGTM!
Jul 15 2020
@hubert.reinterpretcast or @daltenty can you commit this revision?
Feb 20 2020
Thanks for looking into this. Yes, with the fix you provided, the testcase now passes!