Page MenuHomePhabricator

ZarkoCA (Zarko Todorovski)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2018, 9:51 AM (96 w, 6 d)

Recent Activity

Yesterday

ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Addressed comments and adding parent revisions.

Mon, Oct 19, 3:42 AM · Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Fixed typo in test case.

Mon, Oct 19, 3:39 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Separated the option portion of the previous diff (now found here: https://reviews.llvm.org/D89684).
Addressed other comments.

Mon, Oct 19, 3:32 AM · Restricted Project, Restricted Project
ZarkoCA requested review of D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs. .
Mon, Oct 19, 3:27 AM · Restricted Project, Restricted Project

Fri, Oct 16

ZarkoCA accepted D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error.

LGTM

Fri, Oct 16, 7:01 AM · Restricted Project

Thu, Oct 15

ZarkoCA added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Thu, Oct 15, 2:41 PM · Restricted Project
ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Rebased based on new changes in https://reviews.llvm.org/D88676.
Added error for vector long type.

Thu, Oct 15, 2:34 PM · Restricted Project
ZarkoCA added a reviewer for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI: cebowleratibm.
Thu, Oct 15, 10:16 AM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Thu, Oct 15, 10:15 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Added mvecnvol/mnovecnvol options in clang and vecnvol option in llc
Addressed other comments related to formatting and test case regex usage.
Updated test cases that fail when vecnvol is enabled.

Thu, Oct 15, 10:13 AM · Restricted Project, Restricted Project

Wed, Oct 7

ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Wed, Oct 7, 6:26 AM · Restricted Project, Restricted Project

Tue, Oct 6

ZarkoCA added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Tue, Oct 6, 1:05 PM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

Added test case that includes FP and GP csrs along with the vector crs.
Reduced the number of clobbered VRs in the initial test case.

Tue, Oct 6, 12:54 PM · Restricted Project, Restricted Project

Mon, Oct 5

ZarkoCA updated the diff for D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

This patch now only contains the ISel lowering portion of the previous version. Additionally, lowering on the callee side was implemented since with the work already contained in CC_AIX only the removal of the error in LowerCall_AIX() was required. Return vector types was also enabled. The test case checks the caller, callee and return assembly instructions.

Mon, Oct 5, 7:50 AM · Restricted Project

Thu, Oct 1

ZarkoCA requested review of D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Thu, Oct 1, 9:53 AM · Restricted Project, Restricted Project

Wed, Sep 30

ZarkoCA committed rG052c5bf40a9f: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9 (authored by ZarkoCA).
[PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9
Wed, Sep 30, 8:07 AM
ZarkoCA closed D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Wed, Sep 30, 8:07 AM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Code changes didn't get included in last diff.

Wed, Sep 30, 7:59 AM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Used REG variables in 64Bit part of test case.

Wed, Sep 30, 7:56 AM · Restricted Project

Tue, Sep 29

ZarkoCA accepted D75059: [PowerPC] Remove support for VRSAVE save/restore/update..

LGTM.

Tue, Sep 29, 1:27 PM · Restricted Project, Restricted Project

Mon, Sep 28

ZarkoCA added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Hi Zarko, could rebase this patch on the latest master?

Mon, Sep 28, 9:29 AM · Restricted Project
ZarkoCA added inline comments to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Mon, Sep 28, 7:35 AM · Restricted Project

Fri, Sep 25

ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 25, 8:09 PM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Fixed register usage.

Fri, Sep 25, 1:01 PM · Restricted Project
ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 25, 1:01 PM · Restricted Project
ZarkoCA committed rGf330d9f163f6: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX (authored by cebowleratibm).
[PPC] [AIX] Implement calling convention IR for C99 complex types on AIX
Fri, Sep 25, 4:44 AM
ZarkoCA closed D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX.
Fri, Sep 25, 4:44 AM · Restricted Project

Thu, Sep 24

ZarkoCA accepted D88130: [PPC] [AIX] Implement calling convention IR for C99 complex types on AIX.

LGTM.

Thu, Sep 24, 8:37 PM · Restricted Project
ZarkoCA committed rG64b8a633a872: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex (authored by cebowleratibm).
[NFC] [PPC] Add PowerPC expected IR tests for C99 complex
Thu, Sep 24, 8:31 PM
ZarkoCA closed D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.
Thu, Sep 24, 8:31 PM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Generated test case using update_llc_test_checks.py, added stores and used DAG instead of NEXT when appropriate.

Thu, Sep 24, 11:44 AM · Restricted Project
ZarkoCA planned changes to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Going to work on rebasing this patch.

Thu, Sep 24, 6:09 AM · Restricted Project
ZarkoCA added a comment to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

This clearly changes behaviour and should thereby not have the [NFC] tag.

Thu, Sep 24, 6:08 AM · Restricted Project

Wed, Sep 23

ZarkoCA accepted D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.

Thanks for doing the formatting changes.

Wed, Sep 23, 8:13 PM · Restricted Project
ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Wed, Sep 23, 8:11 PM · Restricted Project
ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Updated test case.

Wed, Sep 23, 8:01 PM · Restricted Project
ZarkoCA added inline comments to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.
Wed, Sep 23, 7:39 AM · Restricted Project

Tue, Sep 22

ZarkoCA added inline comments to D88105: [NFC] [PPC] Add PowerPC expected IR tests for C99 complex.
Tue, Sep 22, 10:41 AM · Restricted Project
ZarkoCA added a comment to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Does PPCMIPeephole::combineSEXTAndSHL have a similar problem that needs to be addressed?

Tue, Sep 22, 9:52 AM · Restricted Project

Mon, Sep 21

ZarkoCA updated the diff for D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

Moved !Subtarget.isPPC64() check earlier alongside other checks.

Mon, Sep 21, 5:15 AM · Restricted Project
ZarkoCA added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Mon, Sep 21, 5:13 AM · Restricted Project

Sep 10 2020

ZarkoCA committed rG035396197a5f: Remove unused variable introduce in 0448d11a06b451a causing build (authored by ZarkoCA).
Remove unused variable introduce in 0448d11a06b451a causing build
Sep 10 2020, 5:11 PM

Sep 2 2020

ZarkoCA requested review of D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 2 2020, 10:46 AM · Restricted Project

Aug 31 2020

ZarkoCA accepted D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..

Looks good with minor nit.

Aug 31 2020, 7:34 AM · Restricted Project, Restricted Project

Aug 24 2020

ZarkoCA updated the summary of D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Aug 24 2020, 10:56 AM · Restricted Project
ZarkoCA requested review of D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.
Aug 24 2020, 10:33 AM · Restricted Project

Aug 14 2020

ZarkoCA added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Aug 14 2020, 10:14 AM · Restricted Project, Restricted Project

Jul 20 2020

ZarkoCA added a comment to D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values.

LGTM but I will leave it up for a bit so other reviewers have a chance to look at it.

Jul 20 2020, 6:03 AM · Restricted Project

Jun 26 2020

ZarkoCA accepted D82030: [PowerPC][AIX] Enable base-pointer..

I think this one is good. I wonder if there should be more tests to check corrected alignment of various allocations but that seems out of scope for the patch and the tests in https://reviews.llvm.org/D72454 covered that anyway.

Jun 26 2020, 10:55 AM · Restricted Project, Restricted Project

Jun 25 2020

ZarkoCA committed rGe504a23b634d: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp (authored by ZarkoCA).
[NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp
Jun 25 2020, 6:54 AM
ZarkoCA closed D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 25 2020, 6:54 AM · Restricted Project, Restricted Project
ZarkoCA updated the summary of D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 25 2020, 6:53 AM · Restricted Project, Restricted Project

Jun 24 2020

ZarkoCA updated the diff for D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.

Added High/Low Memory labels to diagram.

Jun 24 2020, 9:09 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.

Addressed Sean's comments:

Jun 24 2020, 8:36 AM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 24 2020, 8:36 AM · Restricted Project, Restricted Project

Jun 23 2020

ZarkoCA created D82408: [NFC][PPC][AIX] Add stack frame layout diagram to PPCISelLowering.cpp.
Jun 23 2020, 2:00 PM · Restricted Project, Restricted Project

May 22 2020

ZarkoCA added inline comments to D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions.
May 22 2020, 8:33 AM · Restricted Project
ZarkoCA added inline comments to D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions.
May 22 2020, 8:33 AM · Restricted Project

May 20 2020

ZarkoCA accepted D79252: [PowerPC][AIX] Spill CSRs to the ABI specified stack offsets..
May 20 2020, 12:03 PM · Restricted Project, Restricted Project

May 19 2020

ZarkoCA added a comment to D79252: [PowerPC][AIX] Spill CSRs to the ABI specified stack offsets..

LGMT, I will give some time for other reviewers to have a look before I approve.

May 19 2020, 2:18 PM · Restricted Project, Restricted Project

May 14 2020

ZarkoCA added a comment to D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX.

I'm ok with this now. I will let @Xiangling_L approve if she's ok with it since she had the last few comments.

May 14 2020, 10:16 AM · Restricted Project

May 8 2020

ZarkoCA added inline comments to D79252: [PowerPC][AIX] Spill CSRs to the ABI specified stack offsets..
May 8 2020, 12:52 PM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX.
May 8 2020, 12:20 PM · Restricted Project
ZarkoCA added inline comments to D79252: [PowerPC][AIX] Spill CSRs to the ABI specified stack offsets..
May 8 2020, 11:47 AM · Restricted Project, Restricted Project

May 7 2020

ZarkoCA added inline comments to D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX.
May 7 2020, 9:40 AM · Restricted Project
ZarkoCA added inline comments to D74166: [AIX][Frontend] Static init implementation for AIX considering no priority.
May 7 2020, 7:54 AM · Restricted Project, Restricted Project

May 5 2020

ZarkoCA abandoned D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

This work is included in https://reviews.llvm.org/D79035. Abandoning this revision.

May 5 2020, 7:30 AM · Restricted Project
ZarkoCA added inline comments to D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX.
May 5 2020, 6:25 AM · Restricted Project

May 4 2020

ZarkoCA committed rGcb7837643389: Test commit. Modified comment to add a period at the end. (authored by ZarkoCA).
Test commit. Modified comment to add a period at the end.
May 4 2020, 10:10 AM
ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Rebased patch to include latest changes in trunk. Removed that it depended on https://reviews.llvm.org/D73290 in the summary, as that patch has been landed.

May 4 2020, 9:04 AM · Restricted Project

Apr 16 2020

ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Added a TODO to remove the error for msvr4-struct-return on AIX when we verify it works as expected.

Apr 16 2020, 11:41 AM · Restricted Project

Apr 15 2020

ZarkoCA added inline comments to D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.
Apr 15 2020, 1:48 PM · Restricted Project

Apr 9 2020

ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Addressed comments
-added error for -msvr4-struct-return on AIX and modified appropriate test case
-changed code structure as per comment
-renamed test file

Apr 9 2020, 2:10 PM · Restricted Project
ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Rebased on https://reviews.llvm.org/D73290 and this patch now depends on it.
Removed PPCAIX32TargetCodegenClass from previous diff.
Corrected behaviour PPC32TargetCodeGenInfo::initDwarfEHRegSizeTable() for 32BIT AIX, and added the expected output to the test case which has also been renamed to reflect that.

Apr 9 2020, 12:09 PM · Restricted Project
ZarkoCA added inline comments to D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.
Apr 9 2020, 11:50 AM · Restricted Project

Apr 7 2020

ZarkoCA added a comment to D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF.

@jhibbits is this patch going to be committed soon? I have a patch (https://reviews.llvm.org/D76360) that I will need to rebase once this is in. Thanks.

Apr 7 2020, 7:00 AM · Restricted Project

Apr 6 2020

ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Rebase.

Apr 6 2020, 7:32 AM · Restricted Project
ZarkoCA updated the diff for D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

Rebase and ping.

Apr 6 2020, 7:32 AM · Restricted Project, Restricted Project

Apr 2 2020

ZarkoCA added inline comments to D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs.
Apr 2 2020, 7:33 AM · Restricted Project
ZarkoCA added inline comments to D76380: [PowerPC][AIX] Implement by-val caller arguments in multiple registers.
Apr 2 2020, 7:01 AM · Restricted Project

Apr 1 2020

ZarkoCA updated the diff for D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

Removed data layout and target triple info from test output.

Apr 1 2020, 10:26 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Set isSoftFloat to return false for AIX.

Apr 1 2020, 8:27 AM · Restricted Project
ZarkoCA added inline comments to D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.
Apr 1 2020, 8:27 AM · Restricted Project
ZarkoCA updated the diff for D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

Fixed test cases that were breaking.

Apr 1 2020, 7:40 AM · Restricted Project, Restricted Project

Mar 31 2020

ZarkoCA planned changes to D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

Fixing test case issues.

Mar 31 2020, 7:44 AM · Restricted Project, Restricted Project

Mar 30 2020

ZarkoCA added inline comments to D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.
Mar 30 2020, 8:46 PM · Restricted Project
ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Fixed test cases to use builtins again, set no soft float abi for AIX.

Mar 30 2020, 8:46 PM · Restricted Project
ZarkoCA updated the diff for D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

Rebased to include byval changes.

Mar 30 2020, 8:46 PM · Restricted Project, Restricted Project
ZarkoCA added inline comments to D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.
Mar 30 2020, 8:13 PM · Restricted Project, Restricted Project

Mar 27 2020

ZarkoCA added inline comments to D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.
Mar 27 2020, 9:05 AM · Restricted Project
ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Created PPCAIX32TargetCodeGenInfo class so that initDwarfEHRegSizeTable now returns true on AIX and added a test.

Mar 27 2020, 8:45 AM · Restricted Project
ZarkoCA added inline comments to D76875: [NFC] [PPC] [AIX] Test improvements for byval arguments that fit in a single register.
Mar 27 2020, 6:29 AM · Restricted Project
ZarkoCA added a comment to D76902: [PowerPC][AIX] ByVal formal argument support: multiple registers.

A small suggestion would be to add a test to further show that the GPRs are "burned" properly with with floats in the byval handling. Eg. using a struct like `%struct.S31 = type <{ float, i32, i64, double, i32, double }>' and seeing the error that structs split regs and the stack are not handled.

Mar 27 2020, 5:56 AM · Restricted Project, Restricted Project

Mar 24 2020

ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Renamed PPC32_SVR4ABIInfo class to PPC32ABIInfo.
Fixed test case to use builtins.
Changed comment.

Mar 24 2020, 8:02 AM · Restricted Project
ZarkoCA added inline comments to D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.
Mar 24 2020, 8:02 AM · Restricted Project
ZarkoCA added a comment to D76401: [PowerPC][AIX] ByVal formal argument support: single register..

IMO, the patch is pretty much done, just some test clean up.

Mar 24 2020, 7:29 AM · Restricted Project, Restricted Project

Mar 23 2020

ZarkoCA updated the diff for D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

Simplified testcases.
Added testcases for variadic arguments being passed directly to the stack when all registers are used.

Mar 23 2020, 3:16 PM · Restricted Project, Restricted Project

Mar 19 2020

ZarkoCA added inline comments to D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.
Mar 19 2020, 11:27 AM · Restricted Project, Restricted Project
ZarkoCA added a comment to D76401: [PowerPC][AIX] ByVal formal argument support: single register..

I think that we may need some more struct types with varying size elements. Right now, the tests mostly will check for mostly lbz at an offset. Would be great if we see that lha or even lw is used when required. However, this may be easier to do in a patch where arguments greater than register size are used?

Mar 19 2020, 10:52 AM · Restricted Project, Restricted Project
ZarkoCA updated the diff for D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang.

Changed comments per suggestions.
Added va_copy in test case.

Mar 19 2020, 10:17 AM · Restricted Project