Page MenuHomePhabricator

Xiangling_L (Xiangling Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 8:23 AM (76 w, 1 d)

Recent Activity

Fri, Oct 23

Xiangling_L updated the diff for D90063: [AIX] Also error on -G for link-only step.

Fixed the duplication in the testcase;

Fri, Oct 23, 1:07 PM · Restricted Project
Xiangling_L committed rG05bef88eb3ec: [AIX] Let alloca return 16 bytes alignment (authored by Xiangling_L).
[AIX] Let alloca return 16 bytes alignment
Fri, Oct 23, 11:42 AM
Xiangling_L closed D89910: [AIX] Let alloca return 16 bytes alignment.
Fri, Oct 23, 11:42 AM · Restricted Project
Xiangling_L requested review of D90063: [AIX] Also error on -G for link-only step.
Fri, Oct 23, 11:06 AM · Restricted Project

Thu, Oct 22

Xiangling_L committed rG0ba98433971f: [AIX] Emit error for -G option on AIX (authored by Xiangling_L).
[AIX] Emit error for -G option on AIX
Thu, Oct 22, 1:22 PM
Xiangling_L closed D89897: [AIX] Emit error for -G option on AIX.
Thu, Oct 22, 1:21 PM · Restricted Project, Restricted Project
Xiangling_L closed D88659: [NFC] Fix the definition of SuitableAlign.

Manually close the revision after landing it upstream.

Thu, Oct 22, 1:13 PM · Restricted Project
Xiangling_L updated the diff for D89910: [AIX] Let alloca return 16 bytes alignment.

Add one case to the test;

Thu, Oct 22, 10:46 AM · Restricted Project
Xiangling_L added inline comments to D89910: [AIX] Let alloca return 16 bytes alignment.
Thu, Oct 22, 10:43 AM · Restricted Project
Xiangling_L updated the diff for D89897: [AIX] Emit error for -G option on AIX.

Fix the formatting issues;

Thu, Oct 22, 8:38 AM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D89897: [AIX] Emit error for -G option on AIX.
Thu, Oct 22, 8:37 AM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D89910: [AIX] Let alloca return 16 bytes alignment.

Fixed the testcase formatting issues;
Fixed the BIGGEST_ALIGNMENT value in testcases;

Thu, Oct 22, 7:53 AM · Restricted Project

Wed, Oct 21

Xiangling_L updated the summary of D89897: [AIX] Emit error for -G option on AIX.
Wed, Oct 21, 2:08 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D89897: [AIX] Emit error for -G option on AIX.
Wed, Oct 21, 2:02 PM · Restricted Project, Restricted Project
Xiangling_L requested review of D89910: [AIX] Let alloca return 16 bytes alignment.
Wed, Oct 21, 1:45 PM · Restricted Project
Xiangling_L committed rGcf11f017af32: [NFC] Fix the definition of SuitableAlign (authored by Xiangling_L).
[NFC] Fix the definition of SuitableAlign
Wed, Oct 21, 10:36 AM
Xiangling_L requested review of D89897: [AIX] Emit error for -G option on AIX.
Wed, Oct 21, 10:29 AM · Restricted Project, Restricted Project

Tue, Oct 20

Xiangling_L retitled D88659: [NFC] Fix the definition of SuitableAlign from [FE]Split SuitableAlign into two parts to [NFC] Fix the definition of SuitableAlign.
Tue, Oct 20, 10:24 AM · Restricted Project
Xiangling_L updated the diff for D88659: [NFC] Fix the definition of SuitableAlign.

Edit the definition of SuitableAlign;

Tue, Oct 20, 10:22 AM · Restricted Project

Mon, Oct 19

Xiangling_L added inline comments to D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs. .
Mon, Oct 19, 1:03 PM · Restricted Project, Restricted Project
Xiangling_L added a comment to D88659: [NFC] Fix the definition of SuitableAlign.

Hi @jyknight , are you okay with us changing the "definition" of SuitableAlign without sending a note to the mailing list?

Mon, Oct 19, 10:54 AM · Restricted Project
Xiangling_L added inline comments to D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs. .
Mon, Oct 19, 9:01 AM · Restricted Project, Restricted Project

Thu, Oct 15

Xiangling_L added a comment to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.

I am wondering can we split the option related changes to a separate patch for reviews? That would make current patch a bit easier to review and faster to be committed as two small pieces.

Thu, Oct 15, 2:22 PM · Restricted Project, Restricted Project
Xiangling_L added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Hi Zarko, the patch is out of sync with master branch, could you update it?

Thu, Oct 15, 10:55 AM · Restricted Project
Xiangling_L added a comment to D88659: [NFC] Fix the definition of SuitableAlign.

ping.

Thu, Oct 15, 9:18 AM · Restricted Project

Wed, Oct 14

Xiangling_L added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Wed, Oct 14, 3:01 PM · Restricted Project, Restricted Project

Tue, Oct 13

Xiangling_L planned changes to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Tue, Oct 13, 1:49 PM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Tue, Oct 13, 1:49 PM · Restricted Project
Xiangling_L committed rG4c10d6508f54: [AIX] Support two itanium alignment LIT testcases for AIX using regex (authored by Xiangling_L).
[AIX] Support two itanium alignment LIT testcases for AIX using regex
Tue, Oct 13, 1:48 PM
Xiangling_L closed D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.
Tue, Oct 13, 1:48 PM · Restricted Project
Xiangling_L retitled D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex from [AIX] Disable two itanium alignment LIT testcases to [AIX] Support two itanium alignment LIT testcases for AIX using regex.
Tue, Oct 13, 6:53 AM · Restricted Project
Xiangling_L updated the diff for D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

Use regex to match AIX layout dumping format.

Tue, Oct 13, 6:52 AM · Restricted Project

Fri, Oct 9

Xiangling_L added a comment to D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.

Can we use a regex to make this also work in AIX?

Fri, Oct 9, 1:47 PM · Restricted Project

Thu, Oct 8

Xiangling_L requested review of D89064: [AIX] Support two itanium alignment LIT testcases for AIX using regex.
Thu, Oct 8, 12:26 PM · Restricted Project
Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Remove emit errors for oversized long long bitfield and related testcase;

Thu, Oct 8, 7:39 AM · Restricted Project
Xiangling_L retitled D89044: [FE][AIX] Emit error for oversized long long bitfield under 32bit mode from [AIX] Emit error for oversized long long bitfield under 32bit mode to [FE][AIX] Emit error for oversized long long bitfield under 32bit mode.
Thu, Oct 8, 7:37 AM
Xiangling_L updated the summary of D87029: [AIX] Implement AIX special bitfield related alignment rules.
Thu, Oct 8, 6:57 AM · Restricted Project
Xiangling_L requested review of D89044: [FE][AIX] Emit error for oversized long long bitfield under 32bit mode.
Thu, Oct 8, 6:57 AM

Wed, Oct 7

Xiangling_L added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Wed, Oct 7, 10:31 AM · Restricted Project
Xiangling_L added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Wed, Oct 7, 8:45 AM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Wed, Oct 7, 6:05 AM · Restricted Project, Restricted Project

Tue, Oct 6

Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.
  • Fixed the bug of getting underlying type of enum;
  • Fixed the bug to respect align attribute;
  • Add more testcases;
Tue, Oct 6, 10:32 AM · Restricted Project

Mon, Oct 5

Xiangling_L added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Mon, Oct 5, 1:53 PM · Restricted Project
Xiangling_L added a comment to D88659: [NFC] Fix the definition of SuitableAlign.

Hm, to start with, the current state of this confuses me.

In GCC, the preprocessor macro __BIGGEST_ALIGNMENT__ was supposed to expose the alignment used by __attribute__((aligned)) (no arg specified), as well the alignment used for alloca. However, this is no longer the case on x86: BIGGEST_ALIGNMENT is 512bits with avx-512 enabled, 256bits with avx enabled, and otherwise 128bits. Alloca follows this too. But, __attribute__((aligned)) was fixed at 128bit alignment, regardless of AVX being enabled, in order to not break ABI compatibility with structs using that. On other architectures, the 3 values seem to be always the same.

In clang, we similarly have (before this patch) both DefaultAlignForAttributeAligned (used for `attribute((aligned))), and SuitableAlign (used for the predefined __BIGGEST_ALIGNMENT__ and alignment for alloca). But these values are different on very many architectures...which I think is probably wrong. Furthermore, SuitableAlign isn't being adjusted to be suitable for vectors, like it is in gcc, which _also_ seems wrong. Looks like there's actually an earlier patch to fix that which was never merged: https://reviews.llvm.org/D39313

So, anyways -- back to this patch: On AIX PPC, you want alloca to align to 128bits, __attribute__((aligned)) to align to 128bits (aka 8 bytes), but __BIGGEST_ALIGNMENT__ to only be 4?

That seems pretty weird, and probably wrong?

Mon, Oct 5, 10:48 AM · Restricted Project

Thu, Oct 1

Xiangling_L added inline comments to D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI.
Thu, Oct 1, 2:09 PM · Restricted Project, Restricted Project
Xiangling_L requested review of D88659: [NFC] Fix the definition of SuitableAlign.
Thu, Oct 1, 7:51 AM · Restricted Project

Wed, Sep 30

Xiangling_L added a comment to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.

LGTM. Thanks

Wed, Sep 30, 8:07 AM · Restricted Project
Xiangling_L committed rG3a7487f903e2: [FE] Use preferred alignment instead of ABI alignment for complete object when… (authored by Xiangling_L).
[FE] Use preferred alignment instead of ABI alignment for complete object when…
Wed, Sep 30, 7:49 AM
Xiangling_L closed D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Wed, Sep 30, 7:49 AM · Restricted Project
Xiangling_L committed rG944691f0b7fa: [NFC][FE] Replace TypeSize with StorageUnitSize (authored by Xiangling_L).
[NFC][FE] Replace TypeSize with StorageUnitSize
Wed, Sep 30, 7:33 AM
Xiangling_L closed D88260: [NFC][FE] Replace TypeSize with StorageUnitSize.
Wed, Sep 30, 7:33 AM · Restricted Project

Mon, Sep 28

Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Add delete[] function to the testcase;

Mon, Sep 28, 1:04 PM · Restricted Project
Xiangling_L added a comment to D86476: [AIX] Add support for non var_arg extended vector ABI calling convention on AIX.

Hi Zarko, could rebase this patch on the latest master?

Mon, Sep 28, 9:23 AM · Restricted Project

Fri, Sep 25

Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 25, 4:54 PM · Restricted Project
Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Fri, Sep 25, 10:51 AM · Restricted Project

Sep 24 2020

Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Rebased on the NFC patch;

Sep 24 2020, 3:02 PM · Restricted Project
Xiangling_L requested review of D88260: [NFC][FE] Replace TypeSize with StorageUnitSize.
Sep 24 2020, 1:51 PM · Restricted Project
Xiangling_L added a comment to D87029: [AIX] Implement AIX special bitfield related alignment rules.

I think it would help the review if we could put the NFC portion(e.g. TypeSize -> StorageUnitSize) to a new patch, and give some rationale about the NFC change.

Sep 24 2020, 12:39 PM · Restricted Project
Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Updated the comments;

Sep 24 2020, 11:03 AM · Restricted Project
Xiangling_L updated the summary of D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Sep 24 2020, 10:32 AM · Restricted Project

Sep 23 2020

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Addressed the comments;

Sep 23 2020, 2:00 PM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Sep 23 2020, 1:36 PM · Restricted Project
Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 23 2020, 7:58 AM · Restricted Project

Sep 22 2020

Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Addressed the comments;

Sep 22 2020, 1:45 PM · Restricted Project
Xiangling_L added inline comments to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Sep 22 2020, 6:45 AM · Restricted Project

Sep 18 2020

Xiangling_L added inline comments to D87046: [PPC] Do not emit extswsli in 32BIT mode when using -mcpu=pwr9.
Sep 18 2020, 11:59 AM · Restricted Project

Sep 17 2020

Xiangling_L updated subscribers of D87114: [CMake][ExecutionEngine] convert HAVE_EHTABLES_SUPPORT to a real config.h macro.

Do we want to take advantage of this patch to move those checks into the cmake configure so we don't need to duplicate the logic in 2 files as @sfertile mentioned previously?

Sep 17 2020, 1:24 PM · Restricted Project
Xiangling_L updated the diff for D87029: [AIX] Implement AIX special bitfield related alignment rules.

Rebased on the pragma/pack patch;
Added packed related testcase for bitfield;

Sep 17 2020, 9:12 AM · Restricted Project
Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Fix the PragmaStack is empty assertion failure when we do: #pragma pack(2) then #pragma align(reset)

Sep 17 2020, 9:05 AM · Restricted Project

Sep 16 2020

Xiangling_L updated the diff for D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Use default argument;

Sep 16 2020, 7:17 AM · Restricted Project

Sep 15 2020

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Removed redundant header file include;

Sep 15 2020, 8:44 AM · Restricted Project
Xiangling_L updated the summary of D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Sep 15 2020, 8:30 AM · Restricted Project
Xiangling_L requested review of D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Sep 15 2020, 8:29 AM · Restricted Project

Sep 14 2020

Xiangling_L planned changes to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Sep 14 2020, 1:18 PM · Restricted Project

Sep 8 2020

Xiangling_L added a comment to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

Do you have open questions on whether some callsites passing "false" here, should be switched to true? Given what's here, I would say that it definitely does not makes sense to add this parameter everywhere.

Sep 8 2020, 7:04 AM · Restricted Project

Sep 3 2020

Xiangling_L added a comment to D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .

ping.

Sep 3 2020, 12:16 PM · Restricted Project
Xiangling_L added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 3 2020, 8:22 AM · Restricted Project

Sep 2 2020

Xiangling_L added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Sep 2 2020, 2:08 PM · Restricted Project
Xiangling_L requested review of D87029: [AIX] Implement AIX special bitfield related alignment rules.
Sep 2 2020, 7:24 AM · Restricted Project

Aug 31 2020

Xiangling_L added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Aug 31 2020, 8:44 AM · Restricted Project, Restricted Project

Aug 28 2020

Xiangling_L retitled D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable from [FE] Use preferred alignment instead of ABI alignment for complete object when applicable Summary: On some targets, preferred alignment is larger than ABI alignment in some cases. For example, on AIX we have special power alignment rules which... to [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Aug 28 2020, 8:51 AM · Restricted Project
Xiangling_L requested review of D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable .
Aug 28 2020, 8:50 AM · Restricted Project

Aug 14 2020

Xiangling_L committed rGf759b4e43be2: [AIX] Generate unique module id based on Pid and timestamp (authored by Xiangling_L).
[AIX] Generate unique module id based on Pid and timestamp
Aug 14 2020, 1:24 PM
Xiangling_L closed D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 14 2020, 1:23 PM · Restricted Project
Xiangling_L added inline comments to D85850: [PowerPC][AIX] Fix frame-pointer and base-pointer save/restore offset..
Aug 14 2020, 8:31 AM · Restricted Project, Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Add a format indicator as a part of function names;

Aug 14 2020, 7:49 AM · Restricted Project

Aug 13 2020

Xiangling_L added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 5:30 PM · Restricted Project
Xiangling_L added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 1:22 PM · Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Add a separator between PID and timestamp;

Aug 13 2020, 1:02 PM · Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Use itostr for signed integer value ;

Aug 13 2020, 11:09 AM · Restricted Project
Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Addressed the comments;
Fixed the testcase;

Aug 13 2020, 8:56 AM · Restricted Project
Xiangling_L added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 8:27 AM · Restricted Project

Aug 10 2020

Xiangling_L updated the diff for D85527: [AIX] Generate unique module id based on PID and timestamp.

Rebase on the latest master;

Aug 10 2020, 7:24 AM · Restricted Project
Xiangling_L committed rG6ef801aa6bc0: [AIX] Static init frontend recovery and backend support (authored by Xiangling_L).
[AIX] Static init frontend recovery and backend support
Aug 10 2020, 7:11 AM
Xiangling_L closed D84534: [AIX] Static init frontend recovery and backend support.
Aug 10 2020, 7:11 AM · Restricted Project, Restricted Project

Aug 7 2020

Xiangling_L accepted D85455: [XCOFF][AIX] Use TE storage mapping class when large code model is enabled.

LGTM. thanks.

Aug 7 2020, 2:22 PM · Restricted Project
Xiangling_L added a comment to D85455: [XCOFF][AIX] Use TE storage mapping class when large code model is enabled.

so that code compiled with large code model TOC reference would not
take up spaces from the normal small code model TOC reference.

Aug 7 2020, 1:14 PM · Restricted Project
Xiangling_L requested review of D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 7 2020, 8:03 AM · Restricted Project

Aug 6 2020

Xiangling_L updated the diff for D84534: [AIX] Static init frontend recovery and backend support.
Aug 6 2020, 1:07 PM · Restricted Project, Restricted Project
Xiangling_L added inline comments to D84534: [AIX] Static init frontend recovery and backend support.
Aug 6 2020, 1:07 PM · Restricted Project, Restricted Project