Page MenuHomePhabricator

Xiangling_L (Xiangling Liao)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 8:23 AM (100 w, 2 d)

Recent Activity

Thu, Apr 8

Xiangling_L committed rGd5085617986e: [AIX] Support init priority attribute (authored by Xiangling_L).
[AIX] Support init priority attribute
Thu, Apr 8, 12:41 PM
Xiangling_L closed D99291: [AIX] Support init priority attribute.
Thu, Apr 8, 12:40 PM · Restricted Project
Xiangling_L added inline comments to D99291: [AIX] Support init priority attribute.
Thu, Apr 8, 7:03 AM · Restricted Project

Wed, Apr 7

Xiangling_L committed rZORG52da64f693ff: Enable build_standalone in LibcxxAndAbiBuilder (authored by Xiangling_L).
Enable build_standalone in LibcxxAndAbiBuilder
Wed, Apr 7, 7:02 AM
Xiangling_L closed D99985: Enable build_standalone in LibcxxAndAbiBuilder.
Wed, Apr 7, 7:02 AM
Xiangling_L committed rZORG3a9c8098bd8f: [zorg] Adjust libcxx buildbot config on AIX (authored by Xiangling_L).
[zorg] Adjust libcxx buildbot config on AIX
Wed, Apr 7, 6:59 AM
Xiangling_L closed D97326: [zorg] Adjust libcxx buildbot config on AIX.
Wed, Apr 7, 6:59 AM

Tue, Apr 6

Xiangling_L requested review of D99985: Enable build_standalone in LibcxxAndAbiBuilder.
Tue, Apr 6, 12:23 PM
Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Split this patch into two;

Tue, Apr 6, 12:22 PM
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

Looks fine.

However, now the change to buildbot/osuosl/master/config/builders.py and the change to zorg/buildbot/builders/LibcxxAndAbiBuilder.py are not related.
Could you break them to 2 separate patches, please?

Tue, Apr 6, 10:19 AM
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Tue, Apr 6, 7:11 AM

Wed, Mar 31

Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Wed, Mar 31, 6:35 AM

Fri, Mar 26

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Adjust the libcxx buildbot config to enable libcxx project only;
But still keep adding build_standalone functionalities to LibcxxAndAbiBuilder;

Fri, Mar 26, 1:18 PM
Xiangling_L planned changes to D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM

Fri, Mar 26, 6:31 AM

Thu, Mar 25

Xiangling_L updated the diff for D99291: [AIX] Support init priority attribute.

Add assertion to make sure we have correct priority value in range;

Thu, Mar 25, 11:01 AM · Restricted Project
Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Addressed the comments;

Thu, Mar 25, 6:40 AM

Wed, Mar 24

Xiangling_L requested review of D99291: [AIX] Support init priority attribute.
Wed, Mar 24, 12:10 PM · Restricted Project

Mon, Mar 22

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Pass runtimes as src_bo_build_dir when building standalone runtimes

Mon, Mar 22, 7:50 AM

Thu, Mar 18

Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Thu, Mar 18, 12:53 PM

Mar 12 2021

Xiangling_L updated the diff for D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

Bring back two forward declarations to avoid changing pervasive SmallVector to llvm::SmallVector

Mar 12 2021, 7:01 PM · Restricted Project
Xiangling_L added inline comments to D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 3:13 PM · Restricted Project
Xiangling_L updated the diff for D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

Addressed the comments;

Mar 12 2021, 2:07 PM · Restricted Project
Xiangling_L updated the summary of D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 1:58 PM · Restricted Project
Xiangling_L added inline comments to D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 1:52 PM · Restricted Project
Xiangling_L added a comment to D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.

If we use this workaround, can we also revert 561fb7f60ab631e712c3fb6bbeb47061222c6818 and 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07 in this patch?

Mar 12 2021, 1:45 PM · Restricted Project
Xiangling_L requested review of D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue.
Mar 12 2021, 1:37 PM · Restricted Project
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Mar 12 2021, 6:46 AM

Mar 9 2021

Xiangling_L committed rG561fb7f60ab6: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX (authored by Xiangling_L).
[NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX
Mar 9 2021, 10:04 AM
Xiangling_L closed D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.
Mar 9 2021, 10:04 AM · Restricted Project
Xiangling_L added a comment to D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.

Maybe this needs to be addressed in the forward declaration in clang/include/clang/Basic/LLVM.h ?

Mar 9 2021, 9:25 AM · Restricted Project
Xiangling_L requested review of D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX.
Mar 9 2021, 8:28 AM · Restricted Project

Mar 8 2021

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Adjust the build_standalone implementation.

Mar 8 2021, 6:35 PM

Mar 4 2021

Xiangling_L added a comment to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

Or, asked differently, is it intentional that llvm/tools/bugpoint/ToolRunner.cpp still uses LTDL_SHLIB_EXT?

Mar 4 2021, 8:48 AM · Restricted Project
Xiangling_L added a comment to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

what does LTDL_SHLIB_EXT expand to on aix?

Mar 4 2021, 8:41 AM · Restricted Project
Xiangling_L committed rGe9f9ec837d44: [CMake][AIX] Adjust plugin library extension used on AIX (authored by Xiangling_L).
[CMake][AIX] Adjust plugin library extension used on AIX
Mar 4 2021, 8:24 AM
Xiangling_L closed D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Mar 4 2021, 8:24 AM · Restricted Project

Mar 3 2021

Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

I'm not sure I follow what are you trying to achieve by changing the src_root.

Changing src_root would not give you ../llvm/runtimes, it simply changes where the source code gets checked out to. Like <buildbot-worker-directory>/<builder>/runtimes/llvm-project/<the rest of the monorepo tree>.

Mar 3 2021, 7:33 AM

Mar 1 2021

Xiangling_L committed rZORG1d2328ff69a8: [zorg] Use boolean flag to determine if building a unified standalone runtimes (authored by Xiangling_L).
[zorg] Use boolean flag to determine if building a unified standalone runtimes
Mar 1 2021, 1:54 PM
Xiangling_L closed D97326: [zorg] Adjust libcxx buildbot config on AIX.
Mar 1 2021, 1:54 PM

Feb 26 2021

Xiangling_L updated the diff for D97326: [zorg] Adjust libcxx buildbot config on AIX.

Use a boolean flag instead to control if building a unified standalone runtimes;

Feb 26 2021, 1:59 PM
Xiangling_L added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

ping.

Feb 26 2021, 8:24 AM

Feb 24 2021

Xiangling_L committed rZORG70ac07d8c27d: [zorg] Rename cross-targeting buildbot on AIX (authored by Xiangling_L).
[zorg] Rename cross-targeting buildbot on AIX
Feb 24 2021, 6:50 AM
Xiangling_L closed D97222: [zorg] Rename cross-targeting buildbot on AIX.
Feb 24 2021, 6:50 AM

Feb 23 2021

Xiangling_L requested review of D97326: [zorg] Adjust libcxx buildbot config on AIX.
Feb 23 2021, 12:16 PM
Xiangling_L closed D96814: [zorg] Add runtimes buildbot for AIX.
Feb 23 2021, 12:12 PM

Feb 22 2021

Xiangling_L requested review of D97222: [zorg] Rename cross-targeting buildbot on AIX.
Feb 22 2021, 1:22 PM
Xiangling_L committed rZORGb656c613b72e: [zorg] Add buildbot for libcxx build on AIX (authored by Xiangling_L).
[zorg] Add buildbot for libcxx build on AIX
Feb 22 2021, 7:57 AM
Xiangling_L added inline comments to D96814: [zorg] Add runtimes buildbot for AIX.
Feb 22 2021, 6:46 AM

Feb 19 2021

Xiangling_L updated the diff for D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

minor: adjusted the comment;

Feb 19 2021, 7:05 AM · Restricted Project

Feb 18 2021

Xiangling_L updated the diff for D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.

Fix the regression on Linux;

Feb 18 2021, 1:54 PM · Restricted Project
Xiangling_L added inline comments to D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 18 2021, 10:40 AM · Restricted Project

Feb 17 2021

Xiangling_L added a comment to D87029: [AIX] Implement AIX special bitfield related alignment rules.

ping.

Feb 17 2021, 6:40 AM · Restricted Project

Feb 16 2021

Xiangling_L requested review of D96814: [zorg] Add runtimes buildbot for AIX.
Feb 16 2021, 1:13 PM

Feb 11 2021

Xiangling_L committed rZORG24f991707240: [zorg] Remove redundant '\' in AIX buildbot config (authored by Xiangling_L).
[zorg] Remove redundant '\' in AIX buildbot config
Feb 11 2021, 11:45 AM
Xiangling_L closed D96526: [zorg] Remove redundant '\'.
Feb 11 2021, 11:45 AM
Xiangling_L requested review of D96526: [zorg] Remove redundant '\'.
Feb 11 2021, 10:37 AM

Feb 10 2021

Xiangling_L committed rZORGd561eb810542: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX (authored by Xiangling_L).
[zorg] Add Clang ppc64le cross-targeting buildbot on AIX
Feb 10 2021, 6:45 AM
Xiangling_L closed D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 10 2021, 6:45 AM

Feb 8 2021

Xiangling_L requested review of D96282: [CMake][AIX] Adjust plugin library externsion used on AIX.
Feb 8 2021, 10:25 AM · Restricted Project
Xiangling_L committed rG6b1e2fc89327: [FE] Manipulate the first byte of guard variable type in both load and store… (authored by Xiangling_L).
[FE] Manipulate the first byte of guard variable type in both load and store…
Feb 8 2021, 8:16 AM
Xiangling_L closed D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 8 2021, 8:16 AM · Restricted Project
Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Removed redundant -DLLVM_ENABLE_PROJECTS option;

Feb 8 2021, 7:16 AM
Xiangling_L added inline comments to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 8 2021, 7:11 AM

Feb 3 2021

Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Remove make='ninja';

Feb 3 2021, 6:42 AM

Feb 2 2021

Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Addressed the comments;

Feb 2 2021, 1:06 PM
Xiangling_L added inline comments to D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 12:37 PM · Restricted Project
Xiangling_L updated the diff for D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.

Addressed the comments related to test formatting;

Feb 2 2021, 12:36 PM · Restricted Project
Xiangling_L updated the diff for D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.

Remove redundant file;

Feb 2 2021, 12:23 PM · Restricted Project
Xiangling_L added inline comments to D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 12:15 PM · Restricted Project
Xiangling_L retitled D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation from [FE][AIX] Use i8 as guard variable type in both load and store operation to [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 11:37 AM · Restricted Project
Xiangling_L updated the diff for D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.

Align load and store operation related to guard variable by both using the first byte of the variable.

Feb 2 2021, 11:34 AM · Restricted Project
Xiangling_L added inline comments to D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 2 2021, 11:29 AM · Restricted Project
Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Update build dir name accordingly;
Ad -qaltivec into cmake config;

Feb 2 2021, 7:45 AM
Xiangling_L added inline comments to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Feb 2 2021, 7:40 AM

Feb 1 2021

Xiangling_L requested review of D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation.
Feb 1 2021, 2:17 PM · Restricted Project
Xiangling_L updated the diff for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

Addressed the comments;

Feb 1 2021, 7:44 AM

Jan 27 2021

Xiangling_L added a reviewer for D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX: ZarkoCA.
Jan 27 2021, 11:27 AM
Xiangling_L added a comment to D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.

@gkistanova Hi Galina, we are trying to set up a cross-targeting buildbot for AIX platform. And I sent you an email on Wed, Jan 20th, 2021 requesting access for the new build bot.

Jan 27 2021, 7:39 AM
Xiangling_L requested review of D95528: [zorg] Add Clang ppc64le cross-targeting buildbot on AIX.
Jan 27 2021, 7:35 AM

Jan 13 2021

Xiangling_L committed rGf0abe2aeaca7: [Frontend] Add pragma align natural and sort out pragma pack stack effect (authored by Xiangling_L).
[Frontend] Add pragma align natural and sort out pragma pack stack effect
Jan 13 2021, 7:54 AM
Xiangling_L closed D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Jan 13 2021, 7:53 AM · Restricted Project
Xiangling_L added a reviewer for D89049: [AIX][XCOFF] print out the traceback info : Xiangling_L.
Jan 13 2021, 6:36 AM · Restricted Project

Jan 12 2021

Xiangling_L added inline comments to D89049: [AIX][XCOFF] print out the traceback info .
Jan 12 2021, 2:18 PM · Restricted Project

Jan 11 2021

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Rebased on latest master;
Addressed the comments;

Jan 11 2021, 10:31 AM · Restricted Project

Jan 8 2021

Xiangling_L committed rGe97071d79520: [NFC] Renaming PackStack to AlignPackStack (authored by Xiangling_L).
[NFC] Renaming PackStack to AlignPackStack
Jan 8 2021, 6:15 AM
Xiangling_L closed D93901: [NFC] Renaming PackStack to AlignPackStack.
Jan 8 2021, 6:15 AM · Restricted Project

Jan 7 2021

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Addressed the comments;
Rebased the patch on latest master;

Jan 7 2021, 6:42 AM · Restricted Project

Jan 6 2021

Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Jan 6 2021, 1:30 PM · Restricted Project
Xiangling_L updated the diff for D93901: [NFC] Renaming PackStack to AlignPackStack.

Add pre-committing tests with the incorrect behaviour as part of the NFC patch.

Jan 6 2021, 8:52 AM · Restricted Project

Jan 1 2021

Xiangling_L added a comment to rGd1fd72343c6f: Refactor how -fno-semantic-interposition sets dso_local on default visibility….

Hi, you commit failed clang-ppc64le-rhel buildbot: http://lab.llvm.org:8011/#/builders/57/builds/2938. Please take a look.

Jan 1 2021, 7:07 AM

Dec 30 2020

Xiangling_L updated the summary of D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Dec 30 2020, 12:39 PM · Restricted Project
Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
  • used memcpy to burn AlignPackInfo into uint32_t and vice versa;
  • named XL on AIX stack effect and related options after "xl" instead of "aix"
  • adjusted natural align related code
Dec 30 2020, 12:38 PM · Restricted Project

Dec 29 2020

Xiangling_L updated the diff for D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .

Rebase on renaming NFC patch

Dec 29 2020, 10:53 AM · Restricted Project
Xiangling_L added inline comments to D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect .
Dec 29 2020, 7:43 AM · Restricted Project
Xiangling_L requested review of D93901: [NFC] Renaming PackStack to AlignPackStack.
Dec 29 2020, 7:41 AM · Restricted Project

Dec 11 2020

Xiangling_L accepted D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors.

LGTM. Thanks!

Dec 11 2020, 11:08 AM · Restricted Project
Xiangling_L added a reviewer for D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors: Xiangling_L.
Dec 11 2020, 7:55 AM · Restricted Project
Xiangling_L added inline comments to D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors.
Dec 11 2020, 7:55 AM · Restricted Project

Dec 10 2020

Xiangling_L added inline comments to D92789: [PPC] Check for PPC64 when emitting 64bit specific VSX nodes when pattern matching built vectors.
Dec 10 2020, 2:20 PM · Restricted Project

Dec 1 2020

Xiangling_L added inline comments to D87029: [AIX] Implement AIX special bitfield related alignment rules.
Dec 1 2020, 7:04 AM · Restricted Project