Page MenuHomePhabricator

Whitney (Whitney Tsang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 29 2019, 6:22 PM (125 w, 1 d)

Recent Activity

Yesterday

Whitney committed rGab244db1fa0b: [AIX] Emitting diagnostics error for profile options (authored by Whitney).
[AIX] Emitting diagnostics error for profile options
Wed, Jun 23, 5:24 PM
Whitney closed D104803: [AIX] Emitting diagnostics error for profile options.
Wed, Jun 23, 5:23 PM · Restricted Project, Restricted Project
Whitney updated the diff for D104803: [AIX] Emitting diagnostics error for profile options.

move code later

Wed, Jun 23, 4:36 PM · Restricted Project, Restricted Project
Whitney updated the diff for D104803: [AIX] Emitting diagnostics error for profile options.

Updated one of the test cases to use --target=powerpc64-ibm-aix.

Wed, Jun 23, 3:57 PM · Restricted Project, Restricted Project
Whitney requested review of D104803: [AIX] Emitting diagnostics error for profile options.
Wed, Jun 23, 11:26 AM · Restricted Project, Restricted Project

Sun, Jun 20

Whitney added inline comments to D104595: [NFC] [LoopIdiom] Let processLoopStridedStore able to take SCEV as Store Size.
Sun, Jun 20, 3:35 PM · Restricted Project
Whitney added a reviewer for D104180: [NFC] [LICM] Create LoopNest Invariant Code Motion (LNICM) pass: nikic.
Sun, Jun 20, 3:09 PM · Restricted Project

Sat, Jun 12

Whitney added a reviewer for D104179: [NFC] [LoopIdiom] [LoopNest] Create LoopIdiomRecognize as a LoopNestPass: qianzhen.
Sat, Jun 12, 7:02 AM · Restricted Project

Tue, Jun 8

Whitney added a reverting change for rG07ef5805abe5: Revert "[LoopNest] Fix Wdeprecated-copy warnings": rG9b022a679b2b: Revert "Revert "[LoopNest] Fix Wdeprecated-copy warnings"".
Tue, Jun 8, 2:52 PM
Whitney committed rG9b022a679b2b: Revert "Revert "[LoopNest] Fix Wdeprecated-copy warnings"" (authored by Whitney).
Revert "Revert "[LoopNest] Fix Wdeprecated-copy warnings""
Tue, Jun 8, 2:52 PM
Whitney added a reverting change for D103752: [LoopNest] Fix Wdeprecated-copy warnings: rG9b022a679b2b: Revert "Revert "[LoopNest] Fix Wdeprecated-copy warnings"".
Tue, Jun 8, 2:52 PM · Restricted Project
Whitney closed D103752: [LoopNest] Fix Wdeprecated-copy warnings.
Tue, Jun 8, 2:52 PM · Restricted Project
Whitney reopened D103752: [LoopNest] Fix Wdeprecated-copy warnings.
Tue, Jun 8, 1:47 PM · Restricted Project
Whitney added a reverting change for rGdee1f0cb348b: [LoopNest] Fix Wdeprecated-copy warnings: rG07ef5805abe5: Revert "[LoopNest] Fix Wdeprecated-copy warnings".
Tue, Jun 8, 1:47 PM
Whitney committed rG07ef5805abe5: Revert "[LoopNest] Fix Wdeprecated-copy warnings" (authored by Whitney).
Revert "[LoopNest] Fix Wdeprecated-copy warnings"
Tue, Jun 8, 1:46 PM
Whitney added a reverting change for D103752: [LoopNest] Fix Wdeprecated-copy warnings: rG07ef5805abe5: Revert "[LoopNest] Fix Wdeprecated-copy warnings".
Tue, Jun 8, 1:46 PM · Restricted Project
Whitney updated subscribers of D103752: [LoopNest] Fix Wdeprecated-copy warnings.

It appears that this change broke the sanitizer-windows bot:
https://lab.llvm.org/buildbot/#/builders/127/builds/12064

Tue, Jun 8, 1:20 PM · Restricted Project
Whitney committed rGdee1f0cb348b: [LoopNest] Fix Wdeprecated-copy warnings (authored by Whitney).
[LoopNest] Fix Wdeprecated-copy warnings
Tue, Jun 8, 7:48 AM
Whitney closed D103752: [LoopNest] Fix Wdeprecated-copy warnings.
Tue, Jun 8, 7:48 AM · Restricted Project

Sat, Jun 5

Whitney requested review of D103752: [LoopNest] Fix Wdeprecated-copy warnings.
Sat, Jun 5, 9:35 AM · Restricted Project

Sun, May 30

Whitney added inline comments to D102300: [LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level nested loops.
Sun, May 30, 10:30 PM · Restricted Project
Whitney added inline comments to D102300: [LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level nested loops.
Sun, May 30, 7:53 PM · Restricted Project
Whitney added inline comments to D102300: [LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level nested loops.
Sun, May 30, 5:10 PM · Restricted Project
Whitney accepted D102743: [LoopInterhcange] Handle movement of reduction phis appropriately during transformation (pr43326 && pr48212).
Sun, May 30, 9:47 AM · Restricted Project
Whitney added inline comments to D102300: [LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level nested loops.
Sun, May 30, 9:44 AM · Restricted Project

Thu, May 27

Whitney accepted D99149: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.

LGTM, thanks!

Thu, May 27, 9:16 AM · Restricted Project
Whitney added inline comments to D99149: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.
Thu, May 27, 9:07 AM · Restricted Project

May 25 2021

Whitney accepted D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.

LGTM.

May 25 2021, 9:16 AM · Restricted Project
Whitney added inline comments to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 25 2021, 7:11 AM · Restricted Project
Whitney added inline comments to D99149: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.
May 25 2021, 7:08 AM · Restricted Project

May 24 2021

Whitney added inline comments to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 24 2021, 5:52 AM · Restricted Project

May 23 2021

Whitney added inline comments to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 23 2021, 6:28 AM · Restricted Project

May 21 2021

Whitney added a reviewer for D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass: SjoerdMeijer.
May 21 2021, 1:41 PM · Restricted Project
Whitney added inline comments to D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass.
May 21 2021, 1:39 PM · Restricted Project

May 14 2021

Whitney accepted D102511: Do actual DCE in LoopUnroll.
May 14 2021, 9:59 AM · Restricted Project

May 11 2021

Whitney accepted D100792: [LoopInterchange] Handle lcssa PHIs with multiple predecessors.
May 11 2021, 8:56 AM · Restricted Project
Whitney accepted D99149: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.
May 11 2021, 7:34 AM · Restricted Project

May 10 2021

Whitney added a comment to D91682: [LoopInterchange] Fix the checking of tightly nested loop.

https://reviews.llvm.org/D98263 covered some of this change now, can you please rebase the patch?
The test case LGTM. Thanks.

May 10 2021, 6:01 PM · Restricted Project
Whitney accepted D100792: [LoopInterchange] Handle lcssa PHIs with multiple predecessors.

Approve with minor comment.

May 10 2021, 5:50 PM · Restricted Project
Whitney accepted D99149: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass.

Approve with minor comment.

May 10 2021, 5:35 PM · Restricted Project

May 7 2021

Whitney committed rG1006ac3963ea: [LoopNest] Consider loop nest with inner loop guard using outer loop (authored by Whitney).
[LoopNest] Consider loop nest with inner loop guard using outer loop
May 7 2021, 9:04 AM
Whitney closed D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
May 7 2021, 9:04 AM · Restricted Project

May 5 2021

Whitney updated the diff for D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

Addressed review comment, and fixed a bug in detecting perfect nest using skipEmptyBlockUntil.

May 5 2021, 7:44 PM · Restricted Project
Whitney added a comment to D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

So if I understand correctly, we still allow code in the exit block and the other target of the guard branch like before, so this is purely an improvement over what we had before. Although, as I said before I think we should allow non-empty blocks as well, but that can come as future extensions.

May 5 2021, 2:24 PM · Restricted Project
Whitney abandoned D101943: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect.

Found out how to update the original review.

May 5 2021, 1:58 PM · Restricted Project
Whitney updated the diff for D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

Addressed review comments.

May 5 2021, 1:57 PM · Restricted Project
Whitney commandeered D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
May 5 2021, 1:56 PM · Restricted Project
Whitney requested review of D101943: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect.
May 5 2021, 1:55 PM · Restricted Project

May 4 2021

Whitney added a comment to D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

As you can see for.end is not empty and so this loop's guard won't be detected!

May 4 2021, 1:50 PM · Restricted Project

Apr 30 2021

Whitney abandoned D73129: [LoopUnrollAndJam] Correctly update LoopInfo when unroll and jam more than 2-levels loop nests..
Apr 30 2021, 6:59 PM · Restricted Project
Whitney added a comment to D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .

I think this changes the semantics for the cases that we used to handle before. For example wouldn't this require the exit successors to be empty? If so I think lcssa phis can prevent us from detecting guards. We need to test for those cases as well.

Apr 30 2021, 5:32 PM · Restricted Project
Whitney accepted D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Apr 30 2021, 2:52 PM · Restricted Project
Whitney accepted D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Apr 30 2021, 2:35 PM · Restricted Project

Apr 29 2021

Whitney added inline comments to D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Apr 29 2021, 4:48 PM · Restricted Project
Whitney added inline comments to D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Apr 29 2021, 12:16 PM · Restricted Project
Whitney accepted D94717: [LoopNest] Consider loop nest with inner loop guard using outer loop induction variable to be perfect .
Apr 29 2021, 10:43 AM · Restricted Project

Apr 15 2021

Whitney added inline comments to D100496: Add emitWcsLen helper function.
Apr 15 2021, 12:11 PM · Restricted Project

Apr 12 2021

Whitney added a comment to D98183: [libLTO] Add support for -save-temps..

@fhahn Thanks for implementing it. When do you plan to commit this change?

Apr 12 2021, 2:29 PM · Restricted Project

Apr 8 2021

Whitney added inline comments to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Apr 8 2021, 9:08 AM · Restricted Project

Apr 7 2021

Whitney added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).

@TaWeiTu How do you want to handle the lcssa.ll failure? Maybe we can only disallow memory accesses that are guarded by loop variant condition?

Apr 7 2021, 12:21 PM · Restricted Project

Mar 23 2021

Whitney accepted D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality.
Mar 23 2021, 7:09 PM · Restricted Project
Whitney added a comment to D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality.

I am fine with this change now, but in the future we should try to

  1. Use utilities in LoopNest as much as possible
  2. Loosen the definition perfect loop nest in LoopNest
  3. Make the transformation more generic to handle more cases, e.g. the newly added test interchange_07.
Mar 23 2021, 8:04 AM · Restricted Project
Whitney added a reviewer for D99149: [LoopUnrollAndJam] Change LoopUnrollAndJamPass to LoopNest pass: dmgreen.
Mar 23 2021, 7:29 AM · Restricted Project

Mar 14 2021

Whitney added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).

Have you considered the case where the blocks guarded by control flow doesn't have memory operation, but affect memory operation through phi?

bb1:
  br %cond, bb2, bb3
bb2:
  br bb4
bb3:
  br bb4
bb4:
  %t = phi [ %t2, %bb2 ], [ %t3, %bb3 ]
  store %t, %p
Mar 14 2021, 8:33 AM · Restricted Project

Mar 10 2021

Whitney added a comment to D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality.

The patch now revert part of https://reviews.llvm.org/rGdf9158c9a45a6902c2b0394f9bd6512e3e441f31, which leave some changes behind.
Given that the change cause a test case crash, @TaWeiTu can you please revert the change?

Mar 10 2021, 9:19 AM · Restricted Project
Whitney added a comment to D98263: [LoopInterchange] fix tightlyNested() in LoopInterchange legality.

Thanks for fixing it. Is the crashing test case an existing test case, or will be added in D96708 or D91682? If not, can you please also include that test case in this patch?

Mar 10 2021, 6:16 AM · Restricted Project

Mar 9 2021

Whitney added a reviewer for D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX: jamieschmeiser.
Mar 9 2021, 8:43 AM · Restricted Project

Mar 8 2021

Whitney accepted D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:58 AM · Restricted Project
Whitney added inline comments to D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:52 AM · Restricted Project
Whitney added inline comments to D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:33 AM · Restricted Project
Whitney added inline comments to D97847: Use LoopNest as the primary object on which LoopInterchange operates.
Mar 8 2021, 6:14 AM · Restricted Project

Mar 7 2021

Whitney committed rG0d8f102809b2: [NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in (authored by Whitney).
[NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in
Mar 7 2021, 3:53 PM
Whitney closed D98098: [NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in `runtime-multiexit-heuristic.ll`.
Mar 7 2021, 3:53 PM · Restricted Project
Whitney committed rG40391cef6164: [LoopUnrollRuntime] Add option to assume the non latch exit block to be (authored by Whitney).
[LoopUnrollRuntime] Add option to assume the non latch exit block to be
Mar 7 2021, 3:50 PM
Whitney accepted D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 7 2021, 8:19 AM · Restricted Project
Whitney added inline comments to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 7 2021, 7:44 AM · Restricted Project
Whitney added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 7 2021, 7:39 AM · Restricted Project
Whitney added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 7 2021, 7:28 AM · Restricted Project
Whitney added inline comments to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 7 2021, 7:19 AM · Restricted Project

Mar 5 2021

Whitney requested review of D98098: [NFC][LoopUnroll] Add `-unroll-runtime-other-exit-predictable=false` in `runtime-multiexit-heuristic.ll`.
Mar 5 2021, 7:37 PM · Restricted Project
Whitney added a comment to D97828: [LoopInterchange] Disallow interchange when memory accesses are guarded by control flow (PR48057).
Mar 5 2021, 9:15 AM · Restricted Project

Mar 3 2021

Whitney committed rG58d531fd6f04: [LoopUnrollRuntime] Add option to assume the non latch exit block to be (authored by Whitney).
[LoopUnrollRuntime] Add option to assume the non latch exit block to be
Mar 3 2021, 12:44 PM
Whitney closed D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 12:43 PM · Restricted Project
Whitney updated the diff for D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..

Add comment.

Mar 3 2021, 10:16 AM · Restricted Project
Whitney added inline comments to D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 9:52 AM · Restricted Project
Whitney updated the diff for D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 9:52 AM · Restricted Project
Whitney added inline comments to D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 7:43 AM · Restricted Project
Whitney retitled D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable. from [LoopUnrollRuntime] Add option to unroll loops with at most two exit/exiting blocks. to [LoopUnrollRuntime] Add option to unroll loops with at most a specified number of exit/exiting blocks..
Mar 3 2021, 7:42 AM · Restricted Project
Whitney updated the summary of D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 7:42 AM · Restricted Project
Whitney added inline comments to D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 7:25 AM · Restricted Project
Whitney updated the diff for D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 7:25 AM · Restricted Project
Whitney updated the diff for D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 3 2021, 6:38 AM · Restricted Project

Mar 2 2021

Whitney updated the diff for D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..

update comment.

Mar 2 2021, 9:56 AM · Restricted Project
Whitney added inline comments to D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 2 2021, 9:52 AM · Restricted Project
Whitney updated the diff for D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..

Fixed LIT

Mar 2 2021, 9:52 AM · Restricted Project

Mar 1 2021

Whitney requested review of D97747: [LoopUnrollRuntime] Add option to assume the non latch exit block to be predictable..
Mar 1 2021, 4:41 PM · Restricted Project
Whitney added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Mar 1 2021, 9:03 AM · Restricted Project

Feb 23 2021

Whitney added inline comments to D97290: [LoopInterchange] Replace tightly-nesting-ness check with the one from `LoopNest`.
Feb 23 2021, 10:49 AM · Restricted Project
Whitney accepted D97286: [LoopNest] Use `getUniqueSuccessor()` instead when checking empty blocks.
Feb 23 2021, 10:42 AM · Restricted Project

Feb 16 2021

Whitney accepted D96644: [NFC] Refactor LoopInterchange into a loop-nest pass.
Feb 16 2021, 7:08 AM · Restricted Project