Page MenuHomePhabricator

MoritzS (Moritz Sichert)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 13 2017, 4:08 AM (167 w, 4 d)

Recent Activity

Thu, Feb 18

MoritzS updated the diff for D95512: [RuntimeDyld] Implemented relocation for ELF::R_X86_64_GOTPC32.

Rebased onto master

Thu, Feb 18, 3:09 AM · Restricted Project

Jan 28 2021

MoritzS requested review of D95597: [RuntimeDyld] Don't error on symbols that resolve to 0.
Jan 28 2021, 1:05 AM · Restricted Project
MoritzS requested review of D95596: [RuntimeDyld] Fixed buffer overflows with absolute symbols.
Jan 28 2021, 1:03 AM · Restricted Project

Jan 27 2021

MoritzS requested review of D95512: [RuntimeDyld] Implemented relocation for ELF::R_X86_64_GOTPC32.
Jan 27 2021, 12:30 AM · Restricted Project

Jan 22 2021

MoritzS committed rGb46545542b30: Avoid fragile type lookups in GDB pretty printer (authored by MoritzS).
Avoid fragile type lookups in GDB pretty printer
Jan 22 2021, 5:58 AM
MoritzS closed D94431: Avoid fragile type lookups in GDB pretty printer.
Jan 22 2021, 5:57 AM · Restricted Project
MoritzS committed rGe16959c9b855: Don't delete default constructor of PathDiagnosticConsumerOptions (authored by MoritzS).
Don't delete default constructor of PathDiagnosticConsumerOptions
Jan 22 2021, 4:47 AM
MoritzS closed D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.
Jan 22 2021, 4:47 AM · Restricted Project
MoritzS added a comment to D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

Some tests were failing, I'll try to fix that and then commit the changes.

Jan 22 2021, 3:05 AM · Restricted Project
MoritzS updated the diff for D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

Initialize bool flags

Jan 22 2021, 2:59 AM · Restricted Project
MoritzS updated the diff for D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

Rebased onto master, run tests again

Jan 22 2021, 1:51 AM · Restricted Project

Jan 12 2021

MoritzS added a comment to D94475: [MC] Emit ELF files with ELFOSABI_GNU if specified in triple.

Looking at the original motivation for the patch I'm not convinced that llvm-readelf etc shouldn't just fall back on displaying the "normal" set of GNU extensions even for ELFOSABI_NONE (i.e. those that FreeBSD and GNU have in common). Things like that are really just part of de-facto generic ELF these days. What does binutils do?

Jan 12 2021, 10:38 AM · Restricted Project
MoritzS added a comment to D94475: [MC] Emit ELF files with ELFOSABI_GNU if specified in triple.

This is known. GNU as by default emits ELFOSABI_NONE on Linux - if it does not use any GNU extensioin. If the assembly uses STT_GNU_IFUNC/STB_GNU_UNIQUE, GNU as will switch to ELFOSABI_GNU.

The patch improves the few cases but regresses other cases, so I am requesting changes. It is also unclear whether respecting the GNU behavior is strictly necessary (see gold https://sourceware.org/bugzilla/show_bug.cgi?id=17735). STT_GNU_IFUNC is GNU extension and it is adopted by some other OSes. I am not sure the readelf -S output is a justifying reason for this change.

Jan 12 2021, 10:36 AM · Restricted Project
MoritzS updated the diff for D94475: [MC] Emit ELF files with ELFOSABI_GNU if specified in triple.

Fixed clang-format error

Jan 12 2021, 2:10 AM · Restricted Project
MoritzS added inline comments to D94475: [MC] Emit ELF files with ELFOSABI_GNU if specified in triple.
Jan 12 2021, 2:07 AM · Restricted Project
MoritzS requested review of D94475: [MC] Emit ELF files with ELFOSABI_GNU if specified in triple.
Jan 12 2021, 1:44 AM · Restricted Project
MoritzS added a comment to D94431: Avoid fragile type lookups in GDB pretty printer.

Thanks for the review! Can you commit this for me, please?

Jan 12 2021, 12:35 AM · Restricted Project

Jan 11 2021

MoritzS requested review of D94431: Avoid fragile type lookups in GDB pretty printer.
Jan 11 2021, 9:55 AM · Restricted Project

Dec 21 2020

MoritzS updated the diff for D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

Rebased onto master

Dec 21 2020, 10:26 AM · Restricted Project
MoritzS updated the diff for D89373: Fixed dangling reference in RuntimeDyldELF.

Rebased onto master

Dec 21 2020, 10:23 AM · Restricted Project

Dec 10 2020

MoritzS added a comment to D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

ping

Dec 10 2020, 3:19 AM · Restricted Project

Nov 30 2020

MoritzS added a comment to D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.

Another way to avoid UB in that case is to use value initialization, i.e. PathDiagnosticConsumerOptions options{};.

Nov 30 2020, 12:20 AM · Restricted Project

Nov 27 2020

MoritzS requested review of D92221: Don't delete default constructor of PathDiagnosticConsumerOptions.
Nov 27 2020, 3:35 AM · Restricted Project

Nov 26 2020

MoritzS updated the diff for D89373: Fixed dangling reference in RuntimeDyldELF.

Rebased onto master

Nov 26 2020, 12:47 AM · Restricted Project

Nov 18 2020

MoritzS added a comment to D91183: Added GDB pretty printer for StringMap.

Can you commit this please? I don't have commit access.

Nov 18 2020, 12:19 AM · Restricted Project

Nov 17 2020

MoritzS added inline comments to D91183: Added GDB pretty printer for StringMap.
Nov 17 2020, 11:22 AM · Restricted Project
MoritzS updated the diff for D91183: Added GDB pretty printer for StringMap.

Read tombstone value from a constexpr variable. The getTombstoneVal() function
is still necessary, though, as reinterpret_cast is not a constant expression.

Nov 17 2020, 11:21 AM · Restricted Project

Nov 12 2020

MoritzS added inline comments to D91183: Added GDB pretty printer for StringMap.
Nov 12 2020, 1:11 AM · Restricted Project

Nov 10 2020

MoritzS added inline comments to D91183: Added GDB pretty printer for StringMap.
Nov 10 2020, 12:23 PM · Restricted Project
MoritzS updated the diff for D91183: Added GDB pretty printer for StringMap.
  • Added test case
  • Use generator instead of iterator class
Nov 10 2020, 12:21 PM · Restricted Project
MoritzS requested review of D91183: Added GDB pretty printer for StringMap.
Nov 10 2020, 9:21 AM · Restricted Project
MoritzS updated the diff for D89373: Fixed dangling reference in RuntimeDyldELF.

Rebased onto master

Nov 10 2020, 4:11 AM · Restricted Project

Nov 5 2020

MoritzS added a comment to D89373: Fixed dangling reference in RuntimeDyldELF.

I don't have commit access, so please go ahead and commit it.

Nov 5 2020, 10:31 AM · Restricted Project

Nov 3 2020

MoritzS added a reviewer for D89373: Fixed dangling reference in RuntimeDyldELF: lhames.
Nov 3 2020, 5:50 AM · Restricted Project

Oct 26 2020

MoritzS added a comment to D89373: Fixed dangling reference in RuntimeDyldELF.

ping

Oct 26 2020, 12:22 PM · Restricted Project

Oct 14 2020

MoritzS updated the diff for D89373: Fixed dangling reference in RuntimeDyldELF.

Fixed build error

Oct 14 2020, 1:55 AM · Restricted Project
MoritzS requested review of D89373: Fixed dangling reference in RuntimeDyldELF.
Oct 14 2020, 1:47 AM · Restricted Project

Dec 22 2017

MoritzS added a comment to D41170: Use dbgs() instead of errs() in docs for DEBUG().

Yes, please commit this.

Dec 22 2017, 4:19 AM

Dec 13 2017

MoritzS created D41170: Use dbgs() instead of errs() in docs for DEBUG().
Dec 13 2017, 4:30 AM