Page MenuHomePhabricator

Mokosha (Pavel Krajcevski)
Research

Projects

User does not belong to any projects.

User Details

User Since
Jul 17 2020, 11:08 AM (18 w, 6 d)

Recent Activity

Wed, Nov 11

Mokosha added a comment to D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

I've added some documentation that hopefully highlights the intent behind the change. The way that we generate rewrite implementations for ops (i.e. the build() call that we use) means that we can omit some of the attributes if they're marked optional and everything should "just work". The tests that were added will hopefully catch this if anything fails in the future. PTAL (and let me know if I'm missing something egregious here!)

Wed, Nov 11, 6:00 PM · Restricted Project
Mokosha updated the diff for D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

Add some documentation and refine the tests a bit further.

Wed, Nov 11, 5:58 PM · Restricted Project
Mokosha updated the diff for D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

Fix some tests to use actual required args and add failure tests

Wed, Nov 11, 4:21 PM · Restricted Project
Mokosha updated the diff for D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

Fix cases where we may have location directives

Wed, Nov 11, 10:55 AM · Restricted Project

Oct 20 2020

Mokosha updated the diff for D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

Fix clang-format to use camel case instead of snake case.

Oct 20 2020, 12:06 PM · Restricted Project

Oct 19 2020

Mokosha requested review of D89756: Relax the restriction that parsed arguments must match op arguments in ODS..
Oct 19 2020, 5:17 PM · Restricted Project

Jul 20 2020

Herald added a project to D84193: Fix typo in Toy tutorial Ch1: Restricted Project.
Jul 20 2020, 9:16 PM · Restricted Project
Mokosha added a reviewer for D84193: Fix typo in Toy tutorial Ch1: mehdi_amini.
Jul 20 2020, 9:16 PM · Restricted Project