Page MenuHomePhabricator

MeeraN (Meera Nakrani)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2020, 1:28 AM (12 w, 6 d)

Recent Activity

Fri, Oct 2

MeeraN committed rGf7c0e2b8f26f: [ARM] Prevent constants from iCmp instruction from being hoisted if part of a… (authored by MeeraN).
[ARM] Prevent constants from iCmp instruction from being hoisted if part of a…
Fri, Oct 2, 2:29 AM
MeeraN closed D88662: [ARM] Prevent constants from ICmp instruction from being hoisted if part of a min(max()) pattern.
Fri, Oct 2, 2:29 AM · Restricted Project

Thu, Oct 1

MeeraN closed D85120: [ARM] Generated SSAT and USAT instructions with shift.

Closed by revision https://reviews.llvm.org/rG20283ff491a4

Thu, Oct 1, 8:28 AM · Restricted Project
MeeraN closed D85825: [ARM] Enabled VMLAV and Add instructions to use VMLAVA.

Closed by revision https://reviews.llvm.org/rG545de56f87f5

Thu, Oct 1, 8:27 AM · Restricted Project
MeeraN closed D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Closed by revision https://reviews.llvm.org/rGdd519bf0b074

Thu, Oct 1, 8:26 AM · Restricted Project
MeeraN requested review of D88662: [ARM] Prevent constants from ICmp instruction from being hoisted if part of a min(max()) pattern.
Thu, Oct 1, 8:12 AM · Restricted Project
MeeraN committed rG48c9e8244b6b: [ARM] Removed hasSideEffects from signed/unsigned saturates (authored by MeeraN).
[ARM] Removed hasSideEffects from signed/unsigned saturates
Thu, Oct 1, 7:56 AM
MeeraN closed D88545: [ARM] Removed hasSideEffects from signed/unsigned saturates.
Thu, Oct 1, 7:56 AM · Restricted Project

Wed, Sep 30

MeeraN added a comment to D88545: [ARM] Removed hasSideEffects from signed/unsigned saturates.

Sorry, didn't realise tags and reviewers were automatically added. Thought it was a mistake. Apologies for the few extra emails notifications that would have been sent.

Wed, Sep 30, 2:18 AM · Restricted Project
MeeraN removed a reviewer for D88545: [ARM] Removed hasSideEffects from signed/unsigned saturates: andreadb.
Wed, Sep 30, 2:14 AM · Restricted Project
MeeraN removed a reviewer for D88545: [ARM] Removed hasSideEffects from signed/unsigned saturates: andreadb.
Wed, Sep 30, 2:14 AM · Restricted Project
MeeraN requested review of D88545: [ARM] Removed hasSideEffects from signed/unsigned saturates.
Wed, Sep 30, 2:13 AM · Restricted Project

Mon, Sep 28

MeeraN committed rG675431b98787: [ARM] Added more patterns to generate SSAT/USAT with shift (authored by MeeraN).
[ARM] Added more patterns to generate SSAT/USAT with shift
Mon, Sep 28, 7:52 AM
MeeraN closed D88145: [ARM] Added more patterns to generate SSAT/USAT with shift.
Mon, Sep 28, 7:51 AM · Restricted Project

Thu, Sep 24

MeeraN updated the diff for D88145: [ARM] Added more patterns to generate SSAT/USAT with shift.

Renamed ARMssatnoshift and ARMusatnoshift to ARMssat and ARMusat

Thu, Sep 24, 7:52 AM · Restricted Project

Wed, Sep 23

MeeraN requested review of D88145: [ARM] Added more patterns to generate SSAT/USAT with shift.
Wed, Sep 23, 5:35 AM · Restricted Project

Sep 22 2020

MeeraN committed rGa3d0dce2608b: [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being… (authored by MeeraN).
[ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being…
Sep 22 2020, 4:55 AM
MeeraN closed D87457: [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being hoisted when in a loop.
Sep 22 2020, 4:54 AM · Restricted Project

Sep 21 2020

MeeraN updated the diff for D87457: [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being hoisted when in a loop.

Added new helper function isSSATMinMaxPattern which checks whether the instruction being passed in is a valid max instruction that is part of a min(max()) or max(min()) pattern. Simplified getIntImmCostInst down to make a call to this function.

Sep 21 2020, 7:46 AM · Restricted Project
MeeraN updated the diff for D87457: [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being hoisted when in a loop.

Improved getIntImmCostInst so that the max(min()) case is properly handled by checking the instruction's operand is a min and a select instruction.

Sep 21 2020, 3:24 AM · Restricted Project

Sep 16 2020

MeeraN updated the diff for D87457: [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being hoisted when in a loop.

Made the checks more specific to min(max()) and max(min()) patterns which should generate SSAT

Sep 16 2020, 8:01 AM · Restricted Project

Sep 15 2020

MeeraN committed rG1119bf95be94: [ARM] Corrected condition in isSaturatingConditional (authored by MeeraN).
[ARM] Corrected condition in isSaturatingConditional
Sep 15 2020, 3:17 AM
MeeraN added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Headsup: This broke a number of tests for me. Looking closer into where it changed things erroneously...

Sep 15 2020, 2:43 AM · Restricted Project

Sep 14 2020

MeeraN committed rGdd519bf0b074: [ARM] Selects SSAT/USAT from correct LLVM IR (authored by MeeraN).
[ARM] Selects SSAT/USAT from correct LLVM IR
Sep 14 2020, 3:59 AM

Sep 10 2020

MeeraN requested review of D87457: [ARM][TTI] Prevents constants in a min(max) or max(min) pattern from being hoisted when in a loop.
Sep 10 2020, 8:24 AM · Restricted Project
MeeraN updated the diff for D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Added explanation about LLVM canonicalizing to min/max patterns to both the comment before the function and commit message. Tidied up formatting by moving a comment, reducing indention where possible and removing unused function (isUpperSaturate).

Sep 10 2020, 5:08 AM · Restricted Project

Sep 9 2020

MeeraN requested review of D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.
Sep 9 2020, 6:51 AM · Restricted Project

Aug 19 2020

MeeraN committed rG545de56f87f5: [ARM] Enabled VMLAV and Add instructions to use VMLAVA (authored by MeeraN).
[ARM] Enabled VMLAV and Add instructions to use VMLAVA
Aug 19 2020, 1:40 AM

Aug 12 2020

MeeraN updated the diff for D85825: [ARM] Enabled VMLAV and Add instructions to use VMLAVA.

Changed tests to show original IR (vmlav and add instructions) being transformed to use vmlava, run using opt -instcombine -S -mtriple=arm -o - %s instead.

Aug 12 2020, 10:12 AM · Restricted Project
MeeraN requested review of D85825: [ARM] Enabled VMLAV and Add instructions to use VMLAVA.
Aug 12 2020, 3:30 AM · Restricted Project

Aug 4 2020

MeeraN committed rG20283ff491a4: [ARM] Generated SSAT and USAT instructions with shift (authored by MeeraN).
[ARM] Generated SSAT and USAT instructions with shift
Aug 4 2020, 2:40 AM

Aug 3 2020

MeeraN updated the diff for D85120: [ARM] Generated SSAT and USAT instructions with shift.

Removed t2_asr_imm and replaced with just asr_imm. Also deleted thumb2 tests and instead included Run command in arm tests to avoid having the same tests repeated.

Aug 3 2020, 8:09 AM · Restricted Project
MeeraN requested review of D85120: [ARM] Generated SSAT and USAT instructions with shift.
Aug 3 2020, 4:26 AM · Restricted Project

Jul 24 2020

MeeraN committed rGdb37937a4738: [ARM] Added additional patterns to VABD instruction (authored by MeeraN).
[ARM] Added additional patterns to VABD instruction
Jul 24 2020, 10:48 AM
MeeraN closed D84500: [ARM] Added additional patterns to VABD instruction.
Jul 24 2020, 10:48 AM · Restricted Project
MeeraN committed rG805e6bcf22f3: Test Commit (authored by MeeraN).
Test Commit
Jul 24 2020, 10:24 AM
MeeraN updated the diff for D84500: [ARM] Added additional patterns to VABD instruction.

Removed fast attributes and added test cases for when the floating point flag is not set.

Jul 24 2020, 7:31 AM · Restricted Project
MeeraN changed the edit policy for D84500: [ARM] Added additional patterns to VABD instruction.
Jul 24 2020, 6:21 AM · Restricted Project
MeeraN updated the diff for D84500: [ARM] Added additional patterns to VABD instruction.

Added second test for f16 case and made test cases much shorter. Also moved position of pattern definition so that the size is handled clearly

Jul 24 2020, 4:25 AM · Restricted Project
Herald added a project to D84500: [ARM] Added additional patterns to VABD instruction: Restricted Project.
Jul 24 2020, 1:57 AM · Restricted Project