Page MenuHomePhabricator

MarcusJohnson91 (Marcus Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 3 2020, 7:37 PM (42 w, 3 h)

Recent Activity

Oct 2 2020

MarcusJohnson91 added a comment to D88629: [lld-macho] Add ARM64 target arch.

It is not entirely clear whether I use the "ARM64" (Apple) or "AArch64" (non-Apple) naming convention. Guidance is appreciated.

Oct 2 2020, 7:32 PM · Restricted Project

Sep 22 2020

MarcusJohnson91 added a comment to D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.

I noticed the pre-merge tests failed!

Sep 22 2020, 1:44 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Sep 22 2020, 3:38 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 requested review of D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.
Sep 22 2020, 3:36 AM · Restricted Project, Unknown Object (Project)

Sep 21 2020

MarcusJohnson91 awarded D86137: Add -Wno-error=unknown flag to clang-format. a Love token.
Sep 21 2020, 1:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

After looking more closely at the issue, it seems you're having an issue with Mozilla's comment alignment option.

Sep 21 2020, 1:43 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.
Sep 21 2020, 1:33 PM · Restricted Project, Unknown Object (Project), Restricted Project

Sep 20 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ?

Sep 20 2020, 1:55 PM · Restricted Project, Unknown Object (Project), Restricted Project

Aug 8 2020

MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Hey guys, I'm rebasing and starting work on this again, sorry for the wait I moved 2000 miles from Michigan to Oregon.

Aug 8 2020, 5:30 PM · Unknown Object (Project), Restricted Project

May 22 2020

MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Hey guys: @sivachandra.

May 22 2020, 1:25 PM · Unknown Object (Project), Restricted Project

May 20 2020

MarcusJohnson91 accepted D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults.

LGTM

May 20 2020, 5:55 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

If you want me to land this for you, I'd feel more comfortable landing it if:

a) We can land D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults first
b) The Mozilla team have tested the impact (they clang-format their entire code base I think)

May 20 2020, 1:02 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 19 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Format.h: indented the `AfterExternBlock: true` example code snippet with 4 spaces like the Indent option so it's more visible and matches.

May 19 2020, 8:08 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Made the IndentExternBlockStyle enum comments a bit clearer, and regenerated the .rst file

May 19 2020, 8:07 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Just fixed the formatting of the ReleaseNotes.rst file, the extern blocks were slightly askew, and it might've made it a bit confusing

May 19 2020, 8:07 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Sorry to "go around the houses" but we'll get there in the end...I think we are close

May 19 2020, 6:28 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
May 19 2020, 6:28 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Ok, I've removed the inherited ones, and also removed the times I was setting a style when there wasn't one before.

May 19 2020, 3:45 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
May 19 2020, 3:45 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 18 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

As for crashes, none of them seem relevant; I'm on MacOS, the windows ABI crash seems especially irrelevent.

May 18 2020, 6:58 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Added the style initializers, moved IEBS_AfterExternBlock to be the first enum value so that it's zero, that way the bool logic works.

May 18 2020, 6:26 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I've initialized all styles to either AfterExternBlock, if there was a BraceWrapping block, or NoIndent if there wasn't.

May 18 2020, 5:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I've got the indenting to work manually now as well, the issue was you need to have BreakBeforeBraces: Custom in the inline style for it to pick up BraceWrapping.AfterExternBlock's value.

May 18 2020, 5:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Fixed the generation of ReleaseNotes.rst

May 18 2020, 5:52 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.
May 18 2020, 5:52 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 17 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

LGTM

May 17 2020, 5:50 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 16 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.
May 16 2020, 6:01 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Removed the lowercase Noindent case, that was a last minute addition I thought might make it a tad easier to work with, but you're right I didn't even test it, and honestly adding that complexity is just pointless at best.

May 16 2020, 6:01 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Did everything you asked and did a littl bit of my own cleanup as well.

May 16 2020, 8:25 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Removed forgotten comment from control logic of UnwrappedLineParser

May 16 2020, 8:25 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I've fixed all of your comments as well as fixed the tests.

May 16 2020, 7:53 AM · Restricted Project, Unknown Object (Project), Restricted Project

Apr 19 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.
Apr 19 2020, 11:45 AM · Restricted Project, Unknown Object (Project), Restricted Project

Apr 14 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

but I'm also constantly surprised by how many of the enumeration cases started out as booleans only later to have to be converted to enums. The more I think about this the more I think the problem can probably be dealt with better by making it an enumeration. (even if you support true and false to mean "indent" and "don't indent"

Apr 14 2020, 10:10 AM · Restricted Project, Unknown Object (Project), Restricted Project

Apr 3 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I agree that changing formatting randomly isn't a good idea, and I think converting AfterExternBlock to an enum is the way to go, but I'm just not sure on how it should be implemented.

Apr 3 2020, 2:07 AM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 31 2020

MarcusJohnson91 added a project to D75791: [clang-format] Added new option IndentExternBlock: Restricted Project.
Mar 31 2020, 9:27 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D33029: [clang-format] add option for dangling parenthesis.

I don't think that's quite right. Then you will also have to have a AlignWithDanglingParenthesis for cases when people still want closing parenthesis on new line but want parameters as well as closing parenthesis to be aligned with opening parenthesis. I think we need a separate option, something like BreakBeforeClosingBracket.

Mar 31 2020, 9:27 PM · Unknown Object (Project), Restricted Project
MarcusJohnson91 awarded D75791: [clang-format] Added new option IndentExternBlock a Like token.
Mar 31 2020, 9:16 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 25 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Implemented the suggestion to break the test strings down into smaller pieces

Mar 25 2020, 8:02 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Mar 25 2020, 6:25 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 24 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Restored all the test function names to foo().

Mar 24 2020, 6:03 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Mar 24 2020, 6:03 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Implemented @MyDeveloperDay's suggestion to simplify the if/else statements.

Mar 24 2020, 6:03 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 23 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Rebased on Master again, recompiling and re-running all the tests.

Mar 23 2020, 3:48 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Are the functions char[16|32]rtomb doing a UTF-16|32 to UTF-8 conversion? Per the standard, they should convert to the current locale?

Mar 23 2020, 3:16 PM · Unknown Object (Project), Restricted Project

Mar 21 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Rebased on master

Mar 21 2020, 9:37 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Rebased on master

Mar 21 2020, 9:37 AM · Unknown Object (Project), Restricted Project

Mar 18 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.
Mar 18 2020, 12:29 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 14 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Fixed Format.h comments, and rebased on master.

Mar 14 2020, 5:52 AM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 13 2020

MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

I'm refactoring this around wchar (and adding basic wchar support as well)

Mar 13 2020, 2:15 AM · Unknown Object (Project), Restricted Project

Mar 12 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Rebased

Mar 12 2020, 9:13 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Fixed a minor clang-format line length issue in the source files, and removed a duplicated cmake entry

Mar 12 2020, 9:13 AM · Unknown Object (Project), Restricted Project

Mar 11 2020

MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Rebased and Squashed Uchar patch

Mar 11 2020, 11:18 PM · Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

New squashed commit with all changes present

Mar 11 2020, 10:40 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Bump

Mar 11 2020, 10:33 PM · Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

your patch seems to be missing the other files

Mar 11 2020, 1:35 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 7 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Updated the release notes

Mar 7 2020, 5:48 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Removed the debugging comments I added to FormatTest.cpp

Mar 7 2020, 5:16 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

you need documentation and release note changes too

Mar 7 2020, 8:35 AM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 6 2020

MarcusJohnson91 created D75791: [clang-format] Added new option IndentExternBlock.
Mar 6 2020, 6:12 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 3 2020

MarcusJohnson91 abandoned D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.

I'm moving the intended change to a new clang-format option instead of modifying an established one.

Mar 3 2020, 12:23 AM · Restricted Project, Unknown Object (Project)

Mar 1 2020

MarcusJohnson91 updated the diff for D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.

Full Context Diff (I think?)

Mar 1 2020, 3:04 PM · Restricted Project, Unknown Object (Project)

Feb 29 2020

MarcusJohnson91 retitled D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock from Fixed Extern Block Indentation in libFormat to [Clang-Format] Fixed BraceWrapping.AfterExternBlock.
Feb 29 2020, 1:55 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 updated the diff for D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.

Rewrote the AfterExternBlock code to rely on just that clang-format option and remove the ExternNamespace check.

Feb 29 2020, 1:55 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 added a reviewer for D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock: cfe-commits.
Feb 29 2020, 1:55 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 updated the diff for D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.

Clang-Formatted UnwrappedLineParser.cpp

Feb 29 2020, 12:13 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 added a comment to D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.

Not sure why it failed to compile, it compiles just fine on my machine...

Feb 29 2020, 12:13 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 created D75410: [clang-format] Fixed BraceWrapping.AfterExternBlock.
Feb 29 2020, 11:10 AM · Restricted Project, Unknown Object (Project)

Feb 8 2020

MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Added uchar.h.def based on string.h.def, but I don't understand what it's actually doing.

Feb 8 2020, 5:02 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

uint_leastX_t -> UINT_LEASTXTYPE__ in char16_t and char32_t typedefs

Feb 8 2020, 5:02 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Removed all of the new calls, starting work on the latest comments

Feb 8 2020, 4:49 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Fixed the header blocks and reformatted

Feb 8 2020, 4:44 AM · Unknown Object (Project), Restricted Project

Feb 6 2020

MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Added trailing newline to CMakeLists

Feb 6 2020, 5:50 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Fixed typo's.

Feb 6 2020, 5:50 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Clang-formatted, and replaced calloc with calls to new, as well as removed ULL from size_t variable initializations

Feb 6 2020, 5:41 AM · Unknown Object (Project), Restricted Project

Feb 4 2020

MarcusJohnson91 created D74021: Created uChar implementation for libc.
Feb 4 2020, 7:17 PM · Unknown Object (Project), Restricted Project