Page MenuHomePhabricator

MarcusJohnson91 (Marcus Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 3 2020, 7:37 PM (96 w, 24 m)

Recent Activity

Mon, Nov 22

MarcusJohnson91 added a reviewer for D114342: ConvertUTF, new wrapper API: aaron.ballman.
Mon, Nov 22, 5:34 AM · Restricted Project, Restricted Project

Sun, Nov 21

MarcusJohnson91 updated the summary of D114342: ConvertUTF, new wrapper API.
Sun, Nov 21, 6:16 PM · Restricted Project, Restricted Project
MarcusJohnson91 abandoned D107202: ConvertUTF: convertUTF32ToUTF8String.

Reposted as @D114342

Sun, Nov 21, 6:15 PM · Restricted Project
MarcusJohnson91 requested review of D114342: ConvertUTF, new wrapper API.
Sun, Nov 21, 6:13 PM · Restricted Project, Restricted Project

Thu, Nov 18

MarcusJohnson91 updated subscribers of D107202: ConvertUTF: convertUTF32ToUTF8String.

@efreidma

Thu, Nov 18, 1:01 AM · Restricted Project

Wed, Nov 17

MarcusJohnson91 added a comment to D93938: [clang-format] Fixed AfterEnum handling.

Not trying to take over this patch, because I've got a ton of patches I need to be finishing up myself.

Wed, Nov 17, 7:53 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 added a comment to D93938: [clang-format] Fixed AfterEnum handling.

I applied this fix locally to a branch based off llvm 11.x and the FormatTest.FormatsTypedefEnum test now fails.

Wed, Nov 17, 7:45 PM · Restricted Project, Unknown Object (Project)

Tue, Nov 16

MarcusJohnson91 added a comment to D107202: ConvertUTF: convertUTF32ToUTF8String.

Ok, the tests passed, can this be merged now?

Tue, Nov 16, 5:53 PM · Restricted Project
MarcusJohnson91 updated the diff for D106756: Added l16/l32 length modifiers for char16_t/char32_t.

Clang-FormatDiff.py; Still waiting for the UTFConvert patch to land first.

Tue, Nov 16, 4:42 PM · Restricted Project
MarcusJohnson91 updated the diff for D107202: ConvertUTF: convertUTF32ToUTF8String.

clang

Tue, Nov 16, 4:35 PM · Restricted Project

Aug 4 2021

MarcusJohnson91 updated the diff for D107202: ConvertUTF: convertUTF32ToUTF8String.

Seems like the tests still work

Aug 4 2021, 4:04 AM · Restricted Project
MarcusJohnson91 added a comment to D107202: ConvertUTF: convertUTF32ToUTF8String.

The the way the math is written now, for "Example", we allocate UNI_MAX_UTF8_BYTES_PER_CODE_POINT * sizeof(UTF32) * 7 = 112 bytes.

Aug 4 2021, 2:46 AM · Restricted Project

Aug 3 2021

MarcusJohnson91 added a comment to D107202: ConvertUTF: convertUTF32ToUTF8String.

I'm not sure the math is right even for UTF-16, but anyway, UTF-32 is a little different from UTF-16. A 2-byte character in UTF-16 can translate to 3 bytes in UTF-8. That sort of thing is impossible in UTF-32: a UTF-32 string is never shorter than its translation to UTF-8. A codepoint in UTF-8 is at most 4 bytes.

Aug 3 2021, 8:53 PM · Restricted Project

Aug 2 2021

MarcusJohnson91 added a comment to D107202: ConvertUTF: convertUTF32ToUTF8String.

As far as I can tell, the lastest version of the diff you uploaded still has the following issues that haven't been addressed:

  1. The BOM handling is actually actively a problem if you're planning to use the interface to interpret wprintf format strings. We don't want to byteswap L"\uFFFE%s" or something like that.
  2. SrcBytes.size() * UNI_MAX_UTF8_BYTES_PER_CODE_POINT + 1 seems like way too much memory.
Aug 2 2021, 3:59 PM · Restricted Project
MarcusJohnson91 added a comment to D107202: ConvertUTF: convertUTF32ToUTF8String.

@efriedma ping

Aug 2 2021, 2:25 PM · Restricted Project

Aug 1 2021

MarcusJohnson91 updated the diff for D106755: Extended format string checking to wprintf/wscanf.
Aug 1 2021, 10:19 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106756: Added l16/l32 length modifiers for char16_t/char32_t.
Aug 1 2021, 10:18 PM · Restricted Project

Jul 30 2021

MarcusJohnson91 edited reviewers for D106755: Extended format string checking to wprintf/wscanf, added: tahonermann; removed: aaron.ballman.
Jul 30 2021, 6:38 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106755: Extended format string checking to wprintf/wscanf.

Rebased

Jul 30 2021, 6:36 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106756: Added l16/l32 length modifiers for char16_t/char32_t.

Rebased on Main

Jul 30 2021, 6:35 PM · Restricted Project
MarcusJohnson91 abandoned D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.
Jul 30 2021, 5:56 PM · Restricted Project, Restricted Project
MarcusJohnson91 added a reviewer for D107202: ConvertUTF: convertUTF32ToUTF8String: efriedma.
Jul 30 2021, 4:20 PM · Restricted Project
MarcusJohnson91 requested review of D107202: ConvertUTF: convertUTF32ToUTF8String.
Jul 30 2021, 4:19 PM · Restricted Project
MarcusJohnson91 added a comment to D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

There is only one function in ConvertUTFWrapper.cpp: convertUTF32ToUTF8String

Jul 30 2021, 4:10 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

It seems like this diff keeps getting reverted?

Jul 30 2021, 3:06 PM · Restricted Project, Restricted Project

Jul 29 2021

MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.
Jul 29 2021, 4:40 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Formatted the diff

Jul 29 2021, 3:29 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

The tests work on my machine now, turns out the Big endian one needs a BOM, pretty obvious in hindsight.

Jul 29 2021, 2:16 PM · Restricted Project, Restricted Project

Jul 28 2021

MarcusJohnson91 added a comment to D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

The problem seems to be in the conversion function expecting strings to be a multiple of 4 bytes, which doesn't hold up with the way ArrayRef stores things as char that is casted to char32_t, when using ASCII values like in the look of disapproval emoji, having an underscore in the middle.

Jul 28 2021, 6:23 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.
Jul 28 2021, 1:12 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106755: Extended format string checking to wprintf/wscanf.
Jul 28 2021, 10:28 AM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106756: Added l16/l32 length modifiers for char16_t/char32_t.

Added a couple tests

Jul 28 2021, 10:23 AM · Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Updated the tests

Jul 28 2021, 9:44 AM · Restricted Project, Restricted Project

Jul 27 2021

MarcusJohnson91 added inline comments to D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.
Jul 27 2021, 7:46 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Dropped the UTF32 BOM stuff

Jul 27 2021, 3:11 PM · Restricted Project, Restricted Project

Jul 25 2021

MarcusJohnson91 added a comment to D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Anyone got any ideas what happened this time?

Jul 25 2021, 4:06 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106756: Added l16/l32 length modifiers for char16_t/char32_t.

Clang-formatted the diff

Jul 25 2021, 2:17 PM · Restricted Project
MarcusJohnson91 updated the diff for D106755: Extended format string checking to wprintf/wscanf.

Clang-formatted the diff.

Jul 25 2021, 2:14 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Implemented the fixes mentioned and reformatted the patch

Jul 25 2021, 1:53 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106755: Extended format string checking to wprintf/wscanf.
Jul 25 2021, 1:50 PM · Restricted Project, Restricted Project
MarcusJohnson91 added inline comments to D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.
Jul 25 2021, 1:31 PM · Restricted Project, Restricted Project
MarcusJohnson91 added a comment to D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

I don't understand why the build failed?

Jul 25 2021, 12:36 AM · Restricted Project, Restricted Project

Jul 24 2021

MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Added more tests

Jul 24 2021, 8:39 PM · Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Added tests

Jul 24 2021, 8:13 PM · Restricted Project, Restricted Project
MarcusJohnson91 requested review of D106756: Added l16/l32 length modifiers for char16_t/char32_t.
Jul 24 2021, 12:30 PM · Restricted Project
MarcusJohnson91 added a reviewer for D106755: Extended format string checking to wprintf/wscanf: efriedma.
Jul 24 2021, 12:28 PM · Restricted Project, Restricted Project
MarcusJohnson91 requested review of D106755: Extended format string checking to wprintf/wscanf.
Jul 24 2021, 12:28 PM · Restricted Project, Restricted Project
MarcusJohnson91 added reviewers for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String: aaron.ballman, rsmith, efriedma, klimek.
Jul 24 2021, 11:49 AM · Restricted Project, Restricted Project
MarcusJohnson91 requested review of D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.
Jul 24 2021, 11:48 AM · Restricted Project, Restricted Project

Jun 1 2021

MarcusJohnson91 closed D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.
Jun 1 2021, 12:31 AM · Restricted Project, Unknown Object (Project)

May 31 2021

MarcusJohnson91 added a comment to D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.

This patch was merged upstream a long time ago, how do I close it here on Phabricator? thanks

May 31 2021, 12:30 PM · Restricted Project, Unknown Object (Project)

Oct 2 2020

MarcusJohnson91 added a comment to D88629: [lld-macho] Add ARM64 target arch.

It is not entirely clear whether I use the "ARM64" (Apple) or "AArch64" (non-Apple) naming convention. Guidance is appreciated.

Oct 2 2020, 7:32 PM · Unknown Object (Project), Restricted Project

Sep 22 2020

MarcusJohnson91 added a comment to D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.

I noticed the pre-merge tests failed!

Sep 22 2020, 1:44 PM · Restricted Project, Unknown Object (Project)
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Sep 22 2020, 3:38 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 requested review of D88084: [clang-format] Changed default styles BraceWrappping bool table to directly use variables.
Sep 22 2020, 3:36 AM · Restricted Project, Unknown Object (Project)

Sep 21 2020

MarcusJohnson91 awarded D86137: Add -Wno-error=unknown flag to clang-format. a Love token.
Sep 21 2020, 1:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

After looking more closely at the issue, it seems you're having an issue with Mozilla's comment alignment option.

Sep 21 2020, 1:43 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.
Sep 21 2020, 1:33 PM · Restricted Project, Unknown Object (Project), Restricted Project

Sep 20 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ?

Sep 20 2020, 1:55 PM · Restricted Project, Unknown Object (Project), Restricted Project

Aug 8 2020

MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Hey guys, I'm rebasing and starting work on this again, sorry for the wait I moved 2000 miles from Michigan to Oregon.

Aug 8 2020, 5:30 PM · Unknown Object (Project), Restricted Project

May 22 2020

MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Hey guys: @sivachandra.

May 22 2020, 1:25 PM · Unknown Object (Project), Restricted Project

May 20 2020

MarcusJohnson91 accepted D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults.

LGTM

May 20 2020, 5:55 AM · Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

If you want me to land this for you, I'd feel more comfortable landing it if:

a) We can land D80214: [clang-format] Set of unit test to begin to validate that we don't change defaults first
b) The Mozilla team have tested the impact (they clang-format their entire code base I think)

May 20 2020, 1:02 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 19 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Format.h: indented the `AfterExternBlock: true` example code snippet with 4 spaces like the Indent option so it's more visible and matches.

May 19 2020, 8:08 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Made the IndentExternBlockStyle enum comments a bit clearer, and regenerated the .rst file

May 19 2020, 8:07 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Just fixed the formatting of the ReleaseNotes.rst file, the extern blocks were slightly askew, and it might've made it a bit confusing

May 19 2020, 8:07 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Sorry to "go around the houses" but we'll get there in the end...I think we are close

May 19 2020, 6:28 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
May 19 2020, 6:28 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Ok, I've removed the inherited ones, and also removed the times I was setting a style when there wasn't one before.

May 19 2020, 3:45 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
May 19 2020, 3:45 AM · Restricted Project, Unknown Object (Project), Restricted Project

May 18 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

As for crashes, none of them seem relevant; I'm on MacOS, the windows ABI crash seems especially irrelevent.

May 18 2020, 6:58 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Added the style initializers, moved IEBS_AfterExternBlock to be the first enum value so that it's zero, that way the bool logic works.

May 18 2020, 6:26 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I've initialized all styles to either AfterExternBlock, if there was a BraceWrapping block, or NoIndent if there wasn't.

May 18 2020, 5:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I've got the indenting to work manually now as well, the issue was you need to have BreakBeforeBraces: Custom in the inline style for it to pick up BraceWrapping.AfterExternBlock's value.

May 18 2020, 5:54 PM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Fixed the generation of ReleaseNotes.rst

May 18 2020, 5:52 AM · Restricted Project, Unknown Object (Project), Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.
May 18 2020, 5:52 AM · Restricted Project, Restricted Project, Restricted Project

May 17 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

LGTM

May 17 2020, 5:50 AM · Restricted Project, Restricted Project, Restricted Project

May 16 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.
May 16 2020, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Removed the lowercase Noindent case, that was a last minute addition I thought might make it a tad easier to work with, but you're right I didn't even test it, and honestly adding that complexity is just pointless at best.

May 16 2020, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Did everything you asked and did a littl bit of my own cleanup as well.

May 16 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Removed forgotten comment from control logic of UnwrappedLineParser

May 16 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I've fixed all of your comments as well as fixed the tests.

May 16 2020, 7:53 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.
Apr 19 2020, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

but I'm also constantly surprised by how many of the enumeration cases started out as booleans only later to have to be converted to enums. The more I think about this the more I think the problem can probably be dealt with better by making it an enumeration. (even if you support true and false to mean "indent" and "don't indent"

Apr 14 2020, 10:10 AM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

I agree that changing formatting randomly isn't a good idea, and I think converting AfterExternBlock to an enum is the way to go, but I'm just not sure on how it should be implemented.

Apr 3 2020, 2:07 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2020

MarcusJohnson91 added a project to D75791: [clang-format] Added new option IndentExternBlock: Restricted Project.
Mar 31 2020, 9:27 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 added a comment to D33029: [clang-format] add option for dangling parenthesis.

I don't think that's quite right. Then you will also have to have a AlignWithDanglingParenthesis for cases when people still want closing parenthesis on new line but want parameters as well as closing parenthesis to be aligned with opening parenthesis. I think we need a separate option, something like BreakBeforeClosingBracket.

Mar 31 2020, 9:27 PM · Restricted Project, Restricted Project
MarcusJohnson91 awarded D75791: [clang-format] Added new option IndentExternBlock a Like token.
Mar 31 2020, 9:16 PM · Restricted Project, Restricted Project, Restricted Project

Mar 25 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Implemented the suggestion to break the test strings down into smaller pieces

Mar 25 2020, 8:02 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Mar 25 2020, 6:25 PM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Restored all the test function names to foo().

Mar 24 2020, 6:03 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 added inline comments to D75791: [clang-format] Added new option IndentExternBlock.
Mar 24 2020, 6:03 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Implemented @MyDeveloperDay's suggestion to simplify the if/else statements.

Mar 24 2020, 6:03 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Rebased on Master again, recompiling and re-running all the tests.

Mar 23 2020, 3:48 PM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

Are the functions char[16|32]rtomb doing a UTF-16|32 to UTF-8 conversion? Per the standard, they should convert to the current locale?

Mar 23 2020, 3:16 PM · Restricted Project, Restricted Project

Mar 21 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Rebased on master

Mar 21 2020, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
MarcusJohnson91 updated the diff for D74021: Created uChar implementation for libc.

Rebased on master

Mar 21 2020, 9:37 AM · Restricted Project, Restricted Project

Mar 18 2020

MarcusJohnson91 added a comment to D75791: [clang-format] Added new option IndentExternBlock.
Mar 18 2020, 12:29 PM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2020

MarcusJohnson91 updated the diff for D75791: [clang-format] Added new option IndentExternBlock.

Fixed Format.h comments, and rebased on master.

Mar 14 2020, 5:52 AM · Restricted Project, Restricted Project, Restricted Project

Mar 13 2020

MarcusJohnson91 added a comment to D74021: Created uChar implementation for libc.

I'm refactoring this around wchar (and adding basic wchar support as well)

Mar 13 2020, 2:15 AM · Restricted Project, Restricted Project