Page MenuHomePhabricator

LittleFox94 (Mara Sophie Grosch)
User

Projects

User does not belong to any projects.

User Details

User Since
May 3 2020, 10:34 AM (49 w, 4 d)

Recent Activity

Sun, Apr 11

LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

Removed the unnecessary check as requested.

Sun, Apr 11, 4:24 PM · Restricted Project
LittleFox94 updated the diff for D79888: libc++: move checks for newlib to actually work.

Removed an unnecessary check as requested in review

Sun, Apr 11, 4:23 PM · Restricted Project

Wed, Apr 7

LittleFox94 added a reviewer for D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built: chandlerc.

Adding @chandlerc as a reviewer since first entry in CODE_OWNERS for CMake ^^'

Wed, Apr 7, 9:34 PM · Restricted Project
LittleFox94 updated the diff for D79888: libc++: move checks for newlib to actually work.
Wed, Apr 7, 9:06 PM · Restricted Project
LittleFox94 updated the diff for D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.

formatting was bad and somehow differential didn't show the endif() - added a trailing newline for that

Wed, Apr 7, 6:41 PM · Restricted Project
LittleFox94 requested review of D100081: LLJITWithRemoteDebugger: fix CMake when utils are not built.
Wed, Apr 7, 6:38 PM · Restricted Project

Sep 14 2020

LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

Is this review still relevant? If not, let's abandon it to clear up the review queue.

Sep 14 2020, 5:16 PM · Restricted Project

May 13 2020

LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

We could lift the two macros that depend on _NEWLIB_VERSION into the headers that use them.
Then we'll avoid the include in config.

May 13 2020, 1:03 PM · Restricted Project
LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

I am slightly concerned that this also introduces a bunch of declarations in __config, which is the most included file of the library. That would also be the first time we include unistd.h in the libc++ headers (as opposed to the sources used to build the dylib). That might not be an issue, but it's something to keep in mind.

Another way would be to include _newlib_version.h if it exists, would that be better? Would then be a newlib specific patch.

May 13 2020, 12:31 PM · Restricted Project
LittleFox94 created D79888: libc++: move checks for newlib to actually work.
May 13 2020, 10:50 AM · Restricted Project
LittleFox94 added a comment to D79888: libc++: move checks for newlib to actually work.

Since this include was deleted as "dead code" before, I added a comment why it is not dead

May 13 2020, 10:50 AM · Restricted Project

May 12 2020

LittleFox94 added inline comments to D79784: [libc++] Adjust how we guard the inclusion of unistd.h.
May 12 2020, 8:01 AM · Restricted Project

May 7 2020

LittleFox94 added a comment to D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Cannot commit myself

May 7 2020, 10:14 AM · Restricted Project, Restricted Project

May 4 2020

LittleFox94 updated the diff for D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Also fix duplicated check in filesystem/operations.cpp

May 4 2020, 3:37 PM · Restricted Project, Restricted Project
LittleFox94 added inline comments to D79305: chrono: check _POSIX_TIMERS before using clock_gettime.
May 4 2020, 2:32 PM · Restricted Project, Restricted Project
LittleFox94 updated the diff for D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Do not include unistd.h on _WIN32, re-add __APPLE__ check and change _POSIX_TIMER check to check for > 0

May 4 2020, 2:32 PM · Restricted Project, Restricted Project
LittleFox94 updated the diff for D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

Included unistd.h and removed the check for __APPLE__, since _POSIX_TIMERS should work there, too

May 4 2020, 8:32 AM · Restricted Project, Restricted Project
LittleFox94 added a comment to D79305: chrono: check _POSIX_TIMERS before using clock_gettime.

LGTM generally speaking, but is this triggered by a specific failure you ran into? If so, on what configuration? We should have a way to test this change.

May 4 2020, 8:32 AM · Restricted Project, Restricted Project

May 3 2020

LittleFox94 created D79305: chrono: check _POSIX_TIMERS before using clock_gettime.
May 3 2020, 11:09 AM · Restricted Project, Restricted Project