Page MenuHomePhabricator

Kai (Kai Nacke)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2012, 7:10 AM (407 w, 1 d)

Recent Activity

Wed, Aug 26

Kai committed rGed07e1fe0ffd: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h> (authored by Kai).
[SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>
Wed, Aug 26, 9:46 AM
Kai closed D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.
Wed, Aug 26, 9:46 AM · Restricted Project, Restricted Project
Kai committed rG00d5f1ecccc6: [SystemZ/ZOS] Additions to the build system. (authored by Kai).
[SystemZ/ZOS] Additions to the build system.
Wed, Aug 26, 3:55 AM
Kai closed D83866: [SystemZ/ZOS] Additions to the build system..
Wed, Aug 26, 3:55 AM · Restricted Project

Aug 17 2020

Kai committed rGc2ae7934c809: [SystemZ/ZOS]__(de)register_frame are not available on z/OS. (authored by Kai).
[SystemZ/ZOS]__(de)register_frame are not available on z/OS.
Aug 17 2020, 6:01 AM
Kai closed D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..
Aug 17 2020, 6:00 AM · Restricted Project

Aug 14 2020

Kai added reviewers for D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS.: abhina.sreeskantharajan, hubert.reinterpretcast.
Aug 14 2020, 2:56 AM · Restricted Project
Kai updated the diff for D83866: [SystemZ/ZOS] Additions to the build system..
  • Added a TODO comment to the linker strip section
  • Both z/OS and AIX now use CMAKE_SYSTEM_NAME to determine the host system
Aug 14 2020, 2:55 AM · Restricted Project

Aug 12 2020

Kai added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 12 2020, 5:51 AM · Restricted Project
Kai committed rGbca1b8ed9943: [SystemZ/ZOS] Implement computeHostNumPhysicalCores (authored by Kai).
[SystemZ/ZOS] Implement computeHostNumPhysicalCores
Aug 12 2020, 5:33 AM
Kai closed D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 12 2020, 5:33 AM · Restricted Project

Aug 11 2020

Kai updated the diff for D83866: [SystemZ/ZOS] Additions to the build system..
  • Position-independent code needs not to be disabled
  • Removed message stating that static symbol export is not supported
Aug 11 2020, 5:24 AM · Restricted Project
Kai added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 11 2020, 5:22 AM · Restricted Project
Kai added a comment to D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..

Any comments on this change?

Aug 11 2020, 4:27 AM · Restricted Project
Kai updated the diff for D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
  • Remove list of systems from comment.
Aug 11 2020, 3:07 AM · Restricted Project
Kai committed rGd6f710fd46dc: [NFC] Fix typo in comment. (authored by Kai).
[NFC] Fix typo in comment.
Aug 11 2020, 2:29 AM
Kai committed rGb3aece05313e: [SystemZ/ZOS] Add binary format goff and operating system zos to the triple (authored by Kai).
[SystemZ/ZOS] Add binary format goff and operating system zos to the triple
Aug 11 2020, 2:27 AM
Kai closed D82081: [z/OS] Add binary format goff and operating system zos to the triple.
Aug 11 2020, 2:26 AM · Restricted Project, Restricted Project

Aug 10 2020

Kai added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 5:08 AM · Restricted Project
Kai updated the diff for D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
  • Sorted condition according to OS
  • Updated/fixed comment
Aug 10 2020, 5:06 AM · Restricted Project
Kai added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 3:11 AM · Restricted Project

Aug 7 2020

Kai requested review of D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 7 2020, 8:45 AM · Restricted Project

Jul 28 2020

Kai requested review of D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..
Jul 28 2020, 12:16 PM · Restricted Project
Kai accepted D84764: Fix computeHostNumPhysicalCores() for Linux on POWER and Linux on Z.

LGTM.

Jul 28 2020, 11:21 AM · Restricted Project
Kai committed rGd3557ecede8e: [Support] Use InitLLVM in llvm-stress, sancov and TableGen (authored by anirudhp).
[Support] Use InitLLVM in llvm-stress, sancov and TableGen
Jul 28 2020, 4:51 AM
Kai closed D83484: Use InitLLVM in llvm-stress, sancov and TableGen.
Jul 28 2020, 4:51 AM · Restricted Project
Kai committed rG7294ca3f6eca: [SystemZ/ZOS] Implement setLastAccessAndModificationTime() (authored by Kai).
[SystemZ/ZOS] Implement setLastAccessAndModificationTime()
Jul 28 2020, 3:37 AM
Kai closed D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime().
Jul 28 2020, 3:37 AM · Restricted Project

Jul 27 2020

Kai added reviewers for D82081: [z/OS] Add binary format goff and operating system zos to the triple: RKSimon, SjoerdMeijer, dexonsmith, rjmccall.

Still looking for opinions on the clang part!

Jul 27 2020, 4:34 AM · Restricted Project, Restricted Project

Jul 22 2020

Kai updated the diff for D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime().

Changed check for error condition according to review comment.

Jul 22 2020, 7:12 AM · Restricted Project

Jul 16 2020

Herald added a project to D83945: [SystemZ/ZOS] Implement setLastAccessAndModificationTime(): Restricted Project.
Jul 16 2020, 5:48 AM · Restricted Project

Jul 15 2020

Kai accepted D83889: [NFC] [AIX] [z/OS] Fix build failure on AIX and z/OS.

LGTM.

Jul 15 2020, 11:05 AM · Restricted Project
Herald added a project to D83866: [SystemZ/ZOS] Additions to the build system.: Restricted Project.
Jul 15 2020, 5:10 AM · Restricted Project
Kai added a comment to D82081: [z/OS] Add binary format goff and operating system zos to the triple.

Is there a comment on the clang part?

Jul 15 2020, 4:58 AM · Restricted Project, Restricted Project
Kai added a comment to D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.

Thank you for pointing out the typo!

Jul 15 2020, 4:57 AM · Restricted Project, Restricted Project
Kai updated the diff for D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>.

Fixed two typos in the comment.

Jul 15 2020, 4:56 AM · Restricted Project, Restricted Project

Jul 9 2020

Kai accepted D83484: Use InitLLVM in llvm-stress, sancov and TableGen.

LGTM.

Jul 9 2020, 12:22 PM · Restricted Project
Kai added a reviewer for D82081: [z/OS] Add binary format goff and operating system zos to the triple: compnerd.
Jul 9 2020, 4:34 AM · Restricted Project, Restricted Project
Herald added a project to D83472: [SystemZ/ZOS] Add header file to encapsulate use of <sysexits.h>: Restricted Project.
Jul 9 2020, 4:15 AM · Restricted Project, Restricted Project

Jul 7 2020

Kai accepted D83251: [SystemZ] Allow specifying integer registers as part of the address calculation.

LGTM.

Jul 7 2020, 5:41 AM · Restricted Project

Jul 6 2020

Kai committed rGbfd84b1c034d: [SystemZ/ZOS] Implement getMainExecutable() and is_local_impl() (authored by Kai).
[SystemZ/ZOS] Implement getMainExecutable() and is_local_impl()
Jul 6 2020, 3:49 AM
Kai committed rG0663844b064d: [SystemZ/ZOS] Define Endian constants for z/OS. (authored by Kai).
[SystemZ/ZOS] Define Endian constants for z/OS.
Jul 6 2020, 3:49 AM
Kai closed D82368: [SystemZ/zos] Define Endian constants for z/OS..
Jul 6 2020, 3:49 AM · Restricted Project
Kai closed D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
Jul 6 2020, 3:49 AM · Restricted Project

Jun 29 2020

Kai added a reviewer for D82368: [SystemZ/zos] Define Endian constants for z/OS.: hubert.reinterpretcast.
Jun 29 2020, 6:26 AM · Restricted Project
Kai updated the diff for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
  • Moved comment inside #if defined(__GNU__)
Jun 29 2020, 5:54 AM · Restricted Project

Jun 25 2020

Kai updated the diff for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
  • Moved the first #if defined(__MVS__) into the if/elif casecade right above
  • Rearranged the #if !defined(PATH_MAX) guarded section
Jun 25 2020, 7:25 AM · Restricted Project
Kai added a reviewer for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl(): JDevlieghere.
Jun 25 2020, 6:20 AM · Restricted Project
Kai added a reviewer for D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl(): chandlerc.
Jun 25 2020, 6:20 AM · Restricted Project
Kai created D82544: [SystemZ][ZOS] Implement getMainExecutable() and is_local_impl().
Jun 25 2020, 6:20 AM · Restricted Project

Jun 24 2020

Kai updated the diff for D82081: [z/OS] Add binary format goff and operating system zos to the triple.
  • Added a break; in several places
  • Follow local formatting style in triple.cpp
Jun 24 2020, 5:54 AM · Restricted Project, Restricted Project

Jun 23 2020

Kai added a reviewer for D82368: [SystemZ/zos] Define Endian constants for z/OS.: chandlerc.
Jun 23 2020, 6:21 AM · Restricted Project
Kai created D82368: [SystemZ/zos] Define Endian constants for z/OS..
Jun 23 2020, 5:17 AM · Restricted Project

Jun 22 2020

Kai added a comment to D82081: [z/OS] Add binary format goff and operating system zos to the triple.

I would like to get a 2nd opinion before committing.

Jun 22 2020, 2:06 AM · Restricted Project, Restricted Project

Jun 19 2020

Kai added a reviewer for D82081: [z/OS] Add binary format goff and operating system zos to the triple: ppc-slack.
Jun 19 2020, 6:59 AM · Restricted Project, Restricted Project
Kai updated the diff for D82081: [z/OS] Add binary format goff and operating system zos to the triple.
  • In Triple.cpp: Keep list of binary formats sorted
  • In Triple.cpp: Use isOSzOS() for check
Jun 19 2020, 5:21 AM · Restricted Project, Restricted Project
Kai added inline comments to D82081: [z/OS] Add binary format goff and operating system zos to the triple.
Jun 19 2020, 4:49 AM · Restricted Project, Restricted Project
Kai updated the diff for D82081: [z/OS] Add binary format goff and operating system zos to the triple.
  • Relative order is now consistently GOFF before XCOFF
  • llvm_report_fatal() now follows guideline
  • Updated formatting
Jun 19 2020, 4:49 AM · Restricted Project, Restricted Project

Jun 18 2020

Kai created D82081: [z/OS] Add binary format goff and operating system zos to the triple.
Jun 18 2020, 4:19 AM · Restricted Project, Restricted Project

Feb 10 2020

Kai committed rG34946dfd7950: [SystemZ] Add implementation for the intrinsic llvm.read_register (authored by Kai).
[SystemZ] Add implementation for the intrinsic llvm.read_register
Feb 10 2020, 5:21 AM
Kai closed D73378: [SystemZ] Add implementation for the intrinsic llvm.read_register.
Feb 10 2020, 5:21 AM · Restricted Project
Kai committed rGa5040d5ec97e: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10] (authored by Kai).
[SytemZ] Disable vector ABI when using option -march=arch[8|9|10]
Feb 10 2020, 1:26 AM
Kai closed D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10].
Feb 10 2020, 1:26 AM · Restricted Project, Restricted Project

Feb 6 2020

Kai accepted D73378: [SystemZ] Add implementation for the intrinsic llvm.read_register.

LGTM.

Feb 6 2020, 11:07 AM · Restricted Project
Kai created D74146: [SytemZ] Disable vector ABI when using option -march=arch[8|9|10].
Feb 6 2020, 10:49 AM · Restricted Project, Restricted Project

Dec 16 2019

Kai accepted D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.

LGTM. Thanks!

Dec 16 2019, 10:16 AM · Restricted Project
Kai added a comment to D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF.
Dec 16 2019, 10:07 AM · Restricted Project
Kai added a comment to D71059: [LLD][ELF] Add time-trace to ELF LLD (1/2).

This PR requires TLS support even if LLVM_ENABLE_THREADS is set to OFF. Is this intended?

Dec 16 2019, 2:30 AM · Restricted Project

Dec 13 2019

Kai committed rGcaa7c9e6f356: [Docs] Fix target feature matrix for PowerPC and SystemZ (authored by Kai).
[Docs] Fix target feature matrix for PowerPC and SystemZ
Dec 13 2019, 3:22 AM
Kai closed D71004: [Docs] Fix target feature matrix for PowerPC and SystemZ.
Dec 13 2019, 3:22 AM · Restricted Project

Dec 4 2019

Kai created D71004: [Docs] Fix target feature matrix for PowerPC and SystemZ.
Dec 4 2019, 4:43 AM · Restricted Project

Oct 11 2019

Kai committed rG42b7cd58309a: [Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj). (authored by Kai).
[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
Oct 11 2019, 5:54 AM
Kai committed rG5b5b2fd2b8b4: [FileCheck] Implement --ignore-case option. (authored by Kai).
[FileCheck] Implement --ignore-case option.
Oct 11 2019, 5:13 AM
Kai added a comment to D68146: [FileCheck] Implement --ignore-case option..

The test fails on Linux: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/28537/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Acheck-ignore-case.txt If it takes a while to fix please revert while you investigate.

Also, https://github.com/llvm/llvm-project/commit/dfd2b6f07fc40a190335f580d8a965bbebfe94df looks like you touched ~all lines in docs/CommandGuide/FileCheck.rst and llvm/include/llvm/Support/FileCheck.h Maybe you converted them to windows line endings? If so, please undo that. (Maybe revert and reland with fixed line endings so that the diff for the actual change is readable.)

As described in http://llvm.org/docs/GettingStarted.html#checkout-llvm-from-git, the right way to checkout the repository on windows is:

% git clone --config core.autocrlf=false https://github.com/llvm/llvm-project.git

This is the second time I've reviewed a change like this without realizing, would appreciate tips if this could be more visible in Phab somehow...

Oct 11 2019, 4:42 AM · Restricted Project

Oct 10 2019

Kai committed rG819f01d917fb: [Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj). (authored by Kai).
[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
Oct 10 2019, 6:29 AM
Kai closed D68693: [Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj)..
Oct 10 2019, 6:28 AM · Restricted Project
Kai committed rGdfd2b6f07fc4: [FileCheck] Implement --ignore-case option. (authored by Kai).
[FileCheck] Implement --ignore-case option.
Oct 10 2019, 6:19 AM
Kai closed D68146: [FileCheck] Implement --ignore-case option..
Oct 10 2019, 6:19 AM · Restricted Project
Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

Updated test case:

Oct 10 2019, 4:14 AM · Restricted Project
Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

Changed description of option.

Oct 10 2019, 2:52 AM · Restricted Project
Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

Added a test for CHECK-SAME and for -implicit-check-not.

Oct 10 2019, 2:03 AM · Restricted Project

Oct 9 2019

Kai added inline comments to D68146: [FileCheck] Implement --ignore-case option..
Oct 9 2019, 9:40 AM · Restricted Project
Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

Added newline at end of test case.

Oct 9 2019, 6:51 AM · Restricted Project
Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

Change single digit in test case to form a sequence.

Oct 9 2019, 6:23 AM · Restricted Project
Kai created D68693: [Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj)..
Oct 9 2019, 4:29 AM · Restricted Project
Kai added a comment to D68146: [FileCheck] Implement --ignore-case option..

To make it really --ignore-case, the pattern should also be changed to lowercase.

Oct 9 2019, 4:27 AM · Restricted Project
Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

Added a test case and documentation for the --ignore-case option.
Removed the changed test cases.

Oct 9 2019, 4:27 AM · Restricted Project

Oct 8 2019

Kai committed rGc9ddda840526: [Tools] Mark output of tools as text if it is text (authored by Kai).
[Tools] Mark output of tools as text if it is text
Oct 8 2019, 1:24 AM
Kai closed D67696: [tools] Mark output of tools as text if it is really text.
Oct 8 2019, 1:24 AM · Restricted Project

Oct 2 2019

Kai updated the diff for D68146: [FileCheck] Implement --ignore-case option..

FileCheck has now a new option --ignore-case.
I updated the test cases to use the new option. I touched only test cases which have the lower case/upper case letter problem. I also did not add -A n because some tests also check for the address.

Oct 2 2019, 6:28 AM · Restricted Project

Oct 1 2019

Kai added a comment to D68146: [FileCheck] Implement --ignore-case option..

Yeah, I agree that this is painful. I'll have a look at FileCheck because this really feels like the right solution.
I am not on AIX but z/OS USS.

Oct 1 2019, 12:54 AM · Restricted Project

Sep 27 2019

Herald added a reviewer for D68146: [FileCheck] Implement --ignore-case option.: alexshap.
Sep 27 2019, 10:30 AM · Restricted Project
Kai committed rGd8e38b9b888b: Change -march=systemz to triple and fix test (authored by Kai).
Change -march=systemz to triple and fix test
Sep 27 2019, 9:19 AM
Kai updated the diff for D67696: [tools] Mark output of tools as text if it is really text.
  • Add OF_Text for opt assembly output
  • Fix RemarkStreamer
  • Use OF_None instead of F_None in new code
Sep 27 2019, 5:07 AM · Restricted Project
Kai created D68129: [SystemZ] Change -march=systemz to triple and fix mature-mc test.
Sep 27 2019, 5:02 AM · Restricted Project

Sep 19 2019

Kai updated the diff for D67696: [tools] Mark output of tools as text if it is really text.

Fixed an error introduced in the previous revision.

Sep 19 2019, 1:02 PM · Restricted Project
Kai added a comment to D67696: [tools] Mark output of tools as text if it is really text.
In D67696#1674254, @rnk wrote:

The main effect that I'm aware of here is that this will do CRLF conversion on Windows. Are we sure we really want that? I just did the opposite to TableGen output in rL371683. In general, I think the majority of tools that write text use OF_Text, so your change makes this minority of tools consistent with the other ones.

Sep 19 2019, 6:37 AM · Restricted Project
Kai updated the diff for D67696: [tools] Mark output of tools as text if it is really text.

Use OF_Text for the RemarkStreamer only if format is YAML.

Sep 19 2019, 6:21 AM · Restricted Project

Sep 18 2019

Kai created D67696: [tools] Mark output of tools as text if it is really text.
Sep 18 2019, 1:15 AM · Restricted Project

Sep 17 2019

Kai abandoned D16506: [cmake/AIX] Enhance cmake files to support compiling with gcc on AIX.

Superceded by latest additions for AIX.

Sep 17 2019, 12:34 PM