Page MenuHomePhabricator

Holman (Michael Holman)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 11 2019, 2:42 PM (75 w, 3 d)

Recent Activity

Wed, Apr 21

Holman added a comment to D99994: [CodeView] Add CodeView support for PGO debug information.

Can someone help me get this checked in?

Wed, Apr 21, 2:14 PM · Restricted Project, Restricted Project

Fri, Apr 9

Holman updated the diff for D99994: [CodeView] Add CodeView support for PGO debug information.

Fix clang-format issue.

Fri, Apr 9, 9:42 AM · Restricted Project, Restricted Project

Thu, Apr 8

Holman updated the diff for D99994: [CodeView] Add CodeView support for PGO debug information.

Add a test

Thu, Apr 8, 4:53 PM · Restricted Project, Restricted Project
Holman updated the diff for D99994: [CodeView] Add CodeView support for PGO debug information.

Get PGO info from Module instead of adding new field to debug info.

Thu, Apr 8, 2:07 PM · Restricted Project, Restricted Project
Holman added a comment to D99994: [CodeView] Add CodeView support for PGO debug information.
In D99994#2677566, @rnk wrote:

IMO it's best to avoid adding fields to DICompileUnit if at all possible. It's the "god object" / "katamari damacy" of module debug info. Is there something about the IR module that indicates if PGO data is present or not? We could check that instead. I looked, but I wasn't able to find anything quickly.

Thu, Apr 8, 1:11 PM · Restricted Project, Restricted Project

Tue, Apr 6

Holman added reviewers for D99994: [CodeView] Add CodeView support for PGO debug information: akhuang, aprantl.
Tue, Apr 6, 3:22 PM · Restricted Project, Restricted Project
Holman requested review of D99994: [CodeView] Add CodeView support for PGO debug information.
Tue, Apr 6, 3:16 PM · Restricted Project, Restricted Project

Jan 29 2021

Holman updated the diff for D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.

Address clang-tidy comment.

Jan 29 2021, 12:34 PM · Restricted Project

Jan 27 2021

Holman added a comment to D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.

Looks like my new test is passing in CI, but Debian CI is failing for some unrelated reason.

Jan 27 2021, 2:12 PM · Restricted Project

Jan 25 2021

Holman updated the diff for D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.

Added a unit test

Jan 25 2021, 12:26 PM · Restricted Project

Jan 21 2021

Holman updated the diff for D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.

Fix shadowing bug.

Jan 21 2021, 1:57 PM · Restricted Project
Holman added a comment to D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.

This needs a test case. See llvm/test/Transforms/ConstantHoisting for existing tests for this pass.

Jan 21 2021, 1:35 PM · Restricted Project
Holman added a comment to D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.
In D95019#2513466, @rnk wrote:

Out of curiosity, have you bisected this to a particular change?

Jan 21 2021, 1:33 PM · Restricted Project
Holman added a comment to D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.

This bug is causing Edge builds to fail when using new builds of Clang, so I would appreciate if someone could please take a look.

Jan 21 2021, 11:44 AM · Restricted Project

Jan 19 2021

Holman requested review of D95019: [ConstantHoisting] Fix bug where constant materialization could insert into EH pad.
Jan 19 2021, 9:27 PM · Restricted Project

Feb 3 2020

Holman added a comment to D73217: [InlineCost] Add flag to allow changing the default inline cost .

Thanks! I don't have commit access, so can someone help me with that?

Feb 3 2020, 10:51 AM · Restricted Project
Holman abandoned D70519: [CMake] use findzlib util to include zlib.

Yup, it looks like that supersedes this change. Closing this one out.

Feb 3 2020, 10:41 AM · Restricted Project

Jan 29 2020

Holman updated the diff for D73217: [InlineCost] Add flag to allow changing the default inline cost .

Added test

Jan 29 2020, 12:07 PM · Restricted Project

Jan 22 2020

Holman created D73217: [InlineCost] Add flag to allow changing the default inline cost .
Jan 22 2020, 10:33 AM · Restricted Project

Nov 26 2019

Holman updated the diff for D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Remove duplicate run command

Nov 26 2019, 9:35 AM · Restricted Project, Restricted Project

Nov 21 2019

Holman updated the diff for D70519: [CMake] use findzlib util to include zlib.

Only use FindZLIB if one of the relevant variables is set.

Nov 21 2019, 4:19 PM · Restricted Project
Holman updated the diff for D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Change tests per review comments

Nov 21 2019, 12:31 PM · Restricted Project, Restricted Project
Holman added a comment to D70519: [CMake] use findzlib util to include zlib.

Ah thanks for the context! Unfortunately, it does change that to -l/usr/lib/x86_64-linux-gnu/libz.so. What do you think if I call FindZLIB if (ZLIB_ROOT OR ZLIB_INCLUDE_DIR OR ZLIB_LIBRARY), and otherwise use the existing loop?

Nov 21 2019, 11:27 AM · Restricted Project

Nov 20 2019

Holman created D70519: [CMake] use findzlib util to include zlib.
Nov 20 2019, 5:02 PM · Restricted Project
Holman updated the diff for D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Add block counts to test

Nov 20 2019, 1:47 PM · Restricted Project, Restricted Project
Holman added inline comments to D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.
Nov 20 2019, 12:33 PM · Restricted Project, Restricted Project
Holman updated the diff for D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Added test for actual profile merge.

Nov 20 2019, 12:05 PM · Restricted Project, Restricted Project

Nov 19 2019

Holman added a comment to D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Do you have commit access, or would you like me to commit on your behalf?

Nov 19 2019, 2:24 PM · Restricted Project, Restricted Project
Holman updated the diff for D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Added Windows test case.

Nov 19 2019, 2:24 PM · Restricted Project, Restricted Project

Nov 18 2019

Holman updated the summary of D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.
Nov 18 2019, 11:53 AM · Restricted Project, Restricted Project
Holman added a comment to D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.

Please reference PR43425 in the patch description. I don't know if the reproducer from there can be used as a test case, but at least it should be possible to use to check this works manually.

Nov 18 2019, 11:26 AM · Restricted Project, Restricted Project

Nov 15 2019

Holman updated the summary of D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.
Nov 15 2019, 12:10 PM · Restricted Project, Restricted Project
Holman created D70330: [profile] Fix file contention causing dropped counts on Windows under -fprofile-generate.
Nov 15 2019, 11:26 AM · Restricted Project, Restricted Project