Page MenuHomePhabricator

FarisRehman (Faris Rehman)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 15 2020, 3:47 AM (10 w, 3 d)

Recent Activity

Fri, Feb 19

FarisRehman committed rG529f71811b04: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options (authored by FarisRehman).
[flang][driver] Add debug measure-parse-tree and pre-fir-tree options
Fri, Feb 19, 3:35 AM
FarisRehman closed D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options.
Fri, Feb 19, 3:35 AM · Restricted Project, Restricted Project
FarisRehman retitled D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options from [flang][driver] Add more -fdebug options to [flang][driver] Add debug measure-parse-tree and pre-fir-tree options.
Fri, Feb 19, 2:26 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options.

Remove -fdebug-parsing-log from this patch as it requires additional work that can be implemented in a separate patch.
Also address review comments by @awarzynski

Fri, Feb 19, 2:25 AM · Restricted Project, Restricted Project

Thu, Feb 18

FarisRehman updated the diff for D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options.

Rebase off main

Thu, Feb 18, 3:50 AM · Restricted Project, Restricted Project
FarisRehman committed rG4bd08dab5ff9: [flang][driver] Add debug dump options (authored by FarisRehman).
[flang][driver] Add debug dump options
Thu, Feb 18, 3:36 AM
FarisRehman closed D96716: [flang][driver] Add debug dump options.
Thu, Feb 18, 3:36 AM · Restricted Project, Restricted Project

Wed, Feb 17

FarisRehman added a comment to D96716: [flang][driver] Add debug dump options.

We need %f18 to be replaced with %flang_fc1, but we don't need -fsyntax-only, right?

Wed, Feb 17, 1:51 PM · Restricted Project, Restricted Project
FarisRehman updated the summary of D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options.
Wed, Feb 17, 11:22 AM · Restricted Project, Restricted Project
FarisRehman added reviewers for D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options: tskeith, AMDChirag, SouraVX, sameeranjoshi, kiranktp.
Wed, Feb 17, 11:16 AM · Restricted Project, Restricted Project
FarisRehman requested review of D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options.
Wed, Feb 17, 11:14 AM · Restricted Project, Restricted Project
FarisRehman added a comment to D96716: [flang][driver] Add debug dump options.

This patch doesn't require the tests to be updated, does it?

Wed, Feb 17, 11:12 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D96716: [flang][driver] Add debug dump options.
Wed, Feb 17, 10:29 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D96716: [flang][driver] Add debug dump options.

Make semantics_ private

Wed, Feb 17, 10:28 AM · Restricted Project, Restricted Project

Tue, Feb 16

FarisRehman added inline comments to D96716: [flang][driver] Add debug dump options.
Tue, Feb 16, 8:15 AM · Restricted Project, Restricted Project
FarisRehman committed rG10826ea7b1c1: [flang][driver] Add extension options and -finput-charset (authored by FarisRehman).
[flang][driver] Add extension options and -finput-charset
Tue, Feb 16, 3:27 AM
FarisRehman closed D96407: [flang][driver] Add extension options and -finput-charset.
Tue, Feb 16, 3:27 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D96407: [flang][driver] Add extension options and -finput-charset.

Rebase off main

Tue, Feb 16, 2:52 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D96716: [flang][driver] Add debug dump options.
Tue, Feb 16, 2:24 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D96716: [flang][driver] Add debug dump options.

Rebase off main

Tue, Feb 16, 2:23 AM · Restricted Project, Restricted Project

Mon, Feb 15

FarisRehman accepted D96483: [flang][driver] Add options for unparsing.

Thanks for clarifying

Mon, Feb 15, 8:14 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D96716: [flang][driver] Add debug dump options.
Mon, Feb 15, 8:12 AM · Restricted Project, Restricted Project
FarisRehman requested review of D96716: [flang][driver] Add debug dump options.
Mon, Feb 15, 8:09 AM · Restricted Project, Restricted Project
FarisRehman added a comment to D96483: [flang][driver] Add options for unparsing.

Thanks for working on this @awarzynski
Could you please clarify the situation regarding GetActionKindName in FrontendOptions.h as it is currently not being used anywhere and this patch currently does not update that method with the 2 new cases.
Other than that, looks good to me!

Mon, Feb 15, 5:52 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D96407: [flang][driver] Add extension options and -finput-charset.
Mon, Feb 15, 5:13 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D96407: [flang][driver] Add extension options and -finput-charset.
Mon, Feb 15, 5:13 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D96407: [flang][driver] Add extension options and -finput-charset.

Address review comment

Mon, Feb 15, 5:12 AM · Restricted Project, Restricted Project
FarisRehman accepted D96528: [flang][f18] Make -fdebug-dump-{symbols|parse-tree} imply -fsyntax-only.

This patch makes sense to me as the behaviour of the new driver is similar to clang in that only the last action-related option is run, e.g:

  • Only -emit-llvm is run in: clang -cc1 -ast-dump -emit-llvm file.c
  • Only -ast-dump is run in: clang -cc1 -emit-llvm -ast-dump file.c

This change will mean -fsyntax-only does not need to be specified when running -fdebug-dump-parse-tree or -fdebug-dump-symbols as it will always be run when either one of these action-related options are present.
LRTM!

Mon, Feb 15, 4:36 AM · Restricted Project, Restricted Project

Wed, Feb 10

FarisRehman updated the summary of D96407: [flang][driver] Add extension options and -finput-charset.
Wed, Feb 10, 4:38 AM · Restricted Project, Restricted Project
FarisRehman requested review of D96407: [flang][driver] Add extension options and -finput-charset.
Wed, Feb 10, 4:34 AM · Restricted Project, Restricted Project
FarisRehman committed rG6d48a1a53fab: [flang][driver] Add support for -fopenmp and -fopenacc (authored by FarisRehman).
[flang][driver] Add support for -fopenmp and -fopenacc
Wed, Feb 10, 2:00 AM
FarisRehman closed D96032: [flang][driver] Add support for -fopenmp and -fopenacc.
Wed, Feb 10, 2:00 AM · Restricted Project, Restricted Project

Tue, Feb 9

FarisRehman added inline comments to D96032: [flang][driver] Add support for -fopenmp and -fopenacc.
Tue, Feb 9, 4:39 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D96032: [flang][driver] Add support for -fopenmp and -fopenacc.

Address review comment

Tue, Feb 9, 4:38 AM · Restricted Project, Restricted Project

Mon, Feb 8

FarisRehman updated the diff for D96032: [flang][driver] Add support for -fopenmp and -fopenacc.

Rebase off main

Mon, Feb 8, 3:40 AM · Restricted Project, Restricted Project

Thu, Feb 4

FarisRehman accepted D95465: [flang][driver] Fix reading from stdin when using `-test-io`.

Thanks for working on this @awarzynski!
I've left a comment on the test but otherwise looks good to me.

Thu, Feb 4, 7:52 AM · Restricted Project, Restricted Project
FarisRehman updated FarisRehman.
Thu, Feb 4, 6:51 AM
FarisRehman updated the summary of D96032: [flang][driver] Add support for -fopenmp and -fopenacc.
Thu, Feb 4, 6:22 AM · Restricted Project, Restricted Project
FarisRehman requested review of D96032: [flang][driver] Add support for -fopenmp and -fopenacc.
Thu, Feb 4, 6:17 AM · Restricted Project, Restricted Project
FarisRehman accepted D95464: [flang][driver] Add PrescanAction frontend action (nfc).

Thanks for working on this @awarzynski, this patch allows actions that do not need to run the prescanner to not do so.
I've left a nit, but otherwise LRTM!

Thu, Feb 4, 5:02 AM · Restricted Project, Restricted Project
FarisRehman committed rG3a1513c142f4: [flang][driver] Add forced form flags and -ffixed-line-length (authored by FarisRehman).
[flang][driver] Add forced form flags and -ffixed-line-length
Thu, Feb 4, 4:24 AM
FarisRehman closed D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Thu, Feb 4, 4:24 AM · Restricted Project, Restricted Project

Tue, Feb 2

FarisRehman added inline comments to D95784: [flang][f18] Replace `-fparse-only` with `-fsyntax-only`.
Tue, Feb 2, 9:18 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Tue, Feb 2, 9:08 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D95460: [flang][driver] Add forced form flags and -ffixed-line-length.

Address review comment

Tue, Feb 2, 9:06 AM · Restricted Project, Restricted Project

Fri, Jan 29

FarisRehman updated the summary of D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Fri, Jan 29, 8:29 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D95460: [flang][driver] Add forced form flags and -ffixed-line-length.

Remove -fno-fixed-form and -fno-free-form

Fri, Jan 29, 8:27 AM · Restricted Project, Restricted Project

Thu, Jan 28

FarisRehman added inline comments to D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Thu, Jan 28, 5:49 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Thu, Jan 28, 5:48 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D95460: [flang][driver] Add forced form flags and -ffixed-line-length.

Address review comment

Thu, Jan 28, 5:34 AM · Restricted Project, Restricted Project

Jan 27 2021

FarisRehman committed rGa8f51ea2120b: [flang][driver] Report prescanning diags during syntax-only parsing (authored by FarisRehman).
[flang][driver] Report prescanning diags during syntax-only parsing
Jan 27 2021, 2:28 AM
FarisRehman closed D95220: [flang][driver] Report prescanning diags during syntax-only parsing.
Jan 27 2021, 2:28 AM · Restricted Project, Restricted Project

Jan 26 2021

FarisRehman updated the summary of D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Jan 26 2021, 10:54 AM · Restricted Project, Restricted Project
FarisRehman requested review of D95460: [flang][driver] Add forced form flags and -ffixed-line-length.
Jan 26 2021, 10:51 AM · Restricted Project, Restricted Project

Jan 25 2021

FarisRehman updated the diff for D95220: [flang][driver] Report prescanning diags during syntax-only parsing.

Add f18 RUN line

Jan 25 2021, 6:16 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D95220: [flang][driver] Report prescanning diags during syntax-only parsing.
Jan 25 2021, 4:52 AM · Restricted Project, Restricted Project
FarisRehman committed rG1c8f199f4499: [flang][driver] Update PP tests to use the new driver (authored by FarisRehman).
[flang][driver] Update PP tests to use the new driver
Jan 25 2021, 4:34 AM
FarisRehman closed D94805: [flang][driver] Update PP tests to use the new driver.
Jan 25 2021, 4:33 AM · Restricted Project, Restricted Project
FarisRehman committed rG8e3adda820e8: [flang][driver] Remove newline in CompilerInvocation (authored by FarisRehman).
[flang][driver] Remove newline in CompilerInvocation
Jan 25 2021, 4:00 AM
FarisRehman updated the diff for D94805: [flang][driver] Update PP tests to use the new driver.

Rename flang-driver to flang

Jan 25 2021, 1:26 AM · Restricted Project, Restricted Project

Jan 22 2021

FarisRehman added reviewers for D95220: [flang][driver] Report prescanning diags during syntax-only parsing: awarzynski, tskeith, sameeranjoshi, AMDChirag, SouraVX, kiranktp.
Jan 22 2021, 4:29 AM · Restricted Project, Restricted Project
FarisRehman requested review of D95220: [flang][driver] Report prescanning diags during syntax-only parsing.
Jan 22 2021, 4:26 AM · Restricted Project, Restricted Project

Jan 20 2021

FarisRehman accepted D95042: [flang][driver] Move fixed/free from detection out of FrontendAction API.

Thanks for working on this @awarzynski

Jan 20 2021, 9:33 AM · Restricted Project, Restricted Project

Jan 19 2021

FarisRehman accepted D94968: [flang][driver] Move isFixedFormSuffix and isFreeFormSuffix to flangFrontend.

I've built the latest main branch with -DBUILD_SHARED_LIBS=On and it failed. Applying this patch has resolved that.
Looks good to me.

Jan 19 2021, 7:29 AM · Restricted Project
FarisRehman added inline comments to D94228: [flang][driver] Support fixed form detection.
Jan 19 2021, 4:07 AM · Restricted Project, Restricted Project

Jan 18 2021

FarisRehman updated the summary of D94516: [flang][driver] Add standard predefinitions.
Jan 18 2021, 3:47 AM · Restricted Project
FarisRehman updated the diff for D94516: [flang][driver] Add standard predefinitions.

Remove target-specific predefinition

Jan 18 2021, 3:46 AM · Restricted Project
FarisRehman updated the summary of D93453: [flang][driver] Add support for `-I`.
Jan 18 2021, 2:44 AM · Restricted Project, Restricted Project

Jan 15 2021

FarisRehman updated the summary of D94805: [flang][driver] Update PP tests to use the new driver.
Jan 15 2021, 10:02 AM · Restricted Project, Restricted Project
FarisRehman requested review of D94805: [flang][driver] Update PP tests to use the new driver.
Jan 15 2021, 10:00 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D94228: [flang][driver] Support fixed form detection.
Jan 15 2021, 8:43 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D94228: [flang][driver] Support fixed form detection.

Add helper methods to Utils

Jan 15 2021, 8:42 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D94228: [flang][driver] Support fixed form detection.
Jan 15 2021, 8:42 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D93453: [flang][driver] Add support for `-I`.
Jan 15 2021, 5:04 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D93453: [flang][driver] Add support for `-I`.

Add include-module test

Jan 15 2021, 5:03 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D93453: [flang][driver] Add support for `-I`.
Jan 15 2021, 5:03 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Jan 15 2021, 1:51 AM · Restricted Project, Restricted Project

Jan 14 2021

FarisRehman updated the diff for D94228: [flang][driver] Support fixed form detection.

Update regression test

Jan 14 2021, 4:26 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D94228: [flang][driver] Support fixed form detection.
Jan 14 2021, 4:24 AM · Restricted Project, Restricted Project
FarisRehman added a comment to D94228: [flang][driver] Support fixed form detection.

I think that it would be useful to add a test like this:
Input name: `input.f:

program ShouldFail
end

Run line:

flang-new -E input.f

This should fail as flang-new will identify the input it as fixed-form, yet the actual file is free form.

Jan 14 2021, 3:51 AM · Restricted Project, Restricted Project

Jan 13 2021

FarisRehman updated the diff for D93453: [flang][driver] Add support for `-I`.

Add a new test

Jan 13 2021, 9:07 AM · Restricted Project, Restricted Project

Jan 12 2021

FarisRehman updated the summary of D94516: [flang][driver] Add standard predefinitions.
Jan 12 2021, 9:42 AM · Restricted Project
FarisRehman updated the summary of D94516: [flang][driver] Add standard predefinitions.
Jan 12 2021, 9:38 AM · Restricted Project
FarisRehman requested review of D94516: [flang][driver] Add standard predefinitions.
Jan 12 2021, 9:37 AM · Restricted Project
FarisRehman updated the summary of D94228: [flang][driver] Support fixed form detection.
Jan 12 2021, 6:28 AM · Restricted Project, Restricted Project

Jan 11 2021

FarisRehman updated the summary of D94228: [flang][driver] Support fixed form detection.
Jan 11 2021, 8:01 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D94228: [flang][driver] Support fixed form detection.

Support more extensions

Jan 11 2021, 8:01 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D94228: [flang][driver] Support fixed form detection.
Jan 11 2021, 7:47 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Jan 11 2021, 3:29 AM · Restricted Project, Restricted Project

Jan 7 2021

FarisRehman added reviewers for D94228: [flang][driver] Support fixed form detection: awarzynski, sameeranjoshi, tskeith, kiranktp, AMDChirag, SouraVX.
Jan 7 2021, 4:50 AM · Restricted Project, Restricted Project
FarisRehman requested review of D94228: [flang][driver] Support fixed form detection.
Jan 7 2021, 4:47 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D93453: [flang][driver] Add support for `-I`.

Rename test files

Jan 7 2021, 3:54 AM · Restricted Project, Restricted Project

Jan 6 2021

FarisRehman updated the diff for D93453: [flang][driver] Add support for `-I`.

Address minor changes in review comments

Jan 6 2021, 8:17 AM · Restricted Project, Restricted Project

Dec 23 2020

FarisRehman updated the diff for D93453: [flang][driver] Add support for `-I`.

Clean up test

Dec 23 2020, 4:55 AM · Restricted Project, Restricted Project
FarisRehman updated the diff for D93401: [flang][driver] Add support for `-D`, `-U`.

Address review comments

Dec 23 2020, 4:15 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D93401: [flang][driver] Add support for `-D`, `-U`.
Dec 23 2020, 3:51 AM · Restricted Project, Restricted Project

Dec 22 2020

FarisRehman updated the diff for D93453: [flang][driver] Add support for `-I`.

Address review comments

Dec 22 2020, 6:15 AM · Restricted Project, Restricted Project

Dec 21 2020

FarisRehman added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Dec 21 2020, 8:02 AM · Restricted Project, Restricted Project
FarisRehman added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Dec 21 2020, 7:57 AM · Restricted Project, Restricted Project
FarisRehman updated the summary of D93401: [flang][driver] Add support for `-D`, `-U`.
Dec 21 2020, 7:53 AM · Restricted Project, Restricted Project