Page MenuHomePhabricator

Esme (EsmeYi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2020, 12:06 AM (63 w, 1 d)

Recent Activity

Today

Esme added inline comments to D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Wed, Jun 23, 3:04 AM · Restricted Project
Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Wed, Jun 23, 3:04 AM · Restricted Project
Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..

Addressed comments.

Wed, Jun 23, 1:56 AM · Restricted Project

Mon, Jun 21

Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Mon, Jun 21, 3:39 AM · Restricted Project
Esme updated the diff for D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..

Addressed comments.

Mon, Jun 21, 3:36 AM · Restricted Project

Sun, Jun 20

Esme committed rG657aa3a7631b: [yaml2obj] Add support for writing the long symbol name. (authored by Esme).
[yaml2obj] Add support for writing the long symbol name.
Sun, Jun 20, 10:11 PM
Esme closed D103455: [yaml2obj] Add support for writing the long symbol name..
Sun, Jun 20, 10:11 PM · Restricted Project
Esme requested review of D104613: [llvm-readobj][XCOFF] Add support for printing the String Table..
Sun, Jun 20, 8:25 PM · Restricted Project

Tue, Jun 15

Esme added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Tue, Jun 15, 8:33 PM · Restricted Project
Esme added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Tue, Jun 15, 8:26 PM · Restricted Project
Esme added inline comments to D103696: [XCOFF][AIX] Add support for XCOFF 64 bit Object files.
Tue, Jun 15, 7:48 PM · Restricted Project

Thu, Jun 10

Esme committed rGec43c1213a16: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants. (authored by Esme).
[NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants.
Thu, Jun 10, 4:11 AM
Esme closed D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..
Thu, Jun 10, 4:11 AM · Restricted Project
Esme committed rGc8e980ab4acc: [XCOFF][llvm-objdump] Dump the debug type in `--section-headers` option. (authored by Esme).
[XCOFF][llvm-objdump] Dump the debug type in `--section-headers` option.
Thu, Jun 10, 12:09 AM
Esme closed D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..
Thu, Jun 10, 12:09 AM · Restricted Project

Wed, Jun 9

Esme committed rG8a23f74eb79f: [llvm-objdump][XCOFF] Enable the -l (--line-numbers) option. (authored by Esme).
[llvm-objdump][XCOFF] Enable the -l (--line-numbers) option.
Wed, Jun 9, 9:38 PM
Esme closed D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..
Wed, Jun 9, 9:38 PM · Restricted Project
Esme added a comment to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

As for the need of testing the string table, I will add such test after llvm-readobj --string-table is implemented.

Wed, Jun 9, 1:48 AM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

This patch introduce https://lab.llvm.org/buildbot/#/builders/85/builds/4886

llvm-project/llvm/lib/ObjectYAML/XCOFFEmitter.cpp:67:16: runtime error: null pointer passed as argument 2, which is declared to never be null
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../x86_64-linux-gnu/include/string.h:43:28: note: nonnull attribute specified here
    #0 0x45c3df in (anonymous namespace)::XCOFFWriter::writeXCOFF() /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/ObjectYAML/XCOFFEmitter.cpp
    #1 0x45b0b1 in llvm::yaml::yaml2xcoff(llvm::XCOFFYAML::Object&, llvm::raw_ostream&, llvm::function_ref<void (llvm::Twine const&)>) /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/ObjectYAML/XCOFFEmitter.cpp:311:17
    #2 0x30a181 in llvm::yaml::convertYAML(llvm::yaml::Input&, llvm::raw_ostream&, llvm::function_ref<void (llvm::Twine const&)>, unsigned int, unsigned long) /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/lib/ObjectYAML/yaml2obj.cpp:48:14
    #3 0x306322 in main /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm-project/llvm/tools/yaml2obj/yaml2obj.cpp:136:8
    #4 0x7f38e52b709a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2409a)
    #5 0x2eafd9 in _start (/b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm_build_ubsan/bin/yaml2obj+0x2eafd9)

CC @eugenis

Wed, Jun 9, 1:45 AM · Restricted Project
Esme added a comment to D103455: [yaml2obj] Add support for writing the long symbol name..

Addressed comments except dumping the raw string table.
It seems llvm-readobj can't dump the raw string table for XCOFF, I have to find another tool to do this.

I think it would make a lot of sense to add string table dumping to llvm-readobj. It's generic enough that you could probably get away with implementing it for multiple file formats too (e.g. for ELF it would dump all SHT_STRTAB sections), but initially, you can just implement it for XCOFF. I'd use a switch name as simple as --string-table or possibly --string-tables.

Wed, Jun 9, 1:29 AM · Restricted Project
Esme updated the diff for D103455: [yaml2obj] Add support for writing the long symbol name..
Wed, Jun 9, 1:29 AM · Restricted Project
Esme committed rG699231ab3c7d: Fix the 4203-Buildbot failure in LLVM Buildbot on llvm-clang-win-x-aarch64 (authored by Esme).
Fix the 4203-Buildbot failure in LLVM Buildbot on llvm-clang-win-x-aarch64
Wed, Jun 9, 12:24 AM

Tue, Jun 8

Esme updated the diff for D103455: [yaml2obj] Add support for writing the long symbol name..

Rebase.

Tue, Jun 8, 11:39 PM · Restricted Project
Esme committed rG955bc5950b45: Remove white space in llvm-objdump/XCOFF/section-headers.test (authored by Esme).
Remove white space in llvm-objdump/XCOFF/section-headers.test
Tue, Jun 8, 10:39 PM
Esme added inline comments to D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
Tue, Jun 8, 8:27 PM · Restricted Project
Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Rebase.

Tue, Jun 8, 8:16 PM · Restricted Project
Esme updated the diff for D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..

Addressed comments.

Tue, Jun 8, 8:14 PM · Restricted Project
Esme committed rGdb4ac5a63e11: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of… (authored by Esme).
[NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of…
Tue, Jun 8, 8:12 PM
Esme closed D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..
Tue, Jun 8, 8:12 PM · Restricted Project
Esme updated the diff for D103455: [yaml2obj] Add support for writing the long symbol name..

Addressed comments except dumping the raw string table.
It seems llvm-readobj can't dump the raw string table for XCOFF, I have to find another tool to do this.

Tue, Jun 8, 8:46 AM · Restricted Project
Esme requested review of D103901: [NFC][XCOFF] Replace structs FileHeader32/SectionHeader32 with constants..
Tue, Jun 8, 8:37 AM · Restricted Project
Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Rebase.

Tue, Jun 8, 8:25 AM · Restricted Project

Mon, Jun 7

Esme committed rG310d2b4957c8: [yaml2obj] Fix buildbot-issue-4886 (authored by Esme).
[yaml2obj] Fix buildbot-issue-4886
Mon, Jun 7, 8:04 PM

Sun, Jun 6

Esme committed rGbcb20aa7701d: Fixed the build failure of yaml2obj in XCOFFEmitter.cpp: (authored by Esme).
Fixed the build failure of yaml2obj in XCOFFEmitter.cpp:
Sun, Jun 6, 10:49 PM
Esme committed rG50bb1b930dbc: [yaml2obj] Initial the support of yaml2obj for 32-bit XCOFF. (authored by Esme).
[yaml2obj] Initial the support of yaml2obj for 32-bit XCOFF.
Sun, Jun 6, 9:15 PM
Esme closed D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Sun, Jun 6, 9:15 PM · Restricted Project

Fri, Jun 4

Esme committed rGfbfd71719767: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict… (authored by Esme).
[Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict…
Fri, Jun 4, 1:16 AM
Esme closed D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF..
Fri, Jun 4, 1:15 AM · Restricted Project

Wed, Jun 2

Esme updated the diff for D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF..

Address comments

Wed, Jun 2, 11:19 PM · Restricted Project

Tue, Jun 1

Esme requested review of D103455: [yaml2obj] Add support for writing the long symbol name..
Tue, Jun 1, 6:00 AM · Restricted Project

Mon, May 31

Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Mon, May 31, 2:37 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Address comment.

Mon, May 31, 2:37 AM · Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Mon, May 31, 12:59 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
  1. Addressed Zheng's comments.
  2. Set more fields optional and modified the correspond testing.
Mon, May 31, 12:58 AM · Restricted Project

Sun, May 30

Esme added inline comments to D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
Sun, May 30, 7:58 PM · Restricted Project
Esme updated the diff for D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
  1. Address comment.
  2. Rebase on D85774 and D95505.
Sun, May 30, 7:58 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
  1. Drop the useless Symbol test.
  2. Add normalization/denormalization for the Section Flags set.
Sun, May 30, 7:25 PM · Restricted Project

Thu, May 27

Esme requested review of D103300: [Debug-Info] handle DW_CC_pass_by_value/DW_CC_pass_by_reference under strict DWARF..
Thu, May 27, 10:12 PM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Hi @jasonliu @DiggerLin @sfertile @shchenz @hubert.reinterpretcast, I would appreciate it if you could review this patch and check if the file format is written properly in your opinion. Thanks in advance!

Thu, May 27, 8:27 PM · Restricted Project

Wed, May 26

Esme committed rGd82f2a123f9c: [llvm-objdump] Print the DEBUG type under `--section-headers`. (authored by Esme).
[llvm-objdump] Print the DEBUG type under `--section-headers`.
Wed, May 26, 9:54 PM
Esme closed D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
Wed, May 26, 9:54 PM · Restricted Project
Esme added inline comments to D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..
Wed, May 26, 3:28 AM · Restricted Project
Esme updated the diff for D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..

Address comment.

Wed, May 26, 3:28 AM · Restricted Project
Esme updated the diff for D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..
Wed, May 26, 2:57 AM · Restricted Project
Esme updated the diff for D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..

Address comment.

Wed, May 26, 2:56 AM · Restricted Project
Esme requested review of D103146: [NFC][XCOFF] Use yaml2obj in llvm-objdump/XCOFF/section-headers.test instead of binary files..
Wed, May 26, 2:54 AM · Restricted Project
Esme committed rGbf809cd165f4: [NFC][object] Change the input parameter of the method isDebugSection. (authored by Esme).
[NFC][object] Change the input parameter of the method isDebugSection.
Wed, May 26, 1:48 AM
Esme closed D102601: [NFC][object] Change the input parameter of the method isDebugSection..
Wed, May 26, 1:48 AM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Could you at least test manually the max section limit case.

Wed, May 26, 12:06 AM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Leave the StringTable as a follow-up work.

Wed, May 26, 12:05 AM · Restricted Project

Tue, May 25

Esme updated the diff for D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..
Tue, May 25, 4:16 AM · Restricted Project
Esme requested review of D103079: [XCOFF] [llvm-objdump] Add XCOFF recognition of debug section types under `--section-headers` option..
Tue, May 25, 4:15 AM · Restricted Project
Esme added a comment to D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..

Seems to me like this is two separate patches now: 1) adding generic DEBUG printing support to llvm-objdump, then 2) adding XCOFF recognition of debug section types.

Tue, May 25, 2:53 AM · Restricted Project
Esme updated the diff for D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
Tue, May 25, 2:52 AM · Restricted Project

Mon, May 24

Esme added inline comments to D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
Mon, May 24, 11:25 PM · Restricted Project
Esme updated the diff for D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..

Address comment.

Mon, May 24, 11:25 PM · Restricted Project
Esme updated the diff for D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..

Format.

Mon, May 24, 9:52 PM · Restricted Project
Esme added a comment to D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
Mon, May 24, 9:20 PM · Restricted Project
Esme updated the diff for D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..

Address comments.

Mon, May 24, 9:20 PM · Restricted Project
Esme added a comment to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

I've taken another look and think you need a fair bit more testing.

  1. You need to show that all the fields can be specified explicitly. Currently, you only do it for a subset of the fields.
  2. You probably should show that all the flags are supported.
  3. You need to test your error paths, to show that the errors are reported properly.
  4. If you don't need the string table support in the initial patch (and by my understanding you don't), you can move all the related logic into another indepenedent patch, and then ensure it is properly tested there.
  5. I think you need testing for undef and abs symbols too,
  6. I think you need testing for non data/text/bss sections (with their zero addresses).
Mon, May 24, 8:47 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Mon, May 24, 8:46 PM · Restricted Project

May 24 2021

Esme updated the diff for D102601: [NFC][object] Change the input parameter of the method isDebugSection..

Address comment.

May 24 2021, 12:20 AM · Restricted Project

May 18 2021

Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Addressed comments.

May 18 2021, 8:16 PM · Restricted Project
Esme updated the diff for D102601: [NFC][object] Change the input parameter of the method isDebugSection..

Address comments.

May 18 2021, 5:31 AM · Restricted Project

May 17 2021

Esme added a comment to D102601: [NFC][object] Change the input parameter of the method isDebugSection..

You added implementation of XCOFFObjectFile::isDebugSection, which does not exist before your patch (besides, its implementation is not as 'trivial' as others). Are you sure this is an NFC?

May 17 2021, 8:01 AM · Restricted Project
Esme requested review of D102603: [llvm-objdump] Print the DEBUG type under `--section-headers`..
May 17 2021, 2:58 AM · Restricted Project
Esme added a reviewer for D102601: [NFC][object] Change the input parameter of the method isDebugSection.: shchenz.
May 17 2021, 2:15 AM · Restricted Project
Esme requested review of D102601: [NFC][object] Change the input parameter of the method isDebugSection..
May 17 2021, 2:15 AM · Restricted Project

May 16 2021

Esme updated the diff for D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

Addressed comment.

May 16 2021, 7:52 PM · Restricted Project

May 13 2021

Esme added a comment to D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

There seem to be quite a few new code paths added in this patch, and I'm not convinced they are all tested? Please add the necessary testing.

It appears that the --line-numbers option can't cover these paths.
I would be very grateful if you have any suggestions for adding tests, or find any examples I can follow. Thanks!

For the parts that aren't required and can't be exercised at all, it seems like you should be able to just leave them out? For those parts that are required, you could add gtest unit testing to cover them. See llvm/unittest/Object for some examples.

May 13 2021, 8:00 PM · Restricted Project
Esme updated the diff for D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..
May 13 2021, 8:00 PM · Restricted Project

May 9 2021

Esme added a comment to D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

There seem to be quite a few new code paths added in this patch, and I'm not convinced they are all tested? Please add the necessary testing.

May 9 2021, 11:43 PM · Restricted Project

May 6 2021

Esme added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
May 6 2021, 7:41 PM · Restricted Project
Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Addressed James's comments.

May 6 2021, 7:41 PM · Restricted Project

Apr 29 2021

Esme updated the diff for D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

Thanks for your review @Higuoxing.

Apr 29 2021, 10:03 PM · Restricted Project
Esme updated the diff for D97656: [llvm-objcopy] Initial XCOFF32 support..

Rebase on D85774.

Apr 29 2021, 9:41 PM · Restricted Project

Apr 28 2021

Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Added the ability to specify multiple flags.

Apr 28 2021, 12:59 AM · Restricted Project

Apr 27 2021

Esme updated the diff for D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

Addressed Mask's comment, i.e added the lit.local.cfg.

Apr 27 2021, 10:26 PM · Restricted Project

Apr 25 2021

Esme updated the diff for D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..

Updated test cases.

Apr 25 2021, 11:19 PM · Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Apr 25 2021, 8:20 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Used the enum SectionTypeFlags to represent the set of flags.

Apr 25 2021, 8:19 PM · Restricted Project
Esme abandoned D100440: [Debug-Info] DW_AT_export_symbols shouldn't be generated before version-5 of DWARF..
Apr 25 2021, 6:41 PM · debug-info, Restricted Project
Esme requested review of D101272: [llvm-objdump][XCOFF][AIX] Enable the -l (--line-numbers) option..
Apr 25 2021, 6:27 PM · Restricted Project
Esme added inline comments to D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..
Apr 25 2021, 5:55 PM · Restricted Project
Esme updated the diff for D95505: [yaml2obj] Initial support for 32-bit XCOFF in yaml2obj..

Addressed James's comments.

Apr 25 2021, 5:54 PM · Restricted Project

Apr 20 2021

Esme updated the diff for D100440: [Debug-Info] DW_AT_export_symbols shouldn't be generated before version-5 of DWARF..

use strict dwarf flag instead of DBX debugger

Apr 20 2021, 3:53 AM · debug-info, Restricted Project

Apr 19 2021

Esme added a comment to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.

Hi Jason, what's your plan about the patch? When will you move forward with it?
Currently D100375 relies on the patch for its 64-bit llvm-readobj. In additional, D97656, D99164 and D98003 should be rebased on it.
Besides, I would like to add support for the line number dump in llvm-objdump if this patch is ready.
It looks like this is a fundamental patch for tools implementation. And it looks good except for some comments haven't been addressed yet.
Please let me know if I can be of any help. Thanks!

Apr 19 2021, 1:17 AM · Restricted Project

Apr 18 2021

Esme added inline comments to D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..
Apr 18 2021, 8:29 PM · Restricted Project
Esme updated the diff for D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF..

Addressed Higuoxing's comments.

Apr 18 2021, 8:29 PM · Restricted Project

Apr 16 2021

Esme updated the diff for D100440: [Debug-Info] DW_AT_export_symbols shouldn't be generated before version-5 of DWARF..

Addressed Zheng's comments.

Apr 16 2021, 6:18 AM · debug-info, Restricted Project