- User Since
- Nov 18 2019, 2:20 AM (44 w, 3 d)
May 5 2020
@vitalybuka Thank you for your review. Also, I do not have commit access, so someone else needs to commit the change for me.
Apr 26 2020
Apr 17 2020
The failure in the CI does not appear to be related to my change, but to an infrastructure problem. At least that is what it looks like.
Jan 27 2020
Jan 26 2020
@mehdi_amini Thank you for your review. I wanted to let you know that I do not have commit access, so someone else should commit this change for me. In addition, I think that this change could be backported to older LLVM releases, at least those that still get bugfixes. The bug addressed here is around since LLVM 5 it seems, as discussed here: https://bugs.llvm.org/show_bug.cgi?id=39321
removeGlobalExtension now early-exits when GlobalExtensions is not constructed and uses llvm::find_if to iterate over the collection.
Jan 24 2020
Jan 17 2020
Jan 10 2020
Dec 29 2019
I have added comments to explain the reason of some of the changes and added an assert so that, if the removeGlobalExtension function is called with an invalid ID, the error will be more noticeable.