Page MenuHomePhabricator

EdB (Serge Martin)
User

Projects

User does not belong to any projects.

User Details

User Since
Thu, Jul 23, 2:46 AM (2 w, 6 d)

Recent Activity

Sun, Aug 2

EdB updated the diff for D84392: libclc: add printf support on amd target.

Add printf declaration to generic include
Move implementation part to amdgcn subdir
Add CL 1.2 flag to support variadic arguments

Sun, Aug 2, 4:34 AM
EdB retitled D84392: libclc: add printf support on amd target from libclc: add printf to amd to libclc: add printf support on amd target.
Sun, Aug 2, 4:30 AM

Thu, Jul 23

EdB added a comment to D84392: libclc: add printf support on amd target.
In D84392#2170911, @EdB wrote:

clang already emits an expansion for printf using the hostcall mechanism. This seems to be doing something different, so I'm not sure where it's going

Really I would prefer if this just cloned rocm-device-libs. The backend doesn't need to maintain two ABIs for dnot

the main difference is atomic usage (I use those already in liclc), implict arg pos and asking to set the offset to 8 at buffer init instead of adding 8 on every call.
I can easily change the last 2

Thu, Jul 23, 4:11 PM
EdB added a comment to D84392: libclc: add printf support on amd target.

clang already emits an expansion for printf using the hostcall mechanism. This seems to be doing something different, so I'm not sure where it's going

Really I would prefer if this just cloned rocm-device-libs. The backend doesn't need to maintain two ABIs for dnot

Thu, Jul 23, 4:02 PM
EdB added a comment to D84392: libclc: add printf support on amd target.

clang already emits an expansion for printf using the hostcall mechanism. This seems to be doing something different, so I'm not sure where it's going

Thu, Jul 23, 2:01 PM
EdB added a comment to D84392: libclc: add printf support on amd target.

I don't think there are many benefits in merging this ahead of time without the rest of printf implementation so that it can be tested.

Thu, Jul 23, 1:57 PM
EdB removed a project from D84392: libclc: add printf support on amd target: Restricted Project.
Thu, Jul 23, 2:55 AM
EdB created D84392: libclc: add printf support on amd target.
Thu, Jul 23, 2:54 AM