Page MenuHomePhabricator

CaseyCarter (Casey Carter)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2016, 4:53 PM (222 w, 2 d)

Recent Activity

Mon, Oct 19

CaseyCarter committed rGa668ad92d5e2: [libc++][test] MSVC has no __PRETTY_FUNCTION__ (authored by CaseyCarter).
[libc++][test] MSVC has no __PRETTY_FUNCTION__
Mon, Oct 19, 5:21 PM
CaseyCarter committed rG7f82352a2c76: [libc++][test] Test nonconforming atomic_fetch_XXX overloads only on libc++ (authored by CaseyCarter).
[libc++][test] Test nonconforming atomic_fetch_XXX overloads only on libc++
Mon, Oct 19, 5:20 PM
CaseyCarter committed rGf92d874fe585: [libc++][test] Silence MSVC "comparison of signed and unsigned" warning (authored by CaseyCarter).
[libc++][test] Silence MSVC "comparison of signed and unsigned" warning
Mon, Oct 19, 5:19 PM
CaseyCarter committed rGd5971a63ca32: [libc++][test] test allocator<const T> extension only on libc++ (authored by CaseyCarter).
[libc++][test] test allocator<const T> extension only on libc++
Mon, Oct 19, 5:15 PM
CaseyCarter committed rG877766573b21: [libc++][test] Don't violate precondition [atomics.flag]/6 (authored by CaseyCarter).
[libc++][test] Don't violate precondition [atomics.flag]/6
Mon, Oct 19, 5:14 PM
CaseyCarter committed rGdccc742c2257: [libc++][test] atomic<T> requires trivially copyable T (authored by CaseyCarter).
[libc++][test] atomic<T> requires trivially copyable T
Mon, Oct 19, 5:14 PM
CaseyCarter committed rGfce9ca3c1e3a: [libc++][test] Pass correct ordering to std::merge (authored by CaseyCarter).
[libc++][test] Pass correct ordering to std::merge
Mon, Oct 19, 5:13 PM
CaseyCarter committed rG24ab5787b444: [libc++][test] Spell "TEST_CONSTEXPR_CXX17" correctly (authored by CaseyCarter).
[libc++][test] Spell "TEST_CONSTEXPR_CXX17" correctly
Mon, Oct 19, 5:11 PM
CaseyCarter committed rGb20918997ae5: [libc++][test] Portably silence warnings (authored by CaseyCarter).
[libc++][test] Portably silence warnings
Mon, Oct 19, 8:34 AM

Sat, Oct 17

CaseyCarter added inline comments to D89588: [libcxx] [test] Avoid conflicting definitions of _CRT_SECURE_NO_WARNINGS.
Sat, Oct 17, 5:07 PM · Restricted Project

Fri, Oct 16

CaseyCarter added inline comments to D89588: [libcxx] [test] Avoid conflicting definitions of _CRT_SECURE_NO_WARNINGS.
Fri, Oct 16, 6:32 PM · Restricted Project

Mon, Sep 28

CaseyCarter added inline comments to D88131: adds [concepts.arithmetic].
Mon, Sep 28, 2:29 PM · Restricted Project

Sep 11 2020

CaseyCarter accepted D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.

LGTM! (You should say "Partially implements P0896R4" in the commit log =))

Sep 11 2020, 5:26 PM · Restricted Project

Sep 10 2020

CaseyCarter added a comment to D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.

Ah, I see it. I'll add that bit to libc++ so we don't need special casing in the tests.

Sep 10 2020, 8:51 AM · Restricted Project
CaseyCarter added a comment to D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.

What paper is this? I searched but failed to find a paper this falls off from.

Sep 10 2020, 8:46 AM · Restricted Project
CaseyCarter requested review of D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20.
Sep 10 2020, 8:27 AM · Restricted Project

Aug 18 2020

CaseyCarter added a comment to D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734".

I'm not going to "request changes" since I don't want you to feel like I'm asking for a novel on trivial special member functions. I'm just going to "comment" and race out of the review before someone asks me to do work ;)

Aug 18 2020, 12:00 AM · Restricted Project

Jun 15 2020

CaseyCarter committed rGd66428cb995c: [lit] Allow for tests to have non-parsed requirements (authored by CaseyCarter).
[lit] Allow for tests to have non-parsed requirements
Jun 15 2020, 5:09 PM
CaseyCarter closed D81782: [lit] Allow for tests to have non-parsed requirements.
Jun 15 2020, 5:09 PM · Restricted Project
CaseyCarter added a comment to D81782: [lit] Allow for tests to have non-parsed requirements.

Thanks for the help, Louis!

Jun 15 2020, 5:08 PM · Restricted Project
CaseyCarter added inline comments to D81782: [lit] Allow for tests to have non-parsed requirements.
Jun 15 2020, 4:02 PM · Restricted Project
CaseyCarter updated the diff for D81782: [lit] Allow for tests to have non-parsed requirements.
  • Remove copy-pasta from RUN line in unparsed-requirements.py.
  • Simplify code with +=
  • Complete test coverage
  • Change line endings to LF in new files
Jun 15 2020, 4:02 PM · Restricted Project
CaseyCarter updated the diff for D81782: [lit] Allow for tests to have non-parsed requirements.

Hack together test.

Jun 15 2020, 1:46 PM · Restricted Project
CaseyCarter added a comment to D81782: [lit] Allow for tests to have non-parsed requirements.

I attempted to address everything. The test may be terrible - I've used LIT casually but never peeked inside until yesterday - so please don't refrain from telling me how to improve it.

Jun 15 2020, 1:46 PM · Restricted Project
CaseyCarter updated the diff for D81782: [lit] Allow for tests to have non-parsed requirements.

Partially address review comments.

Jun 15 2020, 12:37 PM · Restricted Project

Jun 12 2020

CaseyCarter created D81782: [lit] Allow for tests to have non-parsed requirements.
Jun 12 2020, 7:22 PM · Restricted Project
CaseyCarter committed rG8b828e983868: [libcxx][test] Silence MSVC signed-to-unsigned implicit conversion warnings (authored by CaseyCarter).
[libcxx][test] Silence MSVC signed-to-unsigned implicit conversion warnings
Jun 12 2020, 3:24 PM
CaseyCarter committed rG6ffa6a300d36: [libcxx][test] include <algorithm> for is_permutation (authored by CaseyCarter).
[libcxx][test] include <algorithm> for is_permutation
Jun 12 2020, 12:07 PM

Jun 10 2020

CaseyCarter committed rG24836f8cd069: [libcxx][test] MSVC's __is_trivially_copyable is fixed in VS 16.7 (authored by CaseyCarter).
[libcxx][test] MSVC's __is_trivially_copyable is fixed in VS 16.7
Jun 10 2020, 2:29 PM

May 15 2020

CaseyCarter committed rG634a0acb307d: Cleanup some test issues: (authored by CaseyCarter).
Cleanup some test issues:
May 15 2020, 3:16 PM
CaseyCarter closed D80030: [libc++][test] cleanup some small test issues.
May 15 2020, 3:16 PM · Restricted Project
CaseyCarter added inline comments to D80030: [libc++][test] cleanup some small test issues.
May 15 2020, 2:42 PM · Restricted Project
CaseyCarter created D80030: [libc++][test] cleanup some small test issues.
May 15 2020, 1:37 PM · Restricted Project

May 12 2020

CaseyCarter committed rG2c861e8a121e: [libc++][test] Properly mark libc++-only XFAILs (authored by CaseyCarter).
[libc++][test] Properly mark libc++-only XFAILs
May 12 2020, 4:12 PM

May 8 2020

CaseyCarter closed D60951: [libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>.

To be clear, I'm trying to move the test suite towards a generic conformance test suite for the Standard, as opposed to a libc++ test suite that happens to be usable by other Standard Libraries. This change highlights that philosophy.

May 8 2020, 6:24 AM
CaseyCarter committed rG197f18527456: [libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t> (authored by CaseyCarter).
[libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>
May 8 2020, 6:24 AM

May 7 2020

CaseyCarter updated the diff for D60951: [libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>.
  • Guard tests for components that libc++ doesn't implement with // UNSUPPORTED: libc++ and an appropriate comment.
May 7 2020, 11:55 AM
CaseyCarter committed rG8615ce246d1c: [libc++][test] Adjust move_iterator tests to allow C++20 (authored by CaseyCarter).
[libc++][test] Adjust move_iterator tests to allow C++20
May 7 2020, 10:14 AM
CaseyCarter closed D79343: [libc++][test] Adjust move_iterator tests to allow C++20.
May 7 2020, 10:14 AM · Restricted Project
CaseyCarter added a comment to D79343: [libc++][test] Adjust move_iterator tests to allow C++20.

Regarding the formatting changes, I personally think we should clang-format all of libc++, libc++abi and libunwind in one go. Then we'd be done with these small issues that add up. And we can even add the revision to .git-blame-ignore-revs.

May 7 2020, 10:14 AM · Restricted Project

May 6 2020

CaseyCarter added a comment to D79343: [libc++][test] Adjust move_iterator tests to allow C++20.

Format issues addressed.

May 6 2020, 4:30 PM · Restricted Project
CaseyCarter updated the diff for D79343: [libc++][test] Adjust move_iterator tests to allow C++20.

clang-format new/changed sections of code per policy.

May 6 2020, 4:30 PM · Restricted Project
CaseyCarter added a comment to D79343: [libc++][test] Adjust move_iterator tests to allow C++20.

I'm not going to reformat *only* my additions per the clang-format instructions - that would be silly - and I suspect that folks would clang-format all of the tests if they actually wanted them formatted, so I won't format the entire file, either.

May 6 2020, 2:09 PM · Restricted Project

May 4 2020

CaseyCarter abandoned D60951: [libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>.
May 4 2020, 11:15 AM
CaseyCarter abandoned D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
May 4 2020, 11:15 AM
CaseyCarter abandoned D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
May 4 2020, 11:15 AM
CaseyCarter abandoned D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference.
May 4 2020, 11:15 AM
CaseyCarter created D79343: [libc++][test] Adjust move_iterator tests to allow C++20.
May 4 2020, 11:15 AM · Restricted Project

May 3 2020

CaseyCarter committed rG7e3ef299cb3f: [libc++][test] Use a non-narrowing conversion in assign_pair.pass.cpp (authored by CaseyCarter).
[libc++][test] Use a non-narrowing conversion in assign_pair.pass.cpp
May 3 2020, 11:09 AM

Apr 28 2020

CaseyCarter committed rG68b30bc02b3a: [NFC] Correct spelling of "ambiguous" (authored by CaseyCarter).
[NFC] Correct spelling of "ambiguous"
Apr 28 2020, 3:08 PM

Apr 27 2020

CaseyCarter committed rGb4437992ecce: [libc++][test] Disable test for extension that's unsupportable in C++20 (authored by CaseyCarter).
[libc++][test] Disable test for extension that's unsupportable in C++20
Apr 27 2020, 1:30 PM
CaseyCarter closed D78944: [libc++][test] Disable test for extension that's unsupportable in C++20.
Apr 27 2020, 1:30 PM · Restricted Project
CaseyCarter updated the diff for D78944: [libc++][test] Disable test for extension that's unsupportable in C++20.

Review comments.

Apr 27 2020, 11:49 AM · Restricted Project
CaseyCarter created D78944: [libc++][test] Disable test for extension that's unsupportable in C++20.
Apr 27 2020, 10:11 AM · Restricted Project

Apr 11 2020

CaseyCarter committed rG470eb62d7bcd: [libc++][test] Silence "unused variable" warning (authored by CaseyCarter).
[libc++][test] Silence "unused variable" warning
Apr 11 2020, 12:15 PM

Apr 2 2020

CaseyCarter committed rGea3152bb3d35: [libc++][test] Partially revert msvc_stdlib_force_include.h _Pragma change (authored by CaseyCarter).
[libc++][test] Partially revert msvc_stdlib_force_include.h _Pragma change
Apr 2 2020, 1:34 PM
CaseyCarter committed rG0e3a8a6f3462: [libc++][test] Update _LIBCPP_SUPPRESS_DEPRECATED_(PUSH|POP) (authored by CaseyCarter).
[libc++][test] Update _LIBCPP_SUPPRESS_DEPRECATED_(PUSH|POP)
Apr 2 2020, 8:07 AM

Mar 16 2020

CaseyCarter committed rG360911096755: Implement _LIBCPP_SUPPRESS_DEPRECATED_XXX when testing MSVC's STL (authored by CaseyCarter).
Implement _LIBCPP_SUPPRESS_DEPRECATED_XXX when testing MSVC's STL
Mar 16 2020, 10:22 AM

Feb 19 2020

CaseyCarter added inline comments to D74292: [libcxx] adds [concept.derived].
Feb 19 2020, 7:55 AM

Feb 14 2020

CaseyCarter resigned from D74291: [libcxx] Adds [concept.same].

LGTM. I'll resign rather than approving so the "real" approvers won't be confused and never look at this.

Feb 14 2020, 3:15 AM

Feb 9 2020

CaseyCarter requested changes to D74291: [libcxx] Adds [concept.same].

Missing a bunch of "Add a new header" changes (https://github.com/llvm/llvm-project/blob/master/libcxx/NOTES.TXT#L19-L29).

Feb 9 2020, 8:29 AM

Jan 29 2020

CaseyCarter abandoned D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++.

@STL_MSFT seems to have already fixed this by removing the problem test cases in bf7dc572f199007cbe042d5ea41bcf873dcedd8f. I'll simply abandon this change.

Jan 29 2020, 5:18 PM

Jan 7 2020

CaseyCarter resigned from D71994: SFINAE span default constructor on Extent == 0.

LGTM. (Resigning as reviewer rather than approving to avoid confusing the folks who are actually authorized to approve.)

Jan 7 2020, 10:14 AM · Restricted Project
CaseyCarter requested changes to D71994: SFINAE span default constructor on Extent == 0.
Jan 7 2020, 9:18 AM · Restricted Project

Nov 11 2019

CaseyCarter created D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++.
Nov 11 2019, 1:25 PM

Oct 23 2019

CaseyCarter committed rG689ce810598b: [libc++][NFC] Remove excess trailing newlines from most files (authored by CaseyCarter).
[libc++][NFC] Remove excess trailing newlines from most files
Oct 23 2019, 8:14 AM

Oct 22 2019

CaseyCarter resigned from D68952: Guard against possible overflow in span.subpan.

(I'm not sure how to withdraw my "Request Changes" without approving - I'm not an authorized approver for libc++ - so I'll "Resign as Reviewer" and see if my red X goes away.)

Oct 22 2019, 12:39 PM
CaseyCarter added inline comments to D68952: Guard against possible overflow in span.subpan.
Oct 22 2019, 12:39 PM

Oct 21 2019

CaseyCarter added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 21 2019, 9:11 AM · Restricted Project

Oct 20 2019

CaseyCarter requested changes to D68952: Guard against possible overflow in span.subpan.
Oct 20 2019, 9:01 PM
CaseyCarter added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 20 2019, 6:32 PM · Restricted Project

Oct 14 2019

CaseyCarter committed rG6f0768f64da3: [libc++][test] Use <version> to get config on MSVC (authored by CaseyCarter).
[libc++][test] Use <version> to get config on MSVC
Oct 14 2019, 5:28 PM
CaseyCarter committed rL374854: [libc++][test] Use <version> to get config on MSVC.
[libc++][test] Use <version> to get config on MSVC
Oct 14 2019, 5:28 PM
CaseyCarter committed rGfcad66f165a7: [libc++][test] Portability fix for std::any tests (authored by CaseyCarter).
[libc++][test] Portability fix for std::any tests
Oct 14 2019, 12:09 PM
CaseyCarter committed rL374806: [libc++][test] Portability fix for std::any tests.
[libc++][test] Portability fix for std::any tests
Oct 14 2019, 12:09 PM
CaseyCarter committed rGc86ba5818833: [libc++][test] Add license headers to test/support/archetypes.* (authored by CaseyCarter).
[libc++][test] Add license headers to test/support/archetypes.*
Oct 14 2019, 11:02 AM
CaseyCarter committed rL374797: [libc++][test] Add license headers to test/support/archetypes.*.
[libc++][test] Add license headers to test/support/archetypes.*
Oct 14 2019, 11:02 AM
CaseyCarter closed D68947: [libc++][test] Add license headers to test/support/archetypes.*.
Oct 14 2019, 11:02 AM · Restricted Project
CaseyCarter created D68947: [libc++][test] Add license headers to test/support/archetypes.*.
Oct 14 2019, 9:20 AM · Restricted Project
CaseyCarter committed rGa4f07b4d2e8d: [libc++][test] Silence more warnings in variant tests (authored by CaseyCarter).
[libc++][test] Silence more warnings in variant tests
Oct 14 2019, 7:38 AM
CaseyCarter committed rL374778: [libc++][test] Silence more warnings in variant tests.
[libc++][test] Silence more warnings in variant tests
Oct 14 2019, 7:38 AM

Oct 13 2019

CaseyCarter committed rG80e088e14171: [libc++][test] std::variant test cleanup (authored by CaseyCarter).
[libc++][test] std::variant test cleanup
Oct 13 2019, 9:52 AM
CaseyCarter committed rG1f92d8b5449f: [libc++][test] <=> now has a feature-test macro (authored by CaseyCarter).
[libc++][test] <=> now has a feature-test macro
Oct 13 2019, 9:51 AM
CaseyCarter committed rL374723: [libc++][test] std::variant test cleanup.
[libc++][test] std::variant test cleanup
Oct 13 2019, 9:51 AM
CaseyCarter committed rL374722: [libc++][test] <=> now has a feature-test macro.
[libc++][test] <=> now has a feature-test macro
Oct 13 2019, 9:51 AM

Oct 12 2019

CaseyCarter committed rGe198823b87b2: [libc++][test] Silence MSVC warning in std::optional test (authored by CaseyCarter).
[libc++][test] Silence MSVC warning in std::optional test
Oct 12 2019, 12:08 PM
CaseyCarter committed rL374684: [libc++][test] Silence MSVC warning in std::optional test.
[libc++][test] Silence MSVC warning in std::optional test
Oct 12 2019, 11:59 AM

Oct 10 2019

CaseyCarter committed rL374492: Request commit access for caseycarter.
Request commit access for caseycarter
Oct 10 2019, 6:08 PM
CaseyCarter committed rGffc83995de6d: [libc++][test] Change IsSmallObject's calculation for std::any's small object… (authored by CaseyCarter).
[libc++][test] Change IsSmallObject's calculation for std::any's small object…
Oct 10 2019, 11:13 AM
CaseyCarter closed D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 10 2019, 11:12 AM · Restricted Project
CaseyCarter committed rL374407: [libc++][test] Change IsSmallObject's calculation for std::any's small object….
[libc++][test] Change IsSmallObject's calculation for std::any's small object…
Oct 10 2019, 11:12 AM

Oct 9 2019

CaseyCarter added inline comments to D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 9 2019, 6:59 PM · Restricted Project
CaseyCarter created D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 9 2019, 6:50 PM · Restricted Project
CaseyCarter added a comment to D68681: [libc++][test] Miscellaneous MSVC cleanups.

You have commit access, right? If so, go ahead. Otherwise, LMK and I can commit this for you.

Oct 9 2019, 3:34 PM · Restricted Project
CaseyCarter committed rGb2e3c83b0d64: [libc++][test] Miscellaneous MSVC cleanups (authored by CaseyCarter).
[libc++][test] Miscellaneous MSVC cleanups
Oct 9 2019, 3:25 PM
CaseyCarter closed D68681: [libc++][test] Miscellaneous MSVC cleanups.
Oct 9 2019, 3:24 PM · Restricted Project
CaseyCarter committed rL374248: [libc++][test] Miscellaneous MSVC cleanups.
[libc++][test] Miscellaneous MSVC cleanups
Oct 9 2019, 3:24 PM
CaseyCarter updated the diff for D68681: [libc++][test] Miscellaneous MSVC cleanups.

Avoid rather than suppress truncation warnings in unordered_meow deduction guide tests.

Oct 9 2019, 10:18 AM · Restricted Project
CaseyCarter added inline comments to D68681: [libc++][test] Miscellaneous MSVC cleanups.
Oct 9 2019, 10:18 AM · Restricted Project

Oct 8 2019

CaseyCarter created D68681: [libc++][test] Miscellaneous MSVC cleanups.
Oct 8 2019, 7:00 PM · Restricted Project