Page MenuHomePhabricator

Budovi (Jakub Budiský)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 14 2021, 1:32 AM (7 w, 4 d)

Recent Activity

Wed, Feb 10

Budovi added a comment to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

LGTM. But let other folks a few days to chime in. Especially @MyDeveloperDay's input would be valuable here as he already attempted to implement this.

Wed, Feb 10, 5:40 AM · Restricted Project, Restricted Project
Budovi updated the diff for D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

Changes:

  • Fixed comments
Wed, Feb 10, 4:24 AM · Restricted Project, Restricted Project

Feb 5 2021

Budovi updated the diff for D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

Changes:

  • Added a unit test with a different IndentWidth
  • Removed a unit test that contained a class nested in function; didn't add much IMHO
  • Added brief comments about potentially non-obvious behaviour to some tests
Feb 5 2021, 5:57 AM · Restricted Project, Restricted Project
Budovi planned changes to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Feb 5 2021, 12:21 AM · Restricted Project, Restricted Project

Feb 4 2021

Budovi added inline comments to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Feb 4 2021, 5:25 AM · Restricted Project, Restricted Project
Budovi updated the diff for D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

Changes:

  • Added release notes
  • Changed the documentation (tried to make it more clear in response to the confusion about the added option)
Feb 4 2021, 5:23 AM · Restricted Project, Restricted Project

Feb 2 2021

Budovi planned changes to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

You need to supply a full diff (with context).
Please also add it to the release notes.

Feb 2 2021, 12:09 PM · Restricted Project, Restricted Project
Budovi updated the diff for D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

Updated the tests after checking the issues were not caused by the patch and they are reported / fixed.

Feb 2 2021, 9:30 AM · Restricted Project, Restricted Project
Budovi planned changes to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Feb 2 2021, 9:12 AM · Restricted Project, Restricted Project

Jan 14 2021

Budovi added inline comments to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Jan 14 2021, 9:33 AM · Restricted Project, Restricted Project
Budovi added a comment to D94661: [clang-format] [PR19056] Add support for access modifiers indentation.

I would add a test where you have a member before the first access modifier.

The very first unit test has no modifiers, the third one has a member before a modifier in the nested class C.

Jan 14 2021, 5:02 AM · Restricted Project, Restricted Project
Budovi requested review of D94661: [clang-format] [PR19056] Add support for access modifiers indentation.
Jan 14 2021, 2:07 AM · Restricted Project, Restricted Project