- User Since
- Jan 4 2018, 1:22 PM (141 w, 2 d)
Wed, Sep 9
@BRevzin, you should a) mention the u8/const char* issue in the description too, and also what compiler you used to build this with. I fully expect at this stage that there are some C++20 compilers that might have slightly different interpretations of things which this won't resolve, so knowing which one this is intended to work with could help with historical research.
Tue, Sep 8
Mon, Sep 7
Fri, Sep 4
Updating this review with some additional changes that need to be made since I last touched it, and some of the previous changes had inadvertently broken the C++14 build so fixing those as well.
May 25 2020
- Explaining the cryptic parentheses.
May 23 2020
- Backing out changes that aren't strictly comparison-related.
I hadn't build the tests before, updated with a few more changes. Some of the tests require u8 literals, whose type changes in C++20. I had no idea what to do with that, so I just #ifdef-ed out those tests with the appropriate feature test macro.
- Adding missing return.
- A few more changes from tests.
Apr 28 2020
Apr 27 2020
Trying this again.
Wtf, where'd my other changes go?
More idiomatic comparison implementation.
This review changed just the one type, I went ahead and fixed the rest of the clang build in a bigger review.
Mar 15 2020
Splitting the diff to JUST remove weak/strong_equality.
Mar 4 2020
Feb 6 2020
Jan 5 2018
Updates based on review comments - and rebased off of latest so as to get the ReleaseNotes right. Added options so that the user can provide the list of stream types and int typedef types, as desired, defaulting to just basic_ostream and int8_t/uint8_t.
Jan 4 2018
So admittedly, I don't have any experience in clang-tidy. This check is intended to catch what is to us a really annoying source of error (and I'm probably not the only one?). I suspect there are far better ways of writing this check than the one that I pretty much guess-and-checked my way into.