Page MenuHomePhabricator

AndrewLitteken (Andrew Litteken)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 6:03 PM (40 w, 2 d)

Recent Activity

Thu, Jan 14

AndrewLitteken added a comment to D94427: [NFC][InstructionCost] Use InstructionCost in lib/Transforms/IPO/IROutliner.cpp.

This looks fine to me, just one small nit in getBenefit for consistency with the rest of the patch.

Thu, Jan 14, 11:09 AM · Restricted Project

Wed, Jan 13

AndrewLitteken committed rG05b1a15f703c: [IROutliner] Adapting to hoisted bitcasts in CodeExtractor (authored by AndrewLitteken).
[IROutliner] Adapting to hoisted bitcasts in CodeExtractor
Wed, Jan 13, 9:11 AM
AndrewLitteken closed D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.
Wed, Jan 13, 9:11 AM · Restricted Project

Fri, Jan 8

AndrewLitteken requested review of D94304: Updating the IRSimilarityPrinting Pass to include the first and last instruction.
Fri, Jan 8, 6:37 AM · Restricted Project
AndrewLitteken retitled D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner from Adapting to hoisted bitcasts in CodeExtractor to Adapting to hoisted bitcasts in CodeExtractor in IROutliner.
Fri, Jan 8, 6:35 AM · Restricted Project
AndrewLitteken requested review of D94303: Adapting to hoisted bitcasts in CodeExtractor in IROutliner.
Fri, Jan 8, 6:34 AM · Restricted Project
AndrewLitteken updated the diff for D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..

This updates the diff with all the recent IROutliner updates, and adds testing for verifying the IR DebugInfo.

Fri, Jan 8, 6:33 AM · debug-info, Restricted Project

Sun, Jan 3

AndrewLitteken committed rG5c951623bc89: [IROutliner] Refactoring errors in the cost model from past patches. (authored by AndrewLitteken).
[IROutliner] Refactoring errors in the cost model from past patches.
Sun, Jan 3, 10:13 PM
AndrewLitteken committed rG05e6ac4eb811: [IROutliner] Removing a duplicate addition, causing overestimates in IROutliner. (authored by AndrewLitteken).
[IROutliner] Removing a duplicate addition, causing overestimates in IROutliner.
Sun, Jan 3, 9:38 PM

Fri, Jan 1

AndrewLitteken added a comment to D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions..
In D87302#2277131, @vsk wrote:

CodeExtractor contains a utility to fix up debug info after extraction occurs (I believe it's called fixupDebugInfoPostExtraction). It's solving the same problem - is there any way to generalize/reuse that logic?

Fri, Jan 1, 1:28 PM · debug-info, Restricted Project

Thu, Dec 31

AndrewLitteken committed rG57a46914f5c1: [IRSim][IROutliner] Allowing call instructions to be outlined. (authored by AndrewLitteken).
[IRSim][IROutliner] Allowing call instructions to be outlined.
Thu, Dec 31, 9:30 PM
AndrewLitteken closed D87314: [IRSim][IROutliner] Allowing call instructions to be outlined..
Thu, Dec 31, 9:30 PM · Restricted Project
AndrewLitteken committed rG0d21e66014fc: [IRSim] Letting call instructions be legal for similarity identification. (authored by AndrewLitteken).
[IRSim] Letting call instructions be legal for similarity identification.
Thu, Dec 31, 6:55 PM
AndrewLitteken closed D87312: [IRSim] Letting call instructions be legal for similarity identification..
Thu, Dec 31, 6:55 PM · Restricted Project
AndrewLitteken committed rGb6b1006f0719: [IRSim][IROutliner] Allowing GEP instructions to be outlined. (authored by AndrewLitteken).
[IRSim][IROutliner] Allowing GEP instructions to be outlined.
Thu, Dec 31, 3:19 PM
AndrewLitteken closed D87317: [IRSim][IROutliner] Allowing GEP instructions to be outlined..
Thu, Dec 31, 3:19 PM · Restricted Project
AndrewLitteken added a comment to rGa2513cb8655e: remove pessimizing moves (reported by gcc 10).

I reverted this commit because it was causing problems with clang on several of the buildbots with the general flavor of the following error log:

Thu, Dec 31, 1:37 PM
AndrewLitteken added a reverting change for rGa2513cb8655e: remove pessimizing moves (reported by gcc 10): rG14dc69b09218: Revert "remove pessimizing moves (reported by gcc 10)".
Thu, Dec 31, 1:16 PM
AndrewLitteken committed rG14dc69b09218: Revert "remove pessimizing moves (reported by gcc 10)" (authored by AndrewLitteken).
Revert "remove pessimizing moves (reported by gcc 10)"
Thu, Dec 31, 1:16 PM
AndrewLitteken closed D87315: [IRSim] Letting gep instructions be legal for similarity identification..
Thu, Dec 31, 12:43 PM · Restricted Project
AndrewLitteken committed rGd974ac0224de: [IRSim] Letting gep instructions be legal for similarity identification. (authored by AndrewLitteken).
[IRSim] Letting gep instructions be legal for similarity identification.
Thu, Dec 31, 12:42 PM
AndrewLitteken committed rG1a9eb19af9ba: [IROutliner] Adding consistent function attribute merging (authored by AndrewLitteken).
[IROutliner] Adding consistent function attribute merging
Thu, Dec 31, 10:31 AM
AndrewLitteken closed D87301: [IRSim][IROutliner] Adding consistent function attribute merging.
Thu, Dec 31, 10:30 AM · Restricted Project

Wed, Dec 30

AndrewLitteken committed rGfe431103b633: [IROutliner] Adding option to enable outlining from linkonceodr functions (authored by AndrewLitteken).
[IROutliner] Adding option to enable outlining from linkonceodr functions
Wed, Dec 30, 10:20 AM
AndrewLitteken closed D87309: [IRSim][IROutliner] Adding option to enable outlining from linkonceodr functions.
Wed, Dec 30, 10:20 AM · Restricted Project

Tue, Dec 29

AndrewLitteken committed rG30feb93036eb: [IROutliner] Adding support for swift errors in the IROutliner (authored by AndrewLitteken).
[IROutliner] Adding support for swift errors in the IROutliner
Tue, Dec 29, 11:18 PM
AndrewLitteken added a reverting change for rG71867ed5e660: [IROutliner] Adding support for swift errors: rGeeb99c2ac267: Revert "[IROutliner] Adding support for swift errors".
Tue, Dec 29, 11:18 PM
AndrewLitteken committed rGeeb99c2ac267: Revert "[IROutliner] Adding support for swift errors" (authored by AndrewLitteken).
Revert "[IROutliner] Adding support for swift errors"
Tue, Dec 29, 11:17 PM
AndrewLitteken closed D87742: [IROutliner] Adding support for swift errors.
Tue, Dec 29, 11:17 PM · Restricted Project
AndrewLitteken committed rG71867ed5e660: [IROutliner] Adding support for swift errors (authored by AndrewLitteken).
[IROutliner] Adding support for swift errors
Tue, Dec 29, 11:15 PM
AndrewLitteken committed rGdf4a931c63b6: [IROutliner] Adding OptRemarks to the IROutliner Pass (authored by AndrewLitteken).
[IROutliner] Adding OptRemarks to the IROutliner Pass
Tue, Dec 29, 1:53 PM
AndrewLitteken closed D87300: [IRSim][IROutliner] Adding OptRemarks for the IROutliner..
Tue, Dec 29, 1:52 PM · Restricted Project
AndrewLitteken committed rG6df161a2fbf6: [IROutliner] Adding a cost model, and debug option to turn the model off. (authored by AndrewLitteken).
[IROutliner] Adding a cost model, and debug option to turn the model off.
Tue, Dec 29, 10:44 AM
AndrewLitteken closed D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..
Tue, Dec 29, 10:43 AM · Restricted Project

Mon, Dec 28

AndrewLitteken committed rG1e23802507d1: [IROutliner] Merging identical output blocks for extracted functions. (authored by AndrewLitteken).
[IROutliner] Merging identical output blocks for extracted functions.
Mon, Dec 28, 7:17 PM
AndrewLitteken closed D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.
Mon, Dec 28, 7:17 PM · Restricted Project
AndrewLitteken committed rGe6ae623314ba: [IROutliner] Adding support for consolidating functions with different output… (authored by AndrewLitteken).
[IROutliner] Adding support for consolidating functions with different output…
Mon, Dec 28, 2:17 PM
AndrewLitteken closed D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..
Mon, Dec 28, 2:17 PM · Restricted Project

Wed, Dec 23

AndrewLitteken committed rG48ad8194a56f: [IRSim] Adding support for isomorphic predicates (authored by AndrewLitteken).
[IRSim] Adding support for isomorphic predicates
Wed, Dec 23, 5:50 PM
AndrewLitteken added a reverting change for rG050392660249: [IRSim] Adding support for isomorphic predicates: rG45a4f34bd194: Revert "[IRSim] Adding support for isomorphic predicates".
Wed, Dec 23, 1:14 PM
AndrewLitteken committed rG45a4f34bd194: Revert "[IRSim] Adding support for isomorphic predicates" (authored by AndrewLitteken).
Revert "[IRSim] Adding support for isomorphic predicates"
Wed, Dec 23, 1:14 PM
AndrewLitteken added a reverting change for D87310: [IRSim] Adding support for isomorphic predicates: rG45a4f34bd194: Revert "[IRSim] Adding support for isomorphic predicates".
Wed, Dec 23, 1:14 PM · Restricted Project
AndrewLitteken committed rG050392660249: [IRSim] Adding support for isomorphic predicates (authored by AndrewLitteken).
[IRSim] Adding support for isomorphic predicates
Wed, Dec 23, 1:02 PM
AndrewLitteken committed rGcce473e0c564: [IRSim] Adding commutativity matching to structure checking (authored by AndrewLitteken).
[IRSim] Adding commutativity matching to structure checking
Wed, Dec 23, 1:02 PM
AndrewLitteken closed D87310: [IRSim] Adding support for isomorphic predicates.
Wed, Dec 23, 1:02 PM · Restricted Project
AndrewLitteken closed D87311: [IRSim] Adding commutativity matching to structure checking.
Wed, Dec 23, 1:02 PM · Restricted Project
AndrewLitteken committed rGb1191c843804: [IROutliner] Adding support for elevating constants that are not the same in… (authored by AndrewLitteken).
[IROutliner] Adding support for elevating constants that are not the same in…
Wed, Dec 23, 11:03 AM
AndrewLitteken closed D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.
Wed, Dec 23, 11:03 AM · Restricted Project

Sat, Dec 19

AndrewLitteken committed rG7c6f28a438b5: [IROutliner] Deduplicating functions that only require inputs. (authored by AndrewLitteken).
[IROutliner] Deduplicating functions that only require inputs.
Sat, Dec 19, 3:35 PM
AndrewLitteken added a reverting change for rG5cdc4f57e50b: [IROutliner] Deduplicating functions that only require inputs.: rGb8a2b6af374e: Revert "[IROutliner] Deduplicating functions that only require inputs.".
Sat, Dec 19, 3:35 PM
AndrewLitteken committed rGb8a2b6af374e: Revert "[IROutliner] Deduplicating functions that only require inputs." (authored by AndrewLitteken).
Revert "[IROutliner] Deduplicating functions that only require inputs."
Sat, Dec 19, 3:35 PM
AndrewLitteken closed D86978: [IROutliner] Deduplicating functions that only require inputs..

The URL was not included in commit message for 5cdc4f57e50bbe0d211c109517c17defe78e0b73. Closing manually.

Sat, Dec 19, 3:29 PM · Restricted Project
AndrewLitteken committed rG5cdc4f57e50b: [IROutliner] Deduplicating functions that only require inputs. (authored by AndrewLitteken).
[IROutliner] Deduplicating functions that only require inputs.
Sat, Dec 19, 3:26 PM
AndrewLitteken committed rGc52bcf3a9b2d: [IRSim][IROutliner] Limit to extracting regions that only require (authored by AndrewLitteken).
[IRSim][IROutliner] Limit to extracting regions that only require
Sat, Dec 19, 11:34 AM
AndrewLitteken closed D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.
Sat, Dec 19, 11:34 AM · Restricted Project

Dec 17 2020

AndrewLitteken closed D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..
Dec 17 2020, 7:17 PM · Restricted Project
AndrewLitteken committed rGcea807602a2f: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations. (authored by AndrewLitteken).
[IRSim][IROutliner] Adding InstVisitor to disallow certain operations.
Dec 17 2020, 5:35 PM
AndrewLitteken requested review of D93475: Updating macOS Version logic for macOS 11+ and Darwin 20+.
Dec 17 2020, 10:52 AM · Restricted Project
AndrewLitteken committed rGdae34463e3e0: [IRSim][IROutliner] Adding the extraction basics for the IROutliner. (authored by AndrewLitteken).
[IRSim][IROutliner] Adding the extraction basics for the IROutliner.
Dec 17 2020, 9:28 AM

Dec 2 2020

AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Updating an incorrect typo introduced from the fix-up patch.

Dec 2 2020, 8:51 PM · Restricted Project
AndrewLitteken added a comment to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

@paquette @jroelofs @yroux for reverting fix.

Dec 2 2020, 8:48 PM · Restricted Project
AndrewLitteken added a reviewer for D86974: [IRSim] Adding basic implementation of llvm-sim.: MaskRay.
Dec 2 2020, 8:35 PM · Restricted Project
AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

These are updates to try to fix the build problem of the llvm-sim executable not being found for tests on Windows and some Linux builds. Unfortunately, I do not have the errors anymore. Is there something else that will need added to add llvm-sim as a tool? The changes I've made reflect what I've found has been done for other tools.

Dec 2 2020, 8:34 PM · Restricted Project
AndrewLitteken added a comment to D92532: [IRSimilarity] Don't copy the Mapper for createCandidatesFromSuffixTree.

Good catch, this looks fine to me, but like the other patch, please wait for one of the other reviewers.

Dec 2 2020, 8:27 PM · Restricted Project
AndrewLitteken added a comment to D92524: [IRSimilarity] Strip out the findSimilarity call from the constructor.

I don't think anything in future patches uses the constructor either so should be ok.

Dec 2 2020, 8:27 PM · Restricted Project

Nov 27 2020

AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Updating diff to reflect memory leak fixes, using strategy from D86968 to use SpecificBumpPtrAllocator rather than BumpPtrAllocatotr.

Nov 27 2020, 9:45 PM · Restricted Project
AndrewLitteken added a reverting change for rGbf899e891387: [IRSim][IROutliner] Adding the extraction basics for the IROutliner.: rGa8a43b63388f: Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner.".
Nov 27 2020, 5:56 PM
AndrewLitteken committed rGa8a43b63388f: Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner." (authored by AndrewLitteken).
Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner."
Nov 27 2020, 5:56 PM
AndrewLitteken added a reverting change for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner.: rGa8a43b63388f: Revert "[IRSim][IROutliner] Adding the extraction basics for the IROutliner.".
Nov 27 2020, 5:56 PM · Restricted Project
AndrewLitteken committed rGbf899e891387: [IRSim][IROutliner] Adding the extraction basics for the IROutliner. (authored by AndrewLitteken).
[IRSim][IROutliner] Adding the extraction basics for the IROutliner.
Nov 27 2020, 5:09 PM
AndrewLitteken closed D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Nov 27 2020, 5:09 PM · Restricted Project

Nov 19 2020

AndrewLitteken added inline comments to D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..
Nov 19 2020, 8:52 AM · Restricted Project

Sep 30 2020

AndrewLitteken updated the diff for D87299: [IRSim][IROutliner] Adding a cost model, and debug option to turn the model off..

Fixing an extra addition that fell out of refactoring causing overestimates in the number of instructions outlined.

Sep 30 2020, 11:29 AM · Restricted Project

Sep 25 2020

AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Updating LLVMBuild.txt as well.

Sep 25 2020, 2:53 PM · Restricted Project
AndrewLitteken updated the diff for D86974: [IRSim] Adding basic implementation of llvm-sim..

Fixing CMakeLists.txt to accurately reflect what needs to be linked, and flags and redirection for the tests themselves.

Sep 25 2020, 2:42 PM · Restricted Project
AndrewLitteken added a reverting change for rG15645d044bcf: [IRSim] Adding basic implementation of llvm-sim.: rG69c6f6be07e4: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Sep 25 2020, 2:19 PM
AndrewLitteken committed rG69c6f6be07e4: Revert "[IRSim] Adding basic implementation of llvm-sim." (authored by AndrewLitteken).
Revert "[IRSim] Adding basic implementation of llvm-sim."
Sep 25 2020, 2:19 PM
AndrewLitteken added a reverting change for D86974: [IRSim] Adding basic implementation of llvm-sim.: rG69c6f6be07e4: Revert "[IRSim] Adding basic implementation of llvm-sim.".
Sep 25 2020, 2:19 PM · Restricted Project
AndrewLitteken committed rG15645d044bcf: [IRSim] Adding basic implementation of llvm-sim. (authored by AndrewLitteken).
[IRSim] Adding basic implementation of llvm-sim.
Sep 25 2020, 1:25 PM
AndrewLitteken closed D86974: [IRSim] Adding basic implementation of llvm-sim..
Sep 25 2020, 1:25 PM · Restricted Project

Sep 24 2020

AndrewLitteken committed rGf02c4c87b46c: [IRSim] Adding wrapper pass for IRSimilarityIdentfier (authored by AndrewLitteken).
[IRSim] Adding wrapper pass for IRSimilarityIdentfier
Sep 24 2020, 1:00 PM
AndrewLitteken closed D86973: [IRSim] Adding wrapper pass for IRSimilarityIdentfier.
Sep 24 2020, 12:59 PM · Restricted Project
AndrewLitteken committed rG08d145e6d7a9: [IRSim][NFC] Removing dead variables from IRSimilarityIdentifier.cpp (authored by AndrewLitteken).
[IRSim][NFC] Removing dead variables from IRSimilarityIdentifier.cpp
Sep 24 2020, 9:44 AM
AndrewLitteken added inline comments to D86972: [IRSim] Adding a basic similarity identifier..
Sep 24 2020, 7:57 AM · Restricted Project
AndrewLitteken committed rGb63bfc2030de: [IRSim] Adding a basic similarity identifier. (authored by AndrewLitteken).
[IRSim] Adding a basic similarity identifier.
Sep 24 2020, 12:13 AM
AndrewLitteken closed D86972: [IRSim] Adding a basic similarity identifier..
Sep 24 2020, 12:13 AM · Restricted Project

Sep 23 2020

AndrewLitteken committed rGbeeceb92c082: [IRSim][NFC] Removing warning from IRSimilarityIdentifier (authored by AndrewLitteken).
[IRSim][NFC] Removing warning from IRSimilarityIdentifier
Sep 23 2020, 10:39 PM
AndrewLitteken committed rGd1aa143aa84e: [IRSim] Adding structural comparison to IRSimilarityCandidate. (authored by AndrewLitteken).
[IRSim] Adding structural comparison to IRSimilarityCandidate.
Sep 23 2020, 8:43 PM
AndrewLitteken added a reverting change for rGb27db2bb6816: [IRSim] Adding structural comparison to IRSimilarityCandidate.: rG0a8e097e72df: Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate.".
Sep 23 2020, 8:43 PM
AndrewLitteken committed rG0a8e097e72df: Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate." (authored by AndrewLitteken).
Revert "[IRSim] Adding structural comparison to IRSimilarityCandidate."
Sep 23 2020, 8:43 PM
AndrewLitteken closed D86971: [IRSim] Adding structural comparison to IRSimilarityCandidate..
Sep 23 2020, 8:43 PM · Restricted Project
AndrewLitteken committed rGb27db2bb6816: [IRSim] Adding structural comparison to IRSimilarityCandidate. (authored by AndrewLitteken).
[IRSim] Adding structural comparison to IRSimilarityCandidate.
Sep 23 2020, 8:31 PM
AndrewLitteken updated the diff for D87298: [IRSim][IROutliner] Merging output blocks for extracted functions with outputs.

Updating based on previous patches.

Sep 23 2020, 1:39 PM · Restricted Project
AndrewLitteken updated the diff for D87296: [IRSim][IROutliner] Adding support for consolidating functions with different output arguments..

Updating based on previous changes.

Sep 23 2020, 1:38 PM · Restricted Project
AndrewLitteken updated the diff for D87294: [IRSim][IROutliner] Adding support for elevating constants that are not the same in each region to arguments.

Updating to reflect other patches.

Sep 23 2020, 1:38 PM · Restricted Project
AndrewLitteken updated the diff for D86978: [IROutliner] Deduplicating functions that only require inputs..

Updating to reflect other patches.

Sep 23 2020, 1:37 PM · Restricted Project
AndrewLitteken updated the diff for D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs.

Updating based on comments.

Sep 23 2020, 1:37 PM · Restricted Project
AndrewLitteken updated the diff for D86976: [IRSim][IROutliner] Adding InstVisitor to disallow certain operations..

Updating for whitespace commits.

Sep 23 2020, 1:36 PM · Restricted Project
AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Removing dead variable.

Sep 23 2020, 1:35 PM · Restricted Project
AndrewLitteken updated the diff for D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner..

Fixing some small nits.

Sep 23 2020, 1:16 PM · Restricted Project