Page MenuHomePhabricator

AlexisPerry (Alexis Perry-Holby)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 8:29 AM (33 w, 3 d)

Recent Activity

Wed, Nov 4

AlexisPerry added a comment to D90515: Add -S option.

The idea seems solid to me, but I am also unsure how best to test this. Also, did you clang-format the code before uploading the patch?

Wed, Nov 4, 3:54 PM

Sep 22 2020

AlexisPerry updated subscribers of D84334: [flang] Version information in flang/f18.
Sep 22 2020, 3:52 PM · Restricted Project, Unknown Object (Project)

Aug 6 2020

AlexisPerry accepted D84334: [flang] Version information in flang/f18.
Aug 6 2020, 12:10 PM · Restricted Project, Unknown Object (Project)

Jul 28 2020

AlexisPerry added a comment to D84334: [flang] Version information in flang/f18.

@richard.barton.arm, I don't think I have any code that relies on __F18 being defined, so I'm alright with removing it and the related macros. You also make a very good point about following clang behavior. I wasn't aware of clang's use of lowercase macros and just assumed everyone uses uppercase macros based on my previous experiences with other codes. I think your proposal is likely the better way to go, first because matching style across LLVM projects is generally a good thing and second because your proposal does not require changes to classic Flang so we don't have to impose on those developers.

Jul 28 2020, 8:24 AM · Restricted Project, Unknown Object (Project)
AlexisPerry committed rGca0bf440dbf9: Order of libraries and source files in the f18 frontend (authored by coti).
Order of libraries and source files in the f18 frontend
Jul 28 2020, 8:03 AM
AlexisPerry closed D84340: Order of libraries and source files in the f18 frontend.
Jul 28 2020, 8:03 AM · Restricted Project, Unknown Object (Project)

Jul 27 2020

AlexisPerry accepted D84340: Order of libraries and source files in the f18 frontend.
Jul 27 2020, 4:01 PM · Restricted Project, Unknown Object (Project)
AlexisPerry accepted D84340: Order of libraries and source files in the f18 frontend.
Jul 27 2020, 2:59 PM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D84334: [flang] Version information in flang/f18.

I am assuming that f18 will have a MAJOR version number matching the LLVM release? Does classic flang do that as well? Both compilers will probably co-exist for a while and it would be desirable to make them distinguishable to build systems as CMake.

I don't have a solution, but maybe we need to #define __CLASSIC_FLANG in classic flang. I am just throwing out ideas.

Jul 27 2020, 9:38 AM · Restricted Project, Unknown Object (Project)
AlexisPerry accepted D84340: Order of libraries and source files in the f18 frontend.

This looks good to me. I think these changes mean that the vector relocatables never actually gets populated, so it could be removed since the patch uses objlist and liblist exclusively, which are clearer names anyway.

Jul 27 2020, 9:33 AM · Restricted Project, Unknown Object (Project)
AlexisPerry added a comment to D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.

I don't know what changed between my last patch and now, but I am unable to land this patch myself. I keep getting the following error:
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:65]

Jul 27 2020, 7:56 AM · Unknown Object (Project), Restricted Project

Jul 22 2020

AlexisPerry accepted D84334: [flang] Version information in flang/f18.

Looks good to me. Please wait for approval from at least one of the other reviewers before merging.

Jul 22 2020, 12:51 PM · Restricted Project, Unknown Object (Project)
AlexisPerry requested changes to D84334: [flang] Version information in flang/f18.

Thanks for the patch! I had a couple questions and one small change request (see inline comments). The questions truly should be treated as questions rather than requests for changes, since I'm not 100% sure of the right answer to them.

Jul 22 2020, 10:07 AM · Restricted Project, Unknown Object (Project)

Jul 21 2020

AlexisPerry added reviewers for D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC: naromero77, sscalpone, richard.barton.arm.
Jul 21 2020, 1:24 PM · Unknown Object (Project), Restricted Project
Herald added a project to D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC: Restricted Project.
Jul 21 2020, 1:16 PM · Unknown Object (Project), Restricted Project

Jul 14 2020

AlexisPerry committed rG02c3f70b47b8: [flang] Change the default F18_FC to gfortran (authored by AlexisPerry).
[flang] Change the default F18_FC to gfortran
Jul 14 2020, 12:12 PM
AlexisPerry closed D83488: [flang] Change the default F18_FC to gfortran.
Jul 14 2020, 12:11 PM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

@richard.barton.arm Is this patch acceptable now? Thanks!

Jul 14 2020, 7:40 AM · Unknown Object (Project), Restricted Project

Jul 13 2020

AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Updates following a rebase on master (due to changes on D83687)

Jul 13 2020, 2:38 PM · Unknown Object (Project), Restricted Project
AlexisPerry committed rGf630b8590f0c: [flang] Extended the flang driver options to include gfortran equivalents to… (authored by AlexisPerry).
[flang] Extended the flang driver options to include gfortran equivalents to…
Jul 13 2020, 1:26 PM
AlexisPerry closed D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..
Jul 13 2020, 1:26 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

Extended the flang driver options to include gfortran equivalents to pgf90 specific options.

Jul 13 2020, 11:17 AM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

@richard.barton.arm I have made the requested adjustments in the other patch. Thanks for the feedback!

Jul 13 2020, 11:08 AM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

Correction for handling of OpenMP enabling flags

Jul 13 2020, 10:58 AM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

The second part of the split can be found here: https://reviews.llvm.org/D83687

Jul 13 2020, 9:40 AM · Unknown Object (Project), Restricted Project
Herald added a reviewer for D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options.: jdoerfert.
Jul 13 2020, 9:39 AM · Unknown Object (Project), Restricted Project
Herald added a project to D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options.: Restricted Project.
Jul 13 2020, 9:39 AM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Splitting this into two patches as requested by reviewers.

Jul 13 2020, 9:17 AM · Unknown Object (Project), Restricted Project

Jul 9 2020

AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

I'll admit, this is my first time trying to commit to LLVM directly and using Phabricator (rather than on a fork that uses pull requests), and I'm definitely still learning the workflow. I had some git issues when first creating the patch that meant my first commit was lost locally, so when I went to update the patch it only had the second commit which caused the original changes to disappear. I then created a new branch and re-did the changes and updated again, using only a single commit, so that the diff would now have everything in it.

Jul 9 2020, 5:10 PM · Unknown Object (Project), Restricted Project
AlexisPerry added a comment to D83488: [flang] Change the default F18_FC to gfortran.

I don't see the previous change made to set gfortran as default. Are they gone with your diff update?

Jul 9 2020, 4:58 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Changed the default external compiler used by the flang temporary driver.

Jul 9 2020, 4:55 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated the diff for D83488: [flang] Change the default F18_FC to gfortran.

Extended the flang driver options to include gfortran equivalents to pgf90 specific options.

Jul 9 2020, 4:41 PM · Unknown Object (Project), Restricted Project
AlexisPerry updated subscribers of D83488: [flang] Change the default F18_FC to gfortran.
Jul 9 2020, 9:06 AM · Unknown Object (Project), Restricted Project
Herald added a reviewer for D83488: [flang] Change the default F18_FC to gfortran: jdoerfert.
Jul 9 2020, 9:05 AM · Unknown Object (Project), Restricted Project
Herald added a project to D83488: [flang] Change the default F18_FC to gfortran: Restricted Project.
Jul 9 2020, 9:01 AM · Unknown Object (Project), Restricted Project