Page MenuHomePhabricator

AlexanderLanin (Alexander Lanin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2017, 1:32 PM (182 w, 3 d)

Recent Activity

Thu, Jul 30

AlexanderLanin added inline comments to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
Thu, Jul 30, 3:24 PM · Restricted Project, Restricted Project
AlexanderLanin updated the diff for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

Addressed findings by @njames93

Thu, Jul 30, 3:16 PM · Restricted Project, Restricted Project

Wed, Jul 29

AlexanderLanin planned changes to D74299: [clang-tidy] extend tests of run-clang-tidy.

The reason was that I thought that line doesn't do anything.
Of course "not crashing" is a valid expectation. If nothing else, then "not crashing" should indeed be tested.
I'll try to improve this ancient diff.

Wed, Jul 29, 2:29 PM · Restricted Project
AlexanderLanin added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

*ping*
Last change was over 3 months ago. Should this be merged or abandoned?
It doesn't solve everything. It doesn't improve everything. But it's a fix to two specific bugs.
Is someone missing as a reviewer to get this accepted/rejected any faster?

Wed, Jul 29, 2:25 PM · Restricted Project
AlexanderLanin added a comment to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

*ping*
Sorry, but I have to ask: Is there no interest in improving clang-tidy?
Don't get me wrong. I know it's mostly volunteered time. That's also why this ping took almost 2 months for me.
I frankly lost interest in contributing as I have trouble getting any patches included - and I don't have that much free time anymore. Obviously the time issue is more important, but the other one is still a problem.

Wed, Jul 29, 2:22 PM · Restricted Project, Restricted Project

Jun 2 2020

AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

*ping*

Jun 2 2020, 2:12 AM · Restricted Project
AlexanderLanin added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

*ping*

Jun 2 2020, 2:12 AM · Restricted Project
AlexanderLanin added a comment to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

*ping*

Jun 2 2020, 2:12 AM · Restricted Project, Restricted Project

Apr 24 2020

AlexanderLanin abandoned D76108: do not merge - [clang] fix EndLoc of some Statements.

Mailing list was clear about AST having to many users. No change to clang AST.
Will hopefully be resolved by D75813 instead.

Apr 24 2020, 11:57 PM · Restricted Project
AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

*ping*

Apr 24 2020, 11:57 PM · Restricted Project
AlexanderLanin added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

*ping*

Apr 24 2020, 11:57 PM · Restricted Project
AlexanderLanin added a comment to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

*ping*

Apr 24 2020, 11:57 PM · Restricted Project, Restricted Project

Apr 11 2020

AlexanderLanin updated the diff for D74877: [clang] fix incorrect Wdocumentation fix-its.
  • Add test cases exactly as in bug reports.
  • Test case from https://bugs.llvm.org/show_bug.cgi?id=43808 triggered a second bug due to the short parameter names used. Removed incorrect quick exit in SimpleTypoCorrector (MinPossibleEditDistance).
  • The two requested cases don't work since 'aaab' is as close to 'aaa' as it is to 'aab' (one char). Nothing is changed as there is no best match available. Instead two new test cases with aaab, aaac and aaad added (test3to3_allAlmost + test3to3_allAlmost_rev).
Apr 11 2020, 12:47 PM · Restricted Project

Apr 10 2020

AlexanderLanin planned changes to D74877: [clang] fix incorrect Wdocumentation fix-its.

I need to have a look why the mentioned test case is failing. I'll also add the two examples you provided to the next upload.

Apr 10 2020, 3:04 PM · Restricted Project

Apr 1 2020

AlexanderLanin added a comment to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

I have an opinion on NullStmt, but I would rather see this merged ;-)
Behavior is same as before.

Apr 1 2020, 4:21 PM · Restricted Project, Restricted Project
AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

*ping*

Apr 1 2020, 4:21 PM · Restricted Project
AlexanderLanin added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

*ping*

Apr 1 2020, 4:21 PM · Restricted Project
AlexanderLanin added a comment to D72374: [docs] use git diff instead of git format-patch.

*ping*

Apr 1 2020, 4:21 PM · Restricted Project

Mar 23 2020

AlexanderLanin updated the diff for D74877: [clang] fix incorrect Wdocumentation fix-its.

More tests added to prevent further regressions. It's quite difficult to figure out tests which might fail, but now there is a whole bunch of them so it looks good.
Added explicit references from tests to the two bug reports.

Mar 23 2020, 9:48 AM · Restricted Project

Mar 21 2020

AlexanderLanin added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

Thanks for the feedback!!

Mar 21 2020, 12:15 PM · Restricted Project

Mar 19 2020

AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

Just new tests, easy to review :-)

Mar 19 2020, 1:09 PM · Restricted Project
AlexanderLanin updated the diff for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

new test case as requested (line 256)

Mar 19 2020, 1:08 PM · Restricted Project, Restricted Project
AlexanderLanin added inline comments to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
Mar 19 2020, 12:32 PM · Restricted Project, Restricted Project

Mar 18 2020

AlexanderLanin updated the diff for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

Add further tests from more bug reports.

Mar 18 2020, 1:36 AM · Restricted Project, Restricted Project

Mar 17 2020

AlexanderLanin added inline comments to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
Mar 17 2020, 1:36 AM · Restricted Project, Restricted Project

Mar 16 2020

AlexanderLanin updated the diff for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

Accidentally reverted test file renaming in last commit. Fixed now.
Rebased on current master.

Mar 16 2020, 7:07 PM · Restricted Project, Restricted Project
AlexanderLanin updated the diff for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
  • Added GotoStmt and SEHLeaveStmt as learned from D76108.
  • After applying D76037 and D76054 I was able to run-clang-tidy on llvm and therefore found some new macro related issues
Mar 16 2020, 6:04 PM · Restricted Project, Restricted Project

Mar 14 2020

AlexanderLanin added a comment to D76108: do not merge - [clang] fix EndLoc of some Statements.

One more thought: This originated for me from attempting to fix braces-around-statements which has quite some trouble finding the correct place to place the }. However this is a good definition of "end location of statement" isn't it? The place where you can end the scope. The place where you could place the next statement!

Mar 14 2020, 12:20 PM · Restricted Project
AlexanderLanin added a comment to D74877: [clang] fix incorrect Wdocumentation fix-its.

*ping*

Mar 14 2020, 5:19 AM · Restricted Project
AlexanderLanin added a comment to D76108: do not merge - [clang] fix EndLoc of some Statements.

Thanks for the feedback. I was trying to start a discussion on cfe-dev where I referenced this commit, but I'm also fine having it here! There you'll also find some rationale. Just worried it will get out of sync.
Compare http://lists.llvm.org/pipermail/cfe-dev/2020-March/064861.html

Mar 14 2020, 2:38 AM · Restricted Project

Mar 12 2020

AlexanderLanin created D76108: do not merge - [clang] fix EndLoc of some Statements.
Mar 12 2020, 4:18 PM · Restricted Project
AlexanderLanin resigned from D76037: [clang] tooling replacements are escaped when exporting to YAML.
Mar 12 2020, 3:45 PM · Restricted Project
AlexanderLanin added a comment to D76037: [clang] tooling replacements are escaped when exporting to YAML.

Fine for me. Fixes newline bug in https://bugs.llvm.org/show_bug.cgi?id=45150.
However I don't have "review privileges" here.

Mar 12 2020, 3:45 PM · Restricted Project
AlexanderLanin added a comment to D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU.

Unfortunately I cannot say whether the code is good, but the fix works and certainly helps readability-braces-around-statements which can sometimes add multiple } at the same offset to close several scopes.

Mar 12 2020, 3:45 PM · Restricted Project
AlexanderLanin requested changes to D76037: [clang] tooling replacements are escaped when exporting to YAML.
Mar 12 2020, 11:56 AM · Restricted Project

Mar 11 2020

AlexanderLanin added inline comments to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
Mar 11 2020, 1:35 PM · Restricted Project, Restricted Project

Mar 10 2020

AlexanderLanin updated the diff for D72374: [docs] use git diff instead of git format-patch.

Rebased. Solves the svn issue as it's gone in the meantime.

Mar 10 2020, 3:21 PM · Restricted Project

Mar 9 2020

AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

*ping*

Mar 9 2020, 11:19 AM · Restricted Project
AlexanderLanin added a comment to D72374: [docs] use git diff instead of git format-patch.

*ping*

Mar 9 2020, 11:19 AM · Restricted Project

Mar 7 2020

AlexanderLanin updated the diff for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
  1. Extended Test for another macro scenario.
  2. Added graceful termination to handle problematic locations.
  3. Changed Lexer::findNextToken to no longer run into that graceful termination. Test is passing. I'm not sure whether that's a good idea? check-clang and check-clang-tools are passing with this change.
Mar 7 2020, 2:37 PM · Restricted Project, Restricted Project
AlexanderLanin added a comment to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.

Oh sorry. It's crashing. I'll look into it.

Mar 7 2020, 10:50 AM · Restricted Project, Restricted Project
AlexanderLanin created D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
Mar 7 2020, 10:50 AM · Restricted Project, Restricted Project

Feb 29 2020

AlexanderLanin added a comment to D16267: Handle C++11 brace initializers in readability-braces-around-statements.

Here is the r_brace use case:

Feb 29 2020, 12:22 PM

Feb 23 2020

AlexanderLanin updated the diff for D74877: [clang] fix incorrect Wdocumentation fix-its.

Slightly more code changed, assuming it's better understandable now. Review findings incorporated.

Feb 23 2020, 3:17 PM · Restricted Project

Feb 20 2020

AlexanderLanin added inline comments to D74877: [clang] fix incorrect Wdocumentation fix-its.
Feb 20 2020, 2:48 PM · Restricted Project

Feb 19 2020

AlexanderLanin created D74877: [clang] fix incorrect Wdocumentation fix-its.
Feb 19 2020, 3:24 PM · Restricted Project
AlexanderLanin updated the diff for D74800: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block.

Could someone commit this as I cannot? Thanks.
Alexander Lanin <alex@lanin.de>

Feb 19 2020, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Feb 18 2020

AlexanderLanin created D74800: [clang-tidy] fix readability-redundant-member-init auto-fix of Function-try-block.
Feb 18 2020, 3:11 PM · Restricted Project, Restricted Project, Restricted Project
AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

*ping*

Feb 18 2020, 3:06 PM · Restricted Project

Feb 9 2020

AlexanderLanin added a comment to rGe2de1ba44ea2: [clang] add additional test for run-clang-tidy.

This was an accident on github. Can/should be closed/deleted here. Sorry!
The proper submission is at https://reviews.llvm.org/D74299

Feb 9 2020, 2:45 PM
AlexanderLanin added a comment to D74299: [clang-tidy] extend tests of run-clang-tidy.

I tested this in WSL1 with ninja check-clang-tools.
Is there anything else I can do (besides setting up a second OS)?

Feb 9 2020, 2:28 PM · Restricted Project
AlexanderLanin created D74299: [clang-tidy] extend tests of run-clang-tidy.
Feb 9 2020, 2:27 PM · Restricted Project
AlexanderLanin committed rGe2de1ba44ea2: [clang] add additional test for run-clang-tidy (authored by AlexanderLanin).
[clang] add additional test for run-clang-tidy
Feb 9 2020, 12:50 PM
AlexanderLanin added a comment to D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings.

On second thought maybe this should be fixed in clang-tidy and not here?
Maybe besides -export-fixes there should be an -export-warnings or just -yaml-export?

Feb 9 2020, 12:56 AM · Restricted Project, Restricted Project

Feb 3 2020

AlexanderLanin abandoned D73856: [docu] Improve docu of misc-misplaced-const.

@aaron.ballman I was ready to complain, but you are right. It would make absolutely no sense to move the const, it's just where it should be.

Feb 3 2020, 12:17 PM · Restricted Project, Restricted Project

Feb 2 2020

AlexanderLanin created D73856: [docu] Improve docu of misc-misplaced-const.
Feb 2 2020, 2:53 PM · Restricted Project, Restricted Project

Feb 1 2020

AlexanderLanin abandoned D29692: [clang-tidy] add check modernize-use-const-instead-of-define.

This is now detected by cppcoreguidelines-macro-usage, so this seems out of date.

Feb 1 2020, 1:29 PM
AlexanderLanin updated the summary of D72374: [docs] use git diff instead of git format-patch.
Feb 1 2020, 1:20 PM · Restricted Project
AlexanderLanin updated the diff for D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings.

Review findings applied (no real measurable difference in speed, maybe 100ms) but it's indeed more readable.
Without this fix the export took 12.96 seconds, with this patch 11.07 seconds.
Difference is even bigger when there are less auto fixable findings (70% with FIX-IT in my example).

Feb 1 2020, 1:20 PM · Restricted Project, Restricted Project

Jan 26 2020

AlexanderLanin added a comment to D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness.

This generated 56 "const const" declarations, of which 25 were triple const!

Jan 26 2020, 4:06 PM · Restricted Project, Restricted Project

Jan 22 2020

AlexanderLanin updated the diff for D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.

Updated misc-misplaced-const.c to reflect new output and fixed one wrong col in misc-misplaced-const.cpp - I really do not understand how that happened.
Rebased and verified with check-clang-tools.

Jan 22 2020, 12:05 PM · Restricted Project, Restricted Project
AlexanderLanin added a comment to D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.

Could someone commit this? As I can not.
Alexander Lanin <alex@lanin.de>

Jan 22 2020, 3:22 AM · Restricted Project, Restricted Project

Jan 16 2020

AlexanderLanin added a comment to D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.

Thanks for the review!

Jan 16 2020, 6:28 AM · Restricted Project, Restricted Project

Jan 15 2020

AlexanderLanin added a comment to D72374: [docs] use git diff instead of git format-patch.

Hi, could anyone provide feedback here?
Windows and RC Versions of git do not work with format-patch.

Jan 15 2020, 2:28 AM · Restricted Project

Jan 14 2020

AlexanderLanin added reviewers for D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings: alexfh, alexfh_.
Jan 14 2020, 1:09 PM · Restricted Project, Restricted Project
AlexanderLanin added a comment to D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings.

Important: I'm not a python expert. It works fine as far as I can tell. I would feel better if someone with more than a day python experience would say that it is fine.

Jan 14 2020, 12:59 PM · Restricted Project, Restricted Project
AlexanderLanin created D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings.
Jan 14 2020, 12:59 PM · Restricted Project, Restricted Project

Jan 12 2020

AlexanderLanin updated the diff for D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.

Updated revision with llvm_unreachable

Jan 12 2020, 1:14 PM · Restricted Project, Restricted Project

Jan 8 2020

AlexanderLanin added a comment to D72374: [docs] use git diff instead of git format-patch.

I guess it's not so easy to fix as you reported this 1,5 years ago. That's an even better reason to update the documentation to work around the issue.

Jan 8 2020, 12:23 AM · Restricted Project

Jan 7 2020

AlexanderLanin added a comment to D72374: [docs] use git diff instead of git format-patch.

The only difference is the git version in the end:

Jan 7 2020, 4:12 PM · Restricted Project
AlexanderLanin created D72374: [docs] use git diff instead of git format-patch.
Jan 7 2020, 4:09 PM · Restricted Project
AlexanderLanin added a comment to D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.

looking at this at least many are indeed valid results:


I guess false positives could be reduced by eliminating those cases where the variables are (intentionally) modified.

Jan 7 2020, 4:00 PM · Restricted Project, Restricted Project
AlexanderLanin created D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.
Jan 7 2020, 3:53 PM · Restricted Project, Restricted Project
AlexanderLanin added a comment to D72077: [docs] Improve HowTo commit changes from git.

ping? Could someone push this please.

Jan 7 2020, 3:23 PM · Restricted Project

Jan 3 2020

AlexanderLanin added a comment to D72057: [docs] Remove outdated svn/git information from hacking page.

LGTM with a small typo fix. Do you need someone to commit this on your behalf?

Jan 3 2020, 10:33 AM · Restricted Project
AlexanderLanin updated the diff for D72057: [docs] Remove outdated svn/git information from hacking page.

Getting Started since it's Getting Started with the LLVM System

Jan 3 2020, 10:33 AM · Restricted Project

Jan 2 2020

AlexanderLanin updated the diff for D72057: [docs] Remove outdated svn/git information from hacking page.

Not sure we can call this updated proposal 'love': it's definitely not the goal to have less documentation, just less redundancy.

Jan 2 2020, 4:50 PM · Restricted Project
AlexanderLanin updated the diff for D72077: [docs] Improve HowTo commit changes from git.

I do not have commit rights to the repository, someone please commit this change.
Alexander Lanin <alex@lanin.de>

Jan 2 2020, 2:59 PM · Restricted Project
AlexanderLanin added inline comments to D72057: [docs] Remove outdated svn/git information from hacking page.
Jan 2 2020, 2:39 PM · Restricted Project
AlexanderLanin created D72077: [docs] Improve HowTo commit changes from git.
Jan 2 2020, 5:51 AM · Restricted Project
AlexanderLanin added a comment to D71982: [docs] Update path to clang-tools-extra.

@Jim git commit --amend --author="Alexander Lanin <alex@lanin.de>"

Jan 2 2020, 3:22 AM · Restricted Project, Restricted Project

Jan 1 2020

AlexanderLanin updated the diff for D71982: [docs] Update path to clang-tools-extra.

Removed change in hacking page as discussed.
Can someone commit this as apparently I cannot do it myself (I'll create a PR with updated getting started documentation later...), thanks.

Jan 1 2020, 3:43 PM · Restricted Project, Restricted Project
AlexanderLanin added inline comments to D72057: [docs] Remove outdated svn/git information from hacking page.
Jan 1 2020, 1:26 PM · Restricted Project
AlexanderLanin added a reviewer for D72057: [docs] Remove outdated svn/git information from hacking page: aaron.ballman.
Jan 1 2020, 11:07 AM · Restricted Project
AlexanderLanin created D72057: [docs] Remove outdated svn/git information from hacking page.
Jan 1 2020, 11:00 AM · Restricted Project
AlexanderLanin added inline comments to D71982: [docs] Update path to clang-tools-extra.
Jan 1 2020, 11:00 AM · Restricted Project, Restricted Project

Dec 30 2019

AlexanderLanin updated the diff for D71982: [docs] Update path to clang-tools-extra.

Hi,
I don't see the error message you mentioned anywhere, but I'm gonna assume it involves the number of surrounding lines. Here is another attempt with

git show HEAD -U999999 > mypatch.patch

Dec 30 2019, 4:40 AM · Restricted Project, Restricted Project

Dec 29 2019

AlexanderLanin created D71982: [docs] Update path to clang-tools-extra.
Dec 29 2019, 5:24 PM · Restricted Project, Restricted Project

Feb 14 2017

AlexanderLanin updated the diff for D29692: [clang-tidy] add check modernize-use-const-instead-of-define.

Applied review comments and added test cases regarding parenthesis, floats, doubles, wide chars etc

Feb 14 2017, 2:37 PM
AlexanderLanin added inline comments to D29692: [clang-tidy] add check modernize-use-const-instead-of-define.
Feb 14 2017, 2:29 PM
AlexanderLanin added a comment to D29692: [clang-tidy] add check modernize-use-const-instead-of-define.

Thanks for the feedback. As I'm new to this I cannot say whether checking only the file in question fits better with clang-tidy’s policy or not.
Also, I’m not sure about ODR. Of course, it’s a possibility, but isn’t the programmer responsible for that? This will be more of an issue as soon as this check provides a Fix-It solution.

Feb 14 2017, 10:51 AM

Feb 11 2017

AlexanderLanin updated the diff for D29692: [clang-tidy] add check modernize-use-const-instead-of-define.

Fixes as reported in review

Feb 11 2017, 1:16 PM
AlexanderLanin added a comment to D29692: [clang-tidy] add check modernize-use-const-instead-of-define.

Not sure about CppCoreGuidelines as several guidelines have the same rule and I only used CppCoreGuidelines as it's convenient to link a specific rule. But I can move it if you like?!

Feb 11 2017, 1:13 PM

Feb 7 2017

AlexanderLanin created D29692: [clang-tidy] add check modernize-use-const-instead-of-define.
Feb 7 2017, 4:22 PM