Page MenuHomePhabricator

Recent Activity

Today

smeenai committed rGaa93603ff6a4: [runtimes] Fix umbrella component targets (authored by smeenai).
[runtimes] Fix umbrella component targets
Sat, Jun 12, 7:50 PM
holland11 added a comment to D104149: [MCA] Adding the CustomBehaviour class to llvm-mca.

@andreadb I appreciate all of the suggestions. They all make sense to me and I'll get started on implementing them.

Sat, Jun 12, 7:47 PM · Restricted Project
sushmaunnibhavi updated the diff for D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure.

Updated the patch according to @myhsu comments.

Sat, Jun 12, 7:46 PM · Restricted Project
dblaikie committed rG02c718301b30: llvm-objcopy: fix section size truncation/extension when dumping sections (authored by dblaikie).
llvm-objcopy: fix section size truncation/extension when dumping sections
Sat, Jun 12, 7:30 PM
stephan.yichao.zhao added inline comments to D104165: [dfsan] Add stack-trace printing functions to dfsan interface.
Sat, Jun 12, 7:00 PM · Restricted Project, Restricted Project
kuter added a comment to D104059: [WIP][Attributor] Derive AACallEdges attribute.

Can you please reupload after clang formatting the code :)

Sat, Jun 12, 6:39 PM · Restricted Project
kuter updated the diff for D104059: [WIP][Attributor] Derive AACallEdges attribute.
  • Custom iterator for lazly creating AACallEdges
  • GraphTraits implementation
Sat, Jun 12, 6:36 PM · Restricted Project
LuoYuanke committed rG9eb2f723c245: [X86] Check immediate before get it. (authored by LuoYuanke).
[X86] Check immediate before get it.
Sat, Jun 12, 6:32 PM
LuoYuanke closed D104037: [X86] Check immediate before get it..
Sat, Jun 12, 6:31 PM · Restricted Project
davrec accepted D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.
Sat, Jun 12, 6:17 PM · Restricted Project
lhames committed rG49f4a58d53c7: [ORC-RT] Split Simple-Packed-Serialization code into its own header. (authored by lhames).
[ORC-RT] Split Simple-Packed-Serialization code into its own header.
Sat, Jun 12, 6:07 PM
davidxl added a comment to D104060: Machine IR Profile.

Thanks for the data. With value profile disabled, __llvm_prf_vnds section
should not be emitted -- there is a bug in the compiler.

Sat, Jun 12, 5:14 PM · Restricted Project
bondhugula updated the diff for D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.

Update commit title/summary on phab.

Sat, Jun 12, 4:59 PM · Restricted Project
ellis added a comment to D104060: Machine IR Profile.

I've added text size data to https://gist.github.com/ellishg/92a68cf82bfdeccd10225154425edc69#gistcomment-3778109 and hopefully it is more clear. I randomly chose the test MultiSource/Benchmarks/FreeBench/fourinarow.test to show the size data. You can see the raw data in https://gist.github.com/ellishg/156639f24d728a88067f903cb53e1643

Sat, Jun 12, 4:55 PM · Restricted Project
bondhugula updated the diff for D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.

Mark the change NFC.

Sat, Jun 12, 4:46 PM · Restricted Project
ellis added a comment to D104164: Remove __llvm_mipmap section in llvm-strip.

I'm wondering if you can use llvm-objcopy --remove-section for these purposes instead?

Sat, Jun 12, 4:46 PM · Restricted Project
bondhugula requested review of D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.
Sat, Jun 12, 4:46 PM · Restricted Project
alexshap added a comment to D104164: Remove __llvm_mipmap section in llvm-strip.

I'm wondering if you can use llvm-objcopy --remove-section for these purposes ?

Sat, Jun 12, 4:25 PM · Restricted Project
mehdi_amini committed rG152c9871e6ac: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks (authored by mehdi_amini).
Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks
Sat, Jun 12, 3:56 PM
mehdi_amini closed D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 3:55 PM · Restricted Project
rriddle accepted D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 3:21 PM · Restricted Project
jdoerfert added a comment to D101977: [OpenMP] Create custom state machines for generic target regions.

ping?

Sat, Jun 12, 3:10 PM · Restricted Project
mehdi_amini requested review of D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 2:58 PM · Restricted Project
nikic added a reviewer for D104184: [Coroutine] Put byval params' value into frame, instead of just pointer: efriedma.
Sat, Jun 12, 2:33 PM · Restricted Project
fhahn added inline comments to D100260: [VPlan] Merge predicated-triangle regions, after sinking..
Sat, Jun 12, 2:32 PM · Restricted Project
fhahn updated the diff for D100260: [VPlan] Merge predicated-triangle regions, after sinking..

Thanks for the initial comments! Sorry for the delay with following up.

Sat, Jun 12, 2:32 PM · Restricted Project
fhahn requested review of D104188: [VPlan] Support PHIs as LastInst when inserting scalars in ::get()..
Sat, Jun 12, 2:22 PM · Restricted Project
lebedev.ri requested review of D104187: [DAGCombine] reduceBuildVecToShuffle(): sort input vectors by decreasing size.
Sat, Jun 12, 2:22 PM · Restricted Project
yshui updated the diff for D98659: [MachineCopyPropagation] Do more backward copy propagations.

One more affected test: CodeGen/ARM/umulo-128-legalisation-lowering.ll

Sat, Jun 12, 2:10 PM · Restricted Project
lebedev.ri committed rG2db64e199aa3: [NFC][X86][Codegen] Add shuffle test that would benefit from sorting in… (authored by lebedev.ri).
[NFC][X86][Codegen] Add shuffle test that would benefit from sorting in…
Sat, Jun 12, 2:08 PM
mehdi_amini committed rG8bc1ce0f61da: Use dyn_cast_or_null instead of dyn_cast in FunctionLike::verifyTrait (NFC) (authored by mehdi_amini).
Use dyn_cast_or_null instead of dyn_cast in FunctionLike::verifyTrait (NFC)
Sat, Jun 12, 2:06 PM
rengolin added a comment to D103906: Do not generate calls to the 128-bit function __multi3() on 32-bit ARM..

The build builders/53/builds/3020 fails due a time out. I don't think this is an actual failure. Maybe someone could increase the time out value for certain long-running tests.

Sat, Jun 12, 1:18 PM · Restricted Project
zero9178 added a comment to D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.

Was this performance hit when using the static analyzer? A quick search suggests isAnyDestructorNoReturn() is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (hasIrrelevantDestructor() etc.) seem to be called somewhere by Sema.

So non-users of the analyzer would not benefit from this change, and will incur a slight cost, IIUC. Is that cost remotely noticeable? Probably not, but a quick test along those lines would be helpful.

All in all this is probably good and advisable.

Sat, Jun 12, 1:15 PM · Restricted Project
MaskRay added inline comments to D101332: [llvm-objcopy] Exclude empty sections in IHexWriter output.
Sat, Jun 12, 12:50 PM · Restricted Project
MaskRay requested review of D104186: [llvm-objcopy] Make ihex writer similar to binary writer.
Sat, Jun 12, 12:50 PM · Restricted Project
cjdb updated the diff for D104171: Revert "Revert "[libcxx][gardening] Move all algorithms into their own headers."".

rebases to activate CI

Sat, Jun 12, 12:30 PM · Restricted Project
cjdb updated the diff for D104170: Revert "Revert "[libcxx][module-map] creates submodules for private headers"".

rebases to activate CI

Sat, Jun 12, 12:30 PM · Restricted Project
cjdb updated the diff for D104175: [libcxx][iwyu] ensures we IWYU as prep for modules.

updates a lot of that were lacking explicit header inclusions (see most recent failures in D104170)

Sat, Jun 12, 12:27 PM · Restricted Project
davrec added a comment to D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.

Was this performance hit when using the static analyzer? A quick search suggests isAnyDestructorNoReturn() is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (hasIrrelevantDestructor() etc.) seem to be called somewhere by Sema.

Sat, Jun 12, 12:24 PM · Restricted Project
MaskRay committed rG5899278758b6: [llvm-objcopy] Exclude empty sections in IHexWriter output (authored by mciantyre).
[llvm-objcopy] Exclude empty sections in IHexWriter output
Sat, Jun 12, 12:23 PM