Page MenuHomePhabricator
Feed All Stories

Thu, Apr 8

aardappel closed D99904: [WebAssembly] Fix for PIC external symbol ISEL.
Thu, Apr 8, 12:08 PM · Restricted Project
rampitec accepted D100123: [AMDGPU] Add TransVALU to gfx10.

LGTM. What about other models?

Thu, Apr 8, 12:06 PM · Restricted Project
kzhuravl updated the diff for D100126: AMDGPU: Add gfx90c support to code object v2 for backwards compatibility.

Address review feedback.

Thu, Apr 8, 12:06 PM · Restricted Project
aardappel added inline comments to D99904: [WebAssembly] Fix for PIC external symbol ISEL.
Thu, Apr 8, 12:05 PM · Restricted Project
zoecarver added a comment to D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..

For sure, will do, thanks for reviewing!

Thu, Apr 8, 12:00 PM · Restricted Project
congzhe committed rGce2db9005d70: [LoopInterchange] Fix transformation bugs in loop interchange (authored by congzhe).
[LoopInterchange] Fix transformation bugs in loop interchange
Thu, Apr 8, 12:00 PM
wenlei updated the diff for D100090: [CSSPGO] Fix dangling context strings and improve profile order consistency and error handling.

Address Hongtao's comments.

Thu, Apr 8, 12:00 PM · Restricted Project
congzhe closed D98475: [LoopInterchange] Fix transformation bugs in loop interchange.
Thu, Apr 8, 11:59 AM · Restricted Project
wenlei added inline comments to D100090: [CSSPGO] Fix dangling context strings and improve profile order consistency and error handling.
Thu, Apr 8, 11:59 AM · Restricted Project
ldionne accepted D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..

Thanks! Ship it once CI passes. And you can then close https://llvm.org/PR32147. Thanks a lot!

Thu, Apr 8, 11:58 AM · Restricted Project
nikic accepted D99977: [GVN] Properly invalidate ICF cache when we simplify a value.

LGTM

Thu, Apr 8, 11:57 AM · Restricted Project
zoecarver updated the diff for D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
  • Test the right thing!
  • Remove "explicit" in ctor comment.
Thu, Apr 8, 11:56 AM · Restricted Project
jcai19 added inline comments to D98916: [ARM] support symbolic expression as immediate in memory instructions.
Thu, Apr 8, 11:56 AM · Restricted Project
aeubanks retitled D99977: [GVN] Properly invalidate ICF cache when we simplify a value from [GVN] Clear ICF cache when we simplify a value to [GVN] Properly invalidate ICF cache when we simplify a value.
Thu, Apr 8, 11:52 AM · Restricted Project
craig.topper committed rG461b55499981: [RISCV] Add InstAlias for Zbb Zbp and Zbs extension (authored by LevyHsu).
[RISCV] Add InstAlias for Zbb Zbp and Zbs extension
Thu, Apr 8, 11:52 AM
craig.topper closed D100083: [RISCV] Add InstAlias for Zbb Zbp and Zbs extension.
Thu, Apr 8, 11:52 AM · Restricted Project
jcai19 updated the diff for D98916: [ARM] support symbolic expression as immediate in memory instructions.

Fix a typo.

Thu, Apr 8, 11:52 AM · Restricted Project
aeubanks updated the diff for D99977: [GVN] Properly invalidate ICF cache when we simplify a value.

selectively invalidate

Thu, Apr 8, 11:51 AM · Restricted Project
asbirlea added a comment to D98103: [NPM] Do not run function simplification pipeline unnecessarily.

Restating summary of offline discussion:
Up until now, the repetition of simplification passes has hidden phase ordering issues or the need to rerun certain passes. Turning this flag on will improve compile time and resolve potential exponential compile-time increases, but will also reveal all the cases where the pass pipeline needs to be adjusted to not miss optimizations that were previously done on the follow-up optimization runs.

Thu, Apr 8, 11:49 AM · Restricted Project
jcai19 added a comment to D98916: [ARM] support symbolic expression as immediate in memory instructions.

I have a one major concern, and a number of minor nits that could easily be addressed prior to commit if necessary.

The major concern is that if the intent is to just permit expressions for Arm state LDR instructions (addition of one fixup) then a lot of code in the AsmParser looks like it is permitting expressions for Thumb and Thumb2 LDR instructions that wouldn't use the one new fixup. Can you double check the predicates to make sure that they apply to the instructions you want to permit expressions on? It is possible I've got something wrong though. If I'm right then where we would have had errors had someone use an expression then we may get an internal error or crash as the backend won't be able to handle the expression. My suggestion would be to take out from ARMAsmParser all the code permitting exceptions except for the ARM instructions that support the fixup. Adding support for expressions to all the ARM and Thumb instructions is possible but that would probably be better done over several patches. If I'm wrong please ignore me and sorry for the noise.

Thu, Apr 8, 11:49 AM · Restricted Project
jcai19 updated the diff for D98916: [ARM] support symbolic expression as immediate in memory instructions.

Address comments.

Thu, Apr 8, 11:48 AM · Restricted Project
xingxue requested review of D100132: [libunwind][AIX] Initial patch of the unwinder on AIX.
Thu, Apr 8, 11:48 AM · Restricted Project, Restricted Project
spatel committed rG5094e1279eb2: [InstCombine] fold min/max intrinsic with negated operand to abs (authored by spatel).
[InstCombine] fold min/max intrinsic with negated operand to abs
Thu, Apr 8, 11:47 AM
spatel committed rGc52dbdbc33b9: [InstCombine] add tests for min/max with negated operand; NFC (authored by spatel).
[InstCombine] add tests for min/max with negated operand; NFC
Thu, Apr 8, 11:47 AM
hanchung added inline comments to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 11:45 AM · Restricted Project
Quuxplusone accepted D100129: Tiny format fix.
Thu, Apr 8, 11:45 AM · Restricted Project
ldionne added inline comments to D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
Thu, Apr 8, 11:45 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

address comments

Thu, Apr 8, 11:45 AM · Restricted Project
ABataev requested review of D100131: [SLP]Fix PR49898: Infinite loop in SLP vectorizer..
Thu, Apr 8, 11:44 AM · Restricted Project
oontvoo added inline comments to D100011: [lld-macho] Make time-trace* options more permissive..
Thu, Apr 8, 11:37 AM · Restricted Project, Restricted Project
SaurabhJha added a comment to D99037: [Matrix] Implement C-style explicit type conversions for matrix types.

The windows build failure is solved by itself and its all passing now!

Thu, Apr 8, 11:37 AM · Restricted Project
craig.topper committed rG02ef9963e1ad: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target. (authored by craig.topper).
[RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target.
Thu, Apr 8, 11:36 AM
craig.topper closed D99984: [RISCV] Prevent __builtin_riscv_orc_b_64 from being compiled RV32 target..
Thu, Apr 8, 11:36 AM · Restricted Project
zoecarver accepted D99691: [libcxx] adjusts formatting rules.

I started working on SpacesInAngles: Leave option for clang-format. If that's accepted, we could use this option together with Standard: Latest (or c++20, btw, Cpp11 is deprecated). I need to check that there's nothing else apart angle brackets that may break pre-C++20 code.

Thu, Apr 8, 11:35 AM · Restricted Project
t-tye requested changes to D100126: AMDGPU: Add gfx90c support to code object v2 for backwards compatibility.
Thu, Apr 8, 11:35 AM · Restricted Project
brooksmoses added a comment to D75844: [clang] Set begin loc on GNU attribute parsed attrs.

FWIW, this now causes Clang to produce an error on this code, when it didn't before:

Thu, Apr 8, 11:31 AM · Restricted Project
ldionne added a comment to D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class..

FWIW, I think this is acceptable, but I think even better would be to make it clear in the Standard that this is acceptable. Having spoken with a few folks about this, it doesn't appear to be specified very clearly.

Thu, Apr 8, 11:25 AM · Restricted Project
tlively updated subscribers of D100018: [WebAssembly] Add shuffles as an option for lowering BUILD_VECTOR.
Thu, Apr 8, 11:20 AM · Restricted Project
zoecarver added inline comments to D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
Thu, Apr 8, 11:16 AM · Restricted Project
zoecarver updated the diff for D80882: [libcxx] Allow shared_ptr's unique_ptr converting constructor to support array types..
  • Remove constraint not is_array from overloads.
Thu, Apr 8, 11:15 AM · Restricted Project
dblaikie added a comment to D99751: Add the TableGen assert statement, step 3.

Ah, so I take it from what you're saying that I can start a new branch and then do a revert of an arbitrary commit on it? I guess there is no reason why not.

Thu, Apr 8, 11:14 AM · Restricted Project
rampitec committed rG5f0ac1ef7888: Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph() (authored by rampitec).
Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph()
Thu, Apr 8, 11:14 AM
rampitec closed D99897: Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph().
Thu, Apr 8, 11:14 AM · Restricted Project
jrtc27 accepted D100083: [RISCV] Add InstAlias for Zbb Zbp and Zbs extension.
Thu, Apr 8, 11:14 AM · Restricted Project
int3 committed rGc23b92acd065: [lld-macho] Support -add_ast_path (authored by int3).
[lld-macho] Support -add_ast_path
Thu, Apr 8, 11:13 AM
int3 added inline comments to D100011: [lld-macho] Make time-trace* options more permissive..
Thu, Apr 8, 11:13 AM · Restricted Project, Restricted Project
int3 committed rGc2e76a9a6dcc: [lld-macho][nfc] Use varargs form of hasArg() (authored by int3).
[lld-macho][nfc] Use varargs form of hasArg()
Thu, Apr 8, 11:13 AM
craig.topper added a comment to D100115: [RISCV] Add missing part of instruction vmsge {u}. VX.

Upload patches with full context using git diff -U99999 as documented here https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Thu, Apr 8, 11:13 AM · Restricted Project
int3 closed D100076: [lld-macho] Support -add_ast_path.
Thu, Apr 8, 11:13 AM · Restricted Project, Restricted Project
ldionne added inline comments to D97115: [libc++] Make chars_format a bitmask type..
Thu, Apr 8, 11:11 AM · Restricted Project
Qix- updated the diff for D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

Updated the diff to include a lot more context (-U9999). Thanks again for the tip :)

Thu, Apr 8, 11:10 AM · Restricted Project
cjdb added inline comments to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Thu, Apr 8, 11:06 AM · Restricted Project
hoy added inline comments to D100090: [CSSPGO] Fix dangling context strings and improve profile order consistency and error handling.
Thu, Apr 8, 11:05 AM · Restricted Project
Mordante added inline comments to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Thu, Apr 8, 11:05 AM · Restricted Project
Qix- updated the diff for D99877: [Clang] Allow processing of attributes on statements by plugins.
Thu, Apr 8, 11:05 AM · Restricted Project
mgorny committed rGd01bff8cbdc9: [lldb] [test] Skip clone() tests on Linux/aarch64 (authored by mgorny).
[lldb] [test] Skip clone() tests on Linux/aarch64
Thu, Apr 8, 11:04 AM
abhina.sreeskantharajan requested review of D100130: [SystemZ][z/OS][Windows] Add new functions that set Text/Binary mode for Stdin and Stdout based on OpenFlags.
Thu, Apr 8, 11:04 AM · Restricted Project
craig.topper accepted D100083: [RISCV] Add InstAlias for Zbb Zbp and Zbs extension.

LGTM This matches what we do for immediate instructions in the base ISA.

Thu, Apr 8, 11:02 AM · Restricted Project
aorlov added a comment to D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations).

@krisb Thank you for your comments. I will consider them.

Thu, Apr 8, 11:02 AM · Restricted Project, Restricted Project
antiagainst accepted D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Cool, just one final comment.

Thu, Apr 8, 11:01 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

Okay, I have reverted this revision.

Thu, Apr 8, 11:01 AM · Restricted Project
bmahjour added a comment to D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..

You're right, that comment wasn't correct. I wrote the code last week and incorrectly remembered the change when writing up the comment today.

The issue has to do with the truncation. It stores the floating-point cost in the ProfitableVFs list as unsigned.

For llvm/test/Transforms/LoopVectorize/X86/intrinsiccost.ll, it then compares the costs as follows:

1 < 2 ? true
0 < 1 ? true
0 < 0 ? false

Where it now compares the costs properly as:

5/4 < 5/2 ? true
5/8 < 5/4 ? true
5/16 < 5/8 ? true
Thu, Apr 8, 11:00 AM · Restricted Project
NoQ added a comment to D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way.

I'm catching up and these changes look great.

Thu, Apr 8, 10:59 AM · Restricted Project
Paul-C-Anagnostopoulos added a reverting change for rG3b9a15d910a8: [TableGen] Add support for the 'assert' statement in multiclasses: rG3f919ff25013: Revert "[TableGen] Add support for the 'assert' statement in multiclasses".
Thu, Apr 8, 10:59 AM
Paul-C-Anagnostopoulos committed rG3f919ff25013: Revert "[TableGen] Add support for the 'assert' statement in multiclasses" (authored by Paul-C-Anagnostopoulos).
Revert "[TableGen] Add support for the 'assert' statement in multiclasses"
Thu, Apr 8, 10:59 AM
JDevlieghere committed rGb68545acf977: [lldb] Improve the documentation (#42017) (authored by sushmaunnibhavi).
[lldb] Improve the documentation (#42017)
Thu, Apr 8, 10:58 AM
aeubanks added a comment to D100116: Reuse temporary files for print-changed=diff..

I think I made the request because I thought that FileName and FD were being populated every time, but that's actually not the case.

Thu, Apr 8, 10:58 AM · Restricted Project
JDevlieghere closed D100053: Fixed bug issue #42017.
Thu, Apr 8, 10:58 AM · Restricted Project
efriedma added a comment to D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level.

How is llvm.arith.fence() different from using "freeze" on a floating-point value? The goal isn't really the same, sure, but the effects seem similar at first glance.

They are similar. However, freeze is a no-op if the operand can be proven not to be undef or poison, and in such circumstances could be removed by an optimizer. llvm.arith.fence cannot be removed by an optimizer, because doing so might allow instructions that were "outside" the fence from being reassociated/distrbuted with the instructions/operands that were inside the fence.

Thu, Apr 8, 10:57 AM · Restricted Project
antiagainst accepted D100128: [mlir][spirv] Define spv.ImageDrefGather operation.

Cool, just two minor issue.

Thu, Apr 8, 10:56 AM · Restricted Project
clayborg accepted D100076: [lld-macho] Support -add_ast_path.

Thanks for checking. As long as ld64 allows multiple, I am good.

Thu, Apr 8, 10:56 AM · Restricted Project, Restricted Project
cjdb added inline comments to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.
Thu, Apr 8, 10:55 AM · Restricted Project
daltenty updated the diff for D100071: Add csum fallback to HashProgramOutput.sh.
  • Correct the options we pass to csum
Thu, Apr 8, 10:54 AM
Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

Ah, so I take it from what you're saying that I can start a new branch and then do a revert of an arbitrary commit on it? I guess there is no reason why not.

Thu, Apr 8, 10:54 AM · Restricted Project
sdesmalen added a comment to D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..

You're right, that comment wasn't correct. I wrote the code last week and incorrectly remembered the change when writing up the comment today.

Thu, Apr 8, 10:53 AM · Restricted Project
NoQ added a comment to D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast.

Which is fairly shocking and mind blowing that we've organically developed two independent implementations of casting, one for RegionStore and one for everything else.

Thu, Apr 8, 10:53 AM · Restricted Project
sdesmalen updated the summary of D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor..
Thu, Apr 8, 10:52 AM · Restricted Project
yaxunl added a comment to D99683: [HIP] Support ThinLTO.

Any other concerns? Thanks.

Thu, Apr 8, 10:52 AM · Restricted Project
Mordante added a comment to D99862: [libc++] [CI] Validate the output of the generated scripts..

I meant the temporary change to provoke the failure:). That's already reverted from what I see. :)

Thu, Apr 8, 10:51 AM · Restricted Project
zoecarver added a comment to D99141: [libcxx] adds `std::incrementable_traits` to <iterator>.

This still LGTM. I think we should land this to get stuff unblocked! (After another reviewer approves.)

Thu, Apr 8, 10:50 AM · Restricted Project
dblaikie added a comment to D99751: Add the TableGen assert statement, step 3.

The reason I haven't reverted this patch is because I don't feel comfortable doing a revert with the tangled up branches I have. Do you think it's safe to revert the commit on my 'assert' branch even though it is not the topmost commit?

Thu, Apr 8, 10:48 AM · Restricted Project
urnathan requested review of D100129: Tiny format fix.
Thu, Apr 8, 10:48 AM · Restricted Project
cjdb accepted D90999: [libc++] Implements ranges::enable_borrowed_range.
Thu, Apr 8, 10:45 AM · Restricted Project
efriedma added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

Please add a test for (char*)0-(char*)0.

Thu, Apr 8, 10:44 AM · Restricted Project
hanchung updated the summary of D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 10:43 AM · Restricted Project
hanchung added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Also added the implementation of SPIRVTypeConverter::getOptions().

Thu, Apr 8, 10:43 AM · Restricted Project
Mordante added a reviewer for D90999: [libc++] Implements ranges::enable_borrowed_range: cjdb.
Thu, Apr 8, 10:42 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

The reason I haven't reverted this patch is because I don't feel comfortable doing a revert with the tangled up branches I have. Do you think it's safe to revert the commit on my 'assert' branch even though it is not the topmost commit?

Thu, Apr 8, 10:42 AM · Restricted Project
hanchung added inline comments to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.
Thu, Apr 8, 10:42 AM · Restricted Project
hanchung updated the diff for D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

address comments

Thu, Apr 8, 10:42 AM · Restricted Project
antiagainst committed rG151752ab2082: [mlir][linalg] Fix loop upper bounds in conv fusion test (authored by antiagainst).
[mlir][linalg] Fix loop upper bounds in conv fusion test
Thu, Apr 8, 10:42 AM
antiagainst closed D100112: [mlir][linalg] Fix loop upper bounds in conv fusion test.
Thu, Apr 8, 10:42 AM · Restricted Project
wenlei updated the diff for D100090: [CSSPGO] Fix dangling context strings and improve profile order consistency and error handling.

Update comments.

Thu, Apr 8, 10:40 AM · Restricted Project
dblaikie added a comment to D99751: Add the TableGen assert statement, step 3.

I just pushed this revision and I have no idea how. I meant to push the list slice suffix revision, which I did, and somehow this one went along with it.

Thu, Apr 8, 10:36 AM · Restricted Project
wenlei added inline comments to D100090: [CSSPGO] Fix dangling context strings and improve profile order consistency and error handling.
Thu, Apr 8, 10:35 AM · Restricted Project
dblaikie added a comment to D99900: [llvm] [testsuite] Fix invalid DW_AT_location DWARF expression in unattached-global.ll.

Maybe I'm missing something but it looks to me like this test is supposed to test that we don't attach DW_AT_location to a variable that has been optimized out.

This test is what you get after optimizing away

someglobal = i32 ..., !dbg !3

and I don't think it is invalid at all. Since it doesn't hold a constant, the DIExpression is meaningless without being attached to a global, but it's not invalid IR. It just shouldn't get output in DWARF.

This going to get less ambiguous with the ongoing work to make arguments in DIExpressions more explicit.

Thu, Apr 8, 10:35 AM · Restricted Project
tra added a reviewer for D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions: tra.
Thu, Apr 8, 10:34 AM · Restricted Project, Restricted Project
tra added inline comments to D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions.
Thu, Apr 8, 10:34 AM · Restricted Project, Restricted Project
arsenm accepted D100109: [RegisterScavenging] Add asserts for better errors.
Thu, Apr 8, 10:31 AM · Restricted Project
Weiwei-2021 requested review of D100128: [mlir][spirv] Define spv.ImageDrefGather operation.
Thu, Apr 8, 10:31 AM · Restricted Project