Page MenuHomePhabricator
Feed All Stories

Thu, Jan 14

joechrisellis added a comment to D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls.

@fhahn: thanks for your comments -- you have persuaded me. 馃檪

Thu, Jan 14, 7:09 AMRestricted Project
joechrisellis updated the diff for D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls.

Address @fhahn's comments.

Thu, Jan 14, 7:09 AMRestricted Project
fhahn requested review of D94687: [AArch64] Make target intrinsics DefaultAttrIntrinsics..
Thu, Jan 14, 7:09 AMRestricted Project
tomrittervg retitled D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior from [PATCH] [clang-query] Add a --use-color option to clang-query to [PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 7:07 AMRestricted Project
tomrittervg updated the diff for D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Actually, I think I need to be smarter than changing the default. We want to let clang auto-detect the tty and behave that way by default if the option isn't specified. Otherwise you'd get ASNI color codes when you pipe to a file.

Thu, Jan 14, 7:07 AMRestricted Project
jsji added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 7:07 AMRestricted Project
aaron.ballman added inline comments to D94126: [ASTMatchers] Make it possible to use empty variadic matchers.
Thu, Jan 14, 7:06 AMRestricted Project
HsiangKai updated the diff for D94229: [RISCV] Implement vlseg intrinsics..
Thu, Jan 14, 7:05 AMRestricted Project
thopre added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I've tried applying your patch and its test fail for me.

Thu, Jan 14, 7:01 AM
thopre requested changes to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I've tried applying your patch and its test fail for me.

Thu, Jan 14, 7:00 AM
thopre added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

I've seen it landed on the upstream branch rather than the main branch. Was that a mistake?

Thu, Jan 14, 6:58 AM
antiagainst committed rG6b9fa8a50d0f: [mlir][linalg] Add docstring support for named op spec (authored by antiagainst).
[mlir][linalg] Add docstring support for named op spec
Thu, Jan 14, 6:58 AM
antiagainst closed D94548: [mlir][linalg] Add docstring support for named op spec.
Thu, Jan 14, 6:58 AMRestricted Project
aaron.ballman added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:57 AMRestricted Project
Anastasia committed rGadb77a745692: [OpenCL] Improve online documentation. (authored by Anastasia).
[OpenCL] Improve online documentation.
Thu, Jan 14, 6:57 AM
Anastasia closed D93942: [OpenCL] Improve online documentation..
Thu, Jan 14, 6:57 AMRestricted Project
sameeranjoshi added inline comments to D93453: [flang][driver] Add support for `-I`.
Thu, Jan 14, 6:54 AMRestricted Project, Restricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:54 AMRestricted Project
thopre requested review of D94686: Fix all unused imports flake8 warnings.
Thu, Jan 14, 6:54 AM
sameeranjoshi added inline comments to D94422: [flang][driver] Unify f18_version.h.in and Version.inc.in.
Thu, Jan 14, 6:53 AMRestricted Project, Restricted Project
tskeith committed rG3e41ab18db22: [flang] Fix dangling pointer in LabelEnforce (authored by tskeith).
[flang] Fix dangling pointer in LabelEnforce
Thu, Jan 14, 6:53 AM
tskeith closed D94618: [flang] Fix dangling pointer in LabelEnforce.
Thu, Jan 14, 6:52 AMRestricted Project, Restricted Project
RKSimon committed rG0b46f19a9ecd: [Support] Ensure KnownBits::sextInReg can handle the src == dst sext-in-reg鈥 (authored by RKSimon).
[Support] Ensure KnownBits::sextInReg can handle the src == dst sext-in-reg鈥
Thu, Jan 14, 6:51 AM
balazske added a comment to D94673: [analyzer][CTU] API for CTU macro expansions.

Probably the CrossTranslationUnitContext::ImportedFileIDs can be removed. The FileIDImportHandler in ASTImporter was used only for this (if I know correctly) too but it can be useful if a similar mechanism is needed later, but it remains there as "dead code" if not removed.

Thu, Jan 14, 6:50 AMRestricted Project
sameeranjoshi added a comment to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

Hi @sameeranjoshi , thank you for working on this!

Sadly with this patch one of our upstream builders has started failing: http://lab.llvm.org:8011/#/builders/33/builds/1866. More specifically,Semantics/omp-parallell01.f90 is failing.

All other builders are fine, which makes this weird. The only unique thing about the failing builder (flang-aarch64-ubuntu-clang) is that it uses clang-10. Could you take a look?

Edit: @kiranchandramohan just pointed out to me offline that this is probably fixed here: https://reviews.llvm.org/D94618.

Thu, Jan 14, 6:50 AMRestricted Project, Restricted Project
sgraenitz committed rG332e220ef42b: [docs] Update DebuggingJITedCode page after fix in LLDB (authored by sgraenitz).
[docs] Update DebuggingJITedCode page after fix in LLDB
Thu, Jan 14, 6:45 AM
sgraenitz closed D90789: [docs] Update DebuggingJITedCode page after fix in LLDB.
Thu, Jan 14, 6:45 AMRestricted Project
tdl-g accepted D93703: [libTooling] Change `addInclude` to use expansion locs..
Thu, Jan 14, 6:42 AMRestricted Project
frasercrmck added inline comments to D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
Thu, Jan 14, 6:40 AMRestricted Project
nicolasvasilache accepted D94548: [mlir][linalg] Add docstring support for named op spec.
Thu, Jan 14, 6:40 AMRestricted Project
tomrittervg added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:39 AMRestricted Project
sameeranjoshi accepted D94618: [flang] Fix dangling pointer in LabelEnforce.

Thank you for the patch.
I did get an email from the bot with a weird text Control flow escapes from \xcb\x1c\xda\xff\xff\nexpect at 16: Control flow escapes from PARALLEL\n'
I had a build of gcc 9.2 and the tried to check with the recent pull from main and all tests seem to work.
It was pointed[1] by @awarzynski that the issue was specifically due to clang-10.

Thu, Jan 14, 6:39 AMRestricted Project, Restricted Project
frasercrmck updated the diff for D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs.
  • replace patterns with custom-lowering
Thu, Jan 14, 6:39 AMRestricted Project
sdesmalen added inline comments to D94142: [IR] Allow scalable vectors in structs to support intrinsics returning multiple values..
Thu, Jan 14, 6:38 AMRestricted Project
tislam added a comment to D94576: [LoopVectorize] Guard verifyFunction with EXPENSIVE_CHECKS macro.

Hi @lebedev.ri, I have uploaded an IR file that demonstrates the compile-time implications on our system. I used the following invocation.

Thu, Jan 14, 6:36 AMRestricted Project
sdesmalen accepted D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

Added two nits, but LGTM otherwise.

Thu, Jan 14, 6:36 AMRestricted Project
drich7449 added 1 auditor(s) for rG19297a417117: Change XCore code owner.: Restricted Project.
Thu, Jan 14, 6:35 AM
asb added a comment to D94589: [RISCV] Add intrinsics for vector AMO instructions.

Nitpick: this would be better titled "[RISCV] Add intrinsics for vector AMO instructions" - I was a little confused seeing the title come past :)

Thu, Jan 14, 6:35 AMRestricted Project
sfertile added inline comments to D94458: [PowerPC] Only use some extend mne if assembler is modern enough.
Thu, Jan 14, 6:34 AMRestricted Project
RKSimon added a comment to rG9cf4f493a72f: [DAG] Move SelectionDAG implementation to KnownBits::setInReg(). NFCI..

This was a direct move from SelectionDAG's implementation as I wanted to avoid introducing any subtle behaviour changes - I've added the exhaustive tests (which has already exposed one issue I'm fixing now) and I'll start cleaning up the KnownBits::sextInReg implementation after that.

Thu, Jan 14, 6:34 AM
jansvoboda11 updated the diff for D94682: [clang][cli] Parse Lang and CodeGen options separately.

Stop setting the default for LaxVectorConversions in CompilerInvocation

Thu, Jan 14, 6:32 AMRestricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:32 AMRestricted Project
drich7449 added a comment to rGe8622d27c0e3: [Support] Add KnownBits::sextInReg exhaustive tests.

Macro testcase:

Thu, Jan 14, 6:32 AM
ntesic added a comment to D78105: [CSInfo][ISEL] Call site info generation support for Mips.
Thu, Jan 14, 6:31 AMRestricted Project, Restricted Project, debug-info
kiranchandramohan requested changes to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Thu, Jan 14, 6:31 AMRestricted Project, Restricted Project, Restricted Project
RKSimon committed rGe8622d27c0e3: [Support] Add KnownBits::sextInReg exhaustive tests (authored by RKSimon).
[Support] Add KnownBits::sextInReg exhaustive tests
Thu, Jan 14, 6:28 AM
ntesic requested review of D94685: [CSInfo][MIPS] Update CSInfo during MipsDelaySlotFiller.
Thu, Jan 14, 6:26 AMRestricted Project, debug-info
tomrittervg added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:24 AMRestricted Project
foad committed rG90b310f6caf0: [Support] Simplify KnownBits::icmp helpers. NFC. (authored by foad).
[Support] Simplify KnownBits::icmp helpers. NFC.
Thu, Jan 14, 6:23 AM
foad committed rG517196e56912: [Analysis,CodeGen] Make use of KnownBits::makeConstant. NFC. (authored by foad).
[Analysis,CodeGen] Make use of KnownBits::makeConstant. NFC.
Thu, Jan 14, 6:23 AM
foad committed rGa1cba5b7a1fb: [SelectionDAG] Make use of KnownBits::commonBits. NFC. (authored by foad).
[SelectionDAG] Make use of KnownBits::commonBits. NFC.
Thu, Jan 14, 6:23 AM
foad closed D94595: [Support] Simplify KnownBits::icmp helpers. NFC..
Thu, Jan 14, 6:23 AMRestricted Project
foad closed D94588: [Analysis,CodeGen] Make use of KnownBits::makeConstant. NFC..
Thu, Jan 14, 6:23 AMRestricted Project
foad closed D94587: [SelectionDAG] Make use of KnownBits::commonBits. NFC..
Thu, Jan 14, 6:23 AMRestricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 6:22 AMRestricted Project
jansvoboda11 updated the summary of D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members.
Thu, Jan 14, 6:16 AMRestricted Project
kiranchandramohan added a reviewer for D94618: [flang] Fix dangling pointer in LabelEnforce: awarzynski.
Thu, Jan 14, 6:15 AMRestricted Project, Restricted Project
jansvoboda11 updated the summary of D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR.
Thu, Jan 14, 6:14 AMRestricted Project
jansvoboda11 updated the summary of D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually.
Thu, Jan 14, 6:14 AMRestricted Project
jansvoboda11 updated the summary of D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually.
Thu, Jan 14, 6:13 AMRestricted Project
jansvoboda11 updated the summary of D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually.
Thu, Jan 14, 6:13 AMRestricted Project
jansvoboda11 updated the summary of D94682: [clang][cli] Parse Lang and CodeGen options separately.
Thu, Jan 14, 6:11 AMRestricted Project
awarzynski added a comment to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

Hi @sameeranjoshi , thank you for working on this!

Thu, Jan 14, 6:09 AMRestricted Project, Restricted Project
xbolva00 added a comment to D94684: [InferAttrs] Mark some library functions as willreturn..

Looks ok.

Thu, Jan 14, 6:07 AMRestricted Project
augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Thu, Jan 14, 6:07 AMRestricted Project
fhahn requested review of D94684: [InferAttrs] Mark some library functions as willreturn..
Thu, Jan 14, 5:59 AMRestricted Project
abhina.sreeskantharajan accepted D94683: [Doc] Fix syntax error in CodeGenerator documentation example.

LGTM

Thu, Jan 14, 5:58 AMRestricted Project
fhahn committed rGc23e34e606bf: [InferFunctionAttrs] Improve CHECK variable names (NFC). (authored by fhahn).
[InferFunctionAttrs] Improve CHECK variable names (NFC).
Thu, Jan 14, 5:54 AM
RKSimon accepted D94595: [Support] Simplify KnownBits::icmp helpers. NFC..

LGTM

Thu, Jan 14, 5:54 AMRestricted Project
RKSimon accepted D94587: [SelectionDAG] Make use of KnownBits::commonBits. NFC..

LGTM - cheers

Thu, Jan 14, 5:53 AMRestricted Project
sanwou01 added a comment to D93946: [FuncAttrs] Infer noreturn.

Could you do some initial investigation or come up with a repro? Maybe an optimization remark that doesn't fire after this change?

Yes, I will do an initial investigation, hopefully resulting in a reproducer. It is always a bit of a challenge with LTO benchmarks, but the regression is large enough that it should be easy to spot.

Thu, Jan 14, 5:53 AMRestricted Project
jansvoboda11 updated the summary of D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members.
Thu, Jan 14, 5:53 AMRestricted Project
thopre accepted D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

LGTM, thanks!

Thu, Jan 14, 5:52 AM
awarzynski committed rGa1bbd1ef1dbd: [flang][driver] Unify f18_version.h.in and Version.inc.in (authored by awarzynski).
[flang][driver] Unify f18_version.h.in and Version.inc.in
Thu, Jan 14, 5:51 AM
awarzynski closed D94422: [flang][driver] Unify f18_version.h.in and Version.inc.in.
Thu, Jan 14, 5:51 AMRestricted Project, Restricted Project
miyuki committed rG176f5e95e1af: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck鈥 (authored by miyuki).
[clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck鈥
Thu, Jan 14, 5:50 AM
miyuki closed D94601: [clang-tidy] Use DenseSet<SourceLocation> in UpgradeDurationConversionsCheck, NFCI.
Thu, Jan 14, 5:50 AMRestricted Project, Restricted Project
jansvoboda11 updated the summary of D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set.
Thu, Jan 14, 5:49 AMRestricted Project
vinograd47 abandoned D94658: Remove redundant move call in return statements.
Thu, Jan 14, 5:49 AMRestricted Project
aaron.ballman added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 5:48 AMRestricted Project
jansvoboda11 updated the summary of D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR.
Thu, Jan 14, 5:46 AMRestricted Project
labath added inline comments to D94672: Implement vAttachOrWait.
Thu, Jan 14, 5:45 AMRestricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

Get tile register number from backend.

Thu, Jan 14, 5:42 AMRestricted Project
aganea updated subscribers of D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.
Thu, Jan 14, 5:41 AMRestricted Project
jansvoboda11 updated the summary of D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually.
Thu, Jan 14, 5:40 AMRestricted Project
steveire added inline comments to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.
Thu, Jan 14, 5:38 AMRestricted Project
steveire added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

I also don't think we need to add unit tests for this, just because we can. The tests would be more complex than the code and wouldn't add much value. https://softwareengineering.stackexchange.com/a/147342 There are lots of resources about this.

Thu, Jan 14, 5:38 AMRestricted Project
aganea added a reverting change for rG854f0984f0b7: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable: rG6abbba3fca9f: Revert "Fix llvm::Optional build breaks in MSVC using std鈥.
Thu, Jan 14, 5:37 AM
aganea committed rG6abbba3fca9f: Revert "Fix llvm::Optional build breaks in MSVC using std鈥 (authored by aganea).
Revert "Fix llvm::Optional build breaks in MSVC using std鈥
Thu, Jan 14, 5:37 AM
aganea added a reverting change for D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable: rG6abbba3fca9f: Revert "Fix llvm::Optional build breaks in MSVC using std鈥.
Thu, Jan 14, 5:37 AMRestricted Project
labath added a comment to D94077: Support unscoped enumeration members in the expression evaluator..

Thanks for the explanation, this makes sense. I've checked the mailing list archives and it seems there was already a discussion about the enumerators in the .debug_names index back in 2018 -- http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2018-April/004443.html. You were the one to bring it up and the consensus was that the enumerators should go into the index too.

But it seems this was never actually implemented, the latest version of the toolchain doesn't add DW_TAG_enumerator entries to the .debug_names index. Is there a reason for that or it just slipped through the cracks? Should I bring it up again on the mailing list or we can assume the consensus is still the same and this should be just implemented?

Thu, Jan 14, 5:35 AMRestricted Project
grimar added a comment to D94667: [llvm-nm] - Move MachO specific logic out from the dumpSymbolNamesFromObject(). NFC..

Does it have to stay in llvm-nm.cpp? A different file for MachO stuff?

Thu, Jan 14, 5:31 AMRestricted Project
LuoYuanke updated the summary of D94155: [X86] Fix tile config register spill issue..
Thu, Jan 14, 5:31 AMRestricted Project
LuoYuanke updated the diff for D94155: [X86] Fix tile config register spill issue..

We also need check tile config register interference. Since we
don't model the config register we should check interference from the
ldtilecfg to each tile data register def.

      ldtilecfg
      /       \
    BB1      BB2
     /         \
    call       BB3
    /           \
%1=tileload   %2=tilezero

We can start from the instruction of each tile def, and backward to
ldtilecfg. If there is any call instruction, and tile data register is
not preserved, we should insert ldtilecfg after the call instruction.

Thu, Jan 14, 5:30 AMRestricted Project
jansvoboda11 updated the summary of D94676: [clang][cli] Specify KeyPath prefixes via TableGen classes.
Thu, Jan 14, 5:29 AMRestricted Project, Restricted Project
danilaml added a comment to D94418: [LNT] Python 3 support: fix several bytes/str inconsistencies.

Could you explain me what does the test you added do? I'm not familiar with lnt runtest and its option nor with all the lit thingy.

Thu, Jan 14, 5:25 AM
asb added a comment to D94568: [RISCV] Rename pcnt->cpop to match 0.93 bitmanip spec..

RVB 0.93 is an awkward version to me, there is mnemonic conflict which is not resolved during release process since it's kind of too rush, the conflict one is bext in zbe and zbs...

However it's also a milestone for B-ext, since this version claim zba, zbb and zbc is frozen, maybe those 3 sub-ext. could be removed from the umbrella of -menable-experimental-extension ?

@asb What do you think about this?

Thu, Jan 14, 5:25 AMRestricted Project
aaron.ballman added a comment to D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior.

Can we make using color the default too? We already use colors for Decls I think, so this just adds colors for other Node types.

Thu, Jan 14, 5:25 AMRestricted Project
steveire added inline comments to D94126: [ASTMatchers] Make it possible to use empty variadic matchers.
Thu, Jan 14, 5:24 AMRestricted Project
tschuett added a comment to D94667: [llvm-nm] - Move MachO specific logic out from the dumpSymbolNamesFromObject(). NFC..

Does it have to stay in llvm-nm.cpp? A different file for MachO stuff?

Thu, Jan 14, 5:22 AMRestricted Project