Page MenuHomePhabricator
Feed All Stories

Sat, Nov 21

MaskRay closed D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.
Sat, Nov 21, 9:04 PM · Restricted Project, Restricted Project, Restricted Project
GeorgeLyon added a comment to D91905: Use MlirStringRef throughout the C API.

To be perfectly clear, I agree that we should use MlirStringRef throughout, but if we decide that we should do that across the API in one fell swoop (I’m happy to author that PR if folks are on board).

Sat, Nov 21, 8:57 PM · Restricted Project
mehdi_amini added inline comments to D91896: [mlir] Add microbenchmark for linalg+async-parallel-for.
Sat, Nov 21, 8:30 PM · Restricted Project
mehdi_amini added inline comments to D91905: Use MlirStringRef throughout the C API.
Sat, Nov 21, 8:21 PM · Restricted Project
bondhugula requested changes to D91863: [mlir][Linalg] NFC - Factor out Linalg functionality for shape and loop bounds computation.
Sat, Nov 21, 8:20 PM · Restricted Project
haowei committed rG914f6c4ff8a4: [StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker (authored by haowei).
[StaticAnalyzer] Support struct annotations in FuchsiaHandleChecker
Sat, Nov 21, 8:03 PM
haowei closed D91223: Support struct annotations in FuchsiaHandleChecker..
Sat, Nov 21, 8:02 PM · Restricted Project
sameeranjoshi updated the diff for D89879: [Flang][OpenMP-5.0] Semantic checks for flush construct..

Based on top of the parser changes which were handled in D91839.
Rebased after D91839.
Address review comments.

Sat, Nov 21, 7:08 PM · Restricted Project, Restricted Project
craig.topper added a comment to D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes.

Is there a test case?

Sat, Nov 21, 7:08 PM · Restricted Project
rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed comments.

Sat, Nov 21, 6:54 PM · Restricted Project
tianshilei1992 added a comment to D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx.

Open to suggestions on testing. Calling it from a target region on amdgcn with multiple GPUs works. I don't have a cuda machine with multiple cards. A machine with one target returns 0 with or without this patch.

Do we have any runtime tests for openmp in tree? Would need a CI machine with GPUs

Sat, Nov 21, 6:25 PM · Restricted Project
tskeith removed a reviewer for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause: tskeith.
Sat, Nov 21, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
LuoYuanke added a comment to D87981: [X86] AMX programming model..

@craig.topper. Thank you for the good idea. I create another patch (https://reviews.llvm.org/D91927) to fix the problem.

Sat, Nov 21, 5:02 PM · Restricted Project, Restricted Project
hvdijk updated the diff for D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes.
Sat, Nov 21, 5:02 PM · Restricted Project
LuoYuanke added reviewers for D91927: [X86] Add x86_amx type for intel AMX.: craig.topper, hfinkel, akashk4, rengolin, mehdi_amini, pengfei, wxiao3, xiangzhangllvm.
Sat, Nov 21, 5:01 PM · Restricted Project, Restricted Project
LuoYuanke retitled D91927: [X86] Add x86_amx type for intel AMX. from [X86] Add x86_amx type for intel AMX. The x86_amx is used for AMX intrisics. <256 x i32> is bitcast to x86_amx when it is used by AMX intrinsics, and x86_amx is bitcast to <256 x i32> when it is used by load/store instruction. So amx intrinsics... to [X86] Add x86_amx type for intel AMX. .
Sat, Nov 21, 4:54 PM · Restricted Project, Restricted Project
LuoYuanke requested review of D91927: [X86] Add x86_amx type for intel AMX..
Sat, Nov 21, 4:51 PM · Restricted Project, Restricted Project
kazu requested review of D91926: [X86] Remove DecodeVPERMVMask and DecodeVPERMV3Mask.
Sat, Nov 21, 4:24 PM · Restricted Project
njames93 updated the diff for D91885: [clang-tidy] Add support for diagnostics with no location.

Fix unittest failing.

Sat, Nov 21, 4:20 PM · Restricted Project
brooksmoses added a comment to D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments..

Aha, okay. I hadn't realized that this optimization had a -fno-delete-null-pointer-checks option to disable it. I agree that since that's available there's no call for a rollback.

Sat, Nov 21, 4:15 PM · Restricted Project, Restricted Project
craig.topper updated the diff for D91479: [RISCV] Custom type legalize i32 fshl/fshr on RV64 with Zbt..

Rebase

Sat, Nov 21, 3:57 PM · Restricted Project
njames93 requested review of D91925: [clangd][NFC] Small tweak to combined provider.
Sat, Nov 21, 3:48 PM · Restricted Project
kazu committed rGdef7cfb7ffd4: [InstCombine] Use is_contained (NFC) (authored by kazu).
[InstCombine] Use is_contained (NFC)
Sat, Nov 21, 3:47 PM
v.g.vassilev added inline comments to D91524: Make iteration over the DeclContext::lookup_result safe..
Sat, Nov 21, 3:29 PM
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Invert the diff, fix a typo.

Sat, Nov 21, 3:20 PM
al3xtjames updated the diff for D91764: [AArch64] Add codegen for Armv8.3 Load-AcquirePC instructions.
Sat, Nov 21, 3:20 PM · Restricted Project
v.g.vassilev updated the diff for D91524: Make iteration over the DeclContext::lookup_result safe..

Take another approach at solving this issue. Instead we are making the lookup_result safe.

Sat, Nov 21, 3:14 PM
kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Flang.Semantics::omp-clause-validity01.f90

Script:

: 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/flang/test/Semantics/test_errors.sh /mnt/disks/ssd0/agent/llvm-project/flang/test/Semantics/omp-clause-validity01.f90 /mnt/disks/ssd0/agent/llvm- project/build/tools/flang/test/Semantics/Output/omp-clause-validity01.f90.tmp /mnt/disks/ssd0/agent/llvm-project/build/bin/f18 -intrinsic-module-directory /mnt/disks/ssd0/agent/llvm-project/build/tools/flang/include/flang -fopenmp

Sat, Nov 21, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

Fine for me too

Sat, Nov 21, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Sat, Nov 21, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

No issues, please go ahead.

Sat, Nov 21, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
hvdijk added inline comments to D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes.
Sat, Nov 21, 2:55 PM · Restricted Project
craig.topper added inline comments to D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes.
Sat, Nov 21, 2:32 PM · Restricted Project
zoecarver added a comment to D87974: [Builtin] Add __builtin_zero_non_value_bits..

@jwakely It looks like UnsizedTail causes a crash.

Sat, Nov 21, 2:16 PM · Restricted Project
hliao committed rGdcc06597b1d6: Fix shared build. (authored by hliao).
Fix shared build.
Sat, Nov 21, 2:08 PM
hvdijk updated the diff for D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes.

Forgot to run clang-format-diff before uploading, updated now.

Sat, Nov 21, 2:02 PM · Restricted Project
hvdijk requested review of D91924: [X86] Have indirect calls take 64-bit operands in 64-bit modes.
Sat, Nov 21, 1:58 PM · Restricted Project
davidxl added a comment to D90648: [SCEV] Fix nsw flags for GEP expressions.

thanks for the background. Regarding D90708 about the LangRef change, was there a RFC before the patch?

Sat, Nov 21, 1:53 PM · Restricted Project
mgorny requested review of D91923: [lldb] [Process/FreeBSDRemote] Fix regset names and related tests.
Sat, Nov 21, 1:20 PM · Restricted Project
mgorny requested review of D91922: [lldb] [test] Fix qRegisterInfo lldb-server test to handle missing registers.
Sat, Nov 21, 1:19 PM · Restricted Project
MaskRay committed rG3324fd8a7b1a: [libunwind] Delete unused handlerNotFound in unwind_phase1 (authored by MaskRay).
[libunwind] Delete unused handlerNotFound in unwind_phase1
Sat, Nov 21, 12:38 PM
nikic committed rGded592886625: [BasicAA] Remove unnecessary sextOrSelf (NFC) (authored by nikic).
[BasicAA] Remove unnecessary sextOrSelf (NFC)
Sat, Nov 21, 12:33 PM
smhc updated the diff for D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

Thanks - I had it like that originally but was not sure how often MacroUsageCallbacks would be instantiated or whether there was a many-to-one relationship. I've now modified it to create and maintain the regex object as a member of MacroUsageCallbacks.

Sat, Nov 21, 12:26 PM · Restricted Project, Restricted Project
dmgreen requested review of D91921: [ARM] Introduce MVETRUNC ISel lowering.
Sat, Nov 21, 12:17 PM · Restricted Project
mstorsjo committed rG33fb9679ec6e: [compiler-rt] [profile] Silence a warning about an unused function on mingw… (authored by mstorsjo).
[compiler-rt] [profile] Silence a warning about an unused function on mingw…
Sat, Nov 21, 12:15 PM
mstorsjo closed D91850: [compiler-rt] [profile] Silence a warning about an unused function on mingw targets.
Sat, Nov 21, 12:15 PM · Restricted Project
nikic committed rG0d114f56d709: [BasicAA] Return DecomposedGEP (NFC) (authored by nikic).
[BasicAA] Return DecomposedGEP (NFC)
Sat, Nov 21, 12:07 PM
brad added a comment to D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets.

@efriedma Eli?

Sat, Nov 21, 12:00 PM · Restricted Project
nikic added a comment to D90648: [SCEV] Fix nsw flags for GEP expressions.

This patch does not have a new test case added to demonstrate what this patch is trying to fix or reference the bug number showing the bug end-to-end.

Sat, Nov 21, 11:58 AM · Restricted Project
dougpuob updated the diff for D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.

Against git master.

Sat, Nov 21, 11:57 AM · Restricted Project, Restricted Project, Restricted Project
nikic committed rGf4412c5ae4ee: [BasicAA] Remove some intermediate variables (NFC) (authored by nikic).
[BasicAA] Remove some intermediate variables (NFC)
Sat, Nov 21, 11:36 AM
clementval committed rG952c9d3a91de: [NFC] Fix typo in atomic (authored by clementval).
[NFC] Fix typo in atomic
Sat, Nov 21, 11:33 AM
clementval committed rGaa179d809909: [flang][openmp] Separate memory-order-clause parser creating OmpClause node (authored by clementval).
[flang][openmp] Separate memory-order-clause parser creating OmpClause node
Sat, Nov 21, 11:32 AM
clementval closed D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.
Sat, Nov 21, 11:31 AM · Restricted Project, Restricted Project
davidxl added a reviewer for D90648: [SCEV] Fix nsw flags for GEP expressions: sanjoy.
Sat, Nov 21, 11:24 AM · Restricted Project
davidxl added a comment to D90648: [SCEV] Fix nsw flags for GEP expressions.

This patch does not have a new test case added to demonstrate what this patch is trying to fix or reference the bug number showing the bug end-to-end.

Sat, Nov 21, 11:24 AM · Restricted Project
praveen requested review of D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Sat, Nov 21, 11:19 AM · Restricted Project, Restricted Project, Restricted Project
nridge added a comment to D91859: [clangd] Fix shared-lib builds.

I applied the patch locally and it fixes most of the linker errors but I'm still seeing one:

Sat, Nov 21, 11:15 AM · Restricted Project, Restricted Project
nikic committed rG913a99c47439: [BasicAA] Remove stale FIXME (NFC) (authored by nikic).
[BasicAA] Remove stale FIXME (NFC)
Sat, Nov 21, 11:07 AM
anton-afanasyev added a comment to D91919: [SLP] Make SLPVectorizer to use `llvm.masked.scatter` intrinsic.

Analogue of https://reviews.llvm.org/D90445 for stores.

Sat, Nov 21, 11:05 AM · Restricted Project
anton-afanasyev requested review of D91919: [SLP] Make SLPVectorizer to use `llvm.masked.scatter` intrinsic.
Sat, Nov 21, 11:03 AM · Restricted Project
steveire requested review of D91918: Remove the IgnoreImplicitCastsAndParentheses traversal kind.
Sat, Nov 21, 10:55 AM · Restricted Project
steveire updated the diff for D91916: Remove automatic traversal from forEach matcher.

Update

Sat, Nov 21, 10:52 AM · Restricted Project
yhegde added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Shall I assume there are no issues with this patch. ?

Sat, Nov 21, 10:51 AM · Restricted Project, Restricted Project, Restricted Project
steveire requested review of D91917: Update mode used in traverse() examples.
Sat, Nov 21, 10:51 AM · Restricted Project
yhegde added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Sat, Nov 21, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
steveire requested review of D91916: Remove automatic traversal from forEach matcher.
Sat, Nov 21, 10:43 AM · Restricted Project
spatel added inline comments to D91589: [DAGCombiner] Fold (sext (not i1 x)) -> (add (zext i1 x), -1).
Sat, Nov 21, 10:23 AM · Restricted Project
xazax.hun accepted D91223: Support struct annotations in FuchsiaHandleChecker..

LGTM!

Sat, Nov 21, 10:20 AM · Restricted Project
njames93 requested review of D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier.
Sat, Nov 21, 9:48 AM · Restricted Project
hvdijk added a comment to D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes.

Then the comment needs to be fixed too i would think?

Sat, Nov 21, 9:41 AM · Restricted Project
lebedev.ri added a comment to D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes.

The associated comment suggested that GCC keeps this extension enabled in C90/C++03 standard-conforming mode, but it actually does not, so rather than adding a check for C++ language version, this change simply removes the check for C language version.

Sat, Nov 21, 9:32 AM · Restricted Project
MaskRay committed rG4629afa101d4: [X86] Include %rip for 32-bit RIP-relative relocs for x32 (authored by hvdijk).
[X86] Include %rip for 32-bit RIP-relative relocs for x32
Sat, Nov 21, 9:20 AM
MaskRay closed D91339: [X86] Include %rip for 32-bit RIP-relative relocs for x32.
Sat, Nov 21, 9:20 AM · Restricted Project
gbencze added a comment to D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check.

Thanks for the review! I'll push this as soon as the updated version of D89649 is also accepted.

Sat, Nov 21, 9:18 AM · Restricted Project, Restricted Project
gbencze added a comment to D89649: Fix __has_unique_object_representations with no_unique_address.

Pinging @rsmith - could you please check the updates to this patch? Thanks!

Sat, Nov 21, 9:17 AM · Restricted Project
RKSimon committed rG5318f6c427c7: MachineDominators.h - remove unused <vector> include (authored by RKSimon).
MachineDominators.h - remove unused <vector> include
Sat, Nov 21, 9:12 AM
RKSimon committed rG7650d655050b: DominanceFrontier - remove unused <vector> includes (authored by RKSimon).
DominanceFrontier - remove unused <vector> includes
Sat, Nov 21, 9:11 AM
RKSimon committed rG63626a199584: [X86] Regenerate vector-reduce-or-cmp.ll (authored by RKSimon).
[X86] Regenerate vector-reduce-or-cmp.ll
Sat, Nov 21, 9:11 AM
sameeranjoshi committed rG1df8fa78e652: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it. (authored by sameeranjoshi).
[Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it.
Sat, Nov 21, 9:08 AM
sameeranjoshi closed D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..
Sat, Nov 21, 9:08 AM · Restricted Project, Restricted Project
nikic requested review of D91914: [BasicAA] Generalize recursive phi alias analysis.
Sat, Nov 21, 9:04 AM · Restricted Project
njames93 updated the diff for D91029: [clangd] Implement clang-tidy options from config.

Fix ChecksToDisable to actually disable the checks.

Sat, Nov 21, 8:58 AM · Restricted Project
nikic committed rG072ddff3f207: [BasicAA] Add recphi test with dynamic offset (NFC) (authored by nikic).
[BasicAA] Add recphi test with dynamic offset (NFC)
Sat, Nov 21, 8:52 AM
nikic accepted D91864: [NFC] Reduce code duplication in binop processing in computeExitLimitFromCondCached.

LGTM

Sat, Nov 21, 8:51 AM · Restricted Project
mgorny committed rG8aea95f3cb4e: [lldb] Reland "Use translated full ftag values" (authored by mgorny).
[lldb] Reland "Use translated full ftag values"
Sat, Nov 21, 8:35 AM
mgorny closed D91504: [lldb] Use translated full ftag values.
Sat, Nov 21, 8:35 AM · Restricted Project
aeubanks added a comment to D91733: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.

This seems to have broken some tests on our Mac bots:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863040226745741728/+/steps/package_clang/0/stdout

Sat, Nov 21, 8:27 AM · Restricted Project
kiranchandramohan accepted D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

LGTM.

Sat, Nov 21, 8:25 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..
Sat, Nov 21, 8:21 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

Thanks for taking a look at the patch @Kiran(arm).
Address review comments.

Sat, Nov 21, 8:20 AM · Restricted Project, Restricted Project
njames93 added a comment to D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check.

While I'm a fan of this change, I think this is the wrong way to do it. Leave the check the same, but build the regex in the pp callback constructor. That should only get called once for the lifetime of the check.

Sat, Nov 21, 8:19 AM · Restricted Project, Restricted Project
mgorny retitled D91728: [lldb] [Process/Utility] Declare register overlaps between ST and MM from [lldb] [Process/Utility] Declare register overlaps between ST and MM [WIP] to [lldb] [Process/Utility] Declare register overlaps between ST and MM.
Sat, Nov 21, 8:10 AM · Restricted Project
hvdijk requested review of D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes.
Sat, Nov 21, 8:00 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG9b7b8de6d12f: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to… (authored by Paul-C-Anagnostopoulos).
[TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to…
Sat, Nov 21, 8:00 AM
Paul-C-Anagnostopoulos closed D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit.
Sat, Nov 21, 7:59 AM · Restricted Project
Bdragon28 added inline comments to D91906: Multiple preprocessor fixes for libunwind on PowerPC*..
Sat, Nov 21, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
faisalv closed D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

committed here: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a

Sat, Nov 21, 7:52 AM · Restricted Project
faisalv committed rG9930d4dff31a: [NFC, Refactor] Modernize enum FunctionDefinitionKind (DeclSpech.h) into a… (authored by faisalv).
[NFC, Refactor] Modernize enum FunctionDefinitionKind (DeclSpech.h) into a…
Sat, Nov 21, 7:51 AM
anhtuyen abandoned D91907: Add missing dependencies, which caused link failure when building with -DBUILD_SHARED_LIBS:BOOL=ON.

The error only occurs when I have more code in my local. I close it now.

Sat, Nov 21, 7:22 AM · Restricted Project