Page MenuHomePhabricator
Feed All Stories

Wed, Sep 16

vitalybuka accepted D87792: [sanitizer] Add facility to print the full StackDepot.

LGTM

Wed, Sep 16, 6:17 PM · Restricted Project
akhuang updated the summary of D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Wed, Sep 16, 6:17 PM · Restricted Project
vitalybuka accepted D87801: [DFSan] Add bcmp wrapper..
Wed, Sep 16, 6:15 PM · Restricted Project
mcgrathr requested review of D87809: [scudo/standalone] Don't define test main function for Fuchsia.
Wed, Sep 16, 6:14 PM · Restricted Project
morehouse added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 6:13 PM · Restricted Project
rsmith committed rG7337f2961944: PR47555: Inheriting constructors are implicitly definable. (authored by rsmith).
PR47555: Inheriting constructors are implicitly definable.
Wed, Sep 16, 6:12 PM
rsmith committed rG905b9ca26c94: Canonicalize declaration pointers when forming APValues. (authored by rsmith).
Canonicalize declaration pointers when forming APValues.
Wed, Sep 16, 6:11 PM
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

convert into lambda to avoid guarding unused function with ARCH_IOVEC_FOR_GETREGSET

Wed, Sep 16, 6:11 PM · Restricted Project
vsapsai accepted D82118: [clang][module] Improve incomplete-umbrella warning.

Looks good to me. I would wait a few days before committing in case other reviewers have comments but not too long as you can address extra comments post-commit.

Wed, Sep 16, 6:05 PM · Restricted Project
wmi accepted D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile.
Wed, Sep 16, 6:04 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

restore VReport for PTRACE_GETREGS

Wed, Sep 16, 6:04 PM · Restricted Project
akhuang requested review of D87808: [DebugInfo] Fix bug in constructor homing for classes with trivial constructors..
Wed, Sep 16, 6:02 PM · Restricted Project
modimo added a comment to D73739: Exception support for basic block sections.

@rahmanl Have you had a chance to run your added test on ARM64 as another itanium C++ ABI target to make sure it works properly? Having testing there is fine as a follow-up but wanted to make sure we're in agreement here. Otherwise changes LGTM, please let @MaskRay have a chance to provide any additional feedback.

Wed, Sep 16, 5:54 PM · Restricted Project
vitalybuka updated subscribers of D87754: [Lsan] Use fp registers to search for pointers.

FYI @eugenis @oontvoo
Maybe we need this for Android as well

Wed, Sep 16, 5:53 PM · Restricted Project
wenlei added inline comments to D87777: [ASAN] Properly deal with musttail calls in ASAN.
Wed, Sep 16, 5:53 PM · Restricted Project
vitalybuka updated the summary of D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 5:52 PM · Restricted Project
rsmith added inline comments to D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.
Wed, Sep 16, 5:51 PM · Restricted Project
vitalybuka added inline comments to D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 5:46 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

restore sched_yield()

Wed, Sep 16, 5:46 PM · Restricted Project
vitalybuka updated the summary of D87754: [Lsan] Use fp registers to search for pointers.
Wed, Sep 16, 5:42 PM · Restricted Project
vitalybuka updated the diff for D87754: [Lsan] Use fp registers to search for pointers.

test

Wed, Sep 16, 5:41 PM · Restricted Project
wmi added a comment to D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile.
In D87740#2277446, @hoy wrote:

Thanks for the fix! LGTM.

I'm also seeing InstrProfSymtab is there to handle MD5-based names for PGO instrumentation. Not sure how it is used exactly. @wmi Have we thought about using that for AutoFDO?

Wed, Sep 16, 5:36 PM · Restricted Project
lxfind added inline comments to D87777: [ASAN] Properly deal with musttail calls in ASAN.
Wed, Sep 16, 5:34 PM · Restricted Project
rsmith added inline comments to D87561: [Sema] List conversion validate character array.
Wed, Sep 16, 5:33 PM · Restricted Project
asbirlea committed rG344a3d0bc0fb: [MemorySSA] Rename uses in blocks with Phis. (authored by asbirlea).
[MemorySSA] Rename uses in blocks with Phis.
Wed, Sep 16, 5:27 PM
asbirlea closed D87661: [MemorySSA] Rename uses in blocks with Phis..
Wed, Sep 16, 5:27 PM · Restricted Project
wenlei accepted D87777: [ASAN] Properly deal with musttail calls in ASAN.

LGTM except a minor comment.

Wed, Sep 16, 5:25 PM · Restricted Project
asbirlea added a comment to D87661: [MemorySSA] Rename uses in blocks with Phis..

Incorrect previous approach. The renaming needs to start at the block with the new def, but it needs to rename all blocks in the IDF, not just those with phis added.

Wed, Sep 16, 5:23 PM · Restricted Project
asbirlea retitled D87661: [MemorySSA] Rename uses in blocks with Phis. from [MemorySSA] Rename uses starting at defining access to [MemorySSA] Rename uses in blocks with Phis..
Wed, Sep 16, 5:22 PM · Restricted Project
asbirlea updated the diff for D87661: [MemorySSA] Rename uses in blocks with Phis..

Update to different approach.

Wed, Sep 16, 5:21 PM · Restricted Project
zzheng updated the diff for D84414: [RISCV] Support Shadow Call Stack.

Fixed comment and lint

Wed, Sep 16, 5:16 PM · Restricted Project, Restricted Project
MaskRay accepted D87803: [lld-macho] Ignore `-mllvm` and its argument.
Wed, Sep 16, 5:07 PM · Restricted Project
craig.topper committed rGe30371d99d51: [DAGCombiner] Teach visitMSTORE to replace an all ones mask with an unmasked… (authored by craig.topper).
[DAGCombiner] Teach visitMSTORE to replace an all ones mask with an unmasked…
Wed, Sep 16, 5:07 PM
wenlei accepted D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile.

LGTM. A small nit: the code snippet in the description could be removed as it's indeed in the codebase already. :)

Wed, Sep 16, 5:02 PM · Restricted Project
phosek added a comment to D87732: [Support] Provide sys::path::guess_style.

I'm not convinced this is really correct. After all, a path with mixed separators (e.g. '/my/path\to\foo') could be a Windows path rooted at the current drive. This mixed style can sometimes happen when things get concatenated together, so I don't think it's compeletely unreasonable.

I'm also concerned that if we guess wrong, the behaviour will end up breaking. For example, if the path were a Windows path "/my/path\../to/foo", I'd expect a remove_dots call (without worrying about slash normalisation) to result in "/my/to/foo", but if the code is using Posix style, will it actually result in the path being left unchanged?

I can think of two competing alternatives:

  1. add an option to remove_dots to not do the separator canonicalization. I'm not sure whether this can be done unambiguously however - which separator should be removed when a directory is removed due to dots? The one before the removed parts? After them?
  2. change all '\' to '/' unconditionally. However, this might break Linux paths with '\' in.
Wed, Sep 16, 5:02 PM · Restricted Project
pcc added inline comments to D87739: scudo: Add an API for disabling memory initialization per-thread..
Wed, Sep 16, 5:01 PM · Restricted Project
ychen accepted D87713: [NewPM] Port -print-alias-sets to NPM.
Wed, Sep 16, 5:00 PM · Restricted Project
steven.zhang accepted D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.

LGTM now.

Wed, Sep 16, 5:00 PM · Restricted Project
jingham added a comment to D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.

LGTM, if you want to remove the last example, I say go ahead. If you want to dig in more, then we should go through another review for the useful example.

Wed, Sep 16, 5:00 PM · Restricted Project
steven.zhang accepted D87698: [SelectionDAG] Check any use of negation result before removal.

LGTM.

Wed, Sep 16, 4:59 PM · Restricted Project
ychen updated the diff for D87001: [IRMover] Avoid materializing global value that belongs to not-yet-linked module.
  • update test to demonstrate the bug
  • actually the bug could be fixed by reverting D47898
Wed, Sep 16, 4:52 PM · Restricted Project
kastiglione added inline comments to D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.
Wed, Sep 16, 4:45 PM · Restricted Project
kastiglione requested review of D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string.
Wed, Sep 16, 4:45 PM · Restricted Project
aeubanks added reviewers for D87806: [ObjCARC][NewPM] Port objc-arc-contract to NPM: ychen, ahatanak, dexonsmith.
Wed, Sep 16, 4:44 PM · Restricted Project
aeubanks requested review of D87806: [ObjCARC][NewPM] Port objc-arc-contract to NPM.
Wed, Sep 16, 4:43 PM · Restricted Project
rsmith added inline comments to D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.
Wed, Sep 16, 4:42 PM · Restricted Project
rprichard added a comment to D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

This seems like a bad name.

Wed, Sep 16, 4:37 PM · Restricted Project, Restricted Project
rsmith added inline comments to D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers.
Wed, Sep 16, 4:37 PM · Restricted Project
compnerd accepted D87803: [lld-macho] Ignore `-mllvm` and its argument.
Wed, Sep 16, 4:33 PM · Restricted Project
rnk updated the summary of D87805: [PDB] Merge types in parallel when using ghashing.
Wed, Sep 16, 4:33 PM · Restricted Project
compnerd accepted D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

Thanks!

Wed, Sep 16, 4:32 PM · Restricted Project, Restricted Project
efriedma accepted D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors.

LGTM

Wed, Sep 16, 4:30 PM · Restricted Project
rnk requested review of D87805: [PDB] Merge types in parallel when using ghashing.
Wed, Sep 16, 4:30 PM · Restricted Project
rprichard updated the diff for D87750: [libunwind][DWARF] Fix end of .eh_frame calculation.

Rename dso_length to text_segment_length.

Wed, Sep 16, 4:29 PM · Restricted Project, Restricted Project
jrtc27 added inline comments to D84414: [RISCV] Support Shadow Call Stack.
Wed, Sep 16, 4:29 PM · Restricted Project, Restricted Project
efriedma accepted D86478: [ARM][CMSE] Issue an error if passing arguments through memory across security boundary.

LGTM

Wed, Sep 16, 4:29 PM · Restricted Project
Conanap requested review of D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins.
Wed, Sep 16, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
__simt__ added inline comments to D72240: Implement C++20 std::atomic_ref and test.
Wed, Sep 16, 4:28 PM · Restricted Project
efriedma added a comment to D87708: [DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046).

Err, actually, thinking about it a bit more, we should probably delete GenWidenVectorTruncStores in favor of using scalarizeVectorStore(), since they do basically the same thing.

Wed, Sep 16, 4:25 PM · Restricted Project
zzheng added inline comments to D84414: [RISCV] Support Shadow Call Stack.
Wed, Sep 16, 4:25 PM · Restricted Project, Restricted Project
zzheng updated the diff for D84414: [RISCV] Support Shadow Call Stack.

Addressed comments by @jrtc27

Wed, Sep 16, 4:23 PM · Restricted Project, Restricted Project
efriedma accepted D87708: [DAG] Remove DAGTypeLegalizer::GenWidenVectorTruncStores (PR42046).

This is by inspection - as was mentioned on the ticket, this code isn't active at all in the tests and I've not been able to get it to fire

Wed, Sep 16, 4:21 PM · Restricted Project
danielkiss committed rGf70baaf71f62: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss).
[AArch64] Add -mmark-bti-property flag.
Wed, Sep 16, 4:21 PM
eugenis added inline comments to D87739: scudo: Add an API for disabling memory initialization per-thread..
Wed, Sep 16, 4:21 PM · Restricted Project
danielkiss added a reverting change for rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag.: rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag.".
Wed, Sep 16, 4:21 PM
danielkiss committed rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag." (authored by danielkiss).
Revert "[AArch64] Add -mmark-bti-property flag."
Wed, Sep 16, 4:21 PM
danielkiss added a reverting change for D81930: [AArch64] Add -mmark-bti-property flag.: rG60e244f82c1f: Revert "[AArch64] Add -mmark-bti-property flag.".
Wed, Sep 16, 4:21 PM · Restricted Project, Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.
Wed, Sep 16, 4:20 PM · Restricted Project
eugenis added inline comments to D87739: scudo: Add an API for disabling memory initialization per-thread..
Wed, Sep 16, 4:20 PM · Restricted Project
rsmith added inline comments to D72240: Implement C++20 std::atomic_ref and test.
Wed, Sep 16, 4:18 PM · Restricted Project
compnerd updated the diff for D87534: Sema: introduce `__attribute__((__swift_name__))`.

Change diagnostics for conflicting swift_name, add a test case

Wed, Sep 16, 4:18 PM · Restricted Project
aeubanks added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This commit seems to cause a test failure on some bots, e.g. here.

Wed, Sep 16, 4:14 PM · Restricted Project
ogiroux <ogiroux@gmail.com> committed rG5b205ff47412: Commenting out atomics with padding to unbreak MSAN tests (authored by ogiroux <ogiroux@gmail.com>).
Commenting out atomics with padding to unbreak MSAN tests
Wed, Sep 16, 4:12 PM
wolfgangp added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This commit seems to cause a test failure on some bots, e.g. here.

Wed, Sep 16, 4:10 PM · Restricted Project
int3 requested review of D87803: [lld-macho] Ignore `-mllvm` and its argument.
Wed, Sep 16, 4:08 PM · Restricted Project
efriedma accepted D87232: [SVE][CodeGen] Lower floating point -> integer conversions.
Wed, Sep 16, 4:05 PM · Restricted Project
aaronpuchert added a comment to D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY.

The mistakes about exceptions came from me taking "(no return)" in the previous documentation too literally thinking it was referring to https://en.cppreference.com/w/cpp/language/attributes/noreturn.

The key here is the word "assumed". We treat the function as if it looks like this:

Wed, Sep 16, 4:03 PM · Restricted Project
efriedma accepted D87789: [ARM] Constant fold VMOVrh.

LGTM

Wed, Sep 16, 4:01 PM · Restricted Project
Carrot requested review of D87802: [MBFIWrapper] Add a new function getBlockProfileCount.
Wed, Sep 16, 3:58 PM · Restricted Project
MaskRay added a comment to D86847: [Bitcode] Add BITCODE_SIZE_BLOCK_ID to encode the size of the bitcode.

The idea is to add a terminator block, but a terminator carries less information so this patch intends to add a size block instead. With a terminator, the following problem can be better addressed

Wed, Sep 16, 3:57 PM · Restricted Project
paquette accepted D86968: [IRSim] Adding IR Instruction Mapper.

I pretty much only have comment nits at this point, so I think this LGTM.

Wed, Sep 16, 3:57 PM · Restricted Project
tianshilei1992 committed rGd89c5ae85772: [Flang] Fixed installation permission of the "binary" flang (authored by tianshilei1992).
[Flang] Fixed installation permission of the "binary" flang
Wed, Sep 16, 3:54 PM
tianshilei1992 closed D87783: [Flang] Fixed installation permission of the "binary" flang.
Wed, Sep 16, 3:54 PM · Restricted Project
george.burgess.iv added a comment to D87661: [MemorySSA] Rename uses in blocks with Phis..

(still lgtm. :) )

Wed, Sep 16, 3:51 PM · Restricted Project
sbc100 accepted D85685: Support dwarf fission for wasm object files.

I don't really grok the TargetFrameLowering::DwarfFrameBase part but everything else LGTM

Wed, Sep 16, 3:42 PM · Restricted Project, Restricted Project
morehouse requested review of D87801: [DFSan] Add bcmp wrapper..
Wed, Sep 16, 3:38 PM · Restricted Project
tejohnson added a comment to D86847: [Bitcode] Add BITCODE_SIZE_BLOCK_ID to encode the size of the bitcode.

I am a bit worry that linker might concatenate bitcode file with padding to achieve alignment requirement, etc. I guess you can create a termination block to mark the end but it is hard to seek the next start.

We can set the section alignment to 1 to avoid padding: (I rushed a bit, sorry: 6ae7b403c3e1aebcb825d3dd4777d3c1149d6d67)

I didn't see that. I don't really have concerns then.

@bartell mentioned something about a bitcode wrapper that does provide the length - how does this patch's strategy compare to that approach? Are they redundant? Should the wrapper be replaced with this patch's approach? (or should the bitcode wrapper approach be used instead of adding this patch?)

I guess that is an implementation choice. This approach prefers a simple linker implementation, while the bitcode wrapper requires linker know to treat this section differently and write bitcode wrapper into section.
@MaskRay Do you have any specific use case in mind for this? If you are tied to a linker like lld, it might be better just teach lld to treat this section differently so we don't need worry about concatenated bitcode file.

It is not tied to a linker like lld. I believe in most binary formats, if you specify an alignment of 1, their linkers will concatenate input sections in the output without padding. Actually, the section content of .llvmbc is entirely opaque to lld/GNU ld/gold. ("dumb linker, smart format" design).

If the bitcode wrapper requires the linker to understand its format, I'd vote against that solution. (It will not work with GNU ld/gold.)

Wed, Sep 16, 3:38 PM · Restricted Project
hliao committed rG4e4c89b22c3f: [EarlyCSE] Simplify max/min pattern matching. NFC. (authored by hliao).
[EarlyCSE] Simplify max/min pattern matching. NFC.
Wed, Sep 16, 3:35 PM
thakis committed rG0c6a56e41dbe: [gn build] (manually) port 1321160a2 (authored by thakis).
[gn build] (manually) port 1321160a2
Wed, Sep 16, 3:29 PM
danielkiss committed rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss).
[AArch64] Add -mmark-bti-property flag.
Wed, Sep 16, 3:24 PM
danielkiss closed D81930: [AArch64] Add -mmark-bti-property flag..
Wed, Sep 16, 3:24 PM · Restricted Project, Restricted Project
Herald added a reviewer for D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl: JDevlieghere.

We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more.

Wed, Sep 16, 3:19 PM · Restricted Project, Restricted Project
rnk retitled D87736: [PDB] Split TypeServerSource and extend type index map lifetime from [PDB] Split TypeServerSource and extend CVIndexMap lifetime to [PDB] Split TypeServerSource and extend type index map lifetime.
Wed, Sep 16, 3:16 PM · Restricted Project
rnk added a comment to D87736: [PDB] Split TypeServerSource and extend type index map lifetime.

Thanks, looks like I can remove it. I made things more uniform by having ipiMap always point to something, so if we have an item reference, always use ipiMap.

Wed, Sep 16, 3:16 PM · Restricted Project
rnk updated the diff for D87736: [PDB] Split TypeServerSource and extend type index map lifetime.
  • remove debugging noinline
Wed, Sep 16, 3:14 PM · Restricted Project
jkorous requested review of D87800: [WIP][Analyzer] find stack addresses leaked via out-params.
Wed, Sep 16, 3:14 PM
tianshilei1992 updated the diff for D87783: [Flang] Fixed installation permission of the "binary" flang.

Rebase and trigger a new test

Wed, Sep 16, 3:10 PM · Restricted Project
congzhe updated the diff for D86956: [AArch64] Avoid pairing loads when the base reg is modified.
Wed, Sep 16, 3:10 PM · Restricted Project, Restricted Project, Restricted Project
joerg accepted D87615: [X86] Fix stack alignment on 32-bit Solaris/x86.

I'm still curious about the source of the vptr diff, but that's a minor question, otherwise. LGTM

Wed, Sep 16, 3:08 PM · Restricted Project, Restricted Project, Restricted Project
dschuff added a comment to D85685: Support dwarf fission for wasm object files.
Wed, Sep 16, 3:07 PM · Restricted Project, Restricted Project