Page MenuHomePhabricator
Feed All Stories

Sat, Aug 1

andwar requested review of D85078: [flang] Fix multi-config generator builds.
Sat, Aug 1, 1:05 PM · Restricted Project
fhahn committed rG95ddb9ff6730: [PPC] Adjust run line for hardware-loops-crash.ll (authored by fhahn).
[PPC] Adjust run line for hardware-loops-crash.ll
Sat, Aug 1, 12:59 PM
fhahn committed rG05b44f7eaebf: [LCSSA] Provide option for caller to clean up unused PHIs. (authored by fhahn).
[LCSSA] Provide option for caller to clean up unused PHIs.
Sat, Aug 1, 12:44 PM
RKSimon added a comment to D84862: [X86] Make ENDBR instruction a scheduling boundary.

SGTM - @craig.topper are you happy with this to go in without a test case?

Sat, Aug 1, 12:41 PM · Restricted Project
RKSimon accepted D84793: [X86] Add assembler support for {disp8} and {disp32} to control the size of displacement used for memory operands..

LGTM - please can you deal with the the double spaces that clang-format is warning about?

Sat, Aug 1, 12:38 PM · Restricted Project
RKSimon committed rG82a5c848e7f5: [X86][AVX512] Fold concat(and(x,y),and(z,w)) -> and(concat(x,z),concat(y,w))… (authored by RKSimon).
[X86][AVX512] Fold concat(and(x,y),and(z,w)) -> and(concat(x,z),concat(y,w))…
Sat, Aug 1, 12:35 PM
tinti updated the diff for D85024: [llvm-objdump] Implement --prefix option.

Make old test unsupported for Windows.
Add new test for Windows.
Reword --prefix help text.

Sat, Aug 1, 12:27 PM · Restricted Project
zoecarver added a comment to D84943: [libc++] Remove workarounds for missing rvalue references.

Not sure if this is the right patch or if it would be better as a follow-up, but there are a lot of places (vector, unique_ptr, valarray, etc.) where rvalues (or in the case of unique_ptr, lvalue references) are gated on _LIBCPP_CXX03_LANG rather than _LIBCPP_HAS_NO_RVALUE_REFERENCES. We should probably try to remove those workarounds as well.

Sat, Aug 1, 12:15 PM · Restricted Project
zoecarver committed rG8697d6cfa894: [libcxx] Add compatible with constraint tests for some shared_ptr constructors. (authored by zoecarver).
[libcxx] Add compatible with constraint tests for some shared_ptr constructors.
Sat, Aug 1, 12:07 PM
zoecarver closed D81532: [libcxx] Add compatible with constraint tests for some shared_ptr constructors..
Sat, Aug 1, 12:07 PM · Restricted Project
kubamracek added a comment to D84570: [tsan] Fix the open and open64 interceptors to have correct declarations (variadic functions).

...and could you also see if perhaps this change helps:

diff --git a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
--- a/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
+++ b/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
@@ -137,7 +137,11 @@ const int PTHREAD_BARRIER_SERIAL_THREAD = -1;
 #endif
 const int MAP_FIXED = 0x10;
 typedef long long_t;
+#if SANITIZER_MAC || SANITIZER_FREEBSD || SANITIZER_NETBSD
 typedef __sanitizer::u16 mode_t;
+#else
+typedef __sanitizer::u32 mode_t;
+#endif
Sat, Aug 1, 11:45 AM · Restricted Project
teemperor added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Also could you rebase the diff here when you have time (e.g., regenerate the diff from you changes on top of the latest master commit)? It no longer applies at the moment without having to manually resolve a conflict.

Does this mean that I should generate diff from the current latest master commit of [https://github.com/llvm/llvm-project]? or from my latest commit (local)? Sorry, I am not used to using git:(

Sat, Aug 1, 11:44 AM
asbirlea added a comment to D84959: [NewPM][LVI] Abandon LVI after CVP.

This is ok to check in to resolve the regression.
I'll go back and check if that invalidate is overly conservative, but don't block in it.

Sat, Aug 1, 11:37 AM · Restricted Project, Restricted Project
jrtc27 updated subscribers of D83384: [GlobalISel][InlineAsm] Fix buildCopy for inputs.

I believe this has broken AArch64 (-global-isel not required due to defaults, but it's a GlobalISel bug so should force it nonetheless):

Sat, Aug 1, 11:20 AM · Restricted Project
RKSimon committed rGbb13c34c3aa1: [X86][AVX] Ensure we only combine to PSHUFLW/PSHUFHW on supporting targets (authored by RKSimon).
[X86][AVX] Ensure we only combine to PSHUFLW/PSHUFHW on supporting targets
Sat, Aug 1, 11:18 AM
kadircet added a comment to D85028: [clangd] Support new/delete operator in TargetFinder..

please note that this might require special handling for go-to-def. as go-to-def only jumps to canonical decl and in operator new's case the user provided one might not be canonical, whereas the canonical one is likely builtin without a source info.

Sat, Aug 1, 10:56 AM · Restricted Project
fhahn committed rGa9b06a2c14f9: [LCSSA] Use IRBuilder for PHI creation. (authored by fhahn).
[LCSSA] Use IRBuilder for PHI creation.
Sat, Aug 1, 10:47 AM
fhahn closed D85037: [LCSSA] Use IRBuilder for PHI creation..
Sat, Aug 1, 10:47 AM · Restricted Project
SouraVX added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Sat, Aug 1, 10:31 AM · Restricted Project
kadircet accepted D84839: Add document outline symbols from unnamed contexts, e.g. extern "C"..

let me know if i should land this for you

Sat, Aug 1, 10:19 AM · Restricted Project
craig.topper accepted D82826: [X86] support .nops directive.

LGTM

Sat, Aug 1, 10:19 AM · Restricted Project
aartbik added a comment to D85058: [mlir][vector] Add experimental memref cast operation..

Does this op really belong to the vector dialect?

It seems like you're plugging a hole somewhere, but it isn't clear what or why this is desirable. Can you explain this in a thread on Discourse?

Sat, Aug 1, 10:18 AM · Restricted Project
wmi accepted D83852: [llvm-profdata] Implement llvm-profdata overlap for sample profiles.

Thanks. Another suggestion about comment. Other than that, LGTM.

Sat, Aug 1, 10:14 AM · Restricted Project
clementval added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Sat, Aug 1, 10:05 AM · Restricted Project
kadircet requested review of D85077: [clang][Tooling] Optimize addTargetAndMode in case of invalid modes.
Sat, Aug 1, 10:04 AM · Restricted Project
fhahn added a comment to D85037: [LCSSA] Use IRBuilder for PHI creation..

LGTM, but shouldn't the patch as-is should be marked as "NFC"?

Sat, Aug 1, 10:04 AM · Restricted Project
kadircet requested review of D85076: [clang][Tooling] Fix addTargetAndModeForProgramName to use correct flag names.
Sat, Aug 1, 10:01 AM · Restricted Project
kparzysz added a comment to D85047: [Hexagon] Use InstSimplify instead of ConstantProp.

These failures seem to be caused by optimizing the code "too much", and simply removing the parts that the tests were looking for.

Sat, Aug 1, 9:58 AM · Restricted Project
SouraVX added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Sat, Aug 1, 9:55 AM · Restricted Project
jurahul requested review of D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.
Sat, Aug 1, 9:47 AM · Restricted Project
compnerd requested review of D82252: MachO: support `-syslibroot`.
Sat, Aug 1, 9:41 AM · Restricted Project, Restricted Project, lld
compnerd planned changes to D82252: MachO: support `-syslibroot`.
Sat, Aug 1, 9:41 AM · Restricted Project, Restricted Project, lld
compnerd updated the diff for D82252: MachO: support `-syslibroot`.

Address review feedback

Sat, Aug 1, 9:37 AM · Restricted Project, Restricted Project, lld
compnerd added inline comments to D82252: MachO: support `-syslibroot`.
Sat, Aug 1, 9:37 AM · Restricted Project, Restricted Project, lld
tejohnson accepted D84959: [NewPM][LVI] Abandon LVI after CVP.

I don't really know what the tradeoff would be between using abandon() here and using InvalidateAnalysisPass. I went with this variant as @asbirlea indicated in https://reviews.llvm.org/D70376#2151283 that this would be preferred, as InvalidateAnalysisPass is really more intended for testing purposes.

Sat, Aug 1, 9:30 AM · Restricted Project, Restricted Project
kumasento added inline comments to D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 8:57 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Fixed OpInst typo and removed unnecessary comments.

Sat, Aug 1, 8:57 AM · Restricted Project
njames93 added inline comments to D85028: [clangd] Support new/delete operator in TargetFinder..
Sat, Aug 1, 8:51 AM · Restricted Project
bondhugula added inline comments to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Sat, Aug 1, 8:50 AM · Restricted Project
bondhugula requested changes to D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 8:48 AM · Restricted Project
njames93 added a comment to D84898: [clang-tidy] Add new checker for complex conditions with no meaning.

I believe all review comments have been address, except for the discussion on implementing this in the CFE or as a tidy check.

Sat, Aug 1, 8:47 AM · Restricted Project, Restricted Project
bondhugula accepted D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 8:47 AM · Restricted Project
kumasento added inline comments to D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 8:26 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Rephrased the doc comment of checkTilingLegality.

Sat, Aug 1, 8:24 AM · Restricted Project
nikic added inline comments to D81766: [VectorCombine] try to create vector loads from scalar loads.
Sat, Aug 1, 8:15 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thank you again Uday for your reviews! Please check again if I've missed any other things. :)

Sat, Aug 1, 8:11 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Improved doc and API design based on reviews.

Sat, Aug 1, 8:09 AM · Restricted Project
sunfish requested review of D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics..
Sat, Aug 1, 7:53 AM · Restricted Project
csigg retitled D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass. from Make gpu.launch_func rewrite pattern part of the LLVM lowering pass. to [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Sat, Aug 1, 7:41 AM · Restricted Project
csigg requested review of D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Sat, Aug 1, 7:41 AM · Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Also could you rebase the diff here when you have time (e.g., regenerate the diff from you changes on top of the latest master commit)? It no longer applies at the moment without having to manually resolve a conflict.

Sat, Aug 1, 7:39 AM
bondhugula added inline comments to D84882: [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 7:36 AM · Restricted Project
bondhugula requested changes to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Sat, Aug 1, 7:30 AM · Restricted Project
spatel updated the diff for D81766: [VectorCombine] try to create vector loads from scalar loads.

Patch updated:
No code changes, but added tests for non-zero gep offsets. This actually works more than I was expecting given that we're only using the base stripPointerCasts(). If there are enough dereferenceable bytes, isSafeToLoadUnconditionally() can still manage to use the offset load via the existing gep.

Sat, Aug 1, 7:26 AM · Restricted Project
spatel added inline comments to D81766: [VectorCombine] try to create vector loads from scalar loads.
Sat, Aug 1, 7:20 AM · Restricted Project
spatel committed rGd620a6fe98f7: [VectorCombine] add tests for non-zero gep offsets; NFC (authored by spatel).
[VectorCombine] add tests for non-zero gep offsets; NFC
Sat, Aug 1, 7:19 AM
spatel added a comment to D85053: [InstSimplify] Fold abs(abs(x)) -> abs(x).

Will need update after:
rG04b99a4d18cf

Sat, Aug 1, 7:03 AM · Restricted Project
dim closed D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Sat, Aug 1, 6:36 AM
bbn committed rGfa30adecc766: [Attributor][NFC] Update description for the dependency graph (authored by bbn).
[Attributor][NFC] Update description for the dependency graph
Sat, Aug 1, 6:27 AM
bbn closed D85065: [Attributor][NFC] Update description for the dependency graph.
Sat, Aug 1, 6:27 AM · Restricted Project
sidbav added a comment to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Hey @sckmodifier, please take a look at some comments after that one you just quoted. I added the NFC tag, but then in later discussion, it was determined it is best to remove the NFC tag since this change is in somewhat in a grey area.

Sat, Aug 1, 6:08 AM · Restricted Project
csigg updated the diff for D84946: [MLIR] Change GpuLaunchFuncToGpuRuntimeCallsPass to wrap a RewritePattern with the same functionality..

Apply reviewer comments.

Sat, Aug 1, 6:08 AM · Restricted Project
dmgreen committed rGfd69df62ed10: [ARM] Distribute post-inc for Thumb2 sign/zero extending loads/stores (authored by dmgreen).
[ARM] Distribute post-inc for Thumb2 sign/zero extending loads/stores
Sat, Aug 1, 6:01 AM
dmgreen closed D78625: [ARM] Distribute post-inc for Thumb2 sign/zero extending loads/stores.
Sat, Aug 1, 6:01 AM · Restricted Project
kuter added a comment to D85065: [Attributor][NFC] Update description for the dependency graph.

Thank you.

Sat, Aug 1, 6:01 AM · Restricted Project
aqjune added a comment to D84250: [InstSimplify] ExpandBinOp should fold an expression only when it's safe.

Assuming D84792 lands, would performing the two SimplifyBinOp queries for L and R with CanUseUndef=false solve this problem as well? I would prefer that if it works.

Sat, Aug 1, 6:00 AM · Restricted Project
bkramer committed rGeb41f9edde10: [mlir][Vector] Simplify code a bit. NFCI. (authored by bkramer).
[mlir][Vector] Simplify code a bit. NFCI.
Sat, Aug 1, 5:49 AM
riccibruno updated the diff for D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..

Don't forget to increment the field iterator in the loop of maybePrintFieldForLambdaCapture, and modify the tests to test this.

Sat, Aug 1, 5:33 AM · Restricted Project
psmith added a comment to D85056: [ELF] Add --keep-section to expose linkerscript KEEP directive as a linker flag.

I do have some sympathy with wanting to use a command line option to keep an individual section from the command line as it has been useful in Arm's proprietary linker, although this is mainly due to the convenience of not having to create or modify another file.

Sat, Aug 1, 5:30 AM · Restricted Project
RKSimon added inline comments to D81766: [VectorCombine] try to create vector loads from scalar loads.
Sat, Aug 1, 5:10 AM · Restricted Project
kumasento added a comment to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Thank you very much Uday for pointing out all these issues! Sorry for costing you much time for doing so. I have fixed all of them and some other similar things. Would you mind taking another round of review to see if it is OK? Thanks!

Sat, Aug 1, 5:06 AM · Restricted Project
kumasento updated the diff for D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.

Fixed issues pinpointed by review comments.

Sat, Aug 1, 5:05 AM · Restricted Project
RKSimon updated the diff for D66004: [WIP][X86][SSE] SimplifyDemandedVectorEltsForTargetNode - add general shuffle combining support.

rebase

Sat, Aug 1, 4:56 AM · Restricted Project
spatel committed rG04b99a4d18cf: [InstSimplify] simplify abs if operand is known non-negative (authored by spatel).
[InstSimplify] simplify abs if operand is known non-negative
Sat, Aug 1, 4:55 AM
spatel committed rG1aa52d67d1c1: [InstSimplify] add abs test with assume; NFC (authored by spatel).
[InstSimplify] add abs test with assume; NFC
Sat, Aug 1, 4:55 AM
spatel closed D85043: [InstSimplify] simplify abs if operand is known non-negative.
Sat, Aug 1, 4:55 AM · Restricted Project
jrtc27 added inline comments to D85067: [RISCV] Enable the use of the old mucounteren name.
Sat, Aug 1, 4:45 AM · Restricted Project
jrtc27 requested changes to D85067: [RISCV] Enable the use of the old mucounteren name.
Sat, Aug 1, 4:43 AM · Restricted Project
RKSimon committed rG1b1901536a7d: [X86][AVX] Extend v2f64 BROADCAST(LOAD) -> BROADCAST_LOAD to v2i64/v4f32/v4i32 (authored by RKSimon).
[X86][AVX] Extend v2f64 BROADCAST(LOAD) -> BROADCAST_LOAD to v2i64/v4f32/v4i32
Sat, Aug 1, 4:29 AM
kumasento added a comment to D84882: [MLIR] Add tiling validity check to loop tiling pass.

Hi @bondhugula Thank you very much for your detailed comments :) I've improved this diff based on your suggestions. Please do let me know if there is any other I should look at.

Sat, Aug 1, 4:07 AM · Restricted Project
kumasento updated the diff for D84882: [MLIR] Add tiling validity check to loop tiling pass.

Fixed several issues based on review comments.

Sat, Aug 1, 4:02 AM · Restricted Project
bondhugula requested changes to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Sat, Aug 1, 3:50 AM · Restricted Project
kumasento retitled D84882: [MLIR] Add tiling validity check to loop tiling pass from [MLIR][Affine] Added legality validator for loop tiling to [MLIR] Add tiling validity check to loop tiling pass.
Sat, Aug 1, 3:39 AM · Restricted Project
sckmodifier added a comment to D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities .

Please put NFC in the title if no functional changes are intended. The same comment applies to D80580. Thanks.

Sat, Aug 1, 3:36 AM · Restricted Project
njames93 requested review of D85072: [ADT] Add getAsOr to Optional.
Sat, Aug 1, 3:23 AM · Restricted Project
njames93 committed rG9f21947a3312: [clang-tidy][NFC] Small refactor (authored by njames93).
[clang-tidy][NFC] Small refactor
Sat, Aug 1, 3:05 AM
evgeny777 committed rGe73f5d86f179: [MachineVerifier] Refactor calcRegsPassed. NFC (authored by evgeny777).
[MachineVerifier] Refactor calcRegsPassed. NFC
Sat, Aug 1, 2:59 AM
evgeny777 closed D84105: [MachineVerifier] Speed-up verification (up to 10x).
Sat, Aug 1, 2:59 AM · Restricted Project
njames93 committed rG4888c9ce97d8: [clang-tidy] readability-identifier-naming checks configs for included files (authored by njames93).
[clang-tidy] readability-identifier-naming checks configs for included files
Sat, Aug 1, 2:36 AM
njames93 closed D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
Sat, Aug 1, 2:35 AM · Restricted Project
yash updated the diff for D84920: [MLIR] Simplify semi-affine expressions.

Minor update in comments.

Sat, Aug 1, 2:18 AM · Restricted Project
teemperor added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Although I thought of how to clear all the following characters, I did not come up with it. So, I will try to fill the space. Should I add how many spaces? If I add too many spaces, sequences will be two lines, but if I add a few spaces, I can't handle some of the cases.

Sat, Aug 1, 1:46 AM
kaz7 requested review of D85071: [VE] Extend integer arguments and return values smaller than 64 bits.
Sat, Aug 1, 1:26 AM · Restricted Project, Restricted Project
gedatsu217 added a comment to D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion .

Although I thought of how to clear all the following characters, I did not come up with it. So, I will try to fill the space. Should I add how many spaces? If I add too many spaces, sequences will be two lines, but if I add a few spaces, I can't handle some of the cases.

Sat, Aug 1, 1:19 AM
njames93 updated the diff for D84814: [clang-tidy] readability-identifier-naming checks configs for included files.

Fix unpunctuated comment and simplify second check command.

Sat, Aug 1, 1:19 AM · Restricted Project
njames93 updated the diff for D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
  • Address comments.
  • Added test case for when this behaviour is disabled.
Sat, Aug 1, 1:14 AM · Restricted Project
dmgreen added a comment to D82998: [BasicAA] Enable -basic-aa-recphi by default.

Thanks to Adenilson and Hans I believe chromium has now fixed the issue their end. I have also ran another bootstrap and the llvm-test-suite, which are both still doing OK.

Sat, Aug 1, 1:11 AM · Restricted Project
nikic accepted D85055: [InstCombine] Fold abs(-x) -> abs(x).

LG. I was wondering if we can use any of our more powerful negation machinery here, but I don't think so, because it would end up looping infinitely.

Sat, Aug 1, 1:09 AM · Restricted Project
nikic accepted D85053: [InstSimplify] Fold abs(abs(x)) -> abs(x).

LG. This has some overlap with D85043, which will already catch the cases where the inner abs has poison=true, but not those with poison=false, so this seems reasonable as an explicit fold. One could make an argument that this should live in InstCombine and try to preserve the outer poison flag, but this doesn't seem particularly important to me.

Sat, Aug 1, 1:01 AM · Restricted Project
vitalybuka accepted D84945: [compiler-rt] Normalize some in/out doxygen parameter in interface headers. NFC..
Sat, Aug 1, 12:56 AM · Restricted Project