Page MenuHomePhabricator
Feed All Stories

Today

tcanens added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Sat, Apr 17, 8:45 PM · Restricted Project
xzq0528 requested review of D100714: Add a new tutorial that talk about how to make a change to llvm..
Sat, Apr 17, 8:38 PM · Restricted Project
tcanens added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Sat, Apr 17, 8:33 PM · Restricted Project
mehdi_amini accepted D100677: [mlir][llvm] Add UnnamedAddr attribute to GlobalOp.

Tests are marked as failing by the pre-merge checks? Otherwise LG after you get these to work as expected!

Sat, Apr 17, 8:33 PM · Restricted Project
aqjune abandoned D99853: [InstSimplify] Teach isUndefValue to understand const vector with both undef & poison.
Sat, Apr 17, 8:15 PM · Restricted Project
mizvekov added inline comments to D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind.
Sat, Apr 17, 7:35 PM · Restricted Project
aaronpuchert added a comment to D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind.

It seems that using is*Value and the introduction of getDecltypeForParenthesizedExpr could be two separate changes.

Sat, Apr 17, 7:19 PM · Restricted Project
mizvekov updated the diff for D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind.

.

Sat, Apr 17, 7:16 PM · Restricted Project
cjdb added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Sat, Apr 17, 7:15 PM · Restricted Project
aqjune committed rG1c10201d9660: Update InstCombine to use undef matcher instead (authored by aqjune).
Update InstCombine to use undef matcher instead
Sat, Apr 17, 7:12 PM
aqjune committed rG2813acb7d1f7: Update m_Undef to match vectors/aggrs with undefs and poisons mixed (authored by aqjune).
Update m_Undef to match vectors/aggrs with undefs and poisons mixed
Sat, Apr 17, 7:12 PM
aqjune closed D100122: Update m_Undef to match vectors/aggrs with undefs and poisons mixed.
Sat, Apr 17, 7:11 PM · Restricted Project
mizvekov updated the summary of D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind.
Sat, Apr 17, 6:54 PM · Restricted Project
mizvekov requested review of D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr and getValueKind.
Sat, Apr 17, 6:51 PM · Restricted Project
HsiangKai updated the diff for D100658: [RISCV] Apply __clang_riscv_builtin_alias to overloaded builtins..

Consider PermuteOperands.

Sat, Apr 17, 6:34 PM · Restricted Project
Quuxplusone updated the diff for D98573: [libc++] Remove the special logic for "noexcept iterators" in basic_string.
Sat, Apr 17, 6:30 PM · Restricted Project
aqjune added a comment to D99853: [InstSimplify] Teach isUndefValue to understand const vector with both undef & poison.

I'm about to land D100122 instead - https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29445 is waiting.
We can revisit this issue if fixing UndefValue is necessary.

Sat, Apr 17, 6:26 PM · Restricted Project
Quuxplusone added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Sat, Apr 17, 6:26 PM · Restricted Project
aqjune added a comment to D100710: Added example for integer constant.

Would you explain what this patch is for?

Sat, Apr 17, 6:22 PM · Restricted Project
ricky26 updated the diff for D98540: [M68k] Implement Disassembler.

Fix up the other switch statement that I somehow missed.

Sat, Apr 17, 5:56 PM · Restricted Project
zoecarver added inline comments to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Sat, Apr 17, 5:36 PM · Restricted Project
cjdb requested changes to D99873: [libcxx] adds `std::ranges::iter_move` and `std::iter_rvalue_reference_t`.
Sat, Apr 17, 5:25 PM · Restricted Project
cjdb added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Sat, Apr 17, 5:22 PM · Restricted Project
cjdb accepted D100686: [libc++][nfc] Move iterator_traits and related into __iterator/iterator_traits.h..
Sat, Apr 17, 5:16 PM · Restricted Project
Quuxplusone added inline comments to D100429: [libc++][ranges] Add range.cmp: equal_to, not_equal_to, less, etc..
Sat, Apr 17, 4:48 PM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

Put everything back the way it was, and poke buildkite one last time. (This time it should succeed.)

Sat, Apr 17, 4:36 PM · Restricted Project
malharJ updated the summary of D99723: [ARM] Transforming memcpy to Tail predicated Loop.
Sat, Apr 17, 3:51 PM · Restricted Project
malharJ updated the diff for D99723: [ARM] Transforming memcpy to Tail predicated Loop.

Removed the dependency as it has been closed.

Sat, Apr 17, 3:49 PM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.
Sat, Apr 17, 3:34 PM · Restricted Project
steveire requested review of D100712: [AST] Add NestedNameSpecifierLoc accessors to node introspection.
Sat, Apr 17, 3:31 PM · Restricted Project
steveire added inline comments to D100516: [AST] Add TypeLoc support to node introspection.
Sat, Apr 17, 3:28 PM · Restricted Project
stephenkelly committed rGdd68942f1d79: [AST] Add TypeLoc support to node introspection (authored by stephenkelly).
[AST] Add TypeLoc support to node introspection
Sat, Apr 17, 3:16 PM
stephenkelly closed D100516: [AST] Add TypeLoc support to node introspection.
Sat, Apr 17, 3:16 PM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

The hard tab and UTF-8 character é are reported here: https://buildkite.com/llvm-project/libcxx-ci/builds/2608#8ae5209d-9f5d-459c-ac7a-271e93ae70c7

Sat, Apr 17, 3:14 PM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

Introduce three intentional errors for testing purposes: hard tab, Unicode, and cyclic dependency. Poke buildkite.

Sat, Apr 17, 2:45 PM · Restricted Project
tschuett added a comment to D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

I thought the Beyonce rule was: if you like a world without unicode characters, you need to put a CI test on it.

Sat, Apr 17, 2:28 PM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.
Sat, Apr 17, 2:19 PM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

Poke buildkite, having removed invisible Unicode characters from the headers.

Sat, Apr 17, 2:08 PM · Restricted Project
arthur.j.odwyer committed rG863d5c4e4dcf: [libc++] Remove hard tabs, U+00AD, and U+200B from all libc++ headers. NFCI. (authored by arthur.j.odwyer).
[libc++] Remove hard tabs, U+00AD, and U+200B from all libc++ headers. NFCI.
Sat, Apr 17, 2:05 PM
krisb updated subscribers of D100595: [libcxx][test] Attempt to make debug mode tests more bulletproof.

Thank you all for your comments! But before proceeding, I want to ask a question.
It seems we have another approach for debug mode tests that was added in D59166, which I didn't notice before but which looks much better than we have now (except the facts that it is more complicated, has more requirements, and may suffer from the same problem because most tests don't check for the exact assertion just the fact that an assertion happened). So, the question is why the approach from D59166 didn't replace other (I mean the tests which this patch about) debug mode tests? Was the reason in the requirements? Should it finally become the only approach for debug mode tests or it is supposed to coexist with others?

Sat, Apr 17, 1:59 PM · Restricted Project
lhames requested review of D100711: [ORC-RT] Initial ORC Runtime directories and build system files..
Sat, Apr 17, 1:36 PM · Restricted Project
xbolva00 updated the diff for D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634).
Sat, Apr 17, 1:09 PM · Restricted Project
xbolva00 updated the summary of D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634).
Sat, Apr 17, 1:04 PM · Restricted Project
xbolva00 updated the diff for D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634).

Updated, addressed review feedback.

Sat, Apr 17, 1:04 PM · Restricted Project
fhahn committed rGd91f864ced6e: [ADT] Update RPOT to work with specializations of different types. (authored by fhahn).
[ADT] Update RPOT to work with specializations of different types.
Sat, Apr 17, 12:49 PM
fhahn closed D100169: [ADT] Update RPOT to work with specializations of different types..
Sat, Apr 17, 12:49 PM · Restricted Project
clementval added a comment to D100677: [mlir][llvm] Add UnnamedAddr attribute to GlobalOp.

@mehdi_amini Thanks for the quick review. I added some tests to/from LLVM IR and addressed other comments.

Sat, Apr 17, 12:27 PM · Restricted Project
clementval updated the diff for D100677: [mlir][llvm] Add UnnamedAddr attribute to GlobalOp.

Address review comment

Sat, Apr 17, 12:26 PM · Restricted Project
lebedev.ri updated the diff for D100684: [X86][CostModel] X86TTIImpl::getMemoryOpCost(): rewrite vector handling again.

Ready for review.
This ended up being a complete rewrite, and it's kinda ugly.

Sat, Apr 17, 12:25 PM · Restricted Project
cjdb added a comment to D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

Update: <type_traits> and maybe some other headers contain U+200B ZERO-WIDTH SPACE (attn: @cjdb). I'll just remove those characters. However, it does indicate that this will be a good check (at least once I improve the error message it gives ;)) because it'll incidentally help keep libc++ ASCII-friendly.

Sat, Apr 17, 12:17 PM · Restricted Project
tschuett added a comment to D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

The C++ draft has some of these lints:
https://github.com/cplusplus/draft/blob/master/tools/check-source.sh#L25-L37

Sat, Apr 17, 12:14 PM · Restricted Project
cjdb accepted D100707: [libcxx][doc] Use Phabricator links..

Should the commit message have NFC in it somewhere or does [doc] imply this?

Sat, Apr 17, 12:13 PM · Restricted Project
xgupta added a comment to D100710: Added example for integer constant.

Also please update the title to include a tag like for this one [Docs].

Sat, Apr 17, 12:11 PM · Restricted Project
xgupta added a reviewer for D100710: Added example for integer constant: aqjune.
Sat, Apr 17, 12:10 PM · Restricted Project
xgupta accepted D100710: Added example for integer constant.

LGTM, But also adding @aqjune as a second reviewer.

Sat, Apr 17, 12:09 PM · Restricted Project
Quuxplusone updated subscribers of D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

Update: <type_traits> and maybe some other headers contain U+200B ZERO-WIDTH SPACE (attn: @cjdb). I'll just remove those characters. However, it does indicate that this will be a good check (at least once I improve the error message it gives ;)) because it'll incidentally help keep libc++ ASCII-friendly.

Sat, Apr 17, 12:07 PM · Restricted Project
nikic committed rGc456ab78ae3a: [LoopUnroll] Regenerate test checks (NFC) (authored by nikic).
[LoopUnroll] Regenerate test checks (NFC)
Sat, Apr 17, 11:59 AM
nikic committed rGfe9a5a806e83: [LoopUnroll] Make some tests more robust (NFC) (authored by nikic).
[LoopUnroll] Make some tests more robust (NFC)
Sat, Apr 17, 11:59 AM
lhames committed rG0c6ee502ebfb: [JITLink] Add testcase that was accidentally left out of 19e402d2b34. (authored by lhames).
[JITLink] Add testcase that was accidentally left out of 19e402d2b34.
Sat, Apr 17, 11:59 AM
xbolva00 added a comment to D72396: [InstCombine] fold zext of masked bit set/clear.

It should be ready to go?

Sat, Apr 17, 11:32 AM · Restricted Project
aganea committed rGbb26fa8c286b: [clang-scan-deps] Add support for clang-cl (authored by saudi).
[clang-scan-deps] Add support for clang-cl
Sat, Apr 17, 11:23 AM
aganea committed rG488a19d00cba: [clang-scan-deps] Support double-dashes in clang command lines (authored by saudi).
[clang-scan-deps] Support double-dashes in clang command lines
Sat, Apr 17, 11:23 AM
aganea committed rG7b75a3a8ebf0: [Support] ThreadPool tests: silence warning unused variable 'It' (authored by aganea).
[Support] ThreadPool tests: silence warning unused variable 'It'
Sat, Apr 17, 11:23 AM
aganea closed D92191: [clang-scan-deps] Add support for clang-cl.
Sat, Apr 17, 11:23 AM · Restricted Project
aganea closed D95099: [clang-scan-deps] : Support -- in clang command lines..
Sat, Apr 17, 11:23 AM · Restricted Project
sushmaunnibhavi requested review of D100710: Added example for integer constant.
Sat, Apr 17, 11:19 AM · Restricted Project
stephenkelly committed rG141945f950e2: [AST] Enable AST node introspection on WIN32 (authored by stephenkelly).
[AST] Enable AST node introspection on WIN32
Sat, Apr 17, 11:00 AM
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.
Sat, Apr 17, 10:57 AM · Restricted Project
craig.topper committed rGa5e579cc2b8d: [TableGen] Remove local SmallSet from TypeSetByHwMode::insert. (authored by craig.topper).
[TableGen] Remove local SmallSet from TypeSetByHwMode::insert.
Sat, Apr 17, 10:49 AM
Paul-C-Anagnostopoulos added a comment to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.

For my future reference: What is the sequence you go through to ensure that no target output files change? Do you just build with the current system, then build with the revision and check that no output file dates changed?

Sat, Apr 17, 10:43 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.
Sat, Apr 17, 10:40 AM · Restricted Project
Mordante added a comment to D100134: [libc++] Fix std::type_info comparison.

Seems the Windows build fails, can you look why the XFAIL doesn't work.

Sat, Apr 17, 10:38 AM · Restricted Project
craig.topper updated the diff for D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.

Have caller create the SmallVector and pass by reference. This is much more common in the code base.

Sat, Apr 17, 10:20 AM · Restricted Project
xgupta added a comment to D100705: Fixed Typos.

Thanks, @Mordante for the tips, I remember from next time :)

Sat, Apr 17, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
yonghong-song added a comment to D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested.

I did some debugging on why DeclRefExpr evaluated not to be a Function pointer. Here is what I got.
I made the following clang change to dump out the pointer to the emited value ('&foo'):

Sat, Apr 17, 10:16 AM · Restricted Project, debug-info
arsenm updated the diff for D100709: X86/GlobalISel: Rely on default assignValueToRe.

Also handle the outgoing case. Changes f32 return promotion from broken, to different broken

Sat, Apr 17, 10:15 AM · Restricted Project
lattner added a comment to D100647: [MLIR] Add API for external timers to pass manager.

I agree with Mehdi and River. it seems like the passmgr should be a client of the more general shared thing.

Sat, Apr 17, 10:11 AM · Restricted Project
Mordante added a comment to D100705: Fixed Typos.

Nice work @jnyfah!

@Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch.

Sat, Apr 17, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
craig.topper added a comment to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.

I presume this passes all the TableGen tests.

How else did you test it? Knowing this may help me in the future.

Sat, Apr 17, 10:07 AM · Restricted Project
yonghong-song updated the diff for D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested.
  • add checking CGDebugInfo pointer. In my original patch but got lost in the revision.
Sat, Apr 17, 10:06 AM · Restricted Project, debug-info
Quuxplusone updated the diff for D98573: [libc++] Remove the special logic for "noexcept iterators" in basic_string.
Sat, Apr 17, 10:06 AM · Restricted Project
fhahn updated the diff for D100169: [ADT] Update RPOT to work with specializations of different types..

Rebased after landing the post-order iterator fixes in bbf01f96b5ccc1dcb4d1d47cb55292c27c698dbb.

Sat, Apr 17, 10:04 AM · Restricted Project
Quuxplusone added inline comments to D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.
Sat, Apr 17, 10:02 AM · Restricted Project
arsenm requested review of D100709: X86/GlobalISel: Rely on default assignValueToRe.
Sat, Apr 17, 10:00 AM · Restricted Project
Quuxplusone updated the diff for D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

Poke buildkite (investigating)

Sat, Apr 17, 10:00 AM · Restricted Project
arsenm requested review of D100708: GlobalISel: Relax verification of physical register copy types.
Sat, Apr 17, 9:59 AM · Restricted Project
Mordante added inline comments to D90999: [libc++] Implements ranges::enable_borrowed_range.
Sat, Apr 17, 9:45 AM · Restricted Project
xgupta added a comment to D100588: Fixed Typos.

@jnyfah Would you please update this revision by submitting a new diff using update diff after making changes as suggested by @Meinersbur.

Sat, Apr 17, 9:44 AM · Restricted Project
xgupta added a comment to D100696: Fixed typos.

@jnyfah you may close this revision. changes are committed by https://reviews.llvm.org/rG21bef4e11e48d5d4bff7a23babbd420e86dd420a.

Sat, Apr 17, 9:41 AM · Restricted Project, Restricted Project
jubnzv added a comment to D99924: [clang-tidy] Avoid bugprone-macro-parentheses warnings after goto argument.

Ping. Could somebody review this, please?

Sat, Apr 17, 9:40 AM · Restricted Project
xgupta updated subscribers of D100705: Fixed Typos.

Nice work @jnyfah!

Sat, Apr 17, 9:38 AM · Restricted Project, Restricted Project, Restricted Project
Mordante added a comment to D100703: [libc++] [CI] Fail if the headers contain cyclic dependencies.

htps://buildkite.com/llvm-project/libcxx-ci/builds/2595#c3483aa2-87b6-44fd-870e-4ce28b115ccc shows build errors. I assume these aren't the intended errors.
I would like to see how a build failure for this script is intended to look at the CI.

Sat, Apr 17, 9:37 AM · Restricted Project
xgupta committed rG21bef4e11e48: [NFC] Fixed Typos (authored by jnyfah).
[NFC] Fixed Typos
Sat, Apr 17, 9:33 AM
xgupta closed D100705: Fixed Typos.
Sat, Apr 17, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
Mordante accepted D100705: Fixed Typos.

Thanks for your contribution. Next time, please provide a patch with more context.
The instructions can be found at https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface.
LGTM, but please wait for an approval of the libc++ group.

Sat, Apr 17, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
stephenkelly committed rGebc6608fb790: [AST] Remove args from LocationCall (authored by stephenkelly).
[AST] Remove args from LocationCall
Sat, Apr 17, 9:22 AM
stephenkelly closed D100688: [AST] Remove args from LocationCall.
Sat, Apr 17, 9:22 AM · Restricted Project
Mordante requested review of D100707: [libcxx][doc] Use Phabricator links..
Sat, Apr 17, 9:16 AM · Restricted Project
fhahn committed rGbbf01f96b5cc: [ADT] Take graph as const & in some post-order iterators (NFC). (authored by fhahn).
[ADT] Take graph as const & in some post-order iterators (NFC).
Sat, Apr 17, 9:13 AM
Mordante committed rGf8f60297d772: [libcxx][doc] Fixes typos. (authored by Mordante).
[libcxx][doc] Fixes typos.
Sat, Apr 17, 9:02 AM