Page MenuHomePhabricator
Feed All Stories

Today

eugenis added a comment to D86000: Add an unsigned shift base sanitizer.
In D86000#2219322, @jfb wrote:
In D86000#2219288, @vsk wrote:

It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.

integer does "not actually UB checks", right? I can certainly put it in there if you think I won't get yelled at 馃槃

Fri, Aug 14, 4:36 PMRestricted Project, Restricted Project
vsk added a comment to D86000: Add an unsigned shift base sanitizer.
In D86000#2219322, @jfb wrote:
In D86000#2219288, @vsk wrote:

It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.

integer does "not actually UB checks", right? I can certainly put it in there if you think I won't get yelled at 馃槃

Fri, Aug 14, 4:36 PMRestricted Project, Restricted Project
fghanim added inline comments to D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.
Fri, Aug 14, 4:35 PMRestricted Project
guiand updated the diff for D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.

Emit a nop instruction to always mark the end of the MSan prologue, and insert prologue instructions before that.

Fri, Aug 14, 4:35 PMRestricted Project
Paul-C-Anagnostopoulos updated the diff for D85838: New TableGen Programmer's Reference document.

Sorry, I noticed one typo just after I submitted the previous revised patch. It is corrected in this patch.

Fri, Aug 14, 4:35 PMRestricted Project
vsk added inline comments to D86000: Add an unsigned shift base sanitizer.
Fri, Aug 14, 4:35 PMRestricted Project, Restricted Project
Meinersbur updated the diff for D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..
  • Make workaround conditional to msvc (requested by @klausler)
Fri, Aug 14, 4:34 PMRestricted Project, Restricted Project
clayborg requested changes to D84974: [WIP] Enable Launching the Debugee in VSCode Terminal.

So there is a lot of noise in this patch that is just reformatting on code that hasn't changed. It would be nice to get rid of any changes that are whitespace/indentation/formatting only. Also see inlined comments for needed changes.

Fri, Aug 14, 4:32 PMRestricted Project
Paul-C-Anagnostopoulos updated the diff for D85838: New TableGen Programmer's Reference document.

Here is the final document with Chris Lattner's suggestions. I have also included index.rst, which now refers to this document rather than the two old ones.

Fri, Aug 14, 4:32 PMRestricted Project
mpark committed rG02197f7e50b9: [libcxx/variant] Avoided variable name shadowing. (authored by mpark).
[libcxx/variant] Avoided variable name shadowing.
Fri, Aug 14, 4:31 PM
kiranchandramohan accepted D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.
Fri, Aug 14, 4:29 PMRestricted Project
efriedma accepted D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.

LGTM, thanks

Fri, Aug 14, 4:28 PMRestricted Project
xbolva00 added a reviewer for D86000: Add an unsigned shift base sanitizer: lebedev.ri.
Fri, Aug 14, 4:26 PMRestricted Project, Restricted Project
vsk added inline comments to D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage.
Fri, Aug 14, 4:21 PMRestricted Project, Restricted Project
aeubanks requested review of D86005: [NewPM][LoopFullUnroll] Make LoopFullUnrollPass required.
Fri, Aug 14, 4:16 PMRestricted Project
smeenai added inline comments to D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.
Fri, Aug 14, 4:13 PMRestricted Project
xbolva00 requested review of D86004: [SLC] Transform strncpy(dst, "text", C) to memcpy(dst, "text\0\0\0", C) for C <= 128 only.
Fri, Aug 14, 4:10 PMRestricted Project
int3 added inline comments to D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.
Fri, Aug 14, 4:09 PMRestricted Project
reames committed rGa96fc4638b73: Remove deopt and gc transition arguments from gc.statepoint intrinsic (authored by reames).
Remove deopt and gc transition arguments from gc.statepoint intrinsic
Fri, Aug 14, 4:08 PM
reames closed D80892: Remove deopt and gc transition arguments from gc.statepoint intrinsic.
Fri, Aug 14, 4:08 PMRestricted Project
klausler accepted D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?

No.

Fri, Aug 14, 4:06 PMRestricted Project, Restricted Project
aeubanks committed rG72effd8d5b08: [test][LoopUnroll] Cleanup FullUnroll.ll (authored by aeubanks).
[test][LoopUnroll] Cleanup FullUnroll.ll
Fri, Aug 14, 4:06 PM
aeubanks closed D85578: [test][LoopUnroll] Cleanup FullUnroll.ll.
Fri, Aug 14, 4:06 PMRestricted Project
jfb added a comment to D86000: Add an unsigned shift base sanitizer.
In D86000#2219288, @vsk wrote:

It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.

Fri, Aug 14, 4:05 PMRestricted Project, Restricted Project
Meinersbur added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

But are there other workarounds? Would adding "static" to the original "constexpr" suffice to avoid the bug?

Fri, Aug 14, 4:04 PMRestricted Project, Restricted Project
MaskRay added reviewers for D70378: [LLD][COFF] Cover usage of LLD as a library: grimar, psmith.
Fri, Aug 14, 4:02 PMlld, Restricted Project
tejohnson updated the diff for D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation.

address comments

Fri, Aug 14, 4:01 PMRestricted Project, Restricted Project
tejohnson added a comment to D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation.

Addressed everyone's comments as well as the clang tidy warnings.

Fri, Aug 14, 4:01 PMRestricted Project, Restricted Project
reames abandoned D84964: [WIP] Demo a functional problem from D81647 with a fix and test case.
Fri, Aug 14, 3:54 PMRestricted Project
plotfi abandoned D11244: New ADT: SortedVector .
Fri, Aug 14, 3:53 PM
plotfi commandeered D11244: New ADT: SortedVector .
Fri, Aug 14, 3:53 PM
aeubanks committed rGe6ea8779c2e0: [NewPM][optnone] Mark various passes as required (authored by aeubanks).
[NewPM][optnone] Mark various passes as required
Fri, Aug 14, 3:52 PM
aeubanks closed D85457: [NewPM][optnone] Mark various passes as required.
Fri, Aug 14, 3:52 PMRestricted Project, Restricted Project
MaskRay committed rG58f5966d5bc1: Fix TargetSubtargetInfo derivatives after D85165 (authored by MaskRay).
Fix TargetSubtargetInfo derivatives after D85165
Fri, Aug 14, 3:52 PM
asbirlea accepted D85457: [NewPM][optnone] Mark various passes as required.
Fri, Aug 14, 3:47 PMRestricted Project, Restricted Project
MaskRay added a comment to D70378: [LLD][COFF] Cover usage of LLD as a library.

Thanks for working on this. I think making lldMain "reentrancy safe" is useful.

Fri, Aug 14, 3:43 PMlld, Restricted Project
klausler added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

I also believe it will generate exactly the same code. There's no functional difference between the new proposal and the old code as far as the standard is concerned. I agree that preprocessor changes aren't necessary here.

Fri, Aug 14, 3:42 PMRestricted Project, Restricted Project
vsk added a comment to D86000: Add an unsigned shift base sanitizer.

It'd be nice to fold the new check into an existing sanitizer group to bring this to a wider audience. Do you foresee adoption issues for existing -fsanitize=integer adopters? Fwiw some recently-added implicit conversion checks were folded in without much/any pushback.

Fri, Aug 14, 3:42 PMRestricted Project, Restricted Project
rampitec requested review of D86003: [AMDGPU] Fix MAI ld/st hazard handling.
Fri, Aug 14, 3:42 PMRestricted Project
MaskRay committed rGb358daddea04: [ELF] Re-initialize InputFile::isInGroup so that elf::link can be called more鈥 (authored by MaskRay).
[ELF] Re-initialize InputFile::isInGroup so that elf::link can be called more鈥
Fri, Aug 14, 3:39 PM
eugenis added a comment to D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.

This adds future implementation complexity.

Fri, Aug 14, 3:34 PMRestricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Fix clang-(format|tidy)

Fri, Aug 14, 3:32 PMlld, Restricted Project
craig.topper committed rGc7a0b2684f74: [X86][MC][Target] Initial backend support a tune CPU to support -mtune (authored by craig.topper).
[X86][MC][Target] Initial backend support a tune CPU to support -mtune
Fri, Aug 14, 3:32 PM
craig.topper closed D85165: [X86][MC][Target] Initial backend support a tune CPU to support -mtune.
Fri, Aug 14, 3:32 PMRestricted Project
klausler added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

Fri, Aug 14, 3:31 PMRestricted Project, Restricted Project
davide committed rG0cceb54366b4: [TestPtrRefsObjC] Prefer `command script import`. (authored by davide).
[TestPtrRefsObjC] Prefer `command script import`.
Fri, Aug 14, 3:31 PM
davide committed rG8fcfe2862fd4: [TestPtrRefs] Prefer `command script import`. (authored by davide).
[TestPtrRefs] Prefer `command script import`.
Fri, Aug 14, 3:31 PM
rampitec accepted D85997: AMDGPU: Remove slc from flat offset complex patterns.
Fri, Aug 14, 3:26 PMRestricted Project
guiand added a comment to D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.

Caught by http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/41009/steps/ninja%20check%201/logs/FAIL%3A%20MemorySanitizer-POWERPC64%3A%3A%20chained_origin_memcpy.cpp

Fri, Aug 14, 3:23 PMRestricted Project
guiand requested review of D86001: [MSAN] Avoid dangling ActualFnStart when replacing instruction.
Fri, Aug 14, 3:21 PMRestricted Project
aeubanks accepted D85999: [NFC] Add raw_ostream parameter to printIR routines.

lgtm

Fri, Aug 14, 3:17 PMRestricted Project
Tyker updated the diff for D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.
  1. I'm pretty sure it's not okay to allocate memory in crash handler.
  2. We can't know that the internal state is still consistent.

i agree with both points but all i was trying to do i salvage what can be salvaged.

Fri, Aug 14, 3:14 PMRestricted Project
gribozavr2 accepted D85962: [SyntaxTree] Create annotations infrastructure and apply it in expression tests..

Very nice improvement to tests!

Fri, Aug 14, 3:04 PMRestricted Project
mcgrathr added inline comments to D85930: [lsan] Follow SANITIZER_CAN_USE_ALLOCATOR64 for LSan allocator.
Fri, Aug 14, 3:02 PMRestricted Project
mcgrathr updated the diff for D85930: [lsan] Follow SANITIZER_CAN_USE_ALLOCATOR64 for LSan allocator.

Refactor to share code directly with asan.

Fri, Aug 14, 3:01 PMRestricted Project
aganea updated the summary of D70378: [LLD][COFF] Cover usage of LLD as a library.
Fri, Aug 14, 2:54 PMlld, Restricted Project
rupprecht added a reverting change for rG7829c33084a7: [SCEVExpander] Add helper to clean up instrs inserted while expanding.: rG38884641f28e: Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while鈥.
Fri, Aug 14, 2:54 PM
rupprecht committed rG38884641f28e: Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while鈥 (authored by rupprecht).
Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while鈥
Fri, Aug 14, 2:54 PM
efriedma accepted D85743: [CodeGen][AArch64] Support arm_sve_vector_bits attribute.

Like I mentioned on the review for the prototype, I still think we should try to implement a scheme that makes CK_BItCast between fixed and scalable types trivial. Doing coercion this way is going to have a significant performance cost. But there isn't any user-visible effect, so I'm fine with leaving that for a followup.

Fri, Aug 14, 2:54 PMRestricted Project
rupprecht added a reverting change for D84327: [SCEVExpander] Add helper to clean up instrs inserted while expanding.: rG38884641f28e: Temporarily revert "[SCEVExpander] Add helper to clean up instrs inserted while鈥.
Fri, Aug 14, 2:54 PMRestricted Project
jfb updated subscribers of D86000: Add an unsigned shift base sanitizer.
Fri, Aug 14, 2:53 PMRestricted Project, Restricted Project
jfb requested review of D86000: Add an unsigned shift base sanitizer.
Fri, Aug 14, 2:51 PMRestricted Project, Restricted Project
aganea updated the diff for D70378: [LLD][COFF] Cover usage of LLD as a library.

Add support for testing LLD as a library, by running the driver several times in a row when LLD_IN_TEST is defined. The value of LLD_IN_TEST tells how many times LLD should loop (3 times right now).

Fri, Aug 14, 2:51 PMlld, Restricted Project
xbolva00 committed rG6dbf0cfcf789: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str) (authored by xbolva00).
[SLC] sprintf(dst, "%s", str) -> strcpy(dst, str)
Fri, Aug 14, 2:49 PM
xbolva00 closed D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Fri, Aug 14, 2:49 PMRestricted Project
nlguillemot committed rG3cf7efec986d: [TableGen] Allow mnemonics with uppercase letters to be matched (authored by nlguillemot).
[TableGen] Allow mnemonics with uppercase letters to be matched
Fri, Aug 14, 2:48 PM
nlguillemot closed D85858: [TableGen] Allow mnemonics with uppercase letters to be matched.
Fri, Aug 14, 2:48 PMRestricted Project
JonChesterfield added inline comments to D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types.
Fri, Aug 14, 2:47 PMRestricted Project
xbolva00 added a comment to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

Thank you

Fri, Aug 14, 2:47 PMRestricted Project
vrnithinkumar added inline comments to D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
Fri, Aug 14, 2:47 PMRestricted Project
efriedma accepted D85165: [X86][MC][Target] Initial backend support a tune CPU to support -mtune.

LGTM

Fri, Aug 14, 2:45 PMRestricted Project
guiand committed rG36ebabc153d4: [MSAN] Convert ActualFnStart to be a particular Instruction *, not BB (authored by guiand).
[MSAN] Convert ActualFnStart to be a particular Instruction *, not BB
Fri, Aug 14, 2:44 PM
guiand closed D85985: [MSAN] Convert ActualFnStart to be a particular Instruction *, not BB.
Fri, Aug 14, 2:44 PMRestricted Project
kzhuravl accepted D85882: [AMDGPU] Update subtarget features for new target ID support.

LGTM

Fri, Aug 14, 2:44 PMRestricted Project
jamieschmeiser requested review of D85999: [NFC] Add raw_ostream parameter to printIR routines.
Fri, Aug 14, 2:43 PMRestricted Project
efriedma accepted D85982: [SVE] Lower fixed length vXi32/vXi64 SDIV.

LGTM

Fri, Aug 14, 2:42 PMRestricted Project
jdoerfert accepted D83507: [AssumeBundles] Fix Bug in Assume Queries.

This seems to fix a problem.

Fri, Aug 14, 2:39 PMRestricted Project
vrnithinkumar updated the diff for D85796: [Analysis] Bug fix for exploded graph branching in evalCall for constructor.
  • Fix without passing the NodeBuilder
Fri, Aug 14, 2:39 PMRestricted Project
anemet added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

@hnrklssn hi, are you panning to get back to this at some point?

Yes, sorry about the delay!
Currently finishing the last bits of the thesis that this work is part of has taken priority, which doesn't leave too much time since I'm now also working full time.
After that's done though I intend to come back and do the cleanup necessary to upstream as much of the work as possible. It's all related to improving optimisation remarks in one way or another. :)

Oh cool, are you planning to publish/publicize this work once it's done?

Yup, it will be published in LUP Student Papers afaict! I can send you a rough draft if you're interested. Most of the final content is in place already, but it's a bit rough around the edges.

Fri, Aug 14, 2:38 PMRestricted Project
eugenis accepted D85985: [MSAN] Convert ActualFnStart to be a particular Instruction *, not BB.

LGTM++

Fri, Aug 14, 2:38 PMRestricted Project
fghanim added a comment to D85617: [OpenMP][OMPBuilder] Adding support for `omp single`.

ping

Fri, Aug 14, 2:36 PMRestricted Project
DavidTruby added a comment to D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC..

You might have to use conditional preprocessing to make this workaround specific to MSVC.

The workaround is valid C++ and works fine with every compiler. So why add a #if maze?

Fri, Aug 14, 2:35 PMRestricted Project, Restricted Project
efriedma accepted D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Fri, Aug 14, 2:34 PMRestricted Project
efriedma added a comment to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

LGTM

Fri, Aug 14, 2:34 PMRestricted Project
lebedev.ri accepted D83507: [AssumeBundles] Fix Bug in Assume Queries.

Please rebase and update the affected test :)

thank you, but how did you reduced it ?

Fri, Aug 14, 2:28 PMRestricted Project
cameron.mcinally updated the diff for D85982: [SVE] Lower fixed length vXi32/vXi64 SDIV.

Remove unneeded braces.

Fri, Aug 14, 2:27 PMRestricted Project
smeenai added inline comments to D85404: [lld-macho] Handle TAPI and regular re-exports uniformly.
Fri, Aug 14, 2:26 PMRestricted Project
leonardchan added a comment to D85924: [clang][feature] Add cxx_abi_relative_vtable feature.

CC @aaron.ballman who committed Features.def for signing off or knowing someone who can sign off.

Fri, Aug 14, 2:24 PMRestricted Project, Restricted Project
leonardchan added a reviewer for D85924: [clang][feature] Add cxx_abi_relative_vtable feature: aaron.ballman.
Fri, Aug 14, 2:23 PMRestricted Project, Restricted Project
Tyker updated the diff for D83507: [AssumeBundles] Fix Bug in Assume Queries.

Please rebase and update the affected test :)

Fri, Aug 14, 2:19 PMRestricted Project
lebedev.ri requested changes to D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.
  1. I'm pretty sure it's not okay to allcate memory in crash handler.
  2. We can't know that the internal state is still consistent.
Fri, Aug 14, 2:17 PMRestricted Project
kubamracek accepted D85995: [TSan][libdispatch] Guard test execution on old platforms.

This looks good to me. Note that I was actually suggesting to avoid the dynamic_lookup + forward declare and requiring that the *SDK* is at least 10.14 to run tests (which is separate from your OS version). But this way it's even more compatible, so I think we should go with it.

Fri, Aug 14, 2:15 PMRestricted Project
zahen requested review of D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain.
Fri, Aug 14, 2:15 PMRestricted Project
arsenm requested review of D85997: AMDGPU: Remove slc from flat offset complex patterns.
Fri, Aug 14, 2:11 PMRestricted Project
smeenai accepted D85992: [lld-macho] Fall back to raw path if we don't find anything under syslibroot.

Can you also add a test for the standard paths not being searched without a syslibroot prefix? As in, if you pass -syslibroot and there's e.g. no /usr/lib under it, we shouldn't add the standard /usr/lib to the search path.

Fri, Aug 14, 2:09 PMRestricted Project
Tyker requested review of D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.
Fri, Aug 14, 2:08 PMRestricted Project
NeHuang added inline comments to D85973: [PowerPC] Fix thunk alignment issue when using pc-rel instruction .
Fri, Aug 14, 2:08 PMRestricted Project
guiand updated the diff for D85985: [MSAN] Convert ActualFnStart to be a particular Instruction *, not BB.

Move removeUnreachableBlocks before inserting the prologue. This makes sure there's no issue with the ActualFnStart instruction being deleted before the visitor loop.

Fri, Aug 14, 2:00 PMRestricted Project
aganea accepted D85993: [lldb] Set the access property on member function decls.
Fri, Aug 14, 1:58 PM
aganea added a comment to D85993: [lldb] Set the access property on member function decls.

LGTM.

Fri, Aug 14, 1:58 PM