Page MenuHomePhabricator
Feed Advanced Search

Yesterday

grimar added a comment to D88288: [Archive] Don't throw away errors for malformed archive members.

Minor nit. Otherwise looks good to me. Lets see what others think.

Fri, Sep 25, 8:16 AM · Restricted Project
grimar updated the summary of D88294: [obj2yaml][yaml2obj] - Stop recognizing SHT_MIPS_ABIFLAGS on non-MIPS targets..
Fri, Sep 25, 5:09 AM · Restricted Project
grimar requested review of D88294: [obj2yaml][yaml2obj] - Stop recognizing SHT_MIPS_ABIFLAGS on non-MIPS targets..
Fri, Sep 25, 5:08 AM · Restricted Project
grimar added a comment to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..

I have no more comments. This LG.

Fri, Sep 25, 4:48 AM · Restricted Project
grimar added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 4:40 AM · Restricted Project
grimar added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 3:51 AM · Restricted Project
grimar added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 3:34 AM · Restricted Project
grimar added inline comments to D88113: [llvm-objcopy][NFC] refactor error handling. part 1..
Fri, Sep 25, 3:25 AM · Restricted Project
grimar added inline comments to D88288: [Archive] Don't throw away errors for malformed archive members.
Fri, Sep 25, 2:56 AM · Restricted Project
grimar committed rG64f878db5022: [Object/yaml2obj/obj2yaml][test] - Split, cleanup and move MIPS abi-flags.yaml… (authored by grimar).
[Object/yaml2obj/obj2yaml][test] - Split, cleanup and move MIPS abi-flags.yaml…
Fri, Sep 25, 2:05 AM
grimar closed D88231: [Object/yaml2obj/obj2yaml][test] - Split, cleanup and move MIPS abi-flags.yaml test. NFCI..
Fri, Sep 25, 2:05 AM · Restricted Project
grimar added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 1:52 AM · Restricted Project
grimar added inline comments to D88228: [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section..
Fri, Sep 25, 1:33 AM · Restricted Project
grimar updated the diff for D88228: [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section..
  • Addressed review comments.
Fri, Sep 25, 1:33 AM · Restricted Project

Thu, Sep 24

grimar requested review of D88231: [Object/yaml2obj/obj2yaml][test] - Split, cleanup and move MIPS abi-flags.yaml test. NFCI..
Thu, Sep 24, 7:49 AM · Restricted Project
grimar updated the diff for D88228: [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section..
  • Rebased, updated llvm-readobj/ELF/ARM/unwind-non-relocatable.test test case which needed an update, because ContentArray can only be used for regular sections currently and with this patch yam2obj failed to parse the YAML description.
Thu, Sep 24, 7:05 AM · Restricted Project
grimar planned changes to D88228: [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section..
Thu, Sep 24, 6:57 AM · Restricted Project
grimar retitled D88228: [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section. from [yaml2obj][obj2yaml] - Add a support for SHT_ARM_EXIDX section. to [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section..
Thu, Sep 24, 6:50 AM · Restricted Project
grimar requested review of D88228: [yaml2obj][obj2yaml] - Add support for SHT_ARM_EXIDX section..
Thu, Sep 24, 6:49 AM · Restricted Project
grimar committed rGbb0597067d1e: [llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for… (authored by grimar).
[llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for…
Thu, Sep 24, 3:32 AM
grimar closed D88076: [llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for non-relocatable objects..
Thu, Sep 24, 3:32 AM · Restricted Project
grimar added inline comments to D88097: [llvm-readelf/obj] - Cleanup the code. NFCI..
Thu, Sep 24, 3:19 AM · Restricted Project
grimar committed rG5bddaf6dbf77: [llvm-readobj] - Fix a warning. (authored by grimar).
[llvm-readobj] - Fix a warning.
Thu, Sep 24, 3:19 AM

Wed, Sep 23

grimar added inline comments to D88076: [llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for non-relocatable objects..
Wed, Sep 23, 5:11 AM · Restricted Project
grimar updated the diff for D88076: [llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for non-relocatable objects..

Thanks, Peter! I've addressed all review comments.

Wed, Sep 23, 5:11 AM · Restricted Project
grimar committed rGbd99fb4e0b5f: [llvm-readelf/obj] - Fix extended section symbol indices printed in warnings… (authored by grimar).
[llvm-readelf/obj] - Fix extended section symbol indices printed in warnings…
Wed, Sep 23, 3:53 AM
grimar closed D88089: [llvm-readelf/obj] - Fix extended section symbol indices printed in warnings for MIPS GOT/PLT entries..
Wed, Sep 23, 3:53 AM · Restricted Project
grimar committed rGd4035af25374: [llvm-readelf/obj] - Print section symbol names properly when dumping… (authored by grimar).
[llvm-readelf/obj] - Print section symbol names properly when dumping…
Wed, Sep 23, 3:34 AM
grimar closed D87613: [llvm-readelf/obj] - Print section symbol names properly when dumping relocations..
Wed, Sep 23, 3:33 AM · Restricted Project
grimar added a comment to D87219: [ELF] Merge .openbsd.randomdata.* sections into a single .openbsd.randomdata section when linking.

Well, if the default compiler on openbsd does it, I think the change is reasonable. @MaskRay?
This patch, as was mentioned, needs a test case.

Wed, Sep 23, 3:12 AM · Restricted Project
grimar committed rG310af42ed9ab: [llvm-readelf/obj] - Cleanup the code. NFCI. (authored by grimar).
[llvm-readelf/obj] - Cleanup the code. NFCI.
Wed, Sep 23, 2:59 AM
grimar closed D88097: [llvm-readelf/obj] - Cleanup the code. NFCI..
Wed, Sep 23, 2:59 AM · Restricted Project
grimar added inline comments to D88097: [llvm-readelf/obj] - Cleanup the code. NFCI..
Wed, Sep 23, 2:45 AM · Restricted Project
grimar added a comment to D88097: [llvm-readelf/obj] - Cleanup the code. NFCI..

I wonder whether it might be easier for downstream providers such as my team to merge this patch in if it were in separate commits for each of the major changes, but I don't really mind.

Wed, Sep 23, 2:26 AM · Restricted Project
grimar added inline comments to D87758: Provide a hook to customize missing library error handling.
Wed, Sep 23, 2:21 AM
grimar added inline comments to D88089: [llvm-readelf/obj] - Fix extended section symbol indices printed in warnings for MIPS GOT/PLT entries..
Wed, Sep 23, 2:05 AM · Restricted Project

Tue, Sep 22

grimar accepted D88094: [lld][test][ELF] Expand a couple of test cases for LTO behaviour.

LGTM with a comment added. Please wait for @MaskRay.

Tue, Sep 22, 7:34 AM · Restricted Project
grimar requested review of D88097: [llvm-readelf/obj] - Cleanup the code. NFCI..
Tue, Sep 22, 7:07 AM · Restricted Project
grimar requested review of D88089: [llvm-readelf/obj] - Fix extended section symbol indices printed in warnings for MIPS GOT/PLT entries..
Tue, Sep 22, 5:21 AM · Restricted Project
grimar added inline comments to D87613: [llvm-readelf/obj] - Print section symbol names properly when dumping relocations..
Tue, Sep 22, 3:39 AM · Restricted Project
grimar updated the diff for D87613: [llvm-readelf/obj] - Print section symbol names properly when dumping relocations..
  • Updated implementation after other changes that were landed independently.
  • Addressed review comments.
Tue, Sep 22, 3:39 AM · Restricted Project
grimar committed rG28b84dd13866: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for… (authored by grimar).
[llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for…
Tue, Sep 22, 2:03 AM
grimar closed D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols..
Tue, Sep 22, 2:03 AM · Restricted Project
grimar updated the diff for D88076: [llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for non-relocatable objects..
  • Fix a mistype in comment.
Tue, Sep 22, 1:47 AM · Restricted Project
grimar requested review of D88076: [llvm-readelf/obj] - Stop printing wrong addresses for arm32 unwind info for non-relocatable objects..
Tue, Sep 22, 1:43 AM · Restricted Project
grimar accepted D88073: [DWARFYAML][test] Simplify __debug_pubnames/types tests. NFC..

I am not an expert in MachO, but this change looks good and reasonable to me. Worth waiting for a second opinion.

Tue, Sep 22, 1:06 AM · Restricted Project

Mon, Sep 21

grimar committed rG0a6860521eb8: [LLD][ELF][test] Fix CHECKs in map-file test (authored by edd).
[LLD][ELF][test] Fix CHECKs in map-file test
Mon, Sep 21, 8:39 AM
grimar closed D88023: [LLD][ELF][test] Fix CHECKs in map-file test.
Mon, Sep 21, 8:39 AM · Restricted Project
grimar added a comment to D88023: [LLD][ELF][test] Fix CHECKs in map-file test.

I need the name and email you'd like to use.
E.g:

Mon, Sep 21, 7:50 AM · Restricted Project
grimar added a comment to D88023: [LLD][ELF][test] Fix CHECKs in map-file test.
In D88023#2285358, @edd wrote:

Thanks for the review. I don't have commit access. Would you be willing to commit on my behalf?

Mon, Sep 21, 7:48 AM · Restricted Project
grimar accepted D88023: [LLD][ELF][test] Fix CHECKs in map-file test.

LGTM, thanks!

Mon, Sep 21, 7:39 AM · Restricted Project
grimar updated the diff for D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols..
  • Addressed review comment.
Mon, Sep 21, 6:39 AM · Restricted Project
grimar committed rGdf3e903655e2: [llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI. (authored by grimar).
[llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI.
Mon, Sep 21, 6:08 AM
grimar closed D88016: [llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI..
Mon, Sep 21, 6:08 AM · Restricted Project
grimar added inline comments to D88016: [llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI..
Mon, Sep 21, 5:38 AM · Restricted Project
grimar added a comment to D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols..

All the passing of FirstSym is for &Sym - &FirstSym in ELF.h getExtendedSymbolTableIndex. If we only care about the index, passing around the index rather than the first symbol probably makes more sense?

+1 - this makes sense to me too. Everything else looks good.

Mon, Sep 21, 4:11 AM · Restricted Project
grimar requested review of D88016: [llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI..
Mon, Sep 21, 4:09 AM · Restricted Project
grimar committed rG095f6fbbd7b6: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols. (authored by grimar).
[llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols.
Mon, Sep 21, 3:06 AM
grimar closed D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Mon, Sep 21, 3:06 AM · Restricted Project
grimar added a comment to D87758: Provide a hook to customize missing library error handling.

Still needs a test case.

Mon, Sep 21, 2:41 AM

Sun, Sep 20

grimar updated the diff for D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols..
  • Addressed review comments.
Sun, Sep 20, 1:37 AM · Restricted Project

Fri, Sep 18

grimar added inline comments to D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols..
Fri, Sep 18, 6:16 AM · Restricted Project
grimar requested review of D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols..
Fri, Sep 18, 5:37 AM · Restricted Project
grimar added inline comments to D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Fri, Sep 18, 2:47 AM · Restricted Project
grimar updated the diff for D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
  • Addressed review comment about SHN_UNDEF section symbols.
Fri, Sep 18, 2:46 AM · Restricted Project
grimar added a comment to D87758: Provide a hook to customize missing library error handling.

Should the option name be more specific? --error-handling-script sounds like all errors can be handled with a script,
though this is only intended to be used for missing libraries errors, right?

Fri, Sep 18, 1:47 AM
grimar added inline comments to D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Fri, Sep 18, 12:15 AM · Restricted Project
grimar updated the diff for D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
  • Addressed review comments.
Fri, Sep 18, 12:15 AM · Restricted Project

Thu, Sep 17

grimar accepted D87824: [lld][ELF][test] Add additional LTO testing.

LGTM. Worth waiting for @MaskRay or someone else opinion too.

Thu, Sep 17, 6:16 AM · Restricted Project
grimar committed rG279943edf878: [obj2yaml] - Don't emit EM_NONE. (authored by grimar).
[obj2yaml] - Don't emit EM_NONE.
Thu, Sep 17, 6:00 AM
grimar closed D87829: [obj2yaml] - Don't emit EM_NONE..
Thu, Sep 17, 6:00 AM · Restricted Project
grimar committed rG0dca1ac617d8: [llvm-readelf/obj][test] - Document what we print in various places for unnamed… (authored by grimar).
[llvm-readelf/obj][test] - Document what we print in various places for unnamed…
Thu, Sep 17, 5:57 AM
grimar closed D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Thu, Sep 17, 5:57 AM · Restricted Project
grimar requested review of D87829: [obj2yaml] - Don't emit EM_NONE..
Thu, Sep 17, 5:46 AM · Restricted Project
grimar added inline comments to D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Thu, Sep 17, 4:54 AM · Restricted Project
grimar updated the diff for D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
  • Addressed review comments.
Thu, Sep 17, 4:54 AM · Restricted Project
grimar added inline comments to D87824: [lld][ELF][test] Add additional LTO testing.
Thu, Sep 17, 4:38 AM · Restricted Project

Wed, Sep 16

grimar updated the summary of D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Wed, Sep 16, 7:44 AM · Restricted Project
grimar requested review of D87764: [llvm-readelf/obj] - Stop printing invalid names for unnamed section symbols..
Wed, Sep 16, 7:43 AM · Restricted Project
grimar requested review of D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols..
Wed, Sep 16, 7:40 AM · Restricted Project
grimar added inline comments to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Wed, Sep 16, 2:55 AM · Restricted Project
grimar added a comment to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..

Looks like this breaks tests on mac: http://45.33.8.238/mac/20491/step_11.txt

Please take a look and revert for now if it takes a while to fix.

Wed, Sep 16, 2:42 AM · Restricted Project
grimar committed rGa8d02015fcb7: [llvm-readobj][test] - Improve section-symbols.test (authored by grimar).
[llvm-readobj][test] - Improve section-symbols.test
Wed, Sep 16, 2:36 AM
grimar closed D87612: [llvm-readobj][test] - Improve section-symbols.test.
Wed, Sep 16, 2:36 AM · Restricted Project
grimar added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

nit: add a "[obj2yaml]" prefix to the patch name:

Wed, Sep 16, 2:03 AM · Restricted Project
grimar accepted D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

LGTM, thanks!

Wed, Sep 16, 2:02 AM · Restricted Project
grimar added a reviewer for D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name.: jhenderson.
Wed, Sep 16, 2:02 AM · Restricted Project
grimar committed rGef4851742de5: [llvm-readobj][test] - Address a forgotten review comment for D86923. (authored by grimar).
[llvm-readobj][test] - Address a forgotten review comment for D86923.
Wed, Sep 16, 1:52 AM
grimar accepted D86137: Add -Wno-error=unknown flag to clang-format..

LGTM. It worth wainting for a second approvement and/or other comments to verify that people are happy with doing this for clang-format.

Wed, Sep 16, 1:01 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 15

grimar updated the diff for D87612: [llvm-readobj][test] - Improve section-symbols.test.
  • Merged tests.
Tue, Sep 15, 8:06 AM · Restricted Project
grimar committed rG7df873f9c670: [llvm-readobj/elf] - Don't crash when the size of s dynamic symbol table… (authored by grimar).
[llvm-readobj/elf] - Don't crash when the size of s dynamic symbol table…
Tue, Sep 15, 7:44 AM
grimar closed D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Tue, Sep 15, 7:44 AM · Restricted Project
grimar planned changes to D87613: [llvm-readelf/obj] - Print section symbol names properly when dumping relocations..
Tue, Sep 15, 5:06 AM · Restricted Project
grimar added inline comments to D87612: [llvm-readobj][test] - Improve section-symbols.test.
Tue, Sep 15, 3:12 AM · Restricted Project
grimar updated the diff for D87612: [llvm-readobj][test] - Improve section-symbols.test.
  • Addressed review comments.
Tue, Sep 15, 3:12 AM · Restricted Project
grimar added inline comments to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
Tue, Sep 15, 2:58 AM · Restricted Project
grimar updated the diff for D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..
  • Addressed review comments.
Tue, Sep 15, 2:58 AM · Restricted Project
grimar committed rGbccd2ec3e216: [llvm-readobj/elf] - Simplify and refine the implementation which dumps . (authored by grimar).
[llvm-readobj/elf] - Simplify and refine the implementation which dumps .
Tue, Sep 15, 1:57 AM
grimar closed D87362: [llvm-readobj/elf] - Simplify and refine the implementation which dumps .stack_sizes.
Tue, Sep 15, 1:57 AM · Restricted Project
grimar committed rG4845531fa88c: [lib/Object] - Refine interface of ELFFile<ELFT>. NFCI. (authored by grimar).
[lib/Object] - Refine interface of ELFFile<ELFT>. NFCI.
Tue, Sep 15, 1:39 AM