addressed @Mordante comments.
Sun, Feb 14
used _LIBCPP_NO_HAS_CHAR8_T and _LIBCPP_HAS_NO_UNICODE_CHARS macro to guard char8_t, and char16_t, char32_t.
Jan 12 2021
Jan 4 2021
fixed a nit.
rebased with the main branch. do not see any conflict.
@ldionne or @abdulras can you please have a look at this, this patch is in this state for a long time.
FYI, I have been using this patch in VxWorks.
Nov 5 2020
Oct 14 2020
Is this a problem unique to vector? Do the other containers have the same constructor? Do those constructors have the same issue?
Checking ... list does not seem to have this problem. deque does not either. forward_list does not either.
<deque> has the following code:template <class _InputIter> deque(_InputIter __f, _InputIter __l, typename enable_if<__is_cpp17_input_iterator<_InputIter>::value>::type* = 0); template <class _InputIter> deque(_InputIter __f, _InputIter __l, const allocator_type& __a, typename enable_if<__is_cpp17_input_iterator<_InputIter>::value>::type* = 0);
I don't think that making vector different from the other containers is the right approach. Then again, I'm not 100% sure why the existing code is failing - so I should look at tha
Oct 2 2020
Added test suggested by @mclow.lists .
So the actual problem in the bug report is that the first argument cannot be used to deduce the type.
I think it is not correct to remove the type restrictions here, they are there for a reason.
Aug 30 2020
Aug 29 2020
Jul 31 2020
Jul 30 2020
rebased with the master.
Jul 26 2020
addressed @mhorne comments.
Jul 23 2020
Jun 29 2020
Jun 24 2020
Jun 22 2020
Jun 19 2020
rebased and cleaned up the diff.
D77505 broke a bunch of bots. This fixes the regression.
I lack commit privileges. Please land as "Raul Tambre <email@example.com>"
Please commit this for me in case no one else has objections. I lack commit privileges.
Jun 18 2020
Jun 17 2020
Addressed @efriedma comments.
added test for strictfp.
Jun 16 2020
thanks @mhorne for reviewing.
addressed your comments.
Jun 15 2020
Jun 14 2020
Jun 13 2020
Jun 12 2020
addressed @luismarques concerns.
This patch extends soft float case .
enhanced and more testcases.
Jun 8 2020
Jun 2 2020
I do not have commit access,
can someone commit this for me?
LGTM. But please give it some time for other people to chime in before you merge, they may disagree with this .inc approach.
I'm approving this assuming the generic test is actually ran against this implementation. @kamleshbhalui did you verify that was the case?
May 30 2020
May 28 2020
@kamleshbhalui Just to be clear -- you need libunwind approval before you can submit a patch that touches libunwind. If you just wanted to iterate on this privately it's OK, but you'll need approval from the group before submitting.
restructured the file. so it can be picked by lit test.
for all these below variants
ILP32 + "f" : xlen = 32, flen = 32 ===> 39
ILP32 + "fd" : xlen = 32, flen = 64 ===>55
LP64 + "f" : xlen = 64, flen = 32 ====>60
LP64 + "fd" : xlen = 64, flen = 64 ====>76 (was already done.)
addressed @luismarques comments.
May 27 2020
Addressed @luismarques concerns.
Still uneasy with the assembly implementation. .c works as well, doesn't it?
May 25 2020
-ftrapping-math will do the work.
so abandoning it.
May 23 2020
fixed failing testcase.
Borrow useful things from D78427:
- A test
- Version guard
- Double include test
Rebased on master.
added CMakeLists.txt change for riscv64.
May 22 2020
duplicate of D77505
thanks @curdeius for pointing this.
I was unaware of this work and ended of doing same work.
please take things from here D78427 which seems reasonable.
and update the this review. so i can cancel my review.
May 11 2020
May 8 2020
I do not have commit access.
May 6 2020
Incorporated @curdeius suggestion.
Addressed @rsmith concerns.
Thanks for the review @curdeius.
addressed your concerns.
May 3 2020
Apr 21 2020
changed value to __value
Thanks for review.
added cxx2a _statu.html
Apr 18 2020
Add one more test.