Page MenuHomePhabricator
Feed Advanced Search

Aug 11 2020

Typz added inline comments to D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.
Aug 11 2020, 4:51 AM · Restricted Project, Restricted Project, Restricted Project
Typz added a comment to D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.

Could this also be causing https://bugs.llvm.org/show_bug.cgi?id=33896 ?

I'll try to see if changes something in that case...

Aug 11 2020, 4:33 AM · Restricted Project, Restricted Project, Restricted Project
Typz added a comment to D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces.

Could this also be causing https://bugs.llvm.org/show_bug.cgi?id=33896 ?

Aug 11 2020, 4:25 AM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2020

Typz added inline comments to D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign.
Jun 24 2020, 10:45 PM · Restricted Project

May 28 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Regarding ?:, this is definitely not considered, and should be relatively easy to handle.

May 28 2020, 9:50 AM · Restricted Project, Restricted Project
Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Indeed, I saw the emails, but I didn't have time to check or investigate the issues.

May 28 2020, 9:50 AM · Restricted Project, Restricted Project

May 26 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.
In D50078#2055227, @srj wrote:

And I also think it should be on by default instead of modifying many .clang-format files. So IMHO if we add an option, it should be opt-out.

I can live with it being opt-out. My big concern is that (as it currently stands) our project gets different 'canonical' clang-format results depending on whether people are using LLVM10 vs LLVM11 (and both are common and supported by our project), which is a headache. I just want a way to get consistent, predictable formatting regardless of the clang-format version.

May 26 2020, 1:05 PM · Restricted Project, Restricted Project

May 22 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

I get the point about Opt In, and if we are going to add an option it needs to go in ASAP otherwise too many people will then start complaining it was on by default before.

To be honest I think the question is do we consider this a bug or a feature, because we DO NOT provide Opt In on bug fixes (and there is no Opt Out).

If its a bug, there is no need for us to not have this on by default, its better to drive the improvement than 10,000's of .clang-format files needing to be updated just to get reasonable behavior.

May 22 2020, 4:45 AM · Restricted Project, Restricted Project

May 15 2020

Typz committed rG4db94094b469: clang-format: support aligned nested conditionals formatting (authored by Typz).
clang-format: support aligned nested conditionals formatting
May 15 2020, 8:07 AM
Typz committed rG0ee04e6e0d0e: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set (authored by Typz).
[clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set
May 15 2020, 8:07 AM
Typz closed D50078: clang-format: support aligned nested conditionals formatting.
May 15 2020, 8:07 AM · Restricted Project, Restricted Project
Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Fix random crash on windows

May 15 2020, 7:33 AM · Restricted Project, Restricted Project

May 6 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Still no chance getting a windows or s390x machine, but i could reproduce the/a problem systematically on linux by enabling sanitizer.
In this case, initializing ConditionalsLevel to 0 in constructor does index fix this issue (and initializing to 1 ensures the issue happens, though not in "regular" linux build).

May 6 2020, 6:24 AM · Restricted Project, Restricted Project

Apr 24 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Thanks for trying the patch, too bad it does not work...
I will see how to get the required setup/env, but it will probably take some time (esp. in the current situation).
Thanks again

Apr 24 2020, 3:13 AM · Restricted Project, Restricted Project

Apr 23 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.

Take the most recent 5 runs of the llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast buildbot. Builds #31973, 31975 and 31976 all failed because of that test failing.

On my local Windows computer, if I build your commit and run the FormatTest unit test multiple times (the same binary without changing anything or rebuilding), that above test fails roughly 50% of the time.

Can you take a look to figure out why your change might be causing this instability?

Hi,
That is very strange indeed, nothing is supposed to be random here...
I will try to have a look, but I don't have a windows computer to test, and never seen this issue on linux/macos :-/

The linux (s390x arch) buildbot is also failing, http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/31811/steps/ninja%20check%201/logs/stdio.
I reverted it in 47ef09e4848a970c530928496b54085cfdba5a76 to make buildbot happy.

Apr 23 2020, 7:32 AM · Restricted Project, Restricted Project

Apr 22 2020

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.
Apr 22 2020, 11:57 PM · Restricted Project, Restricted Project
Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.

Take the most recent 5 runs of the llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast buildbot. Builds #31973, 31975 and 31976 all failed because of that test failing.

On my local Windows computer, if I build your commit and run the FormatTest unit test multiple times (the same binary without changing anything or rebuilding), that above test fails roughly 50% of the time.

Can you take a look to figure out why your change might be causing this instability?

Apr 22 2020, 11:25 PM · Restricted Project, Restricted Project
Typz committed rG3d61b1120e82: clang-format: Introduce stricter AlignOperands flag (authored by Typz).
clang-format: Introduce stricter AlignOperands flag
Apr 22 2020, 8:40 AM
Typz committed rG5daa25fd7a18: clang-format: support aligned nested conditionals formatting (authored by Typz).
clang-format: support aligned nested conditionals formatting
Apr 22 2020, 8:40 AM
Typz closed D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.
Apr 22 2020, 8:40 AM · Restricted Project, Restricted Project

Nov 19 2019

Typz added a comment to D50147: clang-format: support external styles.

First and forehand, I have a problem to solve in my organization : we have many projects, and maintaining the config file in some many repositories is not practical.
In some case (like, LLVM, google or mozilla), this is not an issue because the formatting rules are hard-coded in clang-format.

I think this option is available to anyone with a public style guide that covers a reasonably large body of open-source code, and which can be reasonably well supported by clang-format.
I'd expect QT, KDE etc should be able to use this mechanism.

Nov 19 2019, 2:08 AM · Restricted Project, Restricted Project

Nov 15 2019

Typz added inline comments to rGa75f8d98d7ac: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some….
Nov 15 2019, 5:06 AM
Typz created D70305: clang-format: fix regression in middle pointer alignment.
Nov 15 2019, 5:06 AM · Restricted Project

Nov 14 2019

Typz added inline comments to rGa75f8d98d7ac: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some….
Nov 14 2019, 2:40 AM

Oct 25 2019

Typz added inline comments to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.
Oct 25 2019, 3:33 AM · Restricted Project, Restricted Project
Typz updated the diff for D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

Rebase on top of D50078

Oct 25 2019, 3:05 AM · Restricted Project, Restricted Project
Typz added inline comments to D50078: clang-format: support aligned nested conditionals formatting.
Oct 25 2019, 12:29 AM · Restricted Project, Restricted Project
Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Implement a fallback to regularly indented alignment when the question mark is wrapped.

Oct 25 2019, 12:29 AM · Restricted Project, Restricted Project

Oct 24 2019

Typz added inline comments to D50078: clang-format: support aligned nested conditionals formatting.
Oct 24 2019, 6:39 AM · Restricted Project, Restricted Project
Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Sorry, I struggled a bit with git & phabricator, and ended up uploading non-working code :-/

Oct 24 2019, 6:39 AM · Restricted Project, Restricted Project
Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Fix earlier error in patch upload.

Oct 24 2019, 6:27 AM · Restricted Project, Restricted Project
Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Fix corner in previous rebase

Oct 24 2019, 3:07 AM · Restricted Project, Restricted Project

Oct 23 2019

Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Rebased on master, integrating required code from https://reviews.llvm.org/D32478

Oct 23 2019, 10:05 AM · Restricted Project, Restricted Project

Oct 17 2019

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

This actually depends on another Diff : https://reviews.llvm.org/D32478
That other change introduces the ability to "unindent operator", which is required here; however, it also changes AlignOperands to have more than 2 modes, which does not seem to be acceptable.

Oct 17 2019, 6:43 AM · Restricted Project, Restricted Project

Aug 28 2019

Typz added a comment to D50147: clang-format: support external styles.

ping?

Aug 28 2019, 4:36 AM · Restricted Project, Restricted Project

Jun 11 2019

Typz updated the diff for D50078: clang-format: support aligned nested conditionals formatting.

Rebase

Jun 11 2019, 4:36 AM · Restricted Project, Restricted Project
Typz updated the diff for D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

Rebase

Jun 11 2019, 1:52 AM · Restricted Project, Restricted Project

Jun 7 2019

Typz added a comment to D50147: clang-format: support external styles.

One thing that's unclear to me is whether your aim is to

  1. solve a concrete problem for your organization
  2. solve a family of problems for similar organizations
  3. add a new way of configuring styles for many types of users/projects
Jun 7 2019, 3:14 AM · Restricted Project, Restricted Project

Jun 6 2019

Typz committed rGe8a301f87f75: clang-format: better handle namespace macros (authored by Typz).
clang-format: better handle namespace macros
Jun 6 2019, 1:04 PM
Typz committed rL362740: clang-format: better handle namespace macros.
clang-format: better handle namespace macros
Jun 6 2019, 1:04 PM
Typz closed D37813: clang-format: better handle namespace macros.
Jun 6 2019, 1:04 PM · Restricted Project, Restricted Project
Typz updated the diff for D37813: clang-format: better handle namespace macros.

Rebase

Jun 6 2019, 1:02 PM · Restricted Project, Restricted Project
Typz added a comment to D50147: clang-format: support external styles.

ping?

Jun 6 2019, 6:58 AM · Restricted Project, Restricted Project
Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

ping ?

Jun 6 2019, 6:58 AM · Restricted Project, Restricted Project
Typz added a comment to D37813: clang-format: better handle namespace macros.

ping?

Jun 6 2019, 6:55 AM · Restricted Project, Restricted Project

May 29 2019

Typz committed rGc5227a1f5310: [clang-format] Allow configuring list of function-like macros that resolve to a… (authored by Typz).
[clang-format] Allow configuring list of function-like macros that resolve to a…
May 29 2019, 9:31 AM
Typz committed rL361986: [clang-format] Allow configuring list of function-like macros that resolve to a….
[clang-format] Allow configuring list of function-like macros that resolve to a…
May 29 2019, 9:30 AM
Typz committed rC361986: [clang-format] Allow configuring list of function-like macros that resolve to a….
[clang-format] Allow configuring list of function-like macros that resolve to a…
May 29 2019, 9:30 AM
Typz closed D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type.
May 29 2019, 9:30 AM · Restricted Project
Typz committed rG0a729261e22e: [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest (authored by Typz).
[NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest
May 29 2019, 9:23 AM
Typz committed rC361984: [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest.
[NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest
May 29 2019, 9:23 AM
Typz committed rL361984: [NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest.
[NFC] clang-format: Use LLVM style in NamespaceEndCommentsFixerTest
May 29 2019, 9:23 AM
Typz added inline comments to D37813: clang-format: better handle namespace macros.
May 29 2019, 9:22 AM · Restricted Project, Restricted Project
Typz updated the diff for D37813: clang-format: better handle namespace macros.
  • Rebase
  • Fix NamespaceEndCommentsFixerTest to match LLVM indent style
May 29 2019, 8:44 AM · Restricted Project, Restricted Project

May 28 2019

Typz updated the diff for D50147: clang-format: support external styles.
  • Rebased
  • Adapt styles search path to platform conventions
  • Allow customizing search path at compile time
  • Allow overriding search path at runtime through CLANG_FORMAT_STYLES_PATH env variable
May 28 2019, 9:37 AM · Restricted Project, Restricted Project

May 24 2019

Typz added inline comments to D37813: clang-format: better handle namespace macros.
May 24 2019, 9:23 AM · Restricted Project, Restricted Project

May 23 2019

Typz added a comment to D37813: clang-format: better handle namespace macros.

Ah, wow, I see what confused me now:
In the fixNamespaceEndComment tests you use an indent that clang-format would not produce. Can you please fix that, otherwise I find this super confusing :)

May 23 2019, 2:52 AM · Restricted Project, Restricted Project
Herald added a project to D50147: clang-format: support external styles: Restricted Project.

ping?

Sorry for losing track of this.

I think -style=<filename> is a logical extension of the current options. I'm less sure of supporting it in BasedOnStyle, but happy to go either way.

May 23 2019, 12:39 AM · Restricted Project, Restricted Project

May 22 2019

Typz accepted D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type.

Actually, looking at all the other options, the same is true for all other macro kind of macros (NamespaceMacros...).

May 22 2019, 1:35 PM · Restricted Project
Herald added a project to D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type: Restricted Project.

Regarding variable/setting names, one issue I see is that these macros are not really type names IMO : the macro name is just part of the type (like a template), and its invocation is a type declaration. So maybe renaming to Typedecl or something like this would be slightly more representative.

May 22 2019, 1:31 PM · Restricted Project
Herald added a project to D50078: clang-format: support aligned nested conditionals formatting: Restricted Project.

ping ?

May 22 2019, 9:37 AM · Restricted Project, Restricted Project
Typz added a comment to D37813: clang-format: better handle namespace macros.

The patch goal is indeed to indent the content of namespace-macro blocks like the content of any 'regular' namespace. So it should look like the content of a namespace, possibly depending on the choose style options. To sumarize, here is a detailed summary of the observable differences between macros vs normal namespace.

May 22 2019, 9:27 AM · Restricted Project, Restricted Project

May 17 2019

Herald added a project to D37813: clang-format: better handle namespace macros: Restricted Project.

ping ?

May 17 2019, 8:08 AM · Restricted Project, Restricted Project

Nov 27 2018

Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

ping ?

Nov 27 2018, 9:13 AM · Restricted Project, Restricted Project
Typz added a comment to D37813: clang-format: better handle namespace macros.

ping?

Nov 27 2018, 8:56 AM · Restricted Project, Restricted Project
Typz added a comment to D50147: clang-format: support external styles.

ping?

Nov 27 2018, 8:55 AM · Restricted Project, Restricted Project

Oct 29 2018

Typz added a comment to D50147: clang-format: support external styles.

Being able to discover the right style from the filesystem is powerful, and if I was going to use this flag, I'd consider symlinking the style-file to subproject/.clang_format instead. That way the setting is persistent and available to all tools, rather than us needing to get it right on each invocation.

Oct 29 2018, 10:41 AM · Restricted Project, Restricted Project
Typz added a comment to D50147: clang-format: support external styles.

The idea here does seem to be a natural extension of -style, at least for the case when the arg is a filename directly. I'm not opposed, happy to review this.

I do want to probe the use case a bit though: we have found that configuring via -style= doesn't scale that well to lots of codebases and tools. e.g. if someone's running clang-tidy or clangd via some driver, are they going to have a way to plumb through the right -style=?

Being able to discover the right style from the filesystem is powerful, and if I was going to use this flag, I'd consider symlinking the style-file to subproject/.clang_format instead. That way the setting is persistent and available to all tools, rather than us needing to get it right on each invocation.

Oct 29 2018, 10:28 AM · Restricted Project, Restricted Project

Oct 4 2018

Typz added a comment to D37813: clang-format: better handle namespace macros.

The problem here is that we have different opinions on how the formatting on namespace macros should behave in the first place- I think they should behave like namespaces, you want them to be formatted differently.
Given that you want full control over the formatting of those macros, and them not actually be formatted exactly like namespaces or classes, I think we need a more generic mechanism for you to express that.

Not sure what you mean here. I want them to behave like namespaces as well, this is actually the use case I have... As implemented, they indeed behave exactly like namespaces :

TESTSUITE(a) {                       namespace a {
} // TESTSUITE(a)                    } // namespace a
                                VS
TESTSUITE(a) { TESTSUITE(b) {        namespace a { namespace b {
} // TESTSUITE(a::b)                 }} // namespace a::b

I thought we had the discussion upthread that they indent differently from namespaces. I'm working on a patch that allows you to configure macros.

Oct 4 2018, 2:59 AM · Restricted Project, Restricted Project

Oct 3 2018

Typz added a comment to D37813: clang-format: better handle namespace macros.

The problem here is that we have different opinions on how the formatting on namespace macros should behave in the first place- I think they should behave like namespaces, you want them to be formatted differently.
Given that you want full control over the formatting of those macros, and them not actually be formatted exactly like namespaces or classes, I think we need a more generic mechanism for you to express that.

Oct 3 2018, 8:39 AM · Restricted Project, Restricted Project

Oct 2 2018

Typz committed rC343602: clang-format: better handle statement macros.
clang-format: better handle statement macros
Oct 2 2018, 9:42 AM
Typz committed rL343602: clang-format: better handle statement macros.
clang-format: better handle statement macros
Oct 2 2018, 9:41 AM
Typz closed D33440: clang-format: better handle statement macros.
Oct 2 2018, 9:41 AM · Restricted Project

Sep 25 2018

Typz added a comment to D50147: clang-format: support external styles.

I don't understand the use-case this patch is realizing. Suppose I have a bunch of projects that have to share a format style. Then I can checkout them under a common root directory and put an appropriate .clang-format file there.

Sep 25 2018, 1:50 AM · Restricted Project, Restricted Project

Sep 4 2018

Typz added a comment to D50147: clang-format: support external styles.

clang-format does indeed support .clang-format, which is great for *isolated* projects, and which is not affected by this patch.

Sep 4 2018, 8:51 AM · Restricted Project, Restricted Project

Aug 1 2018

Typz created D50147: clang-format: support external styles.
Aug 1 2018, 9:50 AM · Restricted Project, Restricted Project
Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Could you clarify how each piece is supposed to be aligned in these examples?
This is what makes me happy:

// column  limit             V
int a = condition1 ? result1
      : conditio2 ? result2
      : loooooooooocondition 
        ? result2
        : dition3 ? resul3
                  : resul4;
// column  limit             V
int a = condition1 
        ? loooooresult1
        : conditio2 ? result2
                    : result4;
Aug 1 2018, 7:22 AM · Restricted Project, Restricted Project
Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.
  • I'd be ok with the suggestion for BreakBeforeTernaryOperators=true
Aug 1 2018, 6:56 AM · Restricted Project, Restricted Project
Typz added a comment to D37813: clang-format: better handle namespace macros.

This has been stale for a while now. Last comment indicate this is not the right approach, but some prototyping has been done a more generic approach, with no timeline.
I understand this, but in the meantime the problem is still there, with no solution at the moment...

Aug 1 2018, 2:43 AM · Restricted Project, Restricted Project

Jul 31 2018

Typz updated the diff for D43183: clang-format: introduce `CaseBlockIndent` to control indent in switch.

Regenerate documentation

Jul 31 2018, 9:59 AM
Typz updated the diff for D37813: clang-format: better handle namespace macros.

Regeneration documentation

Jul 31 2018, 9:52 AM · Restricted Project, Restricted Project
Typz updated the diff for D33440: clang-format: better handle statement macros.

Regenerate documentation

Jul 31 2018, 9:50 AM · Restricted Project
Typz added a comment to D50078: clang-format: support aligned nested conditionals formatting.

Notes:

  • I choose not to add an option to enable this behavior, as I think of it as just another way clang-format can (better) format the code; but I can one if needed
  • Currently, it relies on another patch (D32478), which supports aligning the wrapped operator slightly differently. If/since that other patch does not seem to make it, I can change this patch to either do the alignment in this specific case (e.g. for wrapped ternary operator only) or to keep the 'default' behavior of clang-format (e.g. the wrapped colon would be aligned with the first condition):
Jul 31 2018, 9:49 AM · Restricted Project, Restricted Project
Typz created D50078: clang-format: support aligned nested conditionals formatting.
Jul 31 2018, 9:31 AM · Restricted Project, Restricted Project
Typz updated the diff for D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

rebase

Jul 31 2018, 9:28 AM · Restricted Project, Restricted Project

Jun 14 2018

Typz committed rC334709: clang-format: Fix documentation generation.
clang-format: Fix documentation generation
Jun 14 2018, 6:36 AM
Typz committed rL334709: clang-format: Fix documentation generation.
clang-format: Fix documentation generation
Jun 14 2018, 6:36 AM
Typz closed D48161: clang-format: Fix documentation generation.
Jun 14 2018, 6:36 AM
Typz updated the diff for D48161: clang-format: Fix documentation generation.

rebase

Jun 14 2018, 6:35 AM
Typz updated the diff for D48161: clang-format: Fix documentation generation.

Add missing block, for consistency

Jun 14 2018, 2:23 AM
Typz retitled D48161: clang-format: Fix documentation generation from Fix documentation generation to clang-format: Fix documentation generation.
Jun 14 2018, 2:19 AM
Typz created D48161: clang-format: Fix documentation generation.
Jun 14 2018, 2:18 AM

Jun 12 2018

Typz added a comment to D42787: clang-format: do not add extra indent when wrapping last parameter.

The normal rule for formatting options apply. If you can dig up a public style guide and a project of reasonable size where it is used, we can add an option.

Jun 12 2018, 7:29 AM

Jun 11 2018

Typz committed rL334408: clang-format: Introduce BreakInheritanceList option.
clang-format: Introduce BreakInheritanceList option
Jun 11 2018, 7:46 AM
Typz committed rC334408: clang-format: Introduce BreakInheritanceList option.
clang-format: Introduce BreakInheritanceList option
Jun 11 2018, 7:45 AM
Typz closed D43015: clang-format: Introduce BreakInheritanceList option.
Jun 11 2018, 7:45 AM
Typz updated the diff for D43015: clang-format: Introduce BreakInheritanceList option.

rebase

Jun 11 2018, 7:43 AM

Jun 8 2018

Typz added a comment to D42787: clang-format: do not add extra indent when wrapping last parameter.

Would it be acceptable to introduce an option to allow enabling this behavior?
I mean would it have a chance of being integrated, or must I keep maintaining a fork of clang-format...

Jun 8 2018, 7:18 AM
Typz added a comment to D37813: clang-format: better handle namespace macros.

ping?

Jun 8 2018, 7:09 AM · Restricted Project, Restricted Project
Typz added a comment to D43015: clang-format: Introduce BreakInheritanceList option.

ping?

Jun 8 2018, 7:07 AM