Page MenuHomePhabricator
Feed Advanced Search

Thu, Jan 14

JosephTremoulet committed rG85dfcaadc5f0: [LLDB] MinidumpParser: Prefer executable module even at higher address (authored by JosephTremoulet).
[LLDB] MinidumpParser: Prefer executable module even at higher address
Thu, Jan 14, 10:18 AM
JosephTremoulet closed D94629: [LLDB] MinidumpParser: Prefer executable module even at higher address.
Thu, Jan 14, 10:18 AM · Restricted Project

Wed, Jan 13

JosephTremoulet updated the diff for D94629: [LLDB] MinidumpParser: Prefer executable module even at higher address.
  • Fix comment
Wed, Jan 13, 12:58 PM · Restricted Project
JosephTremoulet added reviewers for D94629: [LLDB] MinidumpParser: Prefer executable module even at higher address: clayborg, labath.
Wed, Jan 13, 12:54 PM · Restricted Project
JosephTremoulet requested review of D94629: [LLDB] MinidumpParser: Prefer executable module even at higher address.
Wed, Jan 13, 12:54 PM · Restricted Project

Nov 19 2020

JosephTremoulet added inline comments to D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1.
Nov 19 2020, 11:35 AM · Restricted Project, Restricted Project

Oct 30 2020

JosephTremoulet committed rGd20aa7ca4221: [lldb] Report old modules from ModuleList::ReplaceEquivalent (authored by JosephTremoulet).
[lldb] Report old modules from ModuleList::ReplaceEquivalent
Oct 30 2020, 12:14 PM
JosephTremoulet committed rG61bfc703c3d3: [lldb] GetSharedModule: Collect old modules in SmallVector (authored by JosephTremoulet).
[lldb] GetSharedModule: Collect old modules in SmallVector
Oct 30 2020, 12:14 PM
JosephTremoulet closed D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.
Oct 30 2020, 12:14 PM · Restricted Project
JosephTremoulet closed D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.
Oct 30 2020, 12:14 PM · Restricted Project
JosephTremoulet added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

OK, I believe this is correct now.

Oct 30 2020, 11:08 AM · Restricted Project
JosephTremoulet updated the diff for D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.
  • Ignore old modules not in target list
Oct 30 2020, 11:06 AM · Restricted Project
JosephTremoulet added inline comments to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.
Oct 30 2020, 9:55 AM · Restricted Project
JosephTremoulet updated the diff for D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.
  • Expand logging as suggested in D89157
Oct 30 2020, 9:51 AM · Restricted Project

Oct 29 2020

JosephTremoulet added a comment to D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.

But then you get to a point where you shouldn't really have multiple modules replacing a single one so you aren't really sure what to do about it. That part makes me a little uneasy.

Oct 29 2020, 11:56 AM · Restricted Project
JosephTremoulet added a comment to D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.

Thanks for the review!

Oct 29 2020, 7:15 AM · Restricted Project

Oct 28 2020

JosephTremoulet added a comment to D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.

I'd been hoping to get this bugfix into 11.0.1, but it (and D89156, which is just some cleanup that occurred to me while working on this code) have been stalled for a few weeks, and I don't have any insight into the reason. If there's anything i can do to help either one along, please let me know. One idea I had is that I could rebase this on master so it doesn't depend on the other, would that help?

Oct 28 2020, 6:20 AM · Restricted Project

Oct 21 2020

JosephTremoulet added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

Ping

Oct 21 2020, 5:30 AM · Restricted Project

Oct 16 2020

JosephTremoulet committed rGd30797b4041f: [lldb] Minidump: check for .text hash match with directory (authored by JosephTremoulet).
[lldb] Minidump: check for .text hash match with directory
Oct 16 2020, 6:33 AM
JosephTremoulet closed D89155: [lldb] Minidump: check for .text hash match with directory.
Oct 16 2020, 6:33 AM · Restricted Project

Oct 13 2020

JosephTremoulet added a comment to D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.

IIUC, the problem with ReplaceModule will get fixed in a dependent patch, right? So the last bit of this patch will get cleaned up by that change. If that's right, then this LGTM.

Oct 13 2020, 7:21 PM · Restricted Project
JosephTremoulet added inline comments to D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.
Oct 13 2020, 1:26 PM · Restricted Project
JosephTremoulet added a reviewer for D89156: [lldb] GetSharedModule: Collect old modules in SmallVector: jingham.
Oct 13 2020, 1:25 PM · Restricted Project
JosephTremoulet added a comment to D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.
Oct 13 2020, 1:20 PM · Restricted Project
JosephTremoulet updated the diff for D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.
  • Comment new parameter
Oct 13 2020, 1:15 PM · Restricted Project

Oct 10 2020

JosephTremoulet added a comment to D89155: [lldb] Minidump: check for .text hash match with directory.

Thanks for the speedy review! I've updated it to include a testcase that shows the problem you described, and include the fix you suggested.

Oct 10 2020, 9:58 AM · Restricted Project
JosephTremoulet updated the diff for D89155: [lldb] Minidump: check for .text hash match with directory.
  • Handle finding wrong version before right one
Oct 10 2020, 9:57 AM · Restricted Project

Oct 9 2020

JosephTremoulet added a reviewer for D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent: clayborg.
Oct 9 2020, 12:24 PM · Restricted Project
JosephTremoulet added reviewers for D89155: [lldb] Minidump: check for .text hash match with directory: labath, clayborg.
Oct 9 2020, 12:21 PM · Restricted Project
JosephTremoulet added a reviewer for D89156: [lldb] GetSharedModule: Collect old modules in SmallVector: JDevlieghere.
Oct 9 2020, 12:19 PM · Restricted Project
JosephTremoulet requested review of D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent.
Oct 9 2020, 12:16 PM · Restricted Project
JosephTremoulet requested review of D89156: [lldb] GetSharedModule: Collect old modules in SmallVector.
Oct 9 2020, 12:15 PM · Restricted Project
JosephTremoulet requested review of D89155: [lldb] Minidump: check for .text hash match with directory.
Oct 9 2020, 12:14 PM · Restricted Project

Sep 23 2020

JosephTremoulet committed rG4a55c98fa7be: [lldb] Normalize paths in new test (authored by JosephTremoulet).
[lldb] Normalize paths in new test
Sep 23 2020, 12:42 PM
JosephTremoulet committed rG20f84257ac4a: [lldb] Fix GetRemoteSharedModule fallback logic (authored by JosephTremoulet).
[lldb] Fix GetRemoteSharedModule fallback logic
Sep 23 2020, 6:01 AM
JosephTremoulet closed D88099: [lldb] Fix GetRemoteSharedModule fallback logic.
Sep 23 2020, 6:01 AM · Restricted Project

Sep 22 2020

JosephTremoulet added a reviewer for D88099: [lldb] Fix GetRemoteSharedModule fallback logic: jasonmolenda.
Sep 22 2020, 7:29 AM · Restricted Project
JosephTremoulet requested review of D88099: [lldb] Fix GetRemoteSharedModule fallback logic.
Sep 22 2020, 7:27 AM · Restricted Project

Aug 31 2020

JosephTremoulet added a comment to D86863: [EarlyCSE] Verify hash code in regression tests.

Yeah, the potential for quadratic explosion is why I didn't hook this flag up to expensive checks when I added it. It occurs to me now that if we want, we could presumably have some cutoff counter so that after inserting 300 instructions or whatever limit is reasonable, we start hashing normally. We'd have to empty the table and repopulate it with the normal hash when we cut over, but that should be doable I think (it's similar to what the table does internally when it grows).

Aug 31 2020, 11:07 AM · Restricted Project

Aug 26 2020

JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

To clarify, the failure did not reproduce for me in the SUSE 15.02 container. I don't know what I'm doing differently. To create the environment, I just did docker run ... opensuse/leap:15.2, and then zypper in gcc-c++ python3-devel inside the container.

Aug 26 2020, 9:52 AM · Restricted Project
JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

FWIW, I tried running the test in an SUSE 15.2 docker container (on an Ubuntu 18.04 host), and here's what I'm seeing. raise and abort indeed do not indicate that they had the S set in the augmentation:

Aug 26 2020, 8:38 AM · Restricted Project
JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

eh_frame augmented UnwindPlan:
...
This UnwindPlan is for a trap handler function: yes.

Aug 26 2020, 7:53 AM · Restricted Project

Aug 25 2020

JosephTremoulet added a comment to D86417: [lldb] do not propagate eTrapHandlerFrame repeatedly.

And its parent 'raise' is set so as well because of 'GetNextFrame()->m_frame_type == eTrapHandlerFrame '.

Aug 25 2020, 7:56 AM · Restricted Project

May 12 2020

JosephTremoulet added a reviewer for D79760: [WinEH64] Fix a crush issue when c++ exception nested in a particular form.: tentzen.
May 12 2020, 6:52 PM · Restricted Project

Feb 10 2020

JosephTremoulet accepted D74285: [EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083).

LGTM, thanks.

Feb 10 2020, 2:06 PM · Restricted Project

Dec 4 2019

JosephTremoulet committed rG95b2e516bd3e: Change Target::FindBreakpointsByName to return Expected<vector> (authored by JosephTremoulet).
Change Target::FindBreakpointsByName to return Expected<vector>
Dec 4 2019, 7:03 AM
JosephTremoulet closed D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 4 2019, 7:03 AM · Restricted Project

Dec 3 2019

JosephTremoulet added inline comments to D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 3 2019, 9:37 AM · Restricted Project
JosephTremoulet updated the diff for D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
  • Use invalid_argument error code
Dec 3 2019, 9:37 AM · Restricted Project
JosephTremoulet retitled D70907: Change Target::FindBreakpointsByName to return Expected<vector> from Change Target::FindBreakpointsByName to use a vector to Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 3 2019, 8:14 AM · Restricted Project
JosephTremoulet updated the diff for D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
  • Change signature to return Expected<vector<BreakpointSP>>
Dec 3 2019, 8:04 AM · Restricted Project

Dec 2 2019

JosephTremoulet added inline comments to D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 2 2019, 10:26 AM · Restricted Project
JosephTremoulet added reviewers for D70907: Change Target::FindBreakpointsByName to return Expected<vector>: jingham, JDevlieghere.
Dec 2 2019, 8:05 AM · Restricted Project
JosephTremoulet created D70907: Change Target::FindBreakpointsByName to return Expected<vector>.
Dec 2 2019, 8:05 AM · Restricted Project

Oct 18 2019

JosephTremoulet committed rG77460d3888c5: ProcessMinidump: Suppress reporting stop for signal '0' (authored by JosephTremoulet).
ProcessMinidump: Suppress reporting stop for signal '0'
Oct 18 2019, 8:01 AM
JosephTremoulet committed rGd094d97d0223: LLDB: Use LLVM's type for minidump ExceptionStream [NFC] (authored by JosephTremoulet).
LLDB: Use LLVM's type for minidump ExceptionStream [NFC]
Oct 18 2019, 8:01 AM
JosephTremoulet closed D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
Oct 18 2019, 8:01 AM · Restricted Project
JosephTremoulet committed rGa50272f8261f: Update MinidumpYAML to use minidump::Exception for exception stream (authored by JosephTremoulet).
Update MinidumpYAML to use minidump::Exception for exception stream
Oct 18 2019, 8:01 AM
JosephTremoulet closed D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
Oct 18 2019, 8:01 AM · Restricted Project
JosephTremoulet closed D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 18 2019, 8:01 AM · Restricted Project, Restricted Project
JosephTremoulet committed rGe44524736c4a: Add ExceptionStream to llvm::Object::minidump (authored by JosephTremoulet).
Add ExceptionStream to llvm::Object::minidump
Oct 18 2019, 7:42 AM
JosephTremoulet closed D68656: Add ExceptionStream to llvm::Object::minidump.
Oct 18 2019, 7:42 AM · Restricted Project

Oct 17 2019

JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 17 2019, 10:33 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Rebase
  • Use Twine instead of formatv
Oct 17 2019, 10:33 AM · Restricted Project, Restricted Project

Oct 16 2019

JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 16 2019, 4:39 AM · Restricted Project, Restricted Project

Oct 15 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • punctuation fixes
Oct 15 2019, 7:59 AM · Restricted Project, Restricted Project
JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 15 2019, 7:59 AM · Restricted Project, Restricted Project

Oct 14 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Move test
Oct 14 2019, 7:19 AM · Restricted Project, Restricted Project
JosephTremoulet added inline comments to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 14 2019, 7:01 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Remove TODO, lit-ify negative test and tighten check
Oct 14 2019, 6:52 AM · Restricted Project, Restricted Project

Oct 13 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • ...and fix namespace...
Oct 13 2019, 6:23 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Fix Expected<> types
Oct 13 2019, 6:14 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Apply review feedback (-auto, -memset, +comments)
Oct 13 2019, 5:54 PM · Restricted Project, Restricted Project

Oct 11 2019

JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

If this patch is solely meant to fix this issue, then I remove my "Requires Changes" and this patch is good to go if it no longer hangs LLDB.

Oct 11 2019, 11:19 AM · Restricted Project
JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

Just to make sure I'm understanding the feedback correctly, I'll try to summarize. Please let me know if this is off track:

Oct 11 2019, 9:28 AM · Restricted Project
JosephTremoulet added a comment to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.

Added Exception stream to minidump-basic.yaml as suggested.

Oct 11 2019, 9:01 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Address review feedback
Oct 11 2019, 9:01 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68656: Add ExceptionStream to llvm::Object::minidump.
  • Remove useless comment and leftover debugging cruft
Oct 11 2019, 7:55 AM · Restricted Project
JosephTremoulet added inline comments to D68656: Add ExceptionStream to llvm::Object::minidump.
Oct 11 2019, 7:55 AM · Restricted Project

Oct 10 2019

JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Update test input yaml Exception stream
Oct 10 2019, 2:05 PM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68096: ProcessMinidump: Suppress reporting stop for signal '0'.
  • Rebase
  • Add testcase
Oct 10 2019, 2:05 PM · Restricted Project
JosephTremoulet added a comment to D68657: Update MinidumpYAML to use minidump::Exception for exception stream.

Therefore I think it would make sense to just spell out each member of that array as a separate member in the yaml representation, which should be a much simpler endeavour. We can use the "actual parameter count" field to suppress the fields that don't contain any value, if they really are zero, which should make the yaml output concise in the usual cases. I think something like this should be sufficient:
...
I think that would strike a good balance between code complexity, output brevity, and being able to generate interesting and potentially invalid inputs for other tools (which is one of the main goals of yaml2obj, and so interpreting the input too strictly is not desired/helpful).

Oct 10 2019, 11:31 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Add test with extraneous parameter
Oct 10 2019, 11:23 AM · Restricted Project, Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
  • Change Exception Information format per feedback
Oct 10 2019, 11:12 AM · Restricted Project, Restricted Project
JosephTremoulet added a comment to D68656: Add ExceptionStream to llvm::Object::minidump.

Hmm.. maybe just keep those constants defined in lldb somewhere (e.g. right next to or inside the RefreshStateAfterStop function)? That's the place which does the decoding and also includes the OS switch, so it makes it easier to explain their purpose and why they are different for each OS...

Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet retitled D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC] from LLDB: Use LLVM's type for minidump ExceptionStream to LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet updated the diff for D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
  • Define DumpRequested constant in-line, per feedback in D68656
Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet updated the diff for D68656: Add ExceptionStream to llvm::Object::minidump.
  • Remove ExceptionCode enumeration
Oct 10 2019, 8:31 AM · Restricted Project
JosephTremoulet updated the diff for D68657: Update MinidumpYAML to use minidump::Exception for exception stream.

rebase

Oct 10 2019, 8:31 AM · Restricted Project, Restricted Project

Oct 9 2019

JosephTremoulet updated the diff for D68656: Add ExceptionStream to llvm::Object::minidump.
  • Remove the os-defined exception code enum values
Oct 9 2019, 8:49 PM · Restricted Project
JosephTremoulet added a comment to D68656: Add ExceptionStream to llvm::Object::minidump.

Thanks for taking your time to do this. I have one question: It looks like you're not using the exception code enum in the follow-up patch. I think that's completely reasonable given that the enum values are overloaded and system-dependent. But given this fact, and the fact that I am not convinced the enum values are completely right (e.g. the linux signal numbers depend also on the architecture -- though this may not manifest itself on the architectures that breakpad supports right now), what would you say to just dropping that enumeration?

Oct 9 2019, 8:49 PM · Restricted Project

Oct 8 2019

JosephTremoulet added reviewers for D68657: Update MinidumpYAML to use minidump::Exception for exception stream: labath, jhenderson, clayborg.
Oct 8 2019, 12:03 PM · Restricted Project, Restricted Project
JosephTremoulet added reviewers for D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC]: labath, clayborg.
Oct 8 2019, 12:03 PM · Restricted Project
JosephTremoulet added reviewers for D68656: Add ExceptionStream to llvm::Object::minidump: labath, jhenderson, clayborg.
Oct 8 2019, 12:03 PM · Restricted Project
JosephTremoulet created D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC].
Oct 8 2019, 12:03 PM · Restricted Project
JosephTremoulet created D68657: Update MinidumpYAML to use minidump::Exception for exception stream.
Oct 8 2019, 11:53 AM · Restricted Project, Restricted Project
JosephTremoulet created D68656: Add ExceptionStream to llvm::Object::minidump.
Oct 8 2019, 11:53 AM · Restricted Project
JosephTremoulet added a comment to D68645: MinidumpYAML: Add support for the memory info list stream.

Nit: Title says "thread" rather than "memory info"

Oct 8 2019, 7:57 AM · Restricted Project

Sep 30 2019

JosephTremoulet added a comment to D68096: ProcessMinidump: Suppress reporting stop for signal '0'.

It doesn't look like it should be too hard to add yaml support for the exceptions stream -- it should only be a matter of adapting the patterns already used for other stream to work for this particular case. Could you give a go at that?

Sep 30 2019, 9:01 AM · Restricted Project
JosephTremoulet retitled D68096: ProcessMinidump: Suppress reporting stop for signal '0' from ProcessMinidump: inject SIGSTOP on Linux if no thread has a signal to ProcessMinidump: Suppress reporting stop for signal '0'.
Sep 30 2019, 8:56 AM · Restricted Project