Page MenuHomePhabricator
Feed Advanced Search

Yesterday

DavidSpickett updated subscribers of D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

Ah, @omjavaid already put in a fix. I think you can just reland the change now.

Mon, Apr 12, 4:01 AM · debug-info, Restricted Project
DavidSpickett added a comment to D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions..

This change has caused a test failure in lldb. On our Arm bots: http://lab.llvm.org:8011/#/builders/96/builds/6582
Also on Linux x86_64: http://lab.llvm.org:8011/#/builders/68/builds/10277

Mon, Apr 12, 2:37 AM · debug-info, Restricted Project
DavidSpickett updated the summary of D100193: [lldb] Require x86 backend for a bunch of DWARF tests.
Mon, Apr 12, 2:26 AM · Restricted Project
DavidSpickett updated the diff for D100193: [lldb] Require x86 backend for a bunch of DWARF tests.
  • Add x86 folder with lit config to require x86
  • Remove x86 requirement from indiviual tests in that folder (but not for the target-x86_64 tests which need to run program files)
Mon, Apr 12, 2:25 AM · Restricted Project

Fri, Apr 9

DavidSpickett added a reviewer for D100195: [lldb] Require x86 for unwind no-return test: labath.

(apologies for the review spam, you're the author of the test in this case)

Fri, Apr 9, 6:52 AM · Restricted Project
DavidSpickett requested review of D100195: [lldb] Require x86 for unwind no-return test.
Fri, Apr 9, 6:48 AM · Restricted Project
DavidSpickett added inline comments to D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests.
Fri, Apr 9, 6:47 AM · Restricted Project
DavidSpickett added reviewers for D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests: zturner, labath.

(not adding a reviewer for each file type since most are pretty straightforward I think)

Fri, Apr 9, 6:44 AM · Restricted Project
DavidSpickett requested review of D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests.
Fri, Apr 9, 6:39 AM · Restricted Project
DavidSpickett added reviewers for D100193: [lldb] Require x86 backend for a bunch of DWARF tests: labath, aprantl.
Fri, Apr 9, 6:39 AM · Restricted Project
DavidSpickett requested review of D100193: [lldb] Require x86 backend for a bunch of DWARF tests.
Fri, Apr 9, 6:36 AM · Restricted Project
DavidSpickett added a reviewer for D100192: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64: omjavaid.
Fri, Apr 9, 6:33 AM · Restricted Project
DavidSpickett requested review of D100192: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64.
Fri, Apr 9, 6:33 AM · Restricted Project
DavidSpickett added a comment to rG8bc08c55179f: [lldb] Update UUID after https://reviews.llvm.org/D99978..

Thanks! Passing on our bots now.

Fri, Apr 9, 3:15 AM
DavidSpickett added a comment to rG8bc08c55179f: [lldb] Update UUID after https://reviews.llvm.org/D99978..

@pifon2a This test is now failing on our Armv7 and AArch64 bots: http://lab.llvm.org:8011/#/builders/107/builds/6399

Fri, Apr 9, 1:55 AM

Thu, Apr 8

DavidSpickett added a comment to D99480: [lsan] realloc: don't deallocate if requested size is too large.

Marked the test UNSUPPORTED while we figure out the failure: https://reviews.llvm.org/rG466fab5c9410abb79f1a70c5075147e9a768124e

Thu, Apr 8, 8:00 AM · Restricted Project
DavidSpickett added a comment to rG59e422c90bf4: [lsan][test] Add malloc(0) and realloc(p, 0) tests.

Marked the test UNSUPPORTED for now while we figure this out: https://reviews.llvm.org/rG466fab5c9410abb79f1a70c5075147e9a768124e

Thu, Apr 8, 8:00 AM
DavidSpickett committed rG466fab5c9410: [lsan] Mark 2 new lsan tests unsupported on arm-linux (authored by DavidSpickett).
[lsan] Mark 2 new lsan tests unsupported on arm-linux
Thu, Apr 8, 7:59 AM
DavidSpickett added a comment to D99480: [lsan] realloc: don't deallocate if requested size is too large.

I think the failures are to do with whether we have Address and Leak sanitizer enabled. With both it passes, just leak and it doesn't.

Thu, Apr 8, 7:00 AM · Restricted Project
DavidSpickett added a comment to D99480: [lsan] realloc: don't deallocate if requested size is too large.

@MaskRay realloc_too_big.c is failing on our AArch32 bot: http://lab.llvm.org:8011/#/builders/59/builds/1596

Thu, Apr 8, 2:46 AM · Restricted Project
DavidSpickett added a comment to rG59e422c90bf4: [lsan][test] Add malloc(0) and realloc(p, 0) tests.

@MaskRay malloc_zero.c has been failing on our AArch32 bot: http://lab.llvm.org:8011/#/builders/59/builds/1596

Thu, Apr 8, 2:36 AM

Wed, Apr 7

DavidSpickett added a comment to D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

@omjavaid Any more comments on this?

Wed, Apr 7, 8:47 AM · Restricted Project
DavidSpickett added a comment to D97281: [lldb][AArch64] Add class for managing memory tags.

@labath Could you comment on the overall strategy that I'm going for?

Wed, Apr 7, 8:45 AM · Restricted Project
DavidSpickett added inline comments to D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.
Wed, Apr 7, 8:29 AM · Restricted Project
DavidSpickett added a comment to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.

@omjavaid Current status is that a partial read of memory tags is converted into an error by lldb-server. I think this is justifiable given that the GDB protocol as it stands doesn't describe how to really communicate a partial read (though we could make a reasonable guess I'm sure). Plus, lldb itself will be looking ahead via memory regions so it won't issue things that would fail. (fail for reason of address range at least)

Wed, Apr 7, 8:25 AM · Restricted Project

Tue, Apr 6

DavidSpickett added a comment to D98884: [IR] Ignore bitcasts of function pointers which are only used as callees in callbase instruction.

We've also seen failures on all of our 2 stage bots e.g. http://lab.llvm.org:8011/#/builders/7/builds/2348. Which are fixed now this is reverted.

Tue, Apr 6, 8:06 AM · Restricted Project
DavidSpickett added inline comments to D99947: [LLDB] AArch64 Linux PAC unwinder support.
Tue, Apr 6, 6:04 AM
DavidSpickett added inline comments to D99941: [LLDB] Support AArch64 PAC elf-core register read.
Tue, Apr 6, 4:14 AM
DavidSpickett added a comment to D98926: [sanitizer] Simplify GetTls with dl_iterate_phdr on Linux and use it on musl/FreeBSD.

I've disabled many_tls_keys_pthread.cpp for AArch64 as it requires this change (https://reviews.llvm.org/rG34f8a7f93c98b7c189f9684d0d207ab42aca166f).

Tue, Apr 6, 3:34 AM · Restricted Project
DavidSpickett added a comment to rG04dbb63400c5: [lsan][test] Enable many_tls_keys_pthread.cpp and disable swapcontext..

Phab says I did a total revert, but I've just disabled many_tls_keys_pthread.cpp because it requires https://reviews.llvm.org/D98926 which is currently reverted. The test being enabled got missed in the initial revert.

Tue, Apr 6, 3:31 AM
DavidSpickett added a reverting change for rG04dbb63400c5: [lsan][test] Enable many_tls_keys_pthread.cpp and disable swapcontext.: rG34f8a7f93c98: [lsan][test] Disable many_tls_keys_pthread.cpp on AArch64.
Tue, Apr 6, 3:30 AM
DavidSpickett committed rG34f8a7f93c98: [lsan][test] Disable many_tls_keys_pthread.cpp on AArch64 (authored by DavidSpickett).
[lsan][test] Disable many_tls_keys_pthread.cpp on AArch64
Tue, Apr 6, 3:30 AM
DavidSpickett committed rGf8f4d8f87ba4: [lldb] Improve CPUInfo test predicate (authored by DavidSpickett).
[lldb] Improve CPUInfo test predicate
Tue, Apr 6, 2:47 AM
DavidSpickett closed D99729: [lldb] Improve CPUInfo test predicate.
Tue, Apr 6, 2:46 AM · Restricted Project
DavidSpickett accepted D99847: [LLDB] Fix building for aarch64 windows after d6d3d21cd1cb1567eaf7ff8c0867b07227a19d99.

(we should have caught this on our WoA bots but they've been failing earlier in the builds)

Tue, Apr 6, 2:26 AM · Restricted Project

Thu, Apr 1

DavidSpickett added a comment to D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers .

@omjavaid I get some new warnings when compiling this on x86:

[732/1117] Building CXX object too.../RegisterContextDarwin_arm64.cpp.o
In file included from /work/open_source/lldb-cross-compile/llvm-project/lldb/source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp:70:
/work/open_source/lldb-cross-compile/llvm-project/lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h:794:35: warning: ‘g_register_infos_mte’ defined but not used [-Wunused-variable]
  794 | static lldb_private::RegisterInfo g_register_infos_mte[] = {
      |                                   ^~~~~~~~~~~~~~~~~~~~
/work/open_source/lldb-cross-compile/llvm-project/lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h:791:35: warning: ‘g_register_infos_pauth’ defined but not used [-Wunused-variable]
  791 | static lldb_private::RegisterInfo g_register_infos_pauth[] = {
      |                                   ^~~~~~~~~~~~~~~~~~~~~~
Thu, Apr 1, 7:55 AM · Restricted Project
DavidSpickett added a reviewer for D99729: [lldb] Improve CPUInfo test predicate: omjavaid.
Thu, Apr 1, 7:32 AM · Restricted Project
DavidSpickett requested review of D99729: [lldb] Improve CPUInfo test predicate.
Thu, Apr 1, 7:31 AM · Restricted Project
DavidSpickett abandoned D97284: [lldb][AArch64] Add MTE CPU feature test predicate.

This is now redundant since Omair landed his changes.

Thu, Apr 1, 7:27 AM · Restricted Project
DavidSpickett accepted D99538: [MC][ARM] add .w suffixes for ORN/ORNS T1.
Thu, Apr 1, 2:16 AM · Restricted Project
DavidSpickett accepted D99542: [MC][ARM] add .w suffixes for RSB/RSBS T1.

Redo the comments if you like, LGTM otherwise.

Thu, Apr 1, 2:15 AM · Restricted Project

Tue, Mar 30

DavidSpickett added a comment to D97888: [libc++] Add a CI job to test the Runtimes build.

I'll ship this since the Runtimes build has been fixed, however the Linaro ARM bots seem to be offline. @DavidSpickett can you please take a look? Here's a build where the ARM jobs are stuck: https://buildkite.com/llvm-project/libcxx-ci/builds/2183

Tue, Mar 30, 6:51 AM · Restricted Project
DavidSpickett added a comment to D99542: [MC][ARM] add .w suffixes for RSB/RSBS T1.

Side note: in the v8 docs Rd is optional for all variants, but not in v7. So rsb r1, r8, asr #3 would be valid but GCC doesn't allow it either. Possibly because it could be difficult to tell the variants apart if you did.

Tue, Mar 30, 3:40 AM · Restricted Project
DavidSpickett added inline comments to D99538: [MC][ARM] add .w suffixes for ORN/ORNS T1.
Tue, Mar 30, 3:04 AM · Restricted Project

Tue, Mar 23

DavidSpickett added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

OK we may need to retain the manual setting when I upstream this, instead of going with the pure Process-maintained value determined dynamically by gdb packet or corefile metadata. If this is something you need for your own FixCodeAddress prelim patch, I can upstream the target.process.virtual-addressable-bits setting (I think the name is fine, even once Process can determine this dynamically). We'll need to decide at some point what the correct behavior is when they conflict, but if only one is set the choice is straightforward.

Tue, Mar 23, 3:33 AM · Restricted Project

Fri, Mar 19

DavidSpickett committed rG3aa6a4cb39c4: [libcxx][Arm] Move buildbot flags into cmake files (authored by DavidSpickett).
[libcxx][Arm] Move buildbot flags into cmake files
Fri, Mar 19, 9:45 AM
DavidSpickett closed D98771: [libcxx][Arm] Move buildbot flags into cmake files.
Fri, Mar 19, 9:45 AM · Restricted Project
DavidSpickett updated the diff for D98771: [libcxx][Arm] Move buildbot flags into cmake files.
  • Move all flags into cmake caches.
Fri, Mar 19, 7:11 AM · Restricted Project
DavidSpickett added a comment to D98916: [ARM] support symbolic expression as immediate in memory instructions.

I'm not familiar with how fixups work so someone else should check that part. What you do with them looks fine but I don't know if those names are llvm internal or we have to match some published spec elsewhere.

Fri, Mar 19, 5:25 AM · Restricted Project

Thu, Mar 18

DavidSpickett added inline comments to D98771: [libcxx][Arm] Move buildbot flags into cmake files.
Thu, Mar 18, 3:19 AM · Restricted Project
DavidSpickett added inline comments to D98771: [libcxx][Arm] Move buildbot flags into cmake files.
Thu, Mar 18, 3:17 AM · Restricted Project
DavidSpickett added a comment to D98771: [libcxx][Arm] Move buildbot flags into cmake files.

A question how resource constrained are the Arm buildbots?

Thu, Mar 18, 3:15 AM · Restricted Project

Wed, Mar 17

DavidSpickett committed rG96927bafa413: [lldb] Correct unsigned decimal argument check in memory write (authored by DavidSpickett).
[lldb] Correct unsigned decimal argument check in memory write
Wed, Mar 17, 9:11 AM
DavidSpickett added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

TCR_ELx begins at 1 (see D13.2.123 TCR_EL1, Translation Control Register (EL1) in the armarm) and covers EL0 and 1. Looking at the pseudocode access to this is undefined at EL0.

Wed, Mar 17, 9:05 AM · Restricted Project
DavidSpickett added a reviewer for D98771: [libcxx][Arm] Move buildbot flags into cmake files: ldionne.

As requested in https://reviews.llvm.org/D98771 post commit review.

Wed, Mar 17, 4:24 AM · Restricted Project
DavidSpickett added inline comments to D98019: [libcxx] Move Linaro 32 bit armv bots to buildkite.
Wed, Mar 17, 4:23 AM · Restricted Project
DavidSpickett requested review of D98771: [libcxx][Arm] Move buildbot flags into cmake files.
Wed, Mar 17, 4:22 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.
  • Use PRIx64 to properly print 64 bit addresses in invalid range error message.
Wed, Mar 17, 3:55 AM · Restricted Project
DavidSpickett committed rG4b513b2458d9: [lldb] Correct typo in memory read error (authored by DavidSpickett).
[lldb] Correct typo in memory read error
Wed, Mar 17, 3:38 AM
DavidSpickett closed D98770: [lldb] Correct typo in memory read error.
Wed, Mar 17, 3:38 AM · Restricted Project
DavidSpickett added a comment to D98770: [lldb] Correct typo in memory read error.

Thanks, I'll do that in future.

Wed, Mar 17, 3:36 AM · Restricted Project
DavidSpickett added a reviewer for D98770: [lldb] Correct typo in memory read error: omjavaid.
Wed, Mar 17, 3:33 AM · Restricted Project
DavidSpickett requested review of D98770: [lldb] Correct typo in memory read error.
Wed, Mar 17, 3:32 AM · Restricted Project

Tue, Mar 16

DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
  • Remove extra newline after test decorator
Tue, Mar 16, 8:52 AM · Restricted Project
DavidSpickett updated the diff for D97285: [lldb][AArch64] Add "memory tag read" command.

Expand test to check that we can read tags for a range that spans
two mappings. This covers updated code in GetMemoryTagManager.

Tue, Mar 16, 8:22 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

Correct typo in function comment. "to read tags for"

Tue, Mar 16, 8:16 AM · Restricted Project
DavidSpickett added inline comments to D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.
Tue, Mar 16, 8:16 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

Account for a ranges being split across multiple mappings
that are next to each other.
(tested in the tag read command patch)

Tue, Mar 16, 8:12 AM · Restricted Project

Mon, Mar 15

DavidSpickett added a comment to D97285: [lldb][AArch64] Add "memory tag read" command.

I still have one known (though rare) limitation to this command. That is, if you try to read across two neighbouring MTE regions it will fail because it thinks that the whole range isn't tagged. When it is, it's just split over two regions.

Mon, Mar 15, 9:20 AM · Restricted Project
DavidSpickett added inline comments to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Mon, Mar 15, 9:15 AM · Restricted Project
DavidSpickett updated the diff for D97285: [lldb][AArch64] Add "memory tag read" command.
  • Update after changing earlier revisions
  • Read page size only once in the test file
Mon, Mar 15, 9:13 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.

Update after changing parent

Mon, Mar 15, 9:12 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.

Correctly handle the ptrace call by looping until we
get all tags as an error.

Mon, Mar 15, 9:10 AM · Restricted Project
DavidSpickett added inline comments to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Mon, Mar 15, 5:42 AM · Restricted Project
DavidSpickett added inline comments to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Mon, Mar 15, 4:03 AM · Restricted Project
DavidSpickett added inline comments to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..
Mon, Mar 15, 3:22 AM · Restricted Project

Mar 12 2021

DavidSpickett committed rZORG44679416d06e: [libc++] Remove libc++ ARM builders (authored by ldionne).
[libc++] Remove libc++ ARM builders
Mar 12 2021, 2:12 AM
DavidSpickett closed D92863: [libc++] Remove libc++ ARM builders.
Mar 12 2021, 2:12 AM
DavidSpickett committed rG44e36fc2b1df: [libcxx] Move Linaro 32 bit armv bots to buildkite (authored by DavidSpickett).
[libcxx] Move Linaro 32 bit armv bots to buildkite
Mar 12 2021, 1:47 AM
DavidSpickett closed D98019: [libcxx] Move Linaro 32 bit armv bots to buildkite.
Mar 12 2021, 1:47 AM · Restricted Project

Mar 11 2021

DavidSpickett committed rG87358dba8182: [clang][ARM] Refactor ComputeLLVMTriple code for ARM (authored by DavidSpickett).
[clang][ARM] Refactor ComputeLLVMTriple code for ARM
Mar 11 2021, 2:25 AM
DavidSpickett closed D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM.
Mar 11 2021, 2:25 AM · Restricted Project

Mar 9 2021

DavidSpickett added inline comments to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Mar 9 2021, 8:28 AM · Restricted Project
DavidSpickett retitled D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM from [clang][ARM] Refactor computeLLVMTriple code for ARM to [clang][ARM] Refactor ComputeLLVMTriple code for ARM.
Mar 9 2021, 5:24 AM · Restricted Project
DavidSpickett added a reviewer for D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM: ostannard.

Besides the usual motivations this is prep for fixing https://bugs.llvm.org/show_bug.cgi?id=48894 for AArch64. Which will need a similar (but simpler) set of calls.

Mar 9 2021, 5:23 AM · Restricted Project
DavidSpickett requested review of D98253: [clang][ARM] Refactor ComputeLLVMTriple code for ARM.
Mar 9 2021, 5:15 AM · Restricted Project
DavidSpickett accepted D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64.

LGTM

Mar 9 2021, 3:27 AM
DavidSpickett accepted D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset.

LGTM with that one thing fixed.

Mar 9 2021, 3:25 AM · Restricted Project
DavidSpickett added a comment to D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset.

Did you forget to add the changes? I don't see any diff for the last update.

Mar 9 2021, 3:07 AM · Restricted Project
DavidSpickett added inline comments to D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset.
Mar 9 2021, 2:18 AM · Restricted Project

Mar 8 2021

DavidSpickett updated the diff for D97285: [lldb][AArch64] Add "memory tag read" command.
  • RemoveNonAddressBits over RemoveLogicalTag
  • Set bits 63-60 of test file pointers to check we remove the top byte now.
Mar 8 2021, 8:31 AM · Restricted Project
DavidSpickett updated the diff for D97284: [lldb][AArch64] Add MTE CPU feature test predicate.

Rebase

Mar 8 2021, 8:30 AM · Restricted Project
DavidSpickett updated the diff for D95602: [lldb][AArch64] Add MTE memory tag reading to lldb.
  • Use RemoveNonAddressBits instead of RemoveLogicalTag
Mar 8 2021, 8:28 AM · Restricted Project
DavidSpickett added inline comments to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Mar 8 2021, 8:27 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
  • Comments for the MemoryTaggingDetails struct
Mar 8 2021, 8:24 AM · Restricted Project
DavidSpickett added inline comments to D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
Mar 8 2021, 8:19 AM · Restricted Project
DavidSpickett updated the diff for D95601: [lldb][AArch64] Add memory tag reading to lldb-server.
  • Use RemoveNonAddressBits instead of RemoveLogicalTag
  • Make the top byte of test buffer pointer non zero.
Mar 8 2021, 8:18 AM · Restricted Project
DavidSpickett updated the diff for D97282: [lldb][AArch64] Add memory-tagging qSupported feature.

Rebase

Mar 8 2021, 8:16 AM · Restricted Project
DavidSpickett updated the diff for D97281: [lldb][AArch64] Add class for managing memory tags.
  • Add RemoveNonAddressBits which will remove the entire top byte not just tags
  • Remove SetLogicalTag/RemoveLogicalTag/CopyLogicalTag which are now unused in the proceeding patches
Mar 8 2021, 8:14 AM · Restricted Project
DavidSpickett accepted D92863: [libc++] Remove libc++ ARM builders.

https://reviews.llvm.org/D98019 moves the v7/v8 bots, AArch64 is already done. LGTM once that's landed.

Mar 8 2021, 1:31 AM