Updated to fix all the vqmovun that have incorrect types.
Wed, Sep 16
- Check complete error message instead of using regex
- Return early
- Only check for expected error in TestMemoryRegion
Tue, Sep 15
This seems fine to me with some minor nits. Also do you plan on writing a Linux API test for this which test memory regions on Linux? I couldnt locate one already written.
- clang-format Minidump file
- Remove HasFlags from API, return True/False from GetFlags instead
- Rename MapKind to MapsKind and make it an enum class
Fri, Sep 11
This LGTM but I don't know the API standards very well. Some else should give a final review.
Thu, Sep 10
What isn't covered in testing is checking that "memory region" will not print "flags:" if there was no flag info. This would need a way to make a fake lldbserver that didn't reply with the flags field, I could write tests that expect the "flags:" but then when you ran them on a different kernel they might fail.
This is in support of AArch64 memory tagging support as described here: http://lists.llvm.org/pipermail/lldb-dev/2020-August/016402.html
See "### Extending qMemoryRegion"
Thu, Sep 3
Thanks for the review!
- Use settings command so we don't have to substr help's output
- Move list and dedent calls into assert function
Wed, Sep 2
Combined two functions into one single run command
and check message function.
Fri, Aug 28
I realise the test is a bit meta so if there might be a better place to put it. It does at least run successfully from the API test dir.
Thu, Aug 27
https://www.llvm.org/docs/GettingStarted.html gives the minimum gcc as 5.1. (I found this cross compiling, the apt package for AArch64 is 5.4.0)
Wed, Aug 26
Ok to land this as is just to remove some confusion?
Aug 11 2020
Thanks for the pointer, I found more mistakes this way, e.g.: https://godbolt.org/z/f6n95z
(I don't think I can use <type_traits> in a test but there is clang/test/Headers/x86-64-apple-macosx-types.cpp which uses is_same with it's own implementation so I can use/copy that)
The logic LGTM, I wondered at the time I changed this if it was possible to not have a size but didn't know how to trigger it.
Aug 6 2020
Aug 4 2020
I was surprised too. Perhaps there is a way to write the test file such that any type mismatch is a warning and compile with -Werror (maybe a new file, the IR might get messy). I will spend some time looking into this.
Aug 3 2020
Originally added in https://reviews.llvm.org/D77793.
Jul 23 2020
LGTM, I'll let @chill give the final word.
Jul 22 2020
Jul 21 2020
Jul 15 2020
Jul 13 2020
- Use more standard 'test -f' command before 'mv's
Jul 10 2020
- mv with stderr redirected instead of using non standard file -E flag
Jul 9 2020
- Updated rm/mv command lines to account for $DEFAULT_TRIPLE being the same as %target_triple.
Jul 8 2020
For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606)
- Write to cmake and clang's default triple to also fix failure reported by @stevewan.
Right, I see the issue.
Jul 7 2020
- Removed \ from regex, not needed for POSIX syntax.
- Reflowed text in commit description.
I saw similar behaviour on Mac OSX and fixed that in the reland. (https://reviews.llvm.org/rGd6efc9811646edbfe13f06c2676fb469f1c155b1)
Jul 6 2020
Jul 2 2020
- Added check for alternate gcc names in the first test.
Jun 25 2020
Relanded as d6efc9811646edbfe13f06c2676fb469f1c155b1. Change was to get the default triple from clang itself, as on MacOS this can be different to the value you set via CMake.
Jun 22 2020
Committed but made a mistake with arc so it landed with the wrong diff number. In any case a failure on MacOS was reported so reverted while I investigate that.
Jun 17 2020
Moved pipe (|) to end of the first lines to
make it clearer that there's a continuation.
Jun 15 2020
Address comments from MaskRay.
- Use triple slash for actual comments
- symlink clang, don't run test on Windows
- Merged some commands onto one line e.g. touch/chmod
May 28 2020
May 22 2020
- Addressed comments from nickdesaulniers
Comments on cfe-dev (http://lists.llvm.org/pipermail/cfe-dev/2020-May/065432.html) also in favour of removing the default triple lookup. I tend to agree but think it makes more sense to land this first and address it in a follow up.
May 15 2020
Added target triple as a substitution so the tests
don't have to grep for it.
(which I didn't manage to verify on Windows in any case)
Update from arc to hopefully run harbormaster builds again.
May 13 2020
- Updated test to look for forward or backslash in expected file paths.
- Fix spelling
- Rework explanatory comments to be a bit clearer.