Page MenuHomePhabricator
Feed Advanced Search

Yesterday

DavidSpickett added a reverting change for rGc687af0c30b4: [lldb] Don't send invalid region addresses to lldb server: rGc65627a1fe3b: Revert "[lldb] Don't send invalid region addresses to lldb server".
Thu, Sep 17, 5:09 AM
DavidSpickett committed rGc65627a1fe3b: Revert "[lldb] Don't send invalid region addresses to lldb server" (authored by DavidSpickett).
Revert "[lldb] Don't send invalid region addresses to lldb server"
Thu, Sep 17, 5:09 AM
DavidSpickett added a reverting change for D87694: [lldb] Don't send invalid region addresses to lldb server: rGc65627a1fe3b: Revert "[lldb] Don't send invalid region addresses to lldb server".
Thu, Sep 17, 5:09 AM · Unknown Object (Project)
DavidSpickett edited reviewers for D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics, added: efriedma; removed: dnsampaio.
Thu, Sep 17, 3:30 AM · Restricted Project
DavidSpickett updated the diff for D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics.

Updated to fix all the vqmovun that have incorrect types.

Thu, Sep 17, 3:29 AM · Restricted Project
DavidSpickett committed rGc687af0c30b4: [lldb] Don't send invalid region addresses to lldb server (authored by DavidSpickett).
[lldb] Don't send invalid region addresses to lldb server
Thu, Sep 17, 2:26 AM
DavidSpickett closed D87694: [lldb] Don't send invalid region addresses to lldb server.
Thu, Sep 17, 2:26 AM · Unknown Object (Project)

Wed, Sep 16

DavidSpickett added inline comments to D87694: [lldb] Don't send invalid region addresses to lldb server.
Wed, Sep 16, 4:02 AM · Unknown Object (Project)
DavidSpickett updated the diff for D87694: [lldb] Don't send invalid region addresses to lldb server.
  • Check complete error message instead of using regex
Wed, Sep 16, 3:57 AM · Unknown Object (Project)
DavidSpickett added inline comments to D87694: [lldb] Don't send invalid region addresses to lldb server.
Wed, Sep 16, 1:56 AM · Unknown Object (Project)
DavidSpickett updated the diff for D87694: [lldb] Don't send invalid region addresses to lldb server.
  • Return early
  • Only check for expected error in TestMemoryRegion
Wed, Sep 16, 1:50 AM · Unknown Object (Project)

Tue, Sep 15

DavidSpickett added a reviewer for D87694: [lldb] Don't send invalid region addresses to lldb server: omjavaid.
Tue, Sep 15, 7:51 AM · Unknown Object (Project)
DavidSpickett requested review of D87694: [lldb] Don't send invalid region addresses to lldb server.
Tue, Sep 15, 7:45 AM · Unknown Object (Project)
DavidSpickett added a comment to D87442: [lldb] Show flags for memory regions.

This seems fine to me with some minor nits. Also do you plan on writing a Linux API test for this which test memory regions on Linux? I couldnt locate one already written.

Tue, Sep 15, 2:30 AM · Unknown Object (Project)
DavidSpickett updated the diff for D87442: [lldb] Show flags for memory regions.
  • clang-format Minidump file
  • Remove HasFlags from API, return True/False from GetFlags instead
  • Rename MapKind to MapsKind and make it an enum class
Tue, Sep 15, 2:20 AM · Unknown Object (Project)

Fri, Sep 11

DavidSpickett added a comment to D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.

This LGTM but I don't know the API standards very well. Some else should give a final review.

Fri, Sep 11, 8:46 AM · Unknown Object (Project)
DavidSpickett added a reviewer for D87442: [lldb] Show flags for memory regions: teemperor.
Fri, Sep 11, 2:35 AM · Unknown Object (Project)
DavidSpickett added inline comments to D87491: [lldb/API] Add Breakpoint::SerializeToStructuredData to SBAPI.
Fri, Sep 11, 2:33 AM · Unknown Object (Project)

Thu, Sep 10

DavidSpickett added a reviewer for D87442: [lldb] Show flags for memory regions: omjavaid.

What isn't covered in testing is checking that "memory region" will not print "flags:" if there was no flag info. This would need a way to make a fake lldbserver that didn't reply with the flags field, I could write tests that expect the "flags:" but then when you ran them on a different kernel they might fail.

Thu, Sep 10, 2:33 AM · Unknown Object (Project)
DavidSpickett added a comment to D87442: [lldb] Show flags for memory regions.

This is in support of AArch64 memory tagging support as described here: http://lists.llvm.org/pipermail/lldb-dev/2020-August/016402.html
See "### Extending qMemoryRegion"

Thu, Sep 10, 2:29 AM · Unknown Object (Project)
DavidSpickett requested review of D87442: [lldb] Show flags for memory regions.
Thu, Sep 10, 2:20 AM · Unknown Object (Project)

Thu, Sep 3

DavidSpickett added a comment to D86792: [lldb] Improve test failure reporting for expect().

Thanks for the review!

Thu, Sep 3, 5:35 AM · Unknown Object (Project)
DavidSpickett committed rG9f18f3c858d5: [lldb] Improve test failure reporting for expect() (authored by DavidSpickett).
[lldb] Improve test failure reporting for expect()
Thu, Sep 3, 5:35 AM
DavidSpickett closed D86792: [lldb] Improve test failure reporting for expect().
Thu, Sep 3, 5:35 AM · Unknown Object (Project)
DavidSpickett updated the diff for D86792: [lldb] Improve test failure reporting for expect().
  • Use settings command so we don't have to substr help's output
  • Move list and dedent calls into assert function
Thu, Sep 3, 2:16 AM · Unknown Object (Project)

Wed, Sep 2

DavidSpickett updated the diff for D86792: [lldb] Improve test failure reporting for expect().

Combined two functions into one single run command
and check message function.

Wed, Sep 2, 8:11 AM · Unknown Object (Project)

Fri, Aug 28

DavidSpickett updated the summary of D86792: [lldb] Improve test failure reporting for expect().
Fri, Aug 28, 9:20 AM · Unknown Object (Project)
DavidSpickett added inline comments to D86792: [lldb] Improve test failure reporting for expect().
Fri, Aug 28, 9:13 AM · Unknown Object (Project)
DavidSpickett added reviewers for D86792: [lldb] Improve test failure reporting for expect(): teemperor, labath.

I realise the test is a bit meta so if there might be a better place to put it. It does at least run successfully from the API test dir.

Fri, Aug 28, 9:11 AM · Unknown Object (Project)
DavidSpickett requested review of D86792: [lldb] Improve test failure reporting for expect().
Fri, Aug 28, 9:08 AM · Unknown Object (Project)

Thu, Aug 27

DavidSpickett committed rGc1e6f1a7b1a8: [lldb] Fix gcc 5.4.0 compile error (authored by DavidSpickett).
[lldb] Fix gcc 5.4.0 compile error
Thu, Aug 27, 2:23 AM
DavidSpickett closed D86690: [lldb] Fix gcc 5.4.0 compile error.
Thu, Aug 27, 2:23 AM · Unknown Object (Project)
DavidSpickett added a reviewer for D86690: [lldb] Fix gcc 5.4.0 compile error: labath.

https://www.llvm.org/docs/GettingStarted.html gives the minimum gcc as 5.1. (I found this cross compiling, the apt package for AArch64 is 5.4.0)

Thu, Aug 27, 1:57 AM · Unknown Object (Project)
DavidSpickett requested review of D86690: [lldb] Fix gcc 5.4.0 compile error.
Thu, Aug 27, 1:54 AM · Unknown Object (Project)

Wed, Aug 26

DavidSpickett committed rG9ad5d37fd917: [lldb] Correct wording of EXP_MSG (authored by DavidSpickett).
[lldb] Correct wording of EXP_MSG
Wed, Aug 26, 3:52 AM
DavidSpickett closed D86603: [lldb] Correct wording of EXP_MSG.
Wed, Aug 26, 3:52 AM · Unknown Object (Project)
DavidSpickett added a comment to D86603: [lldb] Correct wording of EXP_MSG.

Ok to land this as is just to remove some confusion?

Wed, Aug 26, 2:46 AM · Unknown Object (Project)
DavidSpickett added a reviewer for D86603: [lldb] Correct wording of EXP_MSG: teemperor.
Wed, Aug 26, 2:13 AM · Unknown Object (Project)
DavidSpickett requested review of D86603: [lldb] Correct wording of EXP_MSG.
Wed, Aug 26, 2:03 AM · Unknown Object (Project)

Aug 11 2020

DavidSpickett planned changes to D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics.
Aug 11 2020, 2:14 AM · Restricted Project
DavidSpickett added a comment to D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics.

Thanks for the pointer, I found more mistakes this way, e.g.: https://godbolt.org/z/f6n95z
(I don't think I can use <type_traits> in a test but there is clang/test/Headers/x86-64-apple-macosx-types.cpp which uses is_same with it's own implementation so I can use/copy that)

Aug 11 2020, 2:14 AM · Restricted Project
DavidSpickett added a comment to D85572: [globalopt] Change so that emitting fragments doesn't use the type size of DIVariables.

The logic LGTM, I wondered at the time I changed this if it was possible to not have a size but didn't know how to trigger it.

Aug 11 2020, 1:30 AM · Restricted Project

Aug 6 2020

DavidSpickett committed rGe82866d5d9ee: [lldb][AArch64] Correct compile options for Neon corefile (authored by DavidSpickett).
[lldb][AArch64] Correct compile options for Neon corefile
Aug 6 2020, 5:39 AM
DavidSpickett closed D85134: [lldb][AArch64] Correct compile options for Neon corefile.
Aug 6 2020, 5:39 AM · Unknown Object (Project)

Aug 4 2020

DavidSpickett added a comment to D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics.

I was surprised too. Perhaps there is a way to write the test file such that any type mismatch is a warning and compile with -Werror (maybe a new file, the IR might get messy). I will spend some time looking into this.

Aug 4 2020, 4:37 AM · Restricted Project

Aug 3 2020

DavidSpickett added a reviewer for D85134: [lldb][AArch64] Correct compile options for Neon corefile: omjavaid.

Originally added in https://reviews.llvm.org/D77793.

Aug 3 2020, 7:15 AM · Unknown Object (Project)
DavidSpickett requested review of D85134: [lldb][AArch64] Correct compile options for Neon corefile.
Aug 3 2020, 7:14 AM · Unknown Object (Project)
DavidSpickett added reviewers for D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics: dnsampaio, miyuki.
Aug 3 2020, 4:07 AM · Restricted Project
DavidSpickett requested review of D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics.
Aug 3 2020, 4:03 AM · Restricted Project

Jul 23 2020

DavidSpickett added a comment to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.

LGTM, I'll let @chill give the final word.

Jul 23 2020, 5:11 AM · Restricted Project, Restricted Project

Jul 22 2020

DavidSpickett committed rG3a3419460647: [ARM] Fix Asm/Disasm of TBB/TBH instructions (authored by DavidSpickett).
[ARM] Fix Asm/Disasm of TBB/TBH instructions
Jul 22 2020, 1:32 AM
DavidSpickett closed D84227: [ARM] Fix Asm/Disasm of TBB/TBH instructions.
Jul 22 2020, 1:32 AM · Restricted Project
DavidSpickett added inline comments to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 22 2020, 1:18 AM · Restricted Project, Restricted Project

Jul 21 2020

DavidSpickett added inline comments to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 21 2020, 5:24 AM · Restricted Project, Restricted Project
DavidSpickett added a reviewer for D84227: [ARM] Fix Asm/Disasm of TBB/TBH instructions: ostannard.
Jul 21 2020, 3:33 AM · Restricted Project
Herald added a project to D84227: [ARM] Fix Asm/Disasm of TBB/TBH instructions: Restricted Project.
Jul 21 2020, 3:24 AM · Restricted Project

Jul 15 2020

DavidSpickett committed rGfe5912249efa: [clang][Driver] Fix tool path priority test failures (authored by DavidSpickett).
[clang][Driver] Fix tool path priority test failures
Jul 15 2020, 1:37 AM
DavidSpickett closed D83055: [clang][Driver] Fix tool path priority test failures.
Jul 15 2020, 1:37 AM · Restricted Project

Jul 13 2020

DavidSpickett added inline comments to D83055: [clang][Driver] Fix tool path priority test failures.
Jul 13 2020, 1:37 AM · Restricted Project
DavidSpickett updated the diff for D83055: [clang][Driver] Fix tool path priority test failures.
  • Use more standard 'test -f' command before 'mv's
Jul 13 2020, 1:33 AM · Restricted Project

Jul 10 2020

DavidSpickett added inline comments to D83055: [clang][Driver] Fix tool path priority test failures.
Jul 10 2020, 1:52 AM · Restricted Project
DavidSpickett updated the diff for D83055: [clang][Driver] Fix tool path priority test failures.
  • mv with stderr redirected instead of using non standard file -E flag
Jul 10 2020, 1:49 AM · Restricted Project

Jul 9 2020

DavidSpickett updated the diff for D83055: [clang][Driver] Fix tool path priority test failures.
  • Updated rm/mv command lines to account for $DEFAULT_TRIPLE being the same as %target_triple.
Jul 9 2020, 2:19 AM · Restricted Project

Jul 8 2020

DavidSpickett added a comment to D83055: [clang][Driver] Fix tool path priority test failures.

For the record my logic here is that I could change the tool names to use the same name as --version. However that will break whatever mips toolchain needed this code in the first place. (https://reviews.llvm.org/D13340?id=36227#inline-108606)

Jul 8 2020, 6:37 AM · Restricted Project
DavidSpickett retitled D83055: [clang][Driver] Fix tool path priority test failures from [clang][Driver] Fix tool path priority test failure to [clang][Driver] Fix tool path priority test failures.
Jul 8 2020, 6:33 AM · Restricted Project
DavidSpickett updated the summary of D83055: [clang][Driver] Fix tool path priority test failures.
Jul 8 2020, 6:33 AM · Restricted Project
DavidSpickett added a reviewer for D83055: [clang][Driver] Fix tool path priority test failures: stevewan.
Jul 8 2020, 6:32 AM · Restricted Project
DavidSpickett updated the diff for D83055: [clang][Driver] Fix tool path priority test failures.
  • Write to cmake and clang's default triple to also fix failure reported by @stevewan.
Jul 8 2020, 6:31 AM · Restricted Project
DavidSpickett added a comment to D79842: [clang][Driver] Correct tool search path priority.

Right, I see the issue.

Jul 8 2020, 6:06 AM · Restricted Project

Jul 7 2020

DavidSpickett updated the summary of D83055: [clang][Driver] Fix tool path priority test failures.
Jul 7 2020, 2:09 AM · Restricted Project
DavidSpickett updated the diff for D83055: [clang][Driver] Fix tool path priority test failures.
  • Removed \ from regex, not needed for POSIX syntax.
  • Reflowed text in commit description.
Jul 7 2020, 2:08 AM · Restricted Project
DavidSpickett added a comment to D79842: [clang][Driver] Correct tool search path priority.

I saw similar behaviour on Mac OSX and fixed that in the reland. (https://reviews.llvm.org/rGd6efc9811646edbfe13f06c2676fb469f1c155b1)

Jul 7 2020, 1:17 AM · Restricted Project

Jul 6 2020

DavidSpickett added a reviewer for D83055: [clang][Driver] Fix tool path priority test failures: MaskRay.
Jul 6 2020, 1:41 AM · Restricted Project

Jul 2 2020

DavidSpickett updated the summary of D83055: [clang][Driver] Fix tool path priority test failures.
Jul 2 2020, 9:10 AM · Restricted Project
DavidSpickett updated the diff for D83055: [clang][Driver] Fix tool path priority test failures.
  • Added check for alternate gcc names in the first test.
Jul 2 2020, 9:10 AM · Restricted Project
DavidSpickett created D83055: [clang][Driver] Fix tool path priority test failures.
Jul 2 2020, 8:37 AM · Restricted Project
DavidSpickett added inline comments to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 2 2020, 1:34 AM · Restricted Project, Restricted Project

Jun 25 2020

DavidSpickett accepted D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.

LGTM

Jun 25 2020, 8:00 AM · Restricted Project
DavidSpickett added inline comments to D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 6:20 AM · Restricted Project
DavidSpickett closed D79842: [clang][Driver] Correct tool search path priority.

Relanded as d6efc9811646edbfe13f06c2676fb469f1c155b1. Change was to get the default triple from clang itself, as on MacOS this can be different to the value you set via CMake.

Jun 25 2020, 2:30 AM · Restricted Project
DavidSpickett committed rGd6efc9811646: Reland "[clang][Driver] Correct tool search path priority" (authored by DavidSpickett).
Reland "[clang][Driver] Correct tool search path priority"
Jun 25 2020, 1:36 AM
DavidSpickett added a reverting change for rGf570d5810485: Revert "[clang][Driver] Correct tool search path priority": rGd6efc9811646: Reland "[clang][Driver] Correct tool search path priority".
Jun 25 2020, 1:36 AM

Jun 22 2020

DavidSpickett committed rGf570d5810485: Revert "[clang][Driver] Correct tool search path priority" (authored by DavidSpickett).
Revert "[clang][Driver] Correct tool search path priority"
Jun 22 2020, 6:25 AM
DavidSpickett added a reverting change for rG028571d60843: [clang][Driver] Correct tool search path priority: rGf570d5810485: Revert "[clang][Driver] Correct tool search path priority".
Jun 22 2020, 6:25 AM
DavidSpickett added a comment to D79842: [clang][Driver] Correct tool search path priority.

Committed but made a mistake with arc so it landed with the wrong diff number. In any case a failure on MacOS was reported so reverted while I investigate that.

Jun 22 2020, 6:24 AM · Restricted Project
DavidSpickett committed rG028571d60843: [clang][Driver] Correct tool search path priority (authored by DavidSpickett).
[clang][Driver] Correct tool search path priority
Jun 22 2020, 2:07 AM

Jun 17 2020

DavidSpickett added inline comments to D79842: [clang][Driver] Correct tool search path priority.
Jun 17 2020, 5:53 AM · Restricted Project
DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.

Moved pipe (|) to end of the first lines to
make it clearer that there's a continuation.

Jun 17 2020, 5:53 AM · Restricted Project

Jun 15 2020

DavidSpickett added inline comments to D79842: [clang][Driver] Correct tool search path priority.
Jun 15 2020, 4:51 AM · Restricted Project
DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.

Address comments from MaskRay.

  • Use triple slash for actual comments
  • symlink clang, don't run test on Windows
  • Merged some commands onto one line e.g. touch/chmod
Jun 15 2020, 4:19 AM · Restricted Project

May 28 2020

DavidSpickett edited reviewers for D79842: [clang][Driver] Correct tool search path priority, added: joerg, MaskRay; removed: ddunbar, chandlerc.
May 28 2020, 5:23 AM · Restricted Project

May 22 2020

DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.
  • Addressed comments from nickdesaulniers
May 22 2020, 4:11 AM · Restricted Project
DavidSpickett added a comment to D79842: [clang][Driver] Correct tool search path priority.

Comments on cfe-dev (http://lists.llvm.org/pipermail/cfe-dev/2020-May/065432.html) also in favour of removing the default triple lookup. I tend to agree but think it makes more sense to land this first and address it in a follow up.

May 22 2020, 4:10 AM · Restricted Project

May 15 2020

DavidSpickett added inline comments to D79842: [clang][Driver] Correct tool search path priority.
May 15 2020, 4:29 AM · Restricted Project
DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.

Added target triple as a substitution so the tests
don't have to grep for it.
(which I didn't manage to verify on Windows in any case)

May 15 2020, 4:29 AM · Restricted Project
DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.

Update from arc to hopefully run harbormaster builds again.

May 15 2020, 2:19 AM · Restricted Project

May 13 2020

DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.
  • Updated test to look for forward or backslash in expected file paths.
May 13 2020, 7:00 AM · Restricted Project
DavidSpickett updated the diff for D79842: [clang][Driver] Correct tool search path priority.
  • Fix spelling
  • Rework explanatory comments to be a bit clearer.
May 13 2020, 5:54 AM · Restricted Project
DavidSpickett added inline comments to D79842: [clang][Driver] Correct tool search path priority.
May 13 2020, 3:11 AM · Restricted Project
DavidSpickett created D79842: [clang][Driver] Correct tool search path priority.
May 13 2020, 3:11 AM · Restricted Project