Page MenuHomePhabricator
Feed Advanced Search

May 4 2020

mattd accepted D79351: [MCA] Fixed a bug where loads and stores were sometimes incorrectly marked as depedent (PR45793)..
May 4 2020, 4:09 PM · Restricted Project
mattd added inline comments to D79351: [MCA] Fixed a bug where loads and stores were sometimes incorrectly marked as depedent (PR45793)..
May 4 2020, 2:00 PM · Restricted Project
mattd added a comment to D79351: [MCA] Fixed a bug where loads and stores were sometimes incorrectly marked as depedent (PR45793)..

I'm totally cool with this change; however, it's been a while since I've taken a look at this part of MCA. I'll let other's chime in as well, but +1 from me.

May 4 2020, 1:26 PM · Restricted Project
mattd added a comment to D79351: [MCA] Fixed a bug where loads and stores were sometimes incorrectly marked as depedent (PR45793)..
May 4 2020, 12:53 PM · Restricted Project

Feb 21 2020

mattd committed rG07d2cdae1163: [lldb/cmake] Enable more verbose find_package output. (authored by mattd).
[lldb/cmake] Enable more verbose find_package output.
Feb 21 2020, 10:42 AM
mattd closed D74917: [lldb/cmake] Enable more verbose find_package output..
Feb 21 2020, 10:42 AM · Restricted Project

Feb 20 2020

mattd updated the diff for D74917: [lldb/cmake] Enable more verbose find_package output..
Feb 20 2020, 5:10 PM · Restricted Project
mattd added a comment to D74917: [lldb/cmake] Enable more verbose find_package output..

It should never be possible for LLDB_ENABLE_PYTHON to be true but SWIG_FOUND to be false. The modules FindPythonInterpAndLibs.cmake and FindLuaAndSwig.cmake should fail early when SWIG isn't found.

Thanks for taking a look. Would you be okay with making the status message() in FindPythonInterpAndLibs.cmake and FindLuaAndSwig.cmake fatal, that way the dependency error is clearer?

That would defeat the purpose of auto-detecting these dependencies. Please take a look at D71306 for all the details. The summary is that all optional dependencies default to Auto: where we enable them if we can find them. You can override this behavior by passing LLDB_ENABLE_PYTHON=ON to CMake, in which case not finding Python (or SWIG) will be a fatal error.

Feb 20 2020, 5:05 PM · Restricted Project
mattd updated the diff for D74917: [lldb/cmake] Enable more verbose find_package output..
Feb 20 2020, 4:41 PM · Restricted Project
mattd added a comment to D74917: [lldb/cmake] Enable more verbose find_package output..

It should never be possible for LLDB_ENABLE_PYTHON to be true but SWIG_FOUND to be false. The modules FindPythonInterpAndLibs.cmake and FindLuaAndSwig.cmake should fail early when SWIG isn't found.

Feb 20 2020, 4:28 PM · Restricted Project
mattd created D74917: [lldb/cmake] Enable more verbose find_package output..
Feb 20 2020, 11:15 AM · Restricted Project

Sep 26 2019

mattd committed rG4d17cdc704db: [lld][mach-o] Avoid segfaulting when handling an empty section list. (authored by mattd).
[lld][mach-o] Avoid segfaulting when handling an empty section list.
Sep 26 2019, 10:06 AM
mattd committed rL372995: [lld][mach-o] Avoid segfaulting when handling an empty section list..
[lld][mach-o] Avoid segfaulting when handling an empty section list.
Sep 26 2019, 10:01 AM
mattd closed D67735: [lld][mach-o] Avoid segfaulting when handling an empty section list..
Sep 26 2019, 10:01 AM · Restricted Project, lld

Sep 25 2019

mattd added a comment to D67735: [lld][mach-o] Avoid segfaulting when handling an empty section list..

LGTM

I don't have a strong preference over silently accepting or reporting an error on an empty YAML, so this change seems fine. Thank you for doing htis.

Sep 25 2019, 8:13 AM · Restricted Project, lld

Sep 18 2019

mattd created D67735: [lld][mach-o] Avoid segfaulting when handling an empty section list..
Sep 18 2019, 3:00 PM · Restricted Project, lld
mattd retitled D67735: [lld][mach-o] Avoid segfaulting when handling an empty section list. from [lld][mach-o] Avoid segfaulting when handling an empty segment list. to [lld][mach-o] Avoid segfaulting when handling an empty section list..
Sep 18 2019, 3:00 PM · Restricted Project, lld

Sep 11 2019

mattd committed rL371641: Request commit access for mattd.
Request commit access for mattd
Sep 11 2019, 11:06 AM

Aug 27 2019

mattd accepted D66810: [Tblgen][MCA] Add the ability to mark groups as LoadQueue and StoreQueue. NFCI.

LGTM, nice change! I assume all of the existing LSUnit testing is sufficient.

Aug 27 2019, 10:46 AM · Restricted Project

Jun 24 2019

mattd accepted D63722: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation.

This looks great! Thanks.

Jun 24 2019, 10:28 AM · Restricted Project

Jun 19 2019

mattd accepted D63543: [MCA][Bottleneck Analysis] Teach how to compute a critical sequence of instructions based on the simulation..

Awesome patch. I'm cool with this as long as Simon's comments are addressed.

Jun 19 2019, 10:03 PM · Restricted Project
mattd accepted D63556: [llvm-mca][docs] clarify how the quality of the perf report is affected by the quality of the scheduling models..
Jun 19 2019, 8:38 AM · Restricted Project
mattd added inline comments to D63556: [llvm-mca][docs] clarify how the quality of the perf report is affected by the quality of the scheduling models..
Jun 19 2019, 8:38 AM · Restricted Project

Jun 11 2019

mattd added a comment to D63040: [Docs] [llvm-mca] Point out a caveat for using llvm-mca markers in source code..

Thanks for the patch @Maxpm! Can we close PR42173? Is there anything left for that ticket?

Jun 11 2019, 8:58 AM · Restricted Project

Jun 10 2019

mattd committed rG41bf444e6129: [Docs] [llvm-mca] Point out a caveat for using llvm-mca markers in source code. (authored by mattd).
[Docs] [llvm-mca] Point out a caveat for using llvm-mca markers in source code.
Jun 10 2019, 1:37 PM
mattd committed rL362979: [Docs] [llvm-mca] Point out a caveat for using llvm-mca markers in source code..
[Docs] [llvm-mca] Point out a caveat for using llvm-mca markers in source code.
Jun 10 2019, 1:37 PM
mattd closed D63040: [Docs] [llvm-mca] Point out a caveat for using llvm-mca markers in source code..
Jun 10 2019, 1:37 PM · Restricted Project

May 9 2019

mattd accepted D61676: [MCA] Add support for nested and overlapping region markers.
May 9 2019, 7:41 AM · Restricted Project

May 8 2019

mattd added a comment to D61676: [MCA] Add support for nested and overlapping region markers.

This looks nice! We should probably also have a test for the case where a user specifies an END before a BEGIN tag.

May 8 2019, 9:11 PM · Restricted Project

Apr 22 2019

mattd committed rG55043e2336c0: [sema][objc] Minor refactor to OverrideSearch. NFCI. (authored by mattd).
[sema][objc] Minor refactor to OverrideSearch. NFCI.
Apr 22 2019, 9:03 AM
mattd committed rL358898: [sema][objc] Minor refactor to OverrideSearch. NFCI..
[sema][objc] Minor refactor to OverrideSearch. NFCI.
Apr 22 2019, 9:02 AM
mattd committed rC358898: [sema][objc] Minor refactor to OverrideSearch. NFCI..
[sema][objc] Minor refactor to OverrideSearch. NFCI.
Apr 22 2019, 9:02 AM
mattd closed D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI..
Apr 22 2019, 9:02 AM · Restricted Project

Apr 19 2019

mattd updated the diff for D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI..

Thanks for the review, I addressed your comments:

  • Removed the reference, and pass the AST node as a pointer.
  • Made a few decls auto
Apr 19 2019, 8:26 AM · Restricted Project

Apr 17 2019

mattd created D60850: [sema][objc] Minor refactor to OverrideSearch. NFCI..
Apr 17 2019, 9:17 PM · Restricted Project

Apr 2 2019

mattd added a comment to D60170: [llvm-objcopy] [llvm-symbolizer] Fix failing tests.

LGTM, I'll let @jhenderson weigh-in to see what he says.

Apr 2 2019, 9:00 PM · Restricted Project
mattd added a comment to D60134: [llvm-nm]Add support for --no-demangle.

LGTM, as long as @rupprecht's comment is addressed.

Apr 2 2019, 8:24 PM · Restricted Project
mattd accepted D60134: [llvm-nm]Add support for --no-demangle.
Apr 2 2019, 8:24 PM · Restricted Project

Apr 1 2019

mattd added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

Could you simply rebase the patch, or acknowledge the new LLVM license, as your patch was written prior to the license change.

My organization (Cray Inc) already signed the new license agreement, so I'm not sure what you need here. I can write that I acknowledge the new LLVM license, if that helps.

Apr 1 2019, 8:27 PM · Restricted Project, Restricted Project
mattd committed rG60a8816c2fc8: [compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID (authored by mattd).
[compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID
Apr 1 2019, 8:25 PM
mattd committed rCRT357449: [compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID.
[compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID
Apr 1 2019, 8:25 PM
mattd committed rL357449: [compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID.
[compiler-rt][test] Make instrprof-set-dir-mode test tolerant of group ID
Apr 1 2019, 8:25 PM
mattd closed D53832: Make instrprof-set-dir-mode test tolerant of group ID.
Apr 1 2019, 8:25 PM · Restricted Project, Restricted Project

Mar 30 2019

mattd added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

I do not have commit access. I probably should request it at some point, but I'm fine with someone else merging this for me.

Mar 30 2019, 11:52 AM · Restricted Project, Restricted Project

Mar 28 2019

mattd accepted D59928: [MCA] Add an experimental MicroOpQueue stage..
Mar 28 2019, 9:15 PM · Restricted Project
mattd added a comment to D59928: [MCA] Add an experimental MicroOpQueue stage..

LGTM!

Mar 28 2019, 9:14 PM · Restricted Project

Mar 22 2019

mattd added a comment to D53832: Make instrprof-set-dir-mode test tolerant of group ID.

This revision is now accepted and ready to land.Dec 3 2018, 12:55 PM

Been about 3.5 months since accepted. Can this be committed?

Mar 22 2019, 8:55 PM · Restricted Project, Restricted Project

Mar 13 2019

mattd removed a watcher for debug-info: mattd.
Mar 13 2019, 10:07 PM

Mar 7 2019

mattd committed rG6c5a49ccb9e4: [llvm-mca] Emit a message when no bottlenecks are identified. (authored by mattd).
[llvm-mca] Emit a message when no bottlenecks are identified.
Mar 7 2019, 11:36 AM
mattd committed rL355628: [llvm-mca] Emit a message when no bottlenecks are identified..
[llvm-mca] Emit a message when no bottlenecks are identified.
Mar 7 2019, 11:35 AM
mattd closed D59098: [llvm-mca] Emit a message when no bottlenecks are identified..
Mar 7 2019, 11:35 AM · Restricted Project
mattd accepted D59095: [llvm-readelf]Don't lose negative-ness of negative addends for no symbol relocations.

Makes sense. LGTM.

Mar 7 2019, 9:40 AM · Restricted Project
mattd created D59098: [llvm-mca] Emit a message when no bottlenecks are identified..
Mar 7 2019, 9:02 AM · Restricted Project

Mar 1 2019

mattd accepted D58728: [MCA] Highlight kernel bottlenecks in the summary view..
Mar 1 2019, 10:29 AM · Restricted Project
mattd committed rGb95daf0b7742: [lld][test] Fix tests. llvm-readobj now emits symbol section names. (authored by mattd).
[lld][test] Fix tests. llvm-readobj now emits symbol section names.
Mar 1 2019, 10:03 AM
mattd committed rL355211: [lld][test] Fix tests. llvm-readobj now emits symbol section names..
[lld][test] Fix tests. llvm-readobj now emits symbol section names.
Mar 1 2019, 10:03 AM
mattd committed rLLD355211: [lld][test] Fix tests. llvm-readobj now emits symbol section names..
[lld][test] Fix tests. llvm-readobj now emits symbol section names.
Mar 1 2019, 10:03 AM
mattd committed rG8a6f11f45fad: [llvm-readobj] Display section names for STT_SECTION symbols. (authored by mattd).
[llvm-readobj] Display section names for STT_SECTION symbols.
Mar 1 2019, 9:31 AM
mattd committed rL355207: [llvm-readobj] Display section names for STT_SECTION symbols..
[llvm-readobj] Display section names for STT_SECTION symbols.
Mar 1 2019, 9:31 AM
mattd closed D58796: [llvm-readobj] Display section names for STT_SECTION symbols..
Mar 1 2019, 9:30 AM · Restricted Project
mattd updated the diff for D58796: [llvm-readobj] Display section names for STT_SECTION symbols..

Thanks for the reviews everyone. This update addresses the feedback, all of which was incorporated.

Mar 1 2019, 9:03 AM · Restricted Project

Feb 28 2019

mattd updated the summary of D58796: [llvm-readobj] Display section names for STT_SECTION symbols..
Feb 28 2019, 2:42 PM · Restricted Project
mattd created D58796: [llvm-readobj] Display section names for STT_SECTION symbols..
Feb 28 2019, 2:42 PM · Restricted Project
mattd accepted D58785: [llvm-cxxfilt]Add test to show that empty lines can be handled.

LGTM

Feb 28 2019, 9:02 AM · Restricted Project

Feb 27 2019

mattd accepted D58728: [MCA] Highlight kernel bottlenecks in the summary view..

I like this and think users will find it very helpful. The changes seem sensible to me; however, I had a few nits... mostly stylistic things, no big deals. Anyways, I'll mark this patch as accept, as long as you cover the suggestions made by @lebedev.ri.

Feb 27 2019, 3:00 PM · Restricted Project
mattd committed rG1d5c23523e0b: [llvm-cxxfilt] Re-enable split and demangle stdin input on certain non… (authored by mattd).
[llvm-cxxfilt] Re-enable split and demangle stdin input on certain non…
Feb 27 2019, 1:39 PM
mattd added a reverting change for rG628ab5c6820b: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non…: rG1d5c23523e0b: [llvm-cxxfilt] Re-enable split and demangle stdin input on certain non….
Feb 27 2019, 1:39 PM
mattd committed rL355031: [llvm-cxxfilt] Re-enable split and demangle stdin input on certain non….
[llvm-cxxfilt] Re-enable split and demangle stdin input on certain non…
Feb 27 2019, 1:38 PM
mattd committed rG628ab5c6820b: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non… (authored by mattd).
Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non…
Feb 27 2019, 11:54 AM
mattd added a reverting change for rG5cd5f8f25633: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.: rG628ab5c6820b: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non….
Feb 27 2019, 11:54 AM
mattd committed rL355021: Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non….
Revert "[llvm-cxxfilt] Split and demangle stdin input on certain non…
Feb 27 2019, 11:54 AM
mattd committed rG7a24dbdfd315: [llvm-readobj] Print section type values for unknown sections. (authored by mattd).
[llvm-readobj] Print section type values for unknown sections.
Feb 27 2019, 10:41 AM
mattd committed rL355014: [llvm-readobj] Print section type values for unknown sections..
[llvm-readobj] Print section type values for unknown sections.
Feb 27 2019, 10:41 AM
mattd closed D58701: [llvm-readobj] Print section type values for unknown sections..
Feb 27 2019, 10:41 AM · Restricted Project
mattd committed rG69bec61998c7: [llvm-cxxfilt] Re-enable the delimiters test on Windows. (authored by mattd).
[llvm-cxxfilt] Re-enable the delimiters test on Windows.
Feb 27 2019, 10:05 AM
mattd committed rL355011: [llvm-cxxfilt] Re-enable the delimiters test on Windows..
[llvm-cxxfilt] Re-enable the delimiters test on Windows.
Feb 27 2019, 10:03 AM
mattd committed rGeaa895368be6: Clean up the delimiters test. (authored by mattd).
Clean up the delimiters test.
Feb 27 2019, 9:39 AM
mattd committed rL355007: Clean up the delimiters test..
Clean up the delimiters test.
Feb 27 2019, 9:39 AM
mattd updated the diff for D58701: [llvm-readobj] Print section type values for unknown sections..
  • Fixed the test case (removed underscore typo, and extraneous shstrtab test).
  • Emit ANDROID_REL ANDROID_RELA instead of section offsets.
  • Modified the range check, allowing us to remove some now redundant code for printing the lower-bound section names.
Feb 27 2019, 8:59 AM · Restricted Project
mattd committed rG5cd5f8f25633: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics. (authored by mattd).
[llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.
Feb 27 2019, 8:31 AM
mattd committed rL354998: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
[llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.
Feb 27 2019, 8:31 AM
mattd closed D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 27 2019, 8:31 AM · Restricted Project

Feb 26 2019

mattd added a comment to D58701: [llvm-readobj] Print section type values for unknown sections..

lgtm

Should the +0 be +0x0 so that it's always a hex digit? Or is the +0 what the binutils already output?

Feb 26 2019, 5:05 PM · Restricted Project
mattd created D58701: [llvm-readobj] Print section type values for unknown sections..
Feb 26 2019, 4:57 PM · Restricted Project
mattd updated the diff for D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
  • Added a more complicated test.
  • Made a few variables 'auto' instead of their iterator type.
Feb 26 2019, 10:16 AM · Restricted Project

Feb 20 2019

mattd accepted D58456: [llvm-readelf]Test a couple of corner-cases for --section-mapping.

LGTM. Thanks for adding these.

Feb 20 2019, 9:12 AM · Restricted Project
mattd added inline comments to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 20 2019, 8:55 AM · Restricted Project

Feb 19 2019

mattd added inline comments to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 19 2019, 5:17 PM · Restricted Project
mattd added a comment to D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..

Previously we would have emitted Foo [[:space:]] . right?

Feb 19 2019, 4:49 PM · Restricted Project
mattd created D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics..
Feb 19 2019, 3:53 PM · Restricted Project

Feb 18 2019

mattd added a comment to D57149: [StackProtector] Skip analysing dead users in HasAddressTaken, PR40436.

Hi @uabelho

The test case in your patch definitely causes a problem, but that's because the -start-before/-stop-after is used. If I run that same test through llc, the UnreachableBlockElim pass kicks-in and drops the dead code.
I took a look at the code in your Janurary 24th comment. I was unable to get the same dead block to surface, but most likely I had the wrong flag set. How did you build the sample in that comment?

It can be reproduced with the full llc -O1 pipe on current trunk using:
llc -O1 -o - pr40436.ll

Feb 18 2019, 4:52 PM

Feb 14 2019

mattd committed rG582274329e3d: [llvm-cxxfilt] Fix a comment typo. NFC. (authored by mattd).
[llvm-cxxfilt] Fix a comment typo. NFC.
Feb 14 2019, 6:44 PM
mattd committed rL354094: [llvm-cxxfilt] Fix a comment typo. NFC..
[llvm-cxxfilt] Fix a comment typo. NFC.
Feb 14 2019, 6:43 PM
mattd committed rG123be5d4c0dd: [symbolizer] Avoid collecting symbols belonging to invalid sections. (authored by mattd).
[symbolizer] Avoid collecting symbols belonging to invalid sections.
Feb 14 2019, 3:54 PM
mattd committed rL354083: [symbolizer] Avoid collecting symbols belonging to invalid sections..
[symbolizer] Avoid collecting symbols belonging to invalid sections.
Feb 14 2019, 3:54 PM
mattd closed D58146: [symbolizer] Avoid collecting symbols belonging to invalid sections..
Feb 14 2019, 3:54 PM · Restricted Project

Feb 12 2019

mattd created D58146: [symbolizer] Avoid collecting symbols belonging to invalid sections..
Feb 12 2019, 1:45 PM · Restricted Project
mattd accepted D58066: [MCA][Scheduler] Use latency information to further classify busy instructions..
Feb 12 2019, 9:26 AM · Restricted Project

Feb 11 2019

mattd committed rG22c21934cefc: [llvm-cxxfilt] Split and demangle stdin input (authored by mattd).
[llvm-cxxfilt] Split and demangle stdin input
Feb 11 2019, 12:31 PM
mattd committed rL353743: [llvm-cxxfilt] Split and demangle stdin input.
[llvm-cxxfilt] Split and demangle stdin input
Feb 11 2019, 12:30 PM