Page MenuHomePhabricator
Feed Advanced Search

Tue, Sep 22

eduucaldas committed rGc3c08bfdfd62: [SyntaxTree] Test the List API (authored by eduucaldas).
[SyntaxTree] Test the List API
Tue, Sep 22, 10:08 AM
eduucaldas closed D87839: [SyntaxTree] Test the List API.
Tue, Sep 22, 10:08 AM · Restricted Project
eduucaldas requested review of D88106: [SyntaxTree] Provide iterator-like functions for Lists.
Tue, Sep 22, 9:38 AM · Restricted Project
eduucaldas added inline comments to D87839: [SyntaxTree] Test the List API.
Tue, Sep 22, 9:23 AM · Restricted Project
eduucaldas updated the diff for D87839: [SyntaxTree] Test the List API.

.

Tue, Sep 22, 9:22 AM · Restricted Project
eduucaldas updated the diff for D87839: [SyntaxTree] Test the List API.

Answer code review.

Tue, Sep 22, 9:22 AM · Restricted Project
eduucaldas committed rG6dc06fa09d1a: [SyntaxTree] Add tests for the assignment of the `canModify` tag. (authored by eduucaldas).
[SyntaxTree] Add tests for the assignment of the `canModify` tag.
Tue, Sep 22, 6:17 AM
eduucaldas closed D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..
Tue, Sep 22, 6:17 AM · Restricted Project
eduucaldas added a comment to D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..

Looking for feedback, specially on the names I used.
Also if you have ideas of interesting tests they will be gladly accepted :)

Tue, Sep 22, 2:57 AM · Restricted Project
eduucaldas added a reviewer for D87839: [SyntaxTree] Test the List API: gribozavr2.

I made a separate class for the tests on Lists, as it didn't share any methods with the tests for Trees. What do you think about that?

Tue, Sep 22, 2:56 AM · Restricted Project
eduucaldas added a reviewer for D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag.: gribozavr2.
Tue, Sep 22, 2:50 AM · Restricted Project
eduucaldas updated the diff for D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..

Add FIXME for MIN(X, Y)

Tue, Sep 22, 2:49 AM · Restricted Project
eduucaldas updated the diff for D87839: [SyntaxTree] Test the List API.
  • [SyntaxTree] Split TreeTest and ListTest testing fixtures.
Tue, Sep 22, 2:40 AM · Restricted Project
eduucaldas committed rG66bcb14312a0: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`. (authored by eduucaldas).
[SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`.
Tue, Sep 22, 2:15 AM
eduucaldas closed D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..
Tue, Sep 22, 2:15 AM · Restricted Project
eduucaldas requested review of D88077: [SyntaxTree] Add tests for the assignment of the `canModify` tag..
Tue, Sep 22, 2:13 AM · Restricted Project
eduucaldas retitled D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`. from [SyntaxTree][Synthesis] Implement `deepCopyExpandingMacros` to [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..
Tue, Sep 22, 12:58 AM · Restricted Project
eduucaldas added a reviewer for D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`.: gribozavr2.
Tue, Sep 22, 12:57 AM · Restricted Project
eduucaldas updated the diff for D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..

.

Tue, Sep 22, 12:49 AM · Restricted Project
eduucaldas updated the diff for D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..

Remove buggy deepCopy

Tue, Sep 22, 12:28 AM · Restricted Project

Mon, Sep 21

eduucaldas committed rGaf582c9b0f3a: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf` (authored by eduucaldas).
[SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`
Mon, Sep 21, 11:48 PM
eduucaldas committed rG1dc7836aed13: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for… (authored by eduucaldas).
[SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for…
Mon, Sep 21, 11:48 PM
eduucaldas closed D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Mon, Sep 21, 11:48 PM · Restricted Project
eduucaldas closed D88024: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`.
Mon, Sep 21, 11:48 PM · Restricted Project
eduucaldas requested review of D88034: [SyntaxTree][Synthesis] Fix: `deepCopy` -> `deepCopyExpandingMacros`..
Mon, Sep 21, 10:06 AM · Restricted Project
eduucaldas requested review of D88024: [SyntaxTree][Nit] Take `ArrayRef` instead of `std::vector` as argument for `createTree`.
Mon, Sep 21, 7:48 AM · Restricted Project
eduucaldas updated the diff for D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.

Comment generateAllTreesWithShape

Mon, Sep 21, 7:32 AM · Restricted Project
eduucaldas updated the diff for D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
  • Answer Review
  • Change names in generateAllTreesWithShape
  • auto x = vector() -> vector x;
Mon, Sep 21, 7:18 AM · Restricted Project
eduucaldas committed rG87f0b51d68de: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector… (authored by eduucaldas).
[SyntaxTree][NFC] follow naming convention + remove auto on empty vector…
Mon, Sep 21, 4:45 AM
eduucaldas closed D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration.
Mon, Sep 21, 4:45 AM · Restricted Project
eduucaldas committed rG4a5cc389c51d: [SyntaxTree][Synthesis] Implement `deepCopy` (authored by eduucaldas).
[SyntaxTree][Synthesis] Implement `deepCopy`
Mon, Sep 21, 2:28 AM
eduucaldas closed D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Mon, Sep 21, 2:28 AM · Restricted Project
eduucaldas added a reviewer for D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration: gribozavr2.
Mon, Sep 21, 2:13 AM · Restricted Project
eduucaldas updated the diff for D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.

.

Mon, Sep 21, 2:01 AM · Restricted Project
eduucaldas requested review of D88004: [SyntaxTree][NFC] follow naming convention + remove auto on empty vector declaration.
Mon, Sep 21, 1:40 AM · Restricted Project
eduucaldas updated the diff for D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.

Fix canModifyAllDescendants, add tests for it

Mon, Sep 21, 1:10 AM · Restricted Project
eduucaldas added inline comments to D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Mon, Sep 21, 12:49 AM · Restricted Project
eduucaldas updated the diff for D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
  • deepCopy returns nullptr if copy code with Macro expansions.
  • deepCopy also deep copies the Tokens.
Mon, Sep 21, 12:16 AM · Restricted Project

Sun, Sep 20

eduucaldas committed rGe616a4259889: [SyntaxTree] Test for '\' inside token. (authored by eduucaldas).
[SyntaxTree] Test for '\' inside token.
Sun, Sep 20, 11:56 PM
eduucaldas closed D87895: [SyntaxTree] Test for '\' inside token..
Sun, Sep 20, 11:56 PM · Restricted Project
eduucaldas committed rGbb5b28f12fbd: [SyntaxTree][Synthesis] Improve testing `createLeaf` (authored by eduucaldas).
[SyntaxTree][Synthesis] Improve testing `createLeaf`
Sun, Sep 20, 11:33 PM
eduucaldas closed D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`.
Sun, Sep 20, 11:33 PM · Restricted Project

Fri, Sep 18

eduucaldas requested review of D87925: [Synthesis] Fix: `createTree` only from children that are not backed by source code.
Fri, Sep 18, 11:45 AM · Restricted Project
eduucaldas updated the diff for D87895: [SyntaxTree] Test for '\' inside token..

Fix typo

Fri, Sep 18, 9:51 AM · Restricted Project
eduucaldas updated the diff for D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`.

rebase

Fri, Sep 18, 9:47 AM · Restricted Project
eduucaldas requested review of D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`.
Fri, Sep 18, 2:51 AM · Restricted Project
eduucaldas requested review of D87895: [SyntaxTree] Test for '\' inside token..
Fri, Sep 18, 2:42 AM · Restricted Project

Thu, Sep 17

eduucaldas updated the diff for D87839: [SyntaxTree] Test the List API.

Apply arc lint patch

Thu, Sep 17, 9:50 AM · Restricted Project
eduucaldas requested review of D87839: [SyntaxTree] Test the List API.
Thu, Sep 17, 9:48 AM · Restricted Project
eduucaldas updated the diff for D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.

Rebase

Thu, Sep 17, 9:21 AM · Restricted Project
eduucaldas committed rG1e19165bd89d: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use (authored by eduucaldas).
[SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use
Thu, Sep 17, 9:19 AM
eduucaldas closed D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use.
Thu, Sep 17, 9:19 AM · Restricted Project
eduucaldas updated the diff for D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use.

Fix comment

Thu, Sep 17, 2:45 AM · Restricted Project
eduucaldas updated the summary of D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use.
Thu, Sep 17, 2:43 AM · Restricted Project
eduucaldas requested review of D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use.
Thu, Sep 17, 2:40 AM · Restricted Project
eduucaldas closed D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`.
Thu, Sep 17, 1:14 AM · Restricted Project
eduucaldas updated the summary of D85439: [SyntaxTree] Expand support for `NestedNameSpecifier`.
Thu, Sep 17, 1:14 AM · Restricted Project
eduucaldas closed D85440: [SyntaxTree] Implement `NNS` using the `List` base API.
Thu, Sep 17, 1:13 AM · Restricted Project
eduucaldas updated the summary of D85440: [SyntaxTree] Implement `NNS` using the `List` base API.
Thu, Sep 17, 1:12 AM · Restricted Project
eduucaldas closed D85897: [SyntaxTree] Split `TreeTest.cpp`.
Thu, Sep 17, 1:11 AM · Restricted Project
eduucaldas updated the summary of D85897: [SyntaxTree] Split `TreeTest.cpp`.
Thu, Sep 17, 1:11 AM · Restricted Project

Wed, Sep 16

eduucaldas updated the summary of D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Wed, Sep 16, 10:50 PM · Restricted Project
eduucaldas added a reviewer for D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`: gribozavr2.
Wed, Sep 16, 11:10 AM · Restricted Project
eduucaldas updated the summary of D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Wed, Sep 16, 11:09 AM · Restricted Project
eduucaldas requested review of D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`.
Wed, Sep 16, 11:09 AM · Restricted Project
eduucaldas updated the diff for D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.

Remove extraneous qualifiers in createTree

Wed, Sep 16, 1:55 AM · Restricted Project
eduucaldas requested review of D87749: [SyntaxTree][Synthesis] Implement `deepCopy`.
Wed, Sep 16, 1:51 AM · Restricted Project

Mon, Sep 14

eduucaldas committed rGceb0128509c5: [SyntaxTree][List] `assertInvariants` for `List`s (authored by eduucaldas).
[SyntaxTree][List] `assertInvariants` for `List`s
Mon, Sep 14, 3:45 AM
eduucaldas closed D87600: [SyntaxTree][List] `assertInvariants` for `List`s.
Mon, Sep 14, 3:45 AM · Restricted Project
eduucaldas updated the diff for D87600: [SyntaxTree][List] `assertInvariants` for `List`s.

rebase

Mon, Sep 14, 3:36 AM · Restricted Project
eduucaldas committed rG0f4cc64fd747: [SyntaxTree] Provide `List::classof` (authored by eduucaldas).
[SyntaxTree] Provide `List::classof`
Mon, Sep 14, 3:36 AM
eduucaldas committed rG12232dc181cb: [SyntaxTree][List] Fix: `ParameterDeclarationList` is the `List` inside… (authored by eduucaldas).
[SyntaxTree][List] Fix: `ParameterDeclarationList` is the `List` inside…
Mon, Sep 14, 3:36 AM
eduucaldas closed D87599: [SyntaxTree] Provide `List::classof`.
Mon, Sep 14, 3:35 AM · Restricted Project
eduucaldas closed D87598: [SyntaxTree][List] Fix: `ParameterDeclarationList` is the `List` inside `ParametersAndQualifiers`.
Mon, Sep 14, 3:35 AM · Restricted Project
eduucaldas updated the diff for D87600: [SyntaxTree][List] `assertInvariants` for `List`s.

Fix build error and clang-tidy lint error

Mon, Sep 14, 2:53 AM · Restricted Project
eduucaldas requested review of D87600: [SyntaxTree][List] `assertInvariants` for `List`s.
Mon, Sep 14, 1:23 AM · Restricted Project
eduucaldas requested review of D87599: [SyntaxTree] Provide `List::classof`.
Mon, Sep 14, 1:22 AM · Restricted Project
eduucaldas requested review of D87598: [SyntaxTree][List] Fix: `ParameterDeclarationList` is the `List` inside `ParametersAndQualifiers`.
Mon, Sep 14, 1:21 AM · Restricted Project

Fri, Sep 11

eduucaldas committed rG7c37b82f5ba5: [SyntaxTree][Synthesis] Add support for Tree. (authored by eduucaldas).
[SyntaxTree][Synthesis] Add support for Tree.
Fri, Sep 11, 1:37 PM
eduucaldas closed D87533: [SyntaxTree][Synthesis] Add support for Tree..
Fri, Sep 11, 1:37 PM · Restricted Project
eduucaldas updated the diff for D87533: [SyntaxTree][Synthesis] Add support for Tree..

Add argument names to function declaration

Fri, Sep 11, 1:01 PM · Restricted Project
eduucaldas committed rG238ae4eee051: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto] (authored by eduucaldas).
[SyntaxTree] Add const qualifiers, from [llvm-qualified-auto]
Fri, Sep 11, 11:44 AM
eduucaldas closed D87522: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto].
Fri, Sep 11, 11:44 AM · Restricted Project
eduucaldas committed rG515238d5b113: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`. (authored by eduucaldas).
[SyntaxTree] Reduce visibility of `Arena::lexBuffer`.
Fri, Sep 11, 11:39 AM
eduucaldas closed D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`..
Fri, Sep 11, 11:38 AM · Restricted Project
eduucaldas abandoned D87526: [SyntaxTree][Synthesis] Add support for Tree..
Fri, Sep 11, 11:37 AM · Restricted Project
eduucaldas updated the diff for D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`..

Rebase

Fri, Sep 11, 11:33 AM · Restricted Project
eduucaldas committed rG5d152127d48f: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump (authored by eduucaldas).
[SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump
Fri, Sep 11, 11:27 AM
eduucaldas closed D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Fri, Sep 11, 11:27 AM · Restricted Project
eduucaldas updated the diff for D87533: [SyntaxTree][Synthesis] Add support for Tree..

Rebase

Fri, Sep 11, 11:15 AM · Restricted Project
eduucaldas updated the diff for D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.

Remove createLeafLowLevel

Fri, Sep 11, 11:10 AM · Restricted Project
eduucaldas added a reviewer for D87533: [SyntaxTree][Synthesis] Add support for Tree.: gribozavr2.
Fri, Sep 11, 11:00 AM · Restricted Project
eduucaldas updated the summary of D87533: [SyntaxTree][Synthesis] Add support for Tree..
Fri, Sep 11, 10:59 AM · Restricted Project
eduucaldas requested review of D87533: [SyntaxTree][Synthesis] Add support for Tree..
Fri, Sep 11, 10:58 AM · Restricted Project
eduucaldas updated the diff for D87526: [SyntaxTree][Synthesis] Add support for Tree..

add previous patch to allow pre-merge checks

Fri, Sep 11, 10:03 AM · Restricted Project
eduucaldas requested review of D87526: [SyntaxTree][Synthesis] Add support for Tree..
Fri, Sep 11, 9:54 AM · Restricted Project
eduucaldas requested review of D87523: [SyntaxTree] Reduce visibility of `Arena::lexBuffer`..
Fri, Sep 11, 9:45 AM · Restricted Project
eduucaldas requested review of D87522: [SyntaxTree] Add const qualifiers, from [llvm-qualified-auto].
Fri, Sep 11, 9:34 AM · Restricted Project
eduucaldas updated the diff for D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.

fix clang-tidy warning

Fri, Sep 11, 9:03 AM · Restricted Project
eduucaldas added inline comments to D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump.
Fri, Sep 11, 9:01 AM · Restricted Project